From: Simon Horman <horms@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Arnd Bergmann <arnd@arndb.de>, Geoff Levand <geoff@infradead.org>,
Petr Machata <petrm@nvidia.com>,
Piotr Raczynski <piotr.raczynski@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Liang He <windhl@126.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static
Date: Thu, 10 Aug 2023 22:46:23 +0200 [thread overview]
Message-ID: <ZNVMn1HMuV0LvnqD@vergenet.net> (raw)
In-Reply-To: <20230810122528.1220434-1-arnd@kernel.org>
On Thu, Aug 10, 2023 at 02:25:15PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The function is exported for no reason and should just be static:
>
> drivers/net/ethernet/sun/ldmvsw.c:127:5: error: no previous prototype for 'ldmvsw_open' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
next prev parent reply other threads:[~2023-08-10 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 12:25 [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static Arnd Bergmann
2023-08-10 12:25 ` [PATCH 2/2] ethernet: atarilance: mark init function static Arnd Bergmann
2023-08-10 12:50 ` Yang Yingliang
2023-08-10 20:46 ` Simon Horman [this message]
2023-08-12 1:50 ` [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNVMn1HMuV0LvnqD@vergenet.net \
--to=horms@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geoff@infradead.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=piotr.raczynski@intel.com \
--cc=windhl@126.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.