From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Thu, 10 Aug 2023 15:20:13 -0700 Subject: [PATCH v8 02/14] KVM: Declare kvm_arch_flush_remote_tlbs() globally In-Reply-To: References: <20230808231330.3855936-1-rananta@google.com> <20230808231330.3855936-3-rananta@google.com> <30e45ef3-309a-63de-e085-be1645c1be79@redhat.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Aug 10, 2023, Raghavendra Rao Ananta wrote: > On Thu, Aug 10, 2023 at 5:26?AM Shaoqin Huang wrote: > > On 8/10/23 00:38, Raghavendra Rao Ananta wrote: > > >>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > >>> index e3f968b38ae97..ade5d4500c2ce 100644 > > >>> --- a/include/linux/kvm_host.h > > >>> +++ b/include/linux/kvm_host.h > > >>> @@ -1484,6 +1484,8 @@ static inline int kvm_arch_flush_remote_tlbs(struct kvm *kvm) > > >>> { > > >>> return -ENOTSUPP; > > >>> } > > >>> +#else > > >>> +int kvm_arch_flush_remote_tlbs(struct kvm *kvm); > > >>> #endif > > >>> > > >>> #ifdef __KVM_HAVE_ARCH_NONCOHERENT_DMA > > >> > > >> Is the declaration inconsistent to that in arch/x86/include/asm/kvm_host.h? > > >> In order to keep them consistent, I guess we need move kvm_arch_flush_remote_tlbs() > > >> from x86's header file to arch/x86/kvm/mmu/mmu.c and 'inline' needs to be dropped. > > >> > > > Unsure of the original intentions, I didn't want to disturb any > > > existing arrangements. If more people agree to this refactoring, I'm > > > happy to move. > > > > This is amazing to me. This change can be compiled without any error > > even if the declaration inconsistent between the kvm_host.h and x86's > > header file. > > > > I'm curious which option make it possible? > > > After doing some experiments, I think it works because of the order in > which the inline-definition and the declaration are laid out. If the > 'inline' part of the function comes first and then the declaration, we > don't see any error. However if the positions were reversed, we would > see an error. (I'm not sure what the technical reason for this is). > > Just to be safe, I can move the definition to arch/x86/kvm/mmu/mmu.c > as a non-inline function. No need, asm/kvm_host.h _must_ be included before the declaration, otherwise the declaration wouldn't be made because __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS wouldn't be defined. I.e. we won't run into issues where the non-static declaration comes before the static inline definition. C99 explicitly covers this case: 6.2.2 Linkages of identifiers ... If the declaration of a file scope identifier for an object or a function contains the storage- class specifier static, the identifier has internal linkage. For an identifier declared with the storage-class specifier extern in a scope in which a prior declaration of that identifier is visible if the prior declaration specifies internal or external linkage, the linkage of the identifier at the later declaration is the same as the linkage specified at the prior declaration. If no prior declaration is visible, or if the prior declaration specifies no linkage, then the identifier has external linkage. In short, because the "static inline" declared internal linkage first, it wins. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 312DF22F02 for ; Thu, 10 Aug 2023 22:20:15 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5867fe87d16so17851587b3.2 for ; Thu, 10 Aug 2023 15:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691706015; x=1692310815; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=tmBFxKohqxWGeEzlaaidWaFnJW/Oy/RvfXuIqafrWOM=; b=6JTyZrfrPMxEB4xAyKq26rEGx6dnOtJemt5mF01prNKQ3cUVfJruc7Fe7RGiRWwnTQ JNdckI2vLoo+gqpkJ4Y/rCI2rOTa5hAiAak/2PN2K2x99UdsCwMzOR99izlBg4yxVppk dQK8g/hJNDIeks6PwAz/oyY3lHetOC4GBoRbRmdSsLay+vWH0iHE9YncdP80LYWTblDI iYMvC5FUjVcDsM/OLHEHwIfhMK0QewWcYKuW2IlqTPX5Otlz706FwBUZ5hXu21vGQIT4 uYlRsQgCaSIAFf7MMqxoS33uW0RGdAOE21lmj0iEkCe384OiQkcbcQF5CJ0cTVjotCgp pMJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691706015; x=1692310815; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tmBFxKohqxWGeEzlaaidWaFnJW/Oy/RvfXuIqafrWOM=; b=cUZ2DNwc3TRWTBEpf5k66FOtWLhwyGMMTC7TPp+GqAGiP4se6F/9sX4SiPkOLSUDsH nEc1ViSAhhIatbLX1dwvuTOE78Lp/rFDXNatV8wgbjXa/3nJPFpXJF+GwQfAt1+IBLnv t1SxbQ7IePUs8mL1ibxjq6aBty0nUkXlvaVaSEJIh1my640ctXhpvshKbCNX7KevZYO4 RncroKddZmpnxrfLddKXsq4f23rSHZ709wksIWm5emSPY2/PzLdduAxAIPz6UZV1Er8q QFcrrYQ/a7npaMqbeYeZTbfCqtTBBaUzahTcRb4ZabffTzu1UNljCLZItN7OZbm3HtfN q8BA== X-Gm-Message-State: AOJu0YyM/LZAzYI8jBBFAqLpG9R5a3fwGuvza/Rt+43nH57QZJZjm/fE /pdaFpLm/n6liqn+vXbRg/P3mIAJsac= X-Google-Smtp-Source: AGHT+IFA+Eoa7k6dQo7jnaWMJsrKFJ33ryvAj3Q3LxXldo+rT6OtEr7lMPaA/JwDbq8aHQpRj3zalPzAYew= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:690c:709:b0:57a:118a:f31 with SMTP id bs9-20020a05690c070900b0057a118a0f31mr4149ywb.7.1691706015047; Thu, 10 Aug 2023 15:20:15 -0700 (PDT) Date: Thu, 10 Aug 2023 15:20:13 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230808231330.3855936-1-rananta@google.com> <20230808231330.3855936-3-rananta@google.com> <30e45ef3-309a-63de-e085-be1645c1be79@redhat.com> Message-ID: Subject: Re: [PATCH v8 02/14] KVM: Declare kvm_arch_flush_remote_tlbs() globally From: Sean Christopherson To: Raghavendra Rao Ananta Cc: Shaoqin Huang , Gavin Shan , Oliver Upton , Marc Zyngier , James Morse , Suzuki K Poulose , Paolo Bonzini , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , Fuad Tabba , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 10, 2023, Raghavendra Rao Ananta wrote: > On Thu, Aug 10, 2023 at 5:26=E2=80=AFAM Shaoqin Huang wrote: > > On 8/10/23 00:38, Raghavendra Rao Ananta wrote: > > >>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > >>> index e3f968b38ae97..ade5d4500c2ce 100644 > > >>> --- a/include/linux/kvm_host.h > > >>> +++ b/include/linux/kvm_host.h > > >>> @@ -1484,6 +1484,8 @@ static inline int kvm_arch_flush_remote_tlbs(= struct kvm *kvm) > > >>> { > > >>> return -ENOTSUPP; > > >>> } > > >>> +#else > > >>> +int kvm_arch_flush_remote_tlbs(struct kvm *kvm); > > >>> #endif > > >>> > > >>> #ifdef __KVM_HAVE_ARCH_NONCOHERENT_DMA > > >> > > >> Is the declaration inconsistent to that in arch/x86/include/asm/kvm_= host.h? > > >> In order to keep them consistent, I guess we need move kvm_arch_flus= h_remote_tlbs() > > >> from x86's header file to arch/x86/kvm/mmu/mmu.c and 'inline' needs = to be dropped. > > >> > > > Unsure of the original intentions, I didn't want to disturb any > > > existing arrangements. If more people agree to this refactoring, I'm > > > happy to move. > > > > This is amazing to me. This change can be compiled without any error > > even if the declaration inconsistent between the kvm_host.h and x86's > > header file. > > > > I'm curious which option make it possible? > > > After doing some experiments, I think it works because of the order in > which the inline-definition and the declaration are laid out. If the > 'inline' part of the function comes first and then the declaration, we > don't see any error. However if the positions were reversed, we would > see an error. (I'm not sure what the technical reason for this is). >=20 > Just to be safe, I can move the definition to arch/x86/kvm/mmu/mmu.c > as a non-inline function. No need, asm/kvm_host.h _must_ be included before the declaration, otherwis= e the declaration wouldn't be made because __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS woul= dn't be defined. I.e. we won't run into issues where the non-static declaration= comes before the static inline definition. C99 explicitly covers this case: 6.2.2 Linkages of identifiers ... If the declaration of a file scope identifier for an object or a function= contains the storage- class specifier static, the identifier has internal linkage. For an identifier declared with the storage-class specifier extern in a s= cope in which a prior declaration of that identifier is visible if the prior declaration = specifies internal or external linkage, the linkage of the identifier at the later declaration = is the same as the linkage specified at the prior declaration. If no prior declaration is vi= sible, or if the prior declaration specifies no linkage, then the identifier has external linkag= e. In short, because the "static inline" declared internal linkage first, it w= ins. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3537AC001B0 for ; Thu, 10 Aug 2023 22:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=WOOcP5UNizPERbsA4P6XY9Y1cWmT2E4bP2Tv2Vl8cmI=; b=DeHF+fb8HI+wPOUjt1VsVmXzzJ vh5EC6NX7I5CGHRExzISYzX2s7Go2mde6ceVP2zLxegfswOIHu1vCxs0anu6sGPh06K3BGqgn/5MV 3e1xn9ioCnixKBNw5kYo14tr1b0F7gOq5rakKpJlwHQaClxpk0BJylVPbdtYoQPknTgZ3k/VY39gp GT0CABQWCewQKmXfdYk6eoM+Fe/iWVTE3Y6sdyfHoDKnAO/CrDt+tl5s0G8xWudETo0C/qxIck49m 2kQ72T1WDUjk6IEyEoJaTJ2i7BPNoxqc1SB3X2X7q0nbJOq2mHYb5aV6x0Fw5czmzz45HanMjvaVB epJ8NlZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUE0y-008pPO-09; Thu, 10 Aug 2023 22:20:20 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUE0u-008pOg-2p for linux-riscv@lists.infradead.org; Thu, 10 Aug 2023 22:20:18 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5865afcb825so18191347b3.0 for ; Thu, 10 Aug 2023 15:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691706015; x=1692310815; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=tmBFxKohqxWGeEzlaaidWaFnJW/Oy/RvfXuIqafrWOM=; b=6JTyZrfrPMxEB4xAyKq26rEGx6dnOtJemt5mF01prNKQ3cUVfJruc7Fe7RGiRWwnTQ JNdckI2vLoo+gqpkJ4Y/rCI2rOTa5hAiAak/2PN2K2x99UdsCwMzOR99izlBg4yxVppk dQK8g/hJNDIeks6PwAz/oyY3lHetOC4GBoRbRmdSsLay+vWH0iHE9YncdP80LYWTblDI iYMvC5FUjVcDsM/OLHEHwIfhMK0QewWcYKuW2IlqTPX5Otlz706FwBUZ5hXu21vGQIT4 uYlRsQgCaSIAFf7MMqxoS33uW0RGdAOE21lmj0iEkCe384OiQkcbcQF5CJ0cTVjotCgp pMJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691706015; x=1692310815; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tmBFxKohqxWGeEzlaaidWaFnJW/Oy/RvfXuIqafrWOM=; b=ElPGxmUaQqkRyBW9eWScHPxDMPL0OYt97vH14UDDzM5TuSCXAI4Rakjdvg6VkVmZdQ 1jRuLGGz7PAJWQR0nMxOqKtE5+v5Vi3IcHPWinuh6bLQIztDHvCTFN57Fyk2y9DPLSFw OQN3v5o/Q71tv6FFKMqaJ/yG7sg1DrV4Fl36n2BZqlmvJevoW2sc+zNjW51Oi0UVCUFY HNfIuuZxbhr7jHDsneKwVswkaLdpvoG7/00IXemC3dMDPW1kJMbJ02nLGZvDwvA8dea9 ZHE3rs3Eq+AqimgmSQsXzxCsQ2DcimvDLK8VR6mfg4ZNJ5BgeomuIoezcb42dAH1r3AE EEhg== X-Gm-Message-State: AOJu0Yz4X6ONJCUicNo0TlKFsL9ips1C3ZBTl1/uuGh5dnvGOUQ0AIAv Ue/41Y+sA/CNO7a56tqNXQHdjwPqB2c= X-Google-Smtp-Source: AGHT+IFA+Eoa7k6dQo7jnaWMJsrKFJ33ryvAj3Q3LxXldo+rT6OtEr7lMPaA/JwDbq8aHQpRj3zalPzAYew= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:690c:709:b0:57a:118a:f31 with SMTP id bs9-20020a05690c070900b0057a118a0f31mr4149ywb.7.1691706015047; Thu, 10 Aug 2023 15:20:15 -0700 (PDT) Date: Thu, 10 Aug 2023 15:20:13 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230808231330.3855936-1-rananta@google.com> <20230808231330.3855936-3-rananta@google.com> <30e45ef3-309a-63de-e085-be1645c1be79@redhat.com> Message-ID: Subject: Re: [PATCH v8 02/14] KVM: Declare kvm_arch_flush_remote_tlbs() globally From: Sean Christopherson To: Raghavendra Rao Ananta Cc: Shaoqin Huang , Gavin Shan , Oliver Upton , Marc Zyngier , James Morse , Suzuki K Poulose , Paolo Bonzini , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , Fuad Tabba , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_152016_926071_15389B1F X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBdWcgMTAsIDIwMjMsIFJhZ2hhdmVuZHJhIFJhbyBBbmFudGEgd3JvdGU6Cj4gT24g VGh1LCBBdWcgMTAsIDIwMjMgYXQgNToyNuKAr0FNIFNoYW9xaW4gSHVhbmcgPHNoYWh1YW5nQHJl ZGhhdC5jb20+IHdyb3RlOgo+ID4gT24gOC8xMC8yMyAwMDozOCwgUmFnaGF2ZW5kcmEgUmFvIEFu YW50YSB3cm90ZToKPiA+ID4+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9rdm1faG9zdC5o IGIvaW5jbHVkZS9saW51eC9rdm1faG9zdC5oCj4gPiA+Pj4gaW5kZXggZTNmOTY4YjM4YWU5Ny4u YWRlNWQ0NTAwYzJjZSAxMDA2NDQKPiA+ID4+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0 LmgKPiA+ID4+PiArKysgYi9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmgKPiA+ID4+PiBAQCAtMTQ4 NCw2ICsxNDg0LDggQEAgc3RhdGljIGlubGluZSBpbnQga3ZtX2FyY2hfZmx1c2hfcmVtb3RlX3Rs YnMoc3RydWN0IGt2bSAqa3ZtKQo+ID4gPj4+ICAgIHsKPiA+ID4+PiAgICAgICAgcmV0dXJuIC1F Tk9UU1VQUDsKPiA+ID4+PiAgICB9Cj4gPiA+Pj4gKyNlbHNlCj4gPiA+Pj4gK2ludCBrdm1fYXJj aF9mbHVzaF9yZW1vdGVfdGxicyhzdHJ1Y3Qga3ZtICprdm0pOwo+ID4gPj4+ICAgICNlbmRpZgo+ ID4gPj4+Cj4gPiA+Pj4gICAgI2lmZGVmIF9fS1ZNX0hBVkVfQVJDSF9OT05DT0hFUkVOVF9ETUEK PiA+ID4+Cj4gPiA+PiBJcyB0aGUgZGVjbGFyYXRpb24gaW5jb25zaXN0ZW50IHRvIHRoYXQgaW4g YXJjaC94ODYvaW5jbHVkZS9hc20va3ZtX2hvc3QuaD8KPiA+ID4+IEluIG9yZGVyIHRvIGtlZXAg dGhlbSBjb25zaXN0ZW50LCBJIGd1ZXNzIHdlIG5lZWQgbW92ZSBrdm1fYXJjaF9mbHVzaF9yZW1v dGVfdGxicygpCj4gPiA+PiBmcm9tIHg4NidzIGhlYWRlciBmaWxlIHRvIGFyY2gveDg2L2t2bS9t bXUvbW11LmMgYW5kICdpbmxpbmUnIG5lZWRzIHRvIGJlIGRyb3BwZWQuCj4gPiA+Pgo+ID4gPiBV bnN1cmUgb2YgdGhlIG9yaWdpbmFsIGludGVudGlvbnMsIEkgZGlkbid0IHdhbnQgdG8gZGlzdHVy YiBhbnkKPiA+ID4gZXhpc3RpbmcgYXJyYW5nZW1lbnRzLiBJZiBtb3JlIHBlb3BsZSBhZ3JlZSB0 byB0aGlzIHJlZmFjdG9yaW5nLCBJJ20KPiA+ID4gaGFwcHkgdG8gbW92ZS4KPiA+Cj4gPiBUaGlz IGlzIGFtYXppbmcgdG8gbWUuIFRoaXMgY2hhbmdlIGNhbiBiZSBjb21waWxlZCB3aXRob3V0IGFu eSBlcnJvcgo+ID4gZXZlbiBpZiB0aGUgZGVjbGFyYXRpb24gaW5jb25zaXN0ZW50IGJldHdlZW4g dGhlIGt2bV9ob3N0LmggYW5kIHg4NidzCj4gPiBoZWFkZXIgZmlsZS4KPiA+Cj4gPiBJJ20gY3Vy aW91cyB3aGljaCBvcHRpb24gbWFrZSBpdCBwb3NzaWJsZT8KPiA+Cj4gQWZ0ZXIgZG9pbmcgc29t ZSBleHBlcmltZW50cywgSSB0aGluayBpdCB3b3JrcyBiZWNhdXNlIG9mIHRoZSBvcmRlciBpbgo+ IHdoaWNoIHRoZSBpbmxpbmUtZGVmaW5pdGlvbiBhbmQgdGhlIGRlY2xhcmF0aW9uIGFyZSBsYWlk IG91dC4gSWYgdGhlCj4gJ2lubGluZScgcGFydCBvZiB0aGUgZnVuY3Rpb24gY29tZXMgZmlyc3Qg YW5kIHRoZW4gdGhlIGRlY2xhcmF0aW9uLCB3ZQo+IGRvbid0IHNlZSBhbnkgZXJyb3IuIEhvd2V2 ZXIgaWYgdGhlIHBvc2l0aW9ucyB3ZXJlIHJldmVyc2VkLCB3ZSB3b3VsZAo+IHNlZSBhbiBlcnJv ci4gKEknbSBub3Qgc3VyZSB3aGF0IHRoZSB0ZWNobmljYWwgcmVhc29uIGZvciB0aGlzIGlzKS4K PiAKPiBKdXN0IHRvIGJlIHNhZmUsIEkgY2FuIG1vdmUgdGhlIGRlZmluaXRpb24gdG8gYXJjaC94 ODYva3ZtL21tdS9tbXUuYwo+IGFzIGEgbm9uLWlubGluZSBmdW5jdGlvbi4KCk5vIG5lZWQsIGFz bS9rdm1faG9zdC5oIF9tdXN0XyBiZSBpbmNsdWRlZCBiZWZvcmUgdGhlIGRlY2xhcmF0aW9uLCBv dGhlcndpc2UgdGhlCmRlY2xhcmF0aW9uIHdvdWxkbid0IGJlIG1hZGUgYmVjYXVzZSBfX0tWTV9I QVZFX0FSQ0hfRkxVU0hfUkVNT1RFX1RMQlMgd291bGRuJ3QKYmUgZGVmaW5lZC4gIEkuZS4gd2Ug d29uJ3QgcnVuIGludG8gaXNzdWVzIHdoZXJlIHRoZSBub24tc3RhdGljIGRlY2xhcmF0aW9uIGNv bWVzCmJlZm9yZSB0aGUgc3RhdGljIGlubGluZSBkZWZpbml0aW9uLgoKQzk5IGV4cGxpY2l0bHkg Y292ZXJzIHRoaXMgY2FzZToKCiAgNi4yLjIgTGlua2FnZXMgb2YgaWRlbnRpZmllcnMKCiAgLi4u CgogIElmIHRoZSBkZWNsYXJhdGlvbiBvZiBhIGZpbGUgc2NvcGUgaWRlbnRpZmllciBmb3IgYW4g b2JqZWN0IG9yIGEgZnVuY3Rpb24gY29udGFpbnMgdGhlIHN0b3JhZ2UtCiAgY2xhc3Mgc3BlY2lm aWVyIHN0YXRpYywgdGhlIGlkZW50aWZpZXIgaGFzIGludGVybmFsIGxpbmthZ2UuCgogIEZvciBh biBpZGVudGlmaWVyIGRlY2xhcmVkIHdpdGggdGhlIHN0b3JhZ2UtY2xhc3Mgc3BlY2lmaWVyIGV4 dGVybiBpbiBhIHNjb3BlIGluIHdoaWNoIGEKICBwcmlvciBkZWNsYXJhdGlvbiBvZiB0aGF0IGlk ZW50aWZpZXIgaXMgdmlzaWJsZSBpZiB0aGUgcHJpb3IgZGVjbGFyYXRpb24gc3BlY2lmaWVzIGlu dGVybmFsIG9yCiAgZXh0ZXJuYWwgbGlua2FnZSwgdGhlIGxpbmthZ2Ugb2YgdGhlIGlkZW50aWZp ZXIgYXQgdGhlIGxhdGVyIGRlY2xhcmF0aW9uIGlzIHRoZSBzYW1lIGFzIHRoZQogIGxpbmthZ2Ug c3BlY2lmaWVkIGF0IHRoZSBwcmlvciBkZWNsYXJhdGlvbi4gSWYgbm8gcHJpb3IgZGVjbGFyYXRp b24gaXMgdmlzaWJsZSwgb3IgaWYgdGhlIHByaW9yCiAgZGVjbGFyYXRpb24gc3BlY2lmaWVzIG5v IGxpbmthZ2UsIHRoZW4gdGhlIGlkZW50aWZpZXIgaGFzIGV4dGVybmFsIGxpbmthZ2UuCgpJbiBz aG9ydCwgYmVjYXVzZSB0aGUgInN0YXRpYyBpbmxpbmUiIGRlY2xhcmVkIGludGVybmFsIGxpbmth Z2UgZmlyc3QsIGl0IHdpbnMuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA1C0C04A94 for ; Thu, 10 Aug 2023 22:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=DJqFI1oUv/P1/Cmjo1SegLIdDX/1OfXK+PHAAoMMEnA=; b=pdiPrkqvssjLs2OELHbDfga2gV P/2bgLOpFkIyKW4kV2c8netyyeMNWUkBaKAON1j6mQRJLGldmMUCoUEUbg5Djhn07WGS0mB4VFiXm By+fuMfO044aw+ntrVQXoi0H0cyBhXGxlYrH+u37LCzqHC0wm1drk/VJBfNfDgedY21Hr9gk2b6o1 MA5jMorPJAiJN9nQXPpgv6wGShieRTZBNMvbp9V2lt/4Cis9R4+6BUYl0Fh1SIx1FAmjb9XYQIp8c 4cJhkXWazf7WeZ9SHfmZ5CF6wdiJDAKfOCLvOh+vJqodxlj2xTSgvfY1uoRzd8nIEzE0uKLjO1f6w FgAH522A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUE1M-008pRq-10; Thu, 10 Aug 2023 22:20:44 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUE1J-008pOe-1T for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 22:20:42 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-56942442eb0so17973637b3.1 for ; Thu, 10 Aug 2023 15:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691706015; x=1692310815; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=tmBFxKohqxWGeEzlaaidWaFnJW/Oy/RvfXuIqafrWOM=; b=6JTyZrfrPMxEB4xAyKq26rEGx6dnOtJemt5mF01prNKQ3cUVfJruc7Fe7RGiRWwnTQ JNdckI2vLoo+gqpkJ4Y/rCI2rOTa5hAiAak/2PN2K2x99UdsCwMzOR99izlBg4yxVppk dQK8g/hJNDIeks6PwAz/oyY3lHetOC4GBoRbRmdSsLay+vWH0iHE9YncdP80LYWTblDI iYMvC5FUjVcDsM/OLHEHwIfhMK0QewWcYKuW2IlqTPX5Otlz706FwBUZ5hXu21vGQIT4 uYlRsQgCaSIAFf7MMqxoS33uW0RGdAOE21lmj0iEkCe384OiQkcbcQF5CJ0cTVjotCgp pMJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691706015; x=1692310815; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tmBFxKohqxWGeEzlaaidWaFnJW/Oy/RvfXuIqafrWOM=; b=eIkopXnFZdOae4qmMEWrLf+AFK3JWEE0atmXTwvdDCy8QDPrrOOOd2bNJZpIKR27Nh oibESoQVziDAOpGwgoRs3FQeiYhzQIAiHu+bhncQ+MSdVfSDZFS+SfT/JWJ/x05oSeY6 HbbGoQwMELyEswJEmdBEqHWXStpRXTNSukb8nTDQZ4ZgQ7qb5HR/+YpZhcZEZrGyQn4t 6JijYIcyFaxB9qdZq+9WDuA//q3IUAV9jAN/C/2CWNiYZNUbIW39Ed7tDWGgG1PMG7lK TIblOO6ZJbatWOXQbrEmNIYqyBr7z0Ue8GbRfvZ+vUaNBYQctIyqg8JcbuEu8h/S+6kV a2lg== X-Gm-Message-State: AOJu0Yz5IcbZqOErsLLBamCTyW8X1M3l00qiBHE64jCzhHWY+U6zXZTJ h65hp5ZjB6qrHtFaK0DMnCHiiXVQU64= X-Google-Smtp-Source: AGHT+IFA+Eoa7k6dQo7jnaWMJsrKFJ33ryvAj3Q3LxXldo+rT6OtEr7lMPaA/JwDbq8aHQpRj3zalPzAYew= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:690c:709:b0:57a:118a:f31 with SMTP id bs9-20020a05690c070900b0057a118a0f31mr4149ywb.7.1691706015047; Thu, 10 Aug 2023 15:20:15 -0700 (PDT) Date: Thu, 10 Aug 2023 15:20:13 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230808231330.3855936-1-rananta@google.com> <20230808231330.3855936-3-rananta@google.com> <30e45ef3-309a-63de-e085-be1645c1be79@redhat.com> Message-ID: Subject: Re: [PATCH v8 02/14] KVM: Declare kvm_arch_flush_remote_tlbs() globally From: Sean Christopherson To: Raghavendra Rao Ananta Cc: Shaoqin Huang , Gavin Shan , Oliver Upton , Marc Zyngier , James Morse , Suzuki K Poulose , Paolo Bonzini , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , Fuad Tabba , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_152041_496030_DC924F10 X-CRM114-Status: GOOD ( 25.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBdWcgMTAsIDIwMjMsIFJhZ2hhdmVuZHJhIFJhbyBBbmFudGEgd3JvdGU6Cj4gT24g VGh1LCBBdWcgMTAsIDIwMjMgYXQgNToyNuKAr0FNIFNoYW9xaW4gSHVhbmcgPHNoYWh1YW5nQHJl ZGhhdC5jb20+IHdyb3RlOgo+ID4gT24gOC8xMC8yMyAwMDozOCwgUmFnaGF2ZW5kcmEgUmFvIEFu YW50YSB3cm90ZToKPiA+ID4+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9rdm1faG9zdC5o IGIvaW5jbHVkZS9saW51eC9rdm1faG9zdC5oCj4gPiA+Pj4gaW5kZXggZTNmOTY4YjM4YWU5Ny4u YWRlNWQ0NTAwYzJjZSAxMDA2NDQKPiA+ID4+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0 LmgKPiA+ID4+PiArKysgYi9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmgKPiA+ID4+PiBAQCAtMTQ4 NCw2ICsxNDg0LDggQEAgc3RhdGljIGlubGluZSBpbnQga3ZtX2FyY2hfZmx1c2hfcmVtb3RlX3Rs YnMoc3RydWN0IGt2bSAqa3ZtKQo+ID4gPj4+ICAgIHsKPiA+ID4+PiAgICAgICAgcmV0dXJuIC1F Tk9UU1VQUDsKPiA+ID4+PiAgICB9Cj4gPiA+Pj4gKyNlbHNlCj4gPiA+Pj4gK2ludCBrdm1fYXJj aF9mbHVzaF9yZW1vdGVfdGxicyhzdHJ1Y3Qga3ZtICprdm0pOwo+ID4gPj4+ICAgICNlbmRpZgo+ ID4gPj4+Cj4gPiA+Pj4gICAgI2lmZGVmIF9fS1ZNX0hBVkVfQVJDSF9OT05DT0hFUkVOVF9ETUEK PiA+ID4+Cj4gPiA+PiBJcyB0aGUgZGVjbGFyYXRpb24gaW5jb25zaXN0ZW50IHRvIHRoYXQgaW4g YXJjaC94ODYvaW5jbHVkZS9hc20va3ZtX2hvc3QuaD8KPiA+ID4+IEluIG9yZGVyIHRvIGtlZXAg dGhlbSBjb25zaXN0ZW50LCBJIGd1ZXNzIHdlIG5lZWQgbW92ZSBrdm1fYXJjaF9mbHVzaF9yZW1v dGVfdGxicygpCj4gPiA+PiBmcm9tIHg4NidzIGhlYWRlciBmaWxlIHRvIGFyY2gveDg2L2t2bS9t bXUvbW11LmMgYW5kICdpbmxpbmUnIG5lZWRzIHRvIGJlIGRyb3BwZWQuCj4gPiA+Pgo+ID4gPiBV bnN1cmUgb2YgdGhlIG9yaWdpbmFsIGludGVudGlvbnMsIEkgZGlkbid0IHdhbnQgdG8gZGlzdHVy YiBhbnkKPiA+ID4gZXhpc3RpbmcgYXJyYW5nZW1lbnRzLiBJZiBtb3JlIHBlb3BsZSBhZ3JlZSB0 byB0aGlzIHJlZmFjdG9yaW5nLCBJJ20KPiA+ID4gaGFwcHkgdG8gbW92ZS4KPiA+Cj4gPiBUaGlz IGlzIGFtYXppbmcgdG8gbWUuIFRoaXMgY2hhbmdlIGNhbiBiZSBjb21waWxlZCB3aXRob3V0IGFu eSBlcnJvcgo+ID4gZXZlbiBpZiB0aGUgZGVjbGFyYXRpb24gaW5jb25zaXN0ZW50IGJldHdlZW4g dGhlIGt2bV9ob3N0LmggYW5kIHg4NidzCj4gPiBoZWFkZXIgZmlsZS4KPiA+Cj4gPiBJJ20gY3Vy aW91cyB3aGljaCBvcHRpb24gbWFrZSBpdCBwb3NzaWJsZT8KPiA+Cj4gQWZ0ZXIgZG9pbmcgc29t ZSBleHBlcmltZW50cywgSSB0aGluayBpdCB3b3JrcyBiZWNhdXNlIG9mIHRoZSBvcmRlciBpbgo+ IHdoaWNoIHRoZSBpbmxpbmUtZGVmaW5pdGlvbiBhbmQgdGhlIGRlY2xhcmF0aW9uIGFyZSBsYWlk IG91dC4gSWYgdGhlCj4gJ2lubGluZScgcGFydCBvZiB0aGUgZnVuY3Rpb24gY29tZXMgZmlyc3Qg YW5kIHRoZW4gdGhlIGRlY2xhcmF0aW9uLCB3ZQo+IGRvbid0IHNlZSBhbnkgZXJyb3IuIEhvd2V2 ZXIgaWYgdGhlIHBvc2l0aW9ucyB3ZXJlIHJldmVyc2VkLCB3ZSB3b3VsZAo+IHNlZSBhbiBlcnJv ci4gKEknbSBub3Qgc3VyZSB3aGF0IHRoZSB0ZWNobmljYWwgcmVhc29uIGZvciB0aGlzIGlzKS4K PiAKPiBKdXN0IHRvIGJlIHNhZmUsIEkgY2FuIG1vdmUgdGhlIGRlZmluaXRpb24gdG8gYXJjaC94 ODYva3ZtL21tdS9tbXUuYwo+IGFzIGEgbm9uLWlubGluZSBmdW5jdGlvbi4KCk5vIG5lZWQsIGFz bS9rdm1faG9zdC5oIF9tdXN0XyBiZSBpbmNsdWRlZCBiZWZvcmUgdGhlIGRlY2xhcmF0aW9uLCBv dGhlcndpc2UgdGhlCmRlY2xhcmF0aW9uIHdvdWxkbid0IGJlIG1hZGUgYmVjYXVzZSBfX0tWTV9I QVZFX0FSQ0hfRkxVU0hfUkVNT1RFX1RMQlMgd291bGRuJ3QKYmUgZGVmaW5lZC4gIEkuZS4gd2Ug d29uJ3QgcnVuIGludG8gaXNzdWVzIHdoZXJlIHRoZSBub24tc3RhdGljIGRlY2xhcmF0aW9uIGNv bWVzCmJlZm9yZSB0aGUgc3RhdGljIGlubGluZSBkZWZpbml0aW9uLgoKQzk5IGV4cGxpY2l0bHkg Y292ZXJzIHRoaXMgY2FzZToKCiAgNi4yLjIgTGlua2FnZXMgb2YgaWRlbnRpZmllcnMKCiAgLi4u CgogIElmIHRoZSBkZWNsYXJhdGlvbiBvZiBhIGZpbGUgc2NvcGUgaWRlbnRpZmllciBmb3IgYW4g b2JqZWN0IG9yIGEgZnVuY3Rpb24gY29udGFpbnMgdGhlIHN0b3JhZ2UtCiAgY2xhc3Mgc3BlY2lm aWVyIHN0YXRpYywgdGhlIGlkZW50aWZpZXIgaGFzIGludGVybmFsIGxpbmthZ2UuCgogIEZvciBh biBpZGVudGlmaWVyIGRlY2xhcmVkIHdpdGggdGhlIHN0b3JhZ2UtY2xhc3Mgc3BlY2lmaWVyIGV4 dGVybiBpbiBhIHNjb3BlIGluIHdoaWNoIGEKICBwcmlvciBkZWNsYXJhdGlvbiBvZiB0aGF0IGlk ZW50aWZpZXIgaXMgdmlzaWJsZSBpZiB0aGUgcHJpb3IgZGVjbGFyYXRpb24gc3BlY2lmaWVzIGlu dGVybmFsIG9yCiAgZXh0ZXJuYWwgbGlua2FnZSwgdGhlIGxpbmthZ2Ugb2YgdGhlIGlkZW50aWZp ZXIgYXQgdGhlIGxhdGVyIGRlY2xhcmF0aW9uIGlzIHRoZSBzYW1lIGFzIHRoZQogIGxpbmthZ2Ug c3BlY2lmaWVkIGF0IHRoZSBwcmlvciBkZWNsYXJhdGlvbi4gSWYgbm8gcHJpb3IgZGVjbGFyYXRp b24gaXMgdmlzaWJsZSwgb3IgaWYgdGhlIHByaW9yCiAgZGVjbGFyYXRpb24gc3BlY2lmaWVzIG5v IGxpbmthZ2UsIHRoZW4gdGhlIGlkZW50aWZpZXIgaGFzIGV4dGVybmFsIGxpbmthZ2UuCgpJbiBz aG9ydCwgYmVjYXVzZSB0aGUgInN0YXRpYyBpbmxpbmUiIGRlY2xhcmVkIGludGVybmFsIGxpbmth Z2UgZmlyc3QsIGl0IHdpbnMuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==