All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [PATCH] xen: Update arm assembly patch to upstream accepted one
Date: Sat, 12 Aug 2023 03:15:36 +0000	[thread overview]
Message-ID: <ZNb5WPv6Nw5fpkaD@gmail.com> (raw)
In-Reply-To: <20230808172553.3632648-1-raj.khem@gmail.com>

merged.

Bruce

In message: [meta-virtualization] [PATCH] xen: Update arm assembly patch to upstream accepted one
on 08/08/2023 Khem Raj wrote:

> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  ...g-solaris-syntax-for-.section-direct.patch | 48 +++++++++++--------
>  1 file changed, 28 insertions(+), 20 deletions(-)
> 
> diff --git a/recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch b/recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch
> index c73bb27..a4038dd 100644
> --- a/recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch
> +++ b/recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch
> @@ -1,33 +1,35 @@
> -From 9add6f9aced42a76f6a2c124754bef6fde56fa05 Mon Sep 17 00:00:00 2001
> +From dfc490a3740bb7d6889939934afadcb58891fbce Mon Sep 17 00:00:00 2001
>  From: Khem Raj <raj.khem@gmail.com>
> -To: xen-devel@lists.xenproject.org
> -Cc: Stefano Stabellini <sstabellini@kernel.org>
> -Cc: Julien Grall <julien@xen.org>
> -Cc: Bertrand Marquis <bertrand.marquis@arm.com>
> -Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> -Date: Mon, 31 Jul 2023 17:01:32 -0700
> -Subject: [PATCH] arm32: Avoid using solaris syntax for .section directive
> +Date: Tue, 1 Aug 2023 10:49:30 -0700
> +Subject: [PATCH] arm: Avoid using solaris syntax for .section directive
>  
> -Assembler from binutils 2.41 rejects this syntax
> +Assembler from binutils 2.41 will rejects ([1], [2]) the following
> +syntax
>  
> -.section "name"[, flags...]
> +.section "name", #alloc
>  
> -where flags could be #alloc, #write, #execstr
> -Switch to using ELF syntax
> +for any other any target other than ELF SPARC. This means we can't use
> +it in the Arm code.
>  
> -.section name[, "flags"[, @type]]
> +So switch to the GNU syntax
>  
> -[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119
> +.section name [, "flags"[, @type]]
>  
> -Upstream-Status: Submitted [by email to xen-devel@lists.xenproject.org and maintainers]
> +[1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601
> +[2] https://sourceware.org/binutils/docs-2.41/as.html#Section
>  
> +Upstream-Status: Backport [https://github.com/xen-project/xen/commit/dfc490a3740bb7d6889939934afadcb58891fbce]
>  Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +Reviewed-by: Michal Orzel <michal.orzel@amd.com>
> +[jgrall: Reword commit message]
> +Acked-by: Julien Grall <jgrall@amazon.com>
>  ---
>   xen/arch/arm/arm32/proc-v7.S | 6 +++---
> - 1 file changed, 3 insertions(+), 3 deletions(-)
> + xen/arch/arm/dtb.S           | 2 +-
> + 2 files changed, 4 insertions(+), 4 deletions(-)
>  
>  diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
> -index c90a31d80f..6d3d19b873 100644
> +index c90a31d80fc5..6d3d19b87354 100644
>  --- a/xen/arch/arm/arm32/proc-v7.S
>  +++ b/xen/arch/arm/arm32/proc-v7.S
>  @@ -29,7 +29,7 @@ brahma15mp_init:
> @@ -57,6 +59,12 @@ index c90a31d80f..6d3d19b873 100644
>           .type __v7_brahma15mp_proc_info, #object
>   __v7_brahma15mp_proc_info:
>           .long 0x420F00F0             /* Broadcom Brahma-B15 */
> --- 
> -2.41.0
> -
> +diff --git a/xen/arch/arm/dtb.S b/xen/arch/arm/dtb.S
> +index c39f3a095c58..386f83ba649e 100644
> +--- a/xen/arch/arm/dtb.S
> ++++ b/xen/arch/arm/dtb.S
> +@@ -1,3 +1,3 @@
> +-        .section .dtb,#alloc
> ++        .section .dtb, "a"
> +         GLOBAL(_sdtb)
> +         .incbin CONFIG_DTB_FILE
> -- 
> 2.41.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8169): https://lists.yoctoproject.org/g/meta-virtualization/message/8169
> Mute This Topic: https://lists.yoctoproject.org/mt/100626730/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      reply	other threads:[~2023-08-12  3:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 17:25 [PATCH] xen: Update arm assembly patch to upstream accepted one Khem Raj
2023-08-12  3:15 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNb5WPv6Nw5fpkaD@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.