From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 624D5C04A6A for ; Sat, 12 Aug 2023 06:19:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DAE3760A70; Sat, 12 Aug 2023 06:19:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DAE3760A70 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1691821193; bh=LMdhUXCKepyJ3Nx8H89CJxtZt7uET1FHwb6FjaFs9z8=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=OZpFtf4yjqbtdUBr+kwDWDrVqQrYrWt7bKJWKi9PVs4WA28/laJDgi78trafzPm0s juBlykCFerbNK0VJ0vXApc66ziW/QlEteSzbofLtJxoCtiugnucnb9CcHW1GuugEYk Hi7jmGEMtMs5GfVadwGXB3eumpabV/SosdD/EteqkT5wcGKHSBs14CCThFsMaNx8+8 9TWPA5WePTk9zRAUh+PbSOnth5qSAI2reMCBUo1WBLW7iBvl/juaMFKrH5yE++38l3 AGtxIQl028iv10kiIfeAnkyEt4zRqOuO8KiP8muT66kmWm9xYRr5X94FcA1IbY6uyl kEBI6pq94YxLQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id siU5QRhKJbU5; Sat, 12 Aug 2023 06:19:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id F16A860A79; Sat, 12 Aug 2023 06:19:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org F16A860A79 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2D8951BF291 for ; Sat, 12 Aug 2023 06:19:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0422382163 for ; Sat, 12 Aug 2023 06:19:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0422382163 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zv_VEn_8PxTW for ; Sat, 12 Aug 2023 06:19:49 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by smtp1.osuosl.org (Postfix) with ESMTPS id 3BDFC82109 for ; Sat, 12 Aug 2023 06:19:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3BDFC82109 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-99c0cb7285fso342476166b.0 for ; Fri, 11 Aug 2023 23:19:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691821187; x=1692425987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TjmLF1rO5TorvHBy4pxrBOw1UIR+s/EKu3iHtx+Nh50=; b=V1WO4l+BmrRmW9e+X3EwjYeG9KLsTC9cjUTEPLrKymXdoCzYu+b9OWbZZszV2nYgdk eCWed8NfGgBIMVYFz8viT0KPBw5BjAV0EDir0q+rsl6S93E1c/hEhfVOLyfzEOidXEJo kEnEqPa9cUZoU3bQBerqrtEvdWYWEDfs8Vg+utEMpwDyeyPGOI74vFIqgCVmGeJB1gDi WroauoICGT4bz8P7/ju/FNUyfufLWENVUW0eqDcncuAi/J5DZUIdMybyUI3okCDbrUJB JbkESYjjDgizKv7wr7jX4xheiATb/F911jqq5L2T9EbGCRRQM12gwIXMeq62xYQ+IOU2 4wLQ== X-Gm-Message-State: AOJu0Yy86a+r/9rQXf1H3PKLQuyCo3mUvC0uNRpVZqPPk2HLjxu1Awn8 b3Pb88UqVs23XPswyEGRg86O/A== X-Google-Smtp-Source: AGHT+IEPlIXz5uM26zKwi4mc++wqqZbRXc7W1xYTx2DsLMBRS7DeeCnK6XHSPYqBnlnaUBHaDTo/VQ== X-Received: by 2002:a17:907:7859:b0:994:4e9c:30c6 with SMTP id lb25-20020a170907785900b009944e9c30c6mr3096190ejc.57.1691821186721; Fri, 11 Aug 2023 23:19:46 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id g18-20020a1709067c5200b0099316c56db9sm3059967ejp.127.2023.08.11.23.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 23:19:46 -0700 (PDT) Date: Sat, 12 Aug 2023 08:19:45 +0200 From: Jiri Pirko To: Vadim Fedorenko Message-ID: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-8-vadim.fedorenko@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230811200340.577359-8-vadim.fedorenko@linux.dev> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1691821187; x=1692425987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TjmLF1rO5TorvHBy4pxrBOw1UIR+s/EKu3iHtx+Nh50=; b=P+eORdmHrfUq0eOC5J81tYaBqXZES0VMhvt28KeKlsdwVdQpvsQD5ws3OtjN61fsgW LVoGtSoX3FefyuQTIaB8zYNKuSxbNG7Kj9xVwmjUNjHhDFvIEpmCafNB8KvndOfaHzFh 6HOAOEQ/SJPuUqYcxHwe08SPbR8UNlIIZAEqiZj9YHsM1LzV6oYVfpwyJcb7x6BH49np jP1vDVspTKKs8a75LKKcYQbm7izz/USlZJCDuZi0tdgAVHZlT8TGB4+gRbN9bw7qmYMW u29Een9xQ3Xiq2P5NnCv95RmRDSHakE1P9iAWWH2Zb9z7WLal0BcUGtiHHfqqri66zI5 uQ5w== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20221208.gappssmtp.com header.i=@resnulli-us.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=P+eORdmH Subject: Re: [Intel-wired-lan] [PATCH net-next v4 7/9] ice: implement dpll interface to control cgu X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bart Van Assche , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, Jiri Pirko , Jonathan Lemon , Jakub Kicinski , Paolo Abeni , linux-clk@vger.kernel.org, Milena Olech Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Fri, Aug 11, 2023 at 10:03:38PM CEST, vadim.fedorenko@linux.dev wrote: [...] >@@ -4690,6 +4694,8 @@ static void ice_deinit_features(struct ice_pf *pf) > ice_gnss_exit(pf); > if (test_bit(ICE_FLAG_PTP_SUPPORTED, pf->flags)) > ice_ptp_release(pf); >+ if (test_bit(ICE_FLAG_DPLL, pf->flags)) This is a duplicate test as you test it as a first thing in ice_dpll_deinit(). But nevermind this nit, let's have v4 merged if possible. >+ ice_dpll_deinit(pf); > } > > static void ice_init_wakeup(struct ice_pf *pf) >-- >2.27.0 > _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B2CC41513 for ; Sat, 12 Aug 2023 06:19:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbjHLGTu (ORCPT ); Sat, 12 Aug 2023 02:19:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbjHLGTu (ORCPT ); Sat, 12 Aug 2023 02:19:50 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D4FA1FE6 for ; Fri, 11 Aug 2023 23:19:49 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-99c1d03e124so339591966b.2 for ; Fri, 11 Aug 2023 23:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1691821187; x=1692425987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TjmLF1rO5TorvHBy4pxrBOw1UIR+s/EKu3iHtx+Nh50=; b=P+eORdmHrfUq0eOC5J81tYaBqXZES0VMhvt28KeKlsdwVdQpvsQD5ws3OtjN61fsgW LVoGtSoX3FefyuQTIaB8zYNKuSxbNG7Kj9xVwmjUNjHhDFvIEpmCafNB8KvndOfaHzFh 6HOAOEQ/SJPuUqYcxHwe08SPbR8UNlIIZAEqiZj9YHsM1LzV6oYVfpwyJcb7x6BH49np jP1vDVspTKKs8a75LKKcYQbm7izz/USlZJCDuZi0tdgAVHZlT8TGB4+gRbN9bw7qmYMW u29Een9xQ3Xiq2P5NnCv95RmRDSHakE1P9iAWWH2Zb9z7WLal0BcUGtiHHfqqri66zI5 uQ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691821187; x=1692425987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TjmLF1rO5TorvHBy4pxrBOw1UIR+s/EKu3iHtx+Nh50=; b=JOUFyAdCy35ccowyhc09XEiRJmuCq7mNcKJVpSIkjMKLes7oTwi7dmc+p+4MFNx6ME 8JrWLgWfxlYNZo8yCYLwp5xGzPdKOdoJMQc8t1DMruK2/nxr/b4XkxSCerG6q5XF2db2 jU0EYNOfmPCKaw6s8aIVdmbhgDO2TaDJGp6LHSus+5U8R163vWdbypWMNC0U6WeM1ysu DV3LkYD3Jl6QrxhKM12A/LOlYkjRQ6sDiom3pZXhGx0A5ckmR8ob6KqBsnLqnCJuq91v yKjYgyk+K3RBLLwo/GZl21JFpmPbE6L2x2dIpnS1eNBmKl6KG+wP3t8q/PErqkV6h5Gz 9LSQ== X-Gm-Message-State: AOJu0Yyb99oJVjqmgKk87w6LsOxo5evGR7h6v50iRxqXQXVl9ywrW5ej AkecY/I11fH+wzCpgPAJiPnN9g== X-Google-Smtp-Source: AGHT+IEPlIXz5uM26zKwi4mc++wqqZbRXc7W1xYTx2DsLMBRS7DeeCnK6XHSPYqBnlnaUBHaDTo/VQ== X-Received: by 2002:a17:907:7859:b0:994:4e9c:30c6 with SMTP id lb25-20020a170907785900b009944e9c30c6mr3096190ejc.57.1691821186721; Fri, 11 Aug 2023 23:19:46 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id g18-20020a1709067c5200b0099316c56db9sm3059967ejp.127.2023.08.11.23.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 23:19:46 -0700 (PDT) Date: Sat, 12 Aug 2023 08:19:45 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko Subject: Re: [PATCH net-next v4 7/9] ice: implement dpll interface to control cgu Message-ID: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-8-vadim.fedorenko@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811200340.577359-8-vadim.fedorenko@linux.dev> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Fri, Aug 11, 2023 at 10:03:38PM CEST, vadim.fedorenko@linux.dev wrote: [...] >@@ -4690,6 +4694,8 @@ static void ice_deinit_features(struct ice_pf *pf) > ice_gnss_exit(pf); > if (test_bit(ICE_FLAG_PTP_SUPPORTED, pf->flags)) > ice_ptp_release(pf); >+ if (test_bit(ICE_FLAG_DPLL, pf->flags)) This is a duplicate test as you test it as a first thing in ice_dpll_deinit(). But nevermind this nit, let's have v4 merged if possible. >+ ice_dpll_deinit(pf); > } > > static void ice_init_wakeup(struct ice_pf *pf) >-- >2.27.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59080C0015E for ; Sat, 12 Aug 2023 06:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VFaRmZNIhs8l1M8tHedI2oIMu5DARUVYZiUec62NN/c=; b=UyfcrBLqTLB/61 7SI2GcV4fm/9Yduw1f9VaKJdBGWvOpMXRX9WtTJUebqt9NJPZgQIlbDy6QS1hVGJ3hqXpcEnNXfF+ t62te1M+HYoqBmWtNmcUYjZBO0GwtqfGaouk4DiOHcyrvXtv5It6/etpWhafWuVlSprSyyvnwO3+O LfmslpSJWLG26KAd+rEWTlS5kwpgikV2Txi3M8zF8PU6BOAJWF6TDsVdE2OAYhIH/7tIO/XenJDOc rQlOhxp8wcdqfP4Dur+LgKUdofRWMrK07rx0l49p76cqSn6jivZBzfvOc/UqU/blNCRqIjG/WfDcf +LZm3VbO6jg2Kgxkr2tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUhyb-00Cm3r-2O; Sat, 12 Aug 2023 06:19:53 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUhyY-00Cm35-00 for linux-arm-kernel@lists.infradead.org; Sat, 12 Aug 2023 06:19:52 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-99c1d03e124so339591866b.2 for ; Fri, 11 Aug 2023 23:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1691821187; x=1692425987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TjmLF1rO5TorvHBy4pxrBOw1UIR+s/EKu3iHtx+Nh50=; b=P+eORdmHrfUq0eOC5J81tYaBqXZES0VMhvt28KeKlsdwVdQpvsQD5ws3OtjN61fsgW LVoGtSoX3FefyuQTIaB8zYNKuSxbNG7Kj9xVwmjUNjHhDFvIEpmCafNB8KvndOfaHzFh 6HOAOEQ/SJPuUqYcxHwe08SPbR8UNlIIZAEqiZj9YHsM1LzV6oYVfpwyJcb7x6BH49np jP1vDVspTKKs8a75LKKcYQbm7izz/USlZJCDuZi0tdgAVHZlT8TGB4+gRbN9bw7qmYMW u29Een9xQ3Xiq2P5NnCv95RmRDSHakE1P9iAWWH2Zb9z7WLal0BcUGtiHHfqqri66zI5 uQ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691821187; x=1692425987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TjmLF1rO5TorvHBy4pxrBOw1UIR+s/EKu3iHtx+Nh50=; b=koRUH6y6mIJCb5qHI1THVxoZAdzEFPU/Qtz0Iqgr94pq55VawFz/jv9faLHzZje7Rn HmmCZlz1Dpv7BRqaYcGHe07Wm7oWpj7HwLQqBxrHLwxuReFEQ/nUVOtRvyon9rjaEMDU HpVVpNldc7wznokhab8RamgJkNPX86KqBfU7AH+LSuobhygq3cgFgqhNs1WVEZnyZUKY /IsPXnuXuAs75ZB7POlAcZHFoLyWIlOxwA4va2pwOG35nKdmVcLCDbtnYyJE3/s1T/A7 S+DnsKpQppI8sK1mtuG8SPAwbhNU8mHe+6yy70xjPFymjU/WCPvmn3SUlLGda8FswG8w h2ug== X-Gm-Message-State: AOJu0Yy+hcmWc4tuDyoGk7Ywf2KWYqqnGRzcK/YjsmiV0cURBa4S2gdY ++ws9/hPArUOQmRRMy6QUvg/gQ== X-Google-Smtp-Source: AGHT+IEPlIXz5uM26zKwi4mc++wqqZbRXc7W1xYTx2DsLMBRS7DeeCnK6XHSPYqBnlnaUBHaDTo/VQ== X-Received: by 2002:a17:907:7859:b0:994:4e9c:30c6 with SMTP id lb25-20020a170907785900b009944e9c30c6mr3096190ejc.57.1691821186721; Fri, 11 Aug 2023 23:19:46 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id g18-20020a1709067c5200b0099316c56db9sm3059967ejp.127.2023.08.11.23.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 23:19:46 -0700 (PDT) Date: Sat, 12 Aug 2023 08:19:45 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko Subject: Re: [PATCH net-next v4 7/9] ice: implement dpll interface to control cgu Message-ID: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-8-vadim.fedorenko@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230811200340.577359-8-vadim.fedorenko@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230811_231950_252584_F87569F4 X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, Aug 11, 2023 at 10:03:38PM CEST, vadim.fedorenko@linux.dev wrote: [...] >@@ -4690,6 +4694,8 @@ static void ice_deinit_features(struct ice_pf *pf) > ice_gnss_exit(pf); > if (test_bit(ICE_FLAG_PTP_SUPPORTED, pf->flags)) > ice_ptp_release(pf); >+ if (test_bit(ICE_FLAG_DPLL, pf->flags)) This is a duplicate test as you test it as a first thing in ice_dpll_deinit(). But nevermind this nit, let's have v4 merged if possible. >+ ice_dpll_deinit(pf); > } > > static void ice_init_wakeup(struct ice_pf *pf) >-- >2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel