All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc: "Yuan, Perry" <Perry.Yuan@amd.com>,
	"Karny, Wyes" <Wyes.Karny@amd.com>,
	"trenn@suse.com" <trenn@suse.com>,
	"shuah@kernel.org" <shuah@kernel.org>,
	"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"chenhq2005@gmail.com" <chenhq2005@gmail.com>
Subject: Re: [PATCH] cpupower: Fix querying boost support for amd-pstate-epp mode
Date: Mon, 14 Aug 2023 12:14:58 +0800	[thread overview]
Message-ID: <ZNmqQkOK7CLa7TNl@amd.com> (raw)
In-Reply-To: <20230811213501.17293-1-mario.limonciello@amd.com>

On Sat, Aug 12, 2023 at 05:35:01AM +0800, Limonciello, Mario wrote:
> When running in active mode the driver for amd-pstate has -epp appended.
> This throws off amd-pstate detection.
> 
> To detect amd-pstate look for the prefix instead.
> 
> Fixes: ffa5096a7c33 ("cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors")
> Reported-by: chenhq2005@gmail.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217755
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  tools/power/cpupower/utils/helpers/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> index 9547b29254a7f..01c0440efe850 100644
> --- a/tools/power/cpupower/utils/helpers/misc.c
> +++ b/tools/power/cpupower/utils/helpers/misc.c
> @@ -95,7 +95,7 @@ bool cpupower_amd_pstate_enabled(void)
>  	if (!driver)
>  		return ret;
>  
> -	if (!strcmp(driver, "amd-pstate"))
> +	if (!strncmp(driver, "amd-pstate", 10))
>  		ret = true;
>  
>  	cpufreq_put_driver(driver);
> -- 
> 2.34.1
> 

  reply	other threads:[~2023-08-14  4:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11 21:35 [PATCH] cpupower: Fix querying boost support for amd-pstate-epp mode Mario Limonciello
2023-08-14  4:14 ` Huang Rui [this message]
2023-08-14 21:28   ` Shuah Khan
2023-08-14 21:50     ` Limonciello, Mario
2023-08-14 23:22       ` Shuah Khan
2023-08-14 23:33         ` Limonciello, Mario
2023-08-15  0:03           ` Shuah Khan
2023-08-15  1:46             ` Limonciello, Mario

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNmqQkOK7CLa7TNl@amd.com \
    --to=ray.huang@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Perry.Yuan@amd.com \
    --cc=Wyes.Karny@amd.com \
    --cc=chenhq2005@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.