From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE738C001B0 for ; Tue, 15 Aug 2023 11:52:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4FA8E61102; Tue, 15 Aug 2023 11:52:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4FA8E61102 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692100339; bh=8GM30dp4FqYcWeuMBH80kiIl7afAqiSrYuFJsvknlzQ=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=F7tG6kkCeSNPqD2ii120Sl69NERuzcqebHqo1faB5yM4mz3DHK/jCaCBbHgzcvx8k kgJEv6N5uqpciFQg11WEQCPr1i9hFJYxjaFYM9RNRJUMTPLXZiklyUQbdVdlJVvxwz 6x8AHKjqBZOkdjuATO+usr0PWSoZe9BbKt2vFG4LofJzG3VTM4gAl6vl1O8YuEDpdt Tmfg029cJYwkO52RtSRvN9rnX6nxLen54BAtKBDSIYhorrXd3P4pGkH0C0pmFFjePW 0GGc9/qBwdxSj2tDJUXJSEkRc6pa9D2ACkFvY5y3VlvHQlCUva8cpw+gh3BlTAVZjD +H7OhE27bm7HQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sCApaRo3rzph; Tue, 15 Aug 2023 11:52:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 4F8ED61103; Tue, 15 Aug 2023 11:52:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4F8ED61103 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 164431BF3FF for ; Tue, 15 Aug 2023 11:52:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E4A3F81F50 for ; Tue, 15 Aug 2023 11:52:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E4A3F81F50 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QpTgzGQ7Mmb5 for ; Tue, 15 Aug 2023 11:52:14 +0000 (UTC) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8FD8D81F4F for ; Tue, 15 Aug 2023 11:52:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8FD8D81F4F Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fe2ba3e260so52160285e9.2 for ; Tue, 15 Aug 2023 04:52:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692100332; x=1692705132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XG1CdDs3BJOFxaT2xWjh9aVXbUzXw0Qce5rbzwyMS1I=; b=DaYMJ6D1f/l8vuPiY1NcHAUhRTMQejU4NoXfXXOpCmdnchzsbYH83dBv7fUGFPdee+ F6JaruwlNTG7A3dX6d2rn1AriAUnp61/63lrCiwRt0ZmVDr/8RaM7L34q3tOatHpnfC+ hYamI9tAXVzQ8jhgE/1zXq4aSMV8NgkYUsPgUthYoHCfgFsJ74EemB377HTtmEw6/tdt lhF3XAXmQ4bTrLSVP9nh6Jr7uhGYZBr5l7o5AwRdW/lC24soWhlnQPsAuoOlYIzHnedO hUlgFhWiOEIbTwKEfNoLl/+BVM64IB4oWy7MZtD7dznOX04TVPkXyRotvoHA92qRlWL0 jitw== X-Gm-Message-State: AOJu0YzUcvOOirKOTyZ3UICDGyFI7ZDM0sYBR0V1Q/V0SYs2u9ImTY/A nOjmrTIPimh+HUje7d2VgnMAcQ== X-Google-Smtp-Source: AGHT+IG4DWtf444jYikYwXk+iJ1caroN9SCLeIUZQSKVD0XACiRvyg7nhoXLwxD45xrNyqAuLwJwHQ== X-Received: by 2002:a05:600c:214d:b0:3fe:179a:9eee with SMTP id v13-20020a05600c214d00b003fe179a9eeemr9396315wml.30.1692100331959; Tue, 15 Aug 2023 04:52:11 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id z5-20020a7bc7c5000000b003fbe4cecc3bsm20301828wmk.16.2023.08.15.04.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 04:52:11 -0700 (PDT) Date: Tue, 15 Aug 2023 13:52:10 +0200 From: Jiri Pirko To: Vadim Fedorenko Message-ID: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230814194528.00baec23@kernel.org> <43395307-9d11-7905-0eec-0a4c1b1fc62a@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <43395307-9d11-7905-0eec-0a4c1b1fc62a@linux.dev> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1692100332; x=1692705132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XG1CdDs3BJOFxaT2xWjh9aVXbUzXw0Qce5rbzwyMS1I=; b=cx29Z2/Gf27wrI+GW+nt3MIGLYw8rdG0pM2V8V6gDIXoay6oVWyPcSlNRrXgx+ia9H bynI3SuDiD1rHaWKQmAYTV+ZTfQRL8SBYnGy7ugUvdKNYR2KihJl4aW/Ae6gZOEY+ppk C+bHh+tb7qpNR5GWM7RLqu4DpPHA6S7nI3guRFLWjxpbWRZGPcmghzt7lHjZWBPKEHrR 2fzhXb3Ah5+iraDZEA83A635nZ1V8bHmbW2lwyeqV/rCQP+S2FLs1H33TInFKWf3s2oO HmUYDH1HIX7JjEYrXa0u+I/jRXatro806knbv5tOnVzBiq3f5FvOjTuiNbgH9Q+B3xzP HZLg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20221208.gappssmtp.com header.i=@resnulli-us.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=cx29Z2/G Subject: Re: [Intel-wired-lan] [PATCH net-next v4 0/9] Create common DPLL configuration API X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bart Van Assche , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, Jonathan Lemon , Jakub Kicinski , Paolo Abeni , linux-clk@vger.kernel.org, Milena Olech Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Tue, Aug 15, 2023 at 01:36:11PM CEST, vadim.fedorenko@linux.dev wrote: >On 15/08/2023 03:45, Jakub Kicinski wrote: >> On Fri, 11 Aug 2023 21:03:31 +0100 Vadim Fedorenko wrote: >> > create mode 100644 Documentation/driver-api/dpll.rst >> > create mode 100644 Documentation/netlink/specs/dpll.yaml >> > create mode 100644 drivers/dpll/Kconfig >> > create mode 100644 drivers/dpll/Makefile >> > create mode 100644 drivers/dpll/dpll_core.c >> > create mode 100644 drivers/dpll/dpll_core.h >> > create mode 100644 drivers/dpll/dpll_netlink.c >> > create mode 100644 drivers/dpll/dpll_netlink.h >> > create mode 100644 drivers/dpll/dpll_nl.c >> > create mode 100644 drivers/dpll/dpll_nl.h >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_dpll.c >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_dpll.h >> > create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/dpll.c >> > create mode 100644 include/linux/dpll.h >> > create mode 100644 include/uapi/linux/dpll.h >> >> Feels like we're lacking tests here. Is there a common subset of >> stuff we can expect reasonable devices to support? >> Anything you used in development that can be turned into tests? > >Well, we were playing with the tool ynl/cli.py and it's stated in >the cover letter. But needs proper hardware to run. I'm not sure >we can easily create emulation device to run tests. Well, something like "dpllsim", similar to netdevsim would be certainly possible, then you can use it to write selftests for the uapi testing. But why don't we do that as a follow-up patchset? _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28558C001E0 for ; Tue, 15 Aug 2023 11:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236863AbjHOLwS (ORCPT ); Tue, 15 Aug 2023 07:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236884AbjHOLwQ (ORCPT ); Tue, 15 Aug 2023 07:52:16 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B53510CF for ; Tue, 15 Aug 2023 04:52:13 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3fe8242fc4dso44877115e9.1 for ; Tue, 15 Aug 2023 04:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1692100332; x=1692705132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XG1CdDs3BJOFxaT2xWjh9aVXbUzXw0Qce5rbzwyMS1I=; b=cx29Z2/Gf27wrI+GW+nt3MIGLYw8rdG0pM2V8V6gDIXoay6oVWyPcSlNRrXgx+ia9H bynI3SuDiD1rHaWKQmAYTV+ZTfQRL8SBYnGy7ugUvdKNYR2KihJl4aW/Ae6gZOEY+ppk C+bHh+tb7qpNR5GWM7RLqu4DpPHA6S7nI3guRFLWjxpbWRZGPcmghzt7lHjZWBPKEHrR 2fzhXb3Ah5+iraDZEA83A635nZ1V8bHmbW2lwyeqV/rCQP+S2FLs1H33TInFKWf3s2oO HmUYDH1HIX7JjEYrXa0u+I/jRXatro806knbv5tOnVzBiq3f5FvOjTuiNbgH9Q+B3xzP HZLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692100332; x=1692705132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XG1CdDs3BJOFxaT2xWjh9aVXbUzXw0Qce5rbzwyMS1I=; b=XgIc5y2y4OVAWc19wI3G+ke22DCI8BgwxIdKQ/Y3md+J9TssinJcoJxNdKMyMNpB8o lgEIc4u+EMNiL6nfB48ewCzhPW0QvyyqQ7uT7wu50TMZHgeIgP4f9sIMpNvjyMcpvLZN iLhMJLXS8tY9zHRtJ005a+/FTgkGQdke71k1cEnIEThbHGfc24iQOfV3lMfPriOHyke/ b0vI7CCI0uPwTkyjTI4pkcIuzIZLQ9SOq6teNI/ymq3oR+y1c2UIh4+yUCtisL84Yu29 IIIFnPrSPTqCUBuravmgEXOCs94F3oBKVJKe8f6fCiV2O2XiZV7rNsMmN1gSk7BqWXO5 +0DQ== X-Gm-Message-State: AOJu0YzcDNk3oMckipfZozYfml7hMlT+ZJkiM2ZkEtxrQR2A7whQPCto 81NMUp76qH5UobaqXobrTlyqaw== X-Google-Smtp-Source: AGHT+IG4DWtf444jYikYwXk+iJ1caroN9SCLeIUZQSKVD0XACiRvyg7nhoXLwxD45xrNyqAuLwJwHQ== X-Received: by 2002:a05:600c:214d:b0:3fe:179a:9eee with SMTP id v13-20020a05600c214d00b003fe179a9eeemr9396315wml.30.1692100331959; Tue, 15 Aug 2023 04:52:11 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id z5-20020a7bc7c5000000b003fbe4cecc3bsm20301828wmk.16.2023.08.15.04.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 04:52:11 -0700 (PDT) Date: Tue, 15 Aug 2023 13:52:10 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next v4 0/9] Create common DPLL configuration API Message-ID: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230814194528.00baec23@kernel.org> <43395307-9d11-7905-0eec-0a4c1b1fc62a@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43395307-9d11-7905-0eec-0a4c1b1fc62a@linux.dev> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Tue, Aug 15, 2023 at 01:36:11PM CEST, vadim.fedorenko@linux.dev wrote: >On 15/08/2023 03:45, Jakub Kicinski wrote: >> On Fri, 11 Aug 2023 21:03:31 +0100 Vadim Fedorenko wrote: >> > create mode 100644 Documentation/driver-api/dpll.rst >> > create mode 100644 Documentation/netlink/specs/dpll.yaml >> > create mode 100644 drivers/dpll/Kconfig >> > create mode 100644 drivers/dpll/Makefile >> > create mode 100644 drivers/dpll/dpll_core.c >> > create mode 100644 drivers/dpll/dpll_core.h >> > create mode 100644 drivers/dpll/dpll_netlink.c >> > create mode 100644 drivers/dpll/dpll_netlink.h >> > create mode 100644 drivers/dpll/dpll_nl.c >> > create mode 100644 drivers/dpll/dpll_nl.h >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_dpll.c >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_dpll.h >> > create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/dpll.c >> > create mode 100644 include/linux/dpll.h >> > create mode 100644 include/uapi/linux/dpll.h >> >> Feels like we're lacking tests here. Is there a common subset of >> stuff we can expect reasonable devices to support? >> Anything you used in development that can be turned into tests? > >Well, we were playing with the tool ynl/cli.py and it's stated in >the cover letter. But needs proper hardware to run. I'm not sure >we can easily create emulation device to run tests. Well, something like "dpllsim", similar to netdevsim would be certainly possible, then you can use it to write selftests for the uapi testing. But why don't we do that as a follow-up patchset? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66429C001B0 for ; Tue, 15 Aug 2023 11:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OUa4XOierYve1EW/vBYjqqLkyqAlDRGGQWbhGaWZLM4=; b=oGwXIdOF9PUbpK fIsJlusxIuSzQ4GgAmTn6t8Re2+Q1JbHlU98fNVAAzCLXlqj1lN/MZLJiBNESF/VIYqD0CvWBdimY W9NCGHJeJYPkpNzBFnS0DBUfabnE9/hfkTejhkTs4QUjuR3dVOQhksWEpgeuCMlVcZpvZ0FAPm3MK iICGjHH72fd1YkiwMqheMYV4uUjukDFV5xUgXUpWvGmlJqEDC6ezyzxZUtKwXi19Un2lCv5ZMZqBB g7JJfAnONR8BGEGJw46Bn1kba+0nbB7vFCNGcuymdHN+2bfDlW2UO/5wx4FMLeU0cEgtDzJaf1lmC lRFV1dpRoqDaObzDGG+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVsaz-001YgQ-0C; Tue, 15 Aug 2023 11:52:21 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVsau-001Yfi-2h for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 11:52:19 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3fe2ba3e260so52160275e9.2 for ; Tue, 15 Aug 2023 04:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1692100332; x=1692705132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XG1CdDs3BJOFxaT2xWjh9aVXbUzXw0Qce5rbzwyMS1I=; b=cx29Z2/Gf27wrI+GW+nt3MIGLYw8rdG0pM2V8V6gDIXoay6oVWyPcSlNRrXgx+ia9H bynI3SuDiD1rHaWKQmAYTV+ZTfQRL8SBYnGy7ugUvdKNYR2KihJl4aW/Ae6gZOEY+ppk C+bHh+tb7qpNR5GWM7RLqu4DpPHA6S7nI3guRFLWjxpbWRZGPcmghzt7lHjZWBPKEHrR 2fzhXb3Ah5+iraDZEA83A635nZ1V8bHmbW2lwyeqV/rCQP+S2FLs1H33TInFKWf3s2oO HmUYDH1HIX7JjEYrXa0u+I/jRXatro806knbv5tOnVzBiq3f5FvOjTuiNbgH9Q+B3xzP HZLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692100332; x=1692705132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XG1CdDs3BJOFxaT2xWjh9aVXbUzXw0Qce5rbzwyMS1I=; b=Kq2KikE2dzlmgEaD/BqEy/wP8BP2uub/9BcJAiyO8PFWF6DZos/yDNVzFjsrM10zE/ ubTXvgecSF0THjjdC3Hs+3AFPsyB8mcuFpfpuCQZaPiuIjNONZ3+oQ6MajYktyFJKOB5 H9SCkm+23rLKp+dLlq58IkvP4hmpJI0cYcHceGcp1OZp/l8W4jOgU/DbXTIJScrsE0Hx yuxF5yKgoQBxheVpGNdtv+Tefrh65WIIMx8T2ilp7ut2GaJKhmh+jJrax+PEl2XrGOFW UFDQqx/uGtodT6jDJWxsygpuCtNC8MKeOWjSzRuQLAuE9HxgyRBLxqjO1i7UPKvymWyD RbOA== X-Gm-Message-State: AOJu0Yy1MY2r5ZCOgXb6o+yvYgM+6eILxE2CIZmuzxbmjKHXUl+GRJeB Q9lP4G5QOcKLLVgaTVeYSYFaj6pzGDi8bjJXvulWYYpa X-Google-Smtp-Source: AGHT+IG4DWtf444jYikYwXk+iJ1caroN9SCLeIUZQSKVD0XACiRvyg7nhoXLwxD45xrNyqAuLwJwHQ== X-Received: by 2002:a05:600c:214d:b0:3fe:179a:9eee with SMTP id v13-20020a05600c214d00b003fe179a9eeemr9396315wml.30.1692100331959; Tue, 15 Aug 2023 04:52:11 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id z5-20020a7bc7c5000000b003fbe4cecc3bsm20301828wmk.16.2023.08.15.04.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 04:52:11 -0700 (PDT) Date: Tue, 15 Aug 2023 13:52:10 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next v4 0/9] Create common DPLL configuration API Message-ID: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230814194528.00baec23@kernel.org> <43395307-9d11-7905-0eec-0a4c1b1fc62a@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <43395307-9d11-7905-0eec-0a4c1b1fc62a@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_045217_113946_66A6AA2C X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tue, Aug 15, 2023 at 01:36:11PM CEST, vadim.fedorenko@linux.dev wrote: >On 15/08/2023 03:45, Jakub Kicinski wrote: >> On Fri, 11 Aug 2023 21:03:31 +0100 Vadim Fedorenko wrote: >> > create mode 100644 Documentation/driver-api/dpll.rst >> > create mode 100644 Documentation/netlink/specs/dpll.yaml >> > create mode 100644 drivers/dpll/Kconfig >> > create mode 100644 drivers/dpll/Makefile >> > create mode 100644 drivers/dpll/dpll_core.c >> > create mode 100644 drivers/dpll/dpll_core.h >> > create mode 100644 drivers/dpll/dpll_netlink.c >> > create mode 100644 drivers/dpll/dpll_netlink.h >> > create mode 100644 drivers/dpll/dpll_nl.c >> > create mode 100644 drivers/dpll/dpll_nl.h >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_dpll.c >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_dpll.h >> > create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/dpll.c >> > create mode 100644 include/linux/dpll.h >> > create mode 100644 include/uapi/linux/dpll.h >> >> Feels like we're lacking tests here. Is there a common subset of >> stuff we can expect reasonable devices to support? >> Anything you used in development that can be turned into tests? > >Well, we were playing with the tool ynl/cli.py and it's stated in >the cover letter. But needs proper hardware to run. I'm not sure >we can easily create emulation device to run tests. Well, something like "dpllsim", similar to netdevsim would be certainly possible, then you can use it to write selftests for the uapi testing. But why don't we do that as a follow-up patchset? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel