From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/2] gpio: sim: simplify code with cleanup helpers
Date: Tue, 15 Aug 2023 18:58:10 +0300 [thread overview]
Message-ID: <ZNugkmhj1Joygorj@smile.fi.intel.com> (raw)
In-Reply-To: <20230815155253.GK212435@hirez.programming.kicks-ass.net>
On Tue, Aug 15, 2023 at 05:52:53PM +0200, Peter Zijlstra wrote:
> On Tue, Aug 15, 2023 at 10:04:32AM +0200, Linus Walleij wrote:
> > On Wed, Aug 9, 2023 at 3:14 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > - mutex_lock(&chip->lock);
> > > + guard(mutex)(&chip->lock);
> Looks about right.
Btw, why don't we have something like
guard_mutex()
to be used as
guard_mutex(&chip->lock);
Moreover, maybe some macro that can predict the API call from the type of
the parameter?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-15 15:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:14 [PATCH 1/2] gpio: sim: use sysfs_streq() and avoid an strdup() Bartosz Golaszewski
2023-08-09 13:14 ` [PATCH 2/2] gpio: sim: simplify code with cleanup helpers Bartosz Golaszewski
2023-08-10 14:39 ` Andy Shevchenko
2023-08-10 19:04 ` Bartosz Golaszewski
2023-08-11 9:14 ` Andy Shevchenko
2023-08-11 12:42 ` Bartosz Golaszewski
2023-08-11 5:20 ` Dan Carpenter
2023-08-11 9:14 ` Andy Shevchenko
2023-08-11 9:31 ` Dan Carpenter
2023-08-15 8:04 ` Linus Walleij
2023-08-15 15:52 ` Peter Zijlstra
2023-08-15 15:58 ` Andy Shevchenko [this message]
2023-08-15 20:31 ` Peter Zijlstra
2023-08-16 12:47 ` Peter Zijlstra
2023-08-17 9:21 ` Andy Shevchenko
2023-08-10 14:04 ` [PATCH 1/2] gpio: sim: use sysfs_streq() and avoid an strdup() Andy Shevchenko
2023-08-11 11:59 ` Bartosz Golaszewski
-- strict thread matches above, loose matches on Subject: below --
2023-08-10 19:05 [PATCH 2/2] gpio: sim: simplify code with cleanup helpers kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNugkmhj1Joygorj@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.