From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Kent Gustavsson <kent@minoris.se>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Cosmin Tanislav <demonsingur@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
ChiYuan Huang <cy_huang@richtek.com>,
Haibo Chen <haibo.chen@nxp.com>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
ChiaEn Wu <chiaen_wu@richtek.com>,
William Breathitt Gray <william.gray@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/6] iio: adc: mcp3911: fix indentation
Date: Tue, 15 Aug 2023 18:55:45 +0200 [thread overview]
Message-ID: <ZNuuER3V8etxeu3o@gmail.com> (raw)
In-Reply-To: <ZNuShXfOoaLk8Ua1@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Tue, Aug 15, 2023 at 05:58:13PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 14, 2023 at 02:10:08PM +0200, Marcus Folkesson wrote:
> > The file does not make use of indentation properly.
>
> > Fix that.
>
> I'm not sure this is anyhow a fix. Yet you may refer to the checkpatch
> if it complains.
>
> ...
>
> This kind of change is preferred to be the last in the series or closer
> to the end where no more code changed.
Checkpatch did never complain about the formatting, but I got a few comments
during the review process about the formatting, so I went
through the whole file to fix it once for all.
I do not think that it has to be the last patch in the series.
All following patches has proper indentation.
Pretty much the same as the simplification of spi->dev I think.
If there is no strong opinions about it I think I will leave it as is.
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Best regards,
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-15 16:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 12:10 [PATCH v5 1/6] dt-bindings: iio: adc: mcp3911: add support for the whole MCP39xx family Marcus Folkesson
2023-08-14 12:10 ` [PATCH v5 2/6] iio: adc: mcp3911: make use of dev_err_probe() Marcus Folkesson
2023-08-15 14:36 ` Andy Shevchenko
2023-08-14 12:10 ` [PATCH v5 3/6] iio: adc: mcp3911: simplify usage of spi->dev Marcus Folkesson
2023-08-15 14:53 ` Andy Shevchenko
2023-08-14 12:10 ` [PATCH v5 4/6] iio: adc: mcp3911: fix indentation Marcus Folkesson
2023-08-15 14:58 ` Andy Shevchenko
2023-08-15 16:55 ` Marcus Folkesson [this message]
2023-08-15 17:04 ` Andy Shevchenko
2023-08-14 12:10 ` [PATCH v5 5/6] iio: adc: mcp3911: avoid ambiguity parameters in macros Marcus Folkesson
2023-08-15 14:56 ` Andy Shevchenko
2023-08-15 16:49 ` Marcus Folkesson
2023-08-15 16:54 ` Andy Shevchenko
2023-08-14 12:10 ` [PATCH v5 6/6] iio: adc: mcp3911: add support for the whole MCP39xx family Marcus Folkesson
2023-08-15 15:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNuuER3V8etxeu3o@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kent@minoris.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.