From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03FFAC001E0 for ; Tue, 15 Aug 2023 18:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239054AbjHOSYg (ORCPT ); Tue, 15 Aug 2023 14:24:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239056AbjHOSYK (ORCPT ); Tue, 15 Aug 2023 14:24:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FF0CE52; Tue, 15 Aug 2023 11:24:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD17B65874; Tue, 15 Aug 2023 18:24:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8874C433C8; Tue, 15 Aug 2023 18:24:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692123848; bh=SsbeNONUUIyspJrA7/OhX+EylvabLswNFMu31Y+23z4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j+KNtdKHYKXl7VJYBnY+JJWYpp/VRA2CXUlBvpgpQbf6m4jeRVqcKSCvKbZc+Gnl9 9H4RMbDdbVFrIuJ+DgKHBRTQY/B6TgkIWod1zmkTQEGpbRl2SkSj4xowoP4EcP2AEi w4eMhdSI0YOnrWEI4s861fC526uUaeJds8ShqgZ/pJXqAScEnn7OstLVxegAPd7cxb v+K73Yw9SU+MJA0cUdtyy8mgX76Il24D0MqbSJFIUc3KRiKxfsrYYe/E/OLhEjLYiV Lwnq03xgNKq7S8Dz95fAsdfkneqRwkDdZ44x/ryV3Oo8Y8Vv/ZRqhxrsm8B2vN/y9R iC2sfuF8v1kbA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E1388404DF; Tue, 15 Aug 2023 15:24:04 -0300 (-03) Date: Tue, 15 Aug 2023 15:24:04 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Leo Yan , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Em Wed, Jul 12, 2023 at 03:37:36PM -0700, Ian Rogers escreveu: > On Mon, Jun 5, 2023 at 6:46 PM Leo Yan wrote: > > > > This patch series is to refactor arch related functions for register > > parsing, which follows up the discussion for v1: > > https://lore.kernel.org/lkml/20230520025537.1811986-1-leo.yan@linaro.org/ > > > > Compared to patch series v1, this patch series introduces new functions > > perf_arch_reg_{ip|sp}(), so this can allow the tool to support cross > > analysis. > > > > To verify the cross analysis, I used below steps: > > > > - Firstly, I captured perf data on Arm64 machine: > > > > $ perf record --call-graph fp -- ./test_program > > > > Or ... > > > > $ perf record --call-graph dwarf -- ./test_program > > > > Then, I also archived associated debug data: > > > > $ perf archive > > > > - Secondly, I copied the perf data file and debug tar file on my x86 > > machine: > > > > $ scp perf.data perf.data.tar.bz2 leoy@IP_ADDRESS:/target/path/ > > > > - On x86 machine, I need to build perf for support multi-arch unwinding: > > > > $ git clone http://git.savannah.gnu.org/r/libunwind.git > > $ cd libunwind > > $ autoreconf -i > > > > # Build and install libunwind aarch64: > > $ ./configure prefix=/home/leoy/Work/tools/libunwind/install/ \ > > --target=aarch64-linux-gnu CC=x86_64-linux-gnu-gcc > > $ make && make install > > > > # Build and install libunwind x86: > > $ ./configure prefix=/home/leoy/Work/tools/libunwind/install/ \ > > --target=x86_64-linux-gnu CC=x86_64-linux-gnu-gcc > > $ make && make install > > > > - Build perf tool for support multi-archs: > > > > $ cd $LINUX/tools/perf > > $ make VF=1 DEBUG=1 LIBUNWIND_DIR=/home/leoy/Work/tools/libunwind/install > > > > At the end, I verified the x86 perf tool can do cross analysis for aarch64's > > perf data file. > > > > Note, I still see x86 perf tool cannot display the complete callgraph > > for aarch64, but it should not the issue caused by this series, which > > will be addressed by separate patches. > > > > I also built this patch series on my Arm64 and x86 machines, both can > > compile perf tool successfully; but I have no chance to build other > > archs natively. > > > > Changes from v1: > > - For support cross analysis for IP/SP registers, introduced patch 0002 > > (James Clark, Ian Rogers). > > > > > > Leo Yan (6): > > perf parse-regs: Refactor arch register parsing functions > > perf parse-regs: Introduce functions perf_arch_reg_{ip|sp}() > > perf unwind: Use perf_arch_reg_{ip|sp}() to substitute macros > > perf parse-regs: Remove unused macros PERF_REG_{IP|SP} > > perf parse-regs: Remove PERF_REGS_{MAX|MASK} from common code > > perf parse-regs: Move out arch specific header from util/perf_regs.h > > Sorry for the slow review. For the series: > Acked-by: Ian Rogers > > Some thoughts: > uint64_t __perf_reg_ip_arm(void) > uint64_t seems like we're giving a lot of space for future register > encodings. I think some of the other functions use this size of value > due to returning a bitmap/mask, but here it isn't clear and just feels > excessive. > > Do we need the "__" prefix on all the functions? > > In Makefile.config there are NO_PERF_REGS and CONFIG_PERF_REGS then > the define HAVE_PERF_REGS_SUPPORT. Is this still relevant? If we had > an architecture with no support, couldn't it still read a perf.data > file from a supported architecture? It would be nice to remove at > least NO_PERF_REGS and HAVE_PERF_REGS_SUPPORT. > > This change is very worthwhile fix and cleanup, it didn't introduce > what is pondered above, hence the acked-by. Agreed, applied to perf-tools-next, sorry for the delay. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC89BC0015E for ; Tue, 15 Aug 2023 18:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=igWO1+CvRGrD2bZttookLDMwA7TWREIyM4ekMhiurc0=; b=R1RLiSPYNHABfW klipYaE958fC+mLLxKgtL8UPnlCoTFr5vyAHksJfSRDcU41AqeFtK5ct+/kT3euiVcQ98xjWgmaAL AjlyxcA5rUIJFrF7upNhFzHK1LASmJVUx0FtYQ76FbOQve+TpWF8m+7pFgydSstEgdcHHXRXPT1Oh LBJzv76rz6N7fsHXhyyVn8QKRW/2pG4saaNj5Oq7sCmwtkMebIBdRB0KY8YgspTbl+PlCTHT0N7oT p7uPoEBNtz3N9xBj9Sn/2ib7afU8Q43nvH1CpIsFf4t7hN9kFDDFvMai8vlpHuMsoM8+OBz9452iy +kwhb4pPWLsMJPsKSIJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVyiC-0029Tu-1m; Tue, 15 Aug 2023 18:24:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVyiA-0029TM-2L; Tue, 15 Aug 2023 18:24:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=HLbqcPFXia5E5QG94M7kSeB1TiYCMsw8FqLqd5/tUKA=; b=k5+nDl6qR93SqQbm9a+EbouWIN dYZoqLpYqEtOEyLyq8Ru9jhBo60mx2peNfBdWxxp9+13FdTrSwiGB+2E1qvRQX4WXAuiUpPNaRmBG yZoB4GXJMGc7c3Dl6Fy2coE5yVHDj4LX9kc7U62ZLzsyFACz7tCtvF7qsStIF0GTiOeH1h4shcAwj nlj/UJk54E6WwhE9ZOoEag3ELZ8jVIurG8m6NZCy/sUWrsYeMryzkDFzqQgVvEQSas41aS6A+xfYL GSw66Vd8ML8jVs3Szw4XOKQ1Bz7gkAgkQX6tDg9f7RusXUHmkTWDkaJl2BCJcT/Jzf4ZBOqcUvswB xBmJPSBA==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qVyi9-009jPN-2E; Tue, 15 Aug 2023 18:24:09 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E1388404DF; Tue, 15 Aug 2023 15:24:04 -0300 (-03) Date: Tue, 15 Aug 2023 15:24:04 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Leo Yan , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org RW0gV2VkLCBKdWwgMTIsIDIwMjMgYXQgMDM6Mzc6MzZQTSAtMDcwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPiBPbiBNb24sIEp1biA1LCAyMDIzIGF0IDY6NDbigK9QTSBMZW8gWWFuIDxsZW8ueWFu QGxpbmFyby5vcmc+IHdyb3RlOgo+ID4KPiA+IFRoaXMgcGF0Y2ggc2VyaWVzIGlzIHRvIHJlZmFj dG9yIGFyY2ggcmVsYXRlZCBmdW5jdGlvbnMgZm9yIHJlZ2lzdGVyCj4gPiBwYXJzaW5nLCB3aGlj aCBmb2xsb3dzIHVwIHRoZSBkaXNjdXNzaW9uIGZvciB2MToKPiA+IGh0dHBzOi8vbG9yZS5rZXJu ZWwub3JnL2xrbWwvMjAyMzA1MjAwMjU1MzcuMTgxMTk4Ni0xLWxlby55YW5AbGluYXJvLm9yZy8K PiA+Cj4gPiBDb21wYXJlZCB0byBwYXRjaCBzZXJpZXMgdjEsIHRoaXMgcGF0Y2ggc2VyaWVzIGlu dHJvZHVjZXMgbmV3IGZ1bmN0aW9ucwo+ID4gcGVyZl9hcmNoX3JlZ197aXB8c3B9KCksIHNvIHRo aXMgY2FuIGFsbG93IHRoZSB0b29sIHRvIHN1cHBvcnQgY3Jvc3MKPiA+IGFuYWx5c2lzLgo+ID4K PiA+IFRvIHZlcmlmeSB0aGUgY3Jvc3MgYW5hbHlzaXMsIEkgdXNlZCBiZWxvdyBzdGVwczoKPiA+ Cj4gPiAtIEZpcnN0bHksIEkgY2FwdHVyZWQgcGVyZiBkYXRhIG9uIEFybTY0IG1hY2hpbmU6Cj4g Pgo+ID4gICAkIHBlcmYgcmVjb3JkIC0tY2FsbC1ncmFwaCBmcCAtLSAuL3Rlc3RfcHJvZ3JhbQo+ ID4KPiA+ICAgT3IgLi4uCj4gPgo+ID4gICAkIHBlcmYgcmVjb3JkIC0tY2FsbC1ncmFwaCBkd2Fy ZiAtLSAuL3Rlc3RfcHJvZ3JhbQo+ID4KPiA+ICAgVGhlbiwgSSBhbHNvIGFyY2hpdmVkIGFzc29j aWF0ZWQgZGVidWcgZGF0YToKPiA+Cj4gPiAgICQgcGVyZiBhcmNoaXZlCj4gPgo+ID4gLSBTZWNv bmRseSwgSSBjb3BpZWQgdGhlIHBlcmYgZGF0YSBmaWxlIGFuZCBkZWJ1ZyB0YXIgZmlsZSBvbiBt eSB4ODYKPiA+ICAgbWFjaGluZToKPiA+Cj4gPiAgICQgc2NwIHBlcmYuZGF0YSBwZXJmLmRhdGEu dGFyLmJ6MiBsZW95QElQX0FERFJFU1M6L3RhcmdldC9wYXRoLwo+ID4KPiA+IC0gT24geDg2IG1h Y2hpbmUsIEkgbmVlZCB0byBidWlsZCBwZXJmIGZvciBzdXBwb3J0IG11bHRpLWFyY2ggdW53aW5k aW5nOgo+ID4KPiA+ICAgJCBnaXQgY2xvbmUgaHR0cDovL2dpdC5zYXZhbm5haC5nbnUub3JnL3Iv bGlidW53aW5kLmdpdAo+ID4gICAkIGNkIGxpYnVud2luZAo+ID4gICAkIGF1dG9yZWNvbmYgLWkK PiA+Cj4gPiAgICMgQnVpbGQgYW5kIGluc3RhbGwgbGlidW53aW5kIGFhcmNoNjQ6Cj4gPiAgICQg Li9jb25maWd1cmUgcHJlZml4PS9ob21lL2xlb3kvV29yay90b29scy9saWJ1bndpbmQvaW5zdGFs bC8gXAo+ID4gICAgICAgICAtLXRhcmdldD1hYXJjaDY0LWxpbnV4LWdudSBDQz14ODZfNjQtbGlu dXgtZ251LWdjYwo+ID4gICAkIG1ha2UgJiYgbWFrZSBpbnN0YWxsCj4gPgo+ID4gICAjIEJ1aWxk IGFuZCBpbnN0YWxsIGxpYnVud2luZCB4ODY6Cj4gPiAgICQgLi9jb25maWd1cmUgcHJlZml4PS9o b21lL2xlb3kvV29yay90b29scy9saWJ1bndpbmQvaW5zdGFsbC8gXAo+ID4gICAgICAgICAtLXRh cmdldD14ODZfNjQtbGludXgtZ251IENDPXg4Nl82NC1saW51eC1nbnUtZ2NjCj4gPiAgICQgbWFr ZSAmJiBtYWtlIGluc3RhbGwKPiA+Cj4gPiAtIEJ1aWxkIHBlcmYgdG9vbCBmb3Igc3VwcG9ydCBt dWx0aS1hcmNoczoKPiA+Cj4gPiAgICQgY2QgJExJTlVYL3Rvb2xzL3BlcmYKPiA+ICAgJCBtYWtl IFZGPTEgREVCVUc9MSBMSUJVTldJTkRfRElSPS9ob21lL2xlb3kvV29yay90b29scy9saWJ1bndp bmQvaW5zdGFsbAo+ID4KPiA+IEF0IHRoZSBlbmQsIEkgdmVyaWZpZWQgdGhlIHg4NiBwZXJmIHRv b2wgY2FuIGRvIGNyb3NzIGFuYWx5c2lzIGZvciBhYXJjaDY0J3MKPiA+IHBlcmYgZGF0YSBmaWxl Lgo+ID4KPiA+IE5vdGUsIEkgc3RpbGwgc2VlIHg4NiBwZXJmIHRvb2wgY2Fubm90IGRpc3BsYXkg dGhlIGNvbXBsZXRlIGNhbGxncmFwaAo+ID4gZm9yIGFhcmNoNjQsIGJ1dCBpdCBzaG91bGQgbm90 IHRoZSBpc3N1ZSBjYXVzZWQgYnkgdGhpcyBzZXJpZXMsIHdoaWNoCj4gPiB3aWxsIGJlIGFkZHJl c3NlZCBieSBzZXBhcmF0ZSBwYXRjaGVzLgo+ID4KPiA+IEkgYWxzbyBidWlsdCB0aGlzIHBhdGNo IHNlcmllcyBvbiBteSBBcm02NCBhbmQgeDg2IG1hY2hpbmVzLCBib3RoIGNhbgo+ID4gY29tcGls ZSBwZXJmIHRvb2wgc3VjY2Vzc2Z1bGx5OyBidXQgSSBoYXZlIG5vIGNoYW5jZSB0byBidWlsZCBv dGhlcgo+ID4gYXJjaHMgbmF0aXZlbHkuCj4gPgo+ID4gQ2hhbmdlcyBmcm9tIHYxOgo+ID4gLSBG b3Igc3VwcG9ydCBjcm9zcyBhbmFseXNpcyBmb3IgSVAvU1AgcmVnaXN0ZXJzLCBpbnRyb2R1Y2Vk IHBhdGNoIDAwMDIKPiA+ICAgKEphbWVzIENsYXJrLCBJYW4gUm9nZXJzKS4KPiA+Cj4gPgo+ID4g TGVvIFlhbiAoNik6Cj4gPiAgIHBlcmYgcGFyc2UtcmVnczogUmVmYWN0b3IgYXJjaCByZWdpc3Rl ciBwYXJzaW5nIGZ1bmN0aW9ucwo+ID4gICBwZXJmIHBhcnNlLXJlZ3M6IEludHJvZHVjZSBmdW5j dGlvbnMgcGVyZl9hcmNoX3JlZ197aXB8c3B9KCkKPiA+ICAgcGVyZiB1bndpbmQ6IFVzZSBwZXJm X2FyY2hfcmVnX3tpcHxzcH0oKSB0byBzdWJzdGl0dXRlIG1hY3Jvcwo+ID4gICBwZXJmIHBhcnNl LXJlZ3M6IFJlbW92ZSB1bnVzZWQgbWFjcm9zIFBFUkZfUkVHX3tJUHxTUH0KPiA+ICAgcGVyZiBw YXJzZS1yZWdzOiBSZW1vdmUgUEVSRl9SRUdTX3tNQVh8TUFTS30gZnJvbSBjb21tb24gY29kZQo+ ID4gICBwZXJmIHBhcnNlLXJlZ3M6IE1vdmUgb3V0IGFyY2ggc3BlY2lmaWMgaGVhZGVyIGZyb20g dXRpbC9wZXJmX3JlZ3MuaAo+IAo+IFNvcnJ5IGZvciB0aGUgc2xvdyByZXZpZXcuIEZvciB0aGUg c2VyaWVzOgo+IEFja2VkLWJ5OiBJYW4gUm9nZXJzIDxpcm9nZXJzQGdvb2dsZS5jb20+Cj4gCj4g U29tZSB0aG91Z2h0czoKPiB1aW50NjRfdCBfX3BlcmZfcmVnX2lwX2FybSh2b2lkKQo+IHVpbnQ2 NF90IHNlZW1zIGxpa2Ugd2UncmUgZ2l2aW5nIGEgbG90IG9mIHNwYWNlIGZvciBmdXR1cmUgcmVn aXN0ZXIKPiBlbmNvZGluZ3MuIEkgdGhpbmsgc29tZSBvZiB0aGUgb3RoZXIgZnVuY3Rpb25zIHVz ZSB0aGlzIHNpemUgb2YgdmFsdWUKPiBkdWUgdG8gcmV0dXJuaW5nIGEgYml0bWFwL21hc2ssIGJ1 dCBoZXJlIGl0IGlzbid0IGNsZWFyIGFuZCBqdXN0IGZlZWxzCj4gZXhjZXNzaXZlLgo+IAo+IERv IHdlIG5lZWQgdGhlICJfXyIgcHJlZml4IG9uIGFsbCB0aGUgZnVuY3Rpb25zPwo+IAo+IEluIE1h a2VmaWxlLmNvbmZpZyB0aGVyZSBhcmUgTk9fUEVSRl9SRUdTIGFuZCBDT05GSUdfUEVSRl9SRUdT IHRoZW4KPiB0aGUgZGVmaW5lIEhBVkVfUEVSRl9SRUdTX1NVUFBPUlQuIElzIHRoaXMgc3RpbGwg cmVsZXZhbnQ/IElmIHdlIGhhZAo+IGFuIGFyY2hpdGVjdHVyZSB3aXRoIG5vIHN1cHBvcnQsIGNv dWxkbid0IGl0IHN0aWxsIHJlYWQgYSBwZXJmLmRhdGEKPiBmaWxlIGZyb20gYSBzdXBwb3J0ZWQg YXJjaGl0ZWN0dXJlPyBJdCB3b3VsZCBiZSBuaWNlIHRvIHJlbW92ZSBhdAo+IGxlYXN0IE5PX1BF UkZfUkVHUyBhbmQgSEFWRV9QRVJGX1JFR1NfU1VQUE9SVC4KPiAKPiBUaGlzIGNoYW5nZSBpcyB2 ZXJ5IHdvcnRod2hpbGUgZml4IGFuZCBjbGVhbnVwLCBpdCBkaWRuJ3QgaW50cm9kdWNlCj4gd2hh dCBpcyBwb25kZXJlZCBhYm92ZSwgaGVuY2UgdGhlIGFja2VkLWJ5LgoKQWdyZWVkLCBhcHBsaWVk IHRvIHBlcmYtdG9vbHMtbmV4dCwgc29ycnkgZm9yIHRoZSBkZWxheS4KCi0gQXJuYWxkbwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3Yg bWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B651EC0015E for ; Tue, 15 Aug 2023 18:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XzoCTw+W67sI3gmQbDY3945ATSMhkNIejE9j1JRkigs=; b=bgFcDgCIEPm1cB Yqon+/RWQzAq+NhPfafuZnIwPQttjK3rX1IPm1yzAj9ezTrRHu3OFKmOzrXEKkvzwsEEEZNOLMdlT qEYca1cEH3SihBgLexaxcCWI6t35ZoYP6lYS5cnml2l5y7VoNeR3aG/iZ4ID0C8dtJAnW3ZwhdxmD uPrvdOBpFg9vi7kvXSHCjTaij0NlpFsZAqzZRK9eN/1Sui3MiHWsablKS6MUBgmQXLeEXtngKS92J 3izPH/VVCgY9eFxnVhQkr+GMiFqI+GNNPLkVfrDn5hJd0JChW+h6ZAL9+m7it9hOR2FZtQgFDSqGW AFB4mv8WRy325m56syKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVyiC-0029Td-0A; Tue, 15 Aug 2023 18:24:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVyiA-0029TM-2L; Tue, 15 Aug 2023 18:24:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=HLbqcPFXia5E5QG94M7kSeB1TiYCMsw8FqLqd5/tUKA=; b=k5+nDl6qR93SqQbm9a+EbouWIN dYZoqLpYqEtOEyLyq8Ru9jhBo60mx2peNfBdWxxp9+13FdTrSwiGB+2E1qvRQX4WXAuiUpPNaRmBG yZoB4GXJMGc7c3Dl6Fy2coE5yVHDj4LX9kc7U62ZLzsyFACz7tCtvF7qsStIF0GTiOeH1h4shcAwj nlj/UJk54E6WwhE9ZOoEag3ELZ8jVIurG8m6NZCy/sUWrsYeMryzkDFzqQgVvEQSas41aS6A+xfYL GSw66Vd8ML8jVs3Szw4XOKQ1Bz7gkAgkQX6tDg9f7RusXUHmkTWDkaJl2BCJcT/Jzf4ZBOqcUvswB xBmJPSBA==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qVyi9-009jPN-2E; Tue, 15 Aug 2023 18:24:09 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E1388404DF; Tue, 15 Aug 2023 15:24:04 -0300 (-03) Date: Tue, 15 Aug 2023 15:24:04 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Leo Yan , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gV2VkLCBKdWwgMTIsIDIwMjMgYXQgMDM6Mzc6MzZQTSAtMDcwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPiBPbiBNb24sIEp1biA1LCAyMDIzIGF0IDY6NDbigK9QTSBMZW8gWWFuIDxsZW8ueWFu QGxpbmFyby5vcmc+IHdyb3RlOgo+ID4KPiA+IFRoaXMgcGF0Y2ggc2VyaWVzIGlzIHRvIHJlZmFj dG9yIGFyY2ggcmVsYXRlZCBmdW5jdGlvbnMgZm9yIHJlZ2lzdGVyCj4gPiBwYXJzaW5nLCB3aGlj aCBmb2xsb3dzIHVwIHRoZSBkaXNjdXNzaW9uIGZvciB2MToKPiA+IGh0dHBzOi8vbG9yZS5rZXJu ZWwub3JnL2xrbWwvMjAyMzA1MjAwMjU1MzcuMTgxMTk4Ni0xLWxlby55YW5AbGluYXJvLm9yZy8K PiA+Cj4gPiBDb21wYXJlZCB0byBwYXRjaCBzZXJpZXMgdjEsIHRoaXMgcGF0Y2ggc2VyaWVzIGlu dHJvZHVjZXMgbmV3IGZ1bmN0aW9ucwo+ID4gcGVyZl9hcmNoX3JlZ197aXB8c3B9KCksIHNvIHRo aXMgY2FuIGFsbG93IHRoZSB0b29sIHRvIHN1cHBvcnQgY3Jvc3MKPiA+IGFuYWx5c2lzLgo+ID4K PiA+IFRvIHZlcmlmeSB0aGUgY3Jvc3MgYW5hbHlzaXMsIEkgdXNlZCBiZWxvdyBzdGVwczoKPiA+ Cj4gPiAtIEZpcnN0bHksIEkgY2FwdHVyZWQgcGVyZiBkYXRhIG9uIEFybTY0IG1hY2hpbmU6Cj4g Pgo+ID4gICAkIHBlcmYgcmVjb3JkIC0tY2FsbC1ncmFwaCBmcCAtLSAuL3Rlc3RfcHJvZ3JhbQo+ ID4KPiA+ICAgT3IgLi4uCj4gPgo+ID4gICAkIHBlcmYgcmVjb3JkIC0tY2FsbC1ncmFwaCBkd2Fy ZiAtLSAuL3Rlc3RfcHJvZ3JhbQo+ID4KPiA+ICAgVGhlbiwgSSBhbHNvIGFyY2hpdmVkIGFzc29j aWF0ZWQgZGVidWcgZGF0YToKPiA+Cj4gPiAgICQgcGVyZiBhcmNoaXZlCj4gPgo+ID4gLSBTZWNv bmRseSwgSSBjb3BpZWQgdGhlIHBlcmYgZGF0YSBmaWxlIGFuZCBkZWJ1ZyB0YXIgZmlsZSBvbiBt eSB4ODYKPiA+ICAgbWFjaGluZToKPiA+Cj4gPiAgICQgc2NwIHBlcmYuZGF0YSBwZXJmLmRhdGEu dGFyLmJ6MiBsZW95QElQX0FERFJFU1M6L3RhcmdldC9wYXRoLwo+ID4KPiA+IC0gT24geDg2IG1h Y2hpbmUsIEkgbmVlZCB0byBidWlsZCBwZXJmIGZvciBzdXBwb3J0IG11bHRpLWFyY2ggdW53aW5k aW5nOgo+ID4KPiA+ICAgJCBnaXQgY2xvbmUgaHR0cDovL2dpdC5zYXZhbm5haC5nbnUub3JnL3Iv bGlidW53aW5kLmdpdAo+ID4gICAkIGNkIGxpYnVud2luZAo+ID4gICAkIGF1dG9yZWNvbmYgLWkK PiA+Cj4gPiAgICMgQnVpbGQgYW5kIGluc3RhbGwgbGlidW53aW5kIGFhcmNoNjQ6Cj4gPiAgICQg Li9jb25maWd1cmUgcHJlZml4PS9ob21lL2xlb3kvV29yay90b29scy9saWJ1bndpbmQvaW5zdGFs bC8gXAo+ID4gICAgICAgICAtLXRhcmdldD1hYXJjaDY0LWxpbnV4LWdudSBDQz14ODZfNjQtbGlu dXgtZ251LWdjYwo+ID4gICAkIG1ha2UgJiYgbWFrZSBpbnN0YWxsCj4gPgo+ID4gICAjIEJ1aWxk IGFuZCBpbnN0YWxsIGxpYnVud2luZCB4ODY6Cj4gPiAgICQgLi9jb25maWd1cmUgcHJlZml4PS9o b21lL2xlb3kvV29yay90b29scy9saWJ1bndpbmQvaW5zdGFsbC8gXAo+ID4gICAgICAgICAtLXRh cmdldD14ODZfNjQtbGludXgtZ251IENDPXg4Nl82NC1saW51eC1nbnUtZ2NjCj4gPiAgICQgbWFr ZSAmJiBtYWtlIGluc3RhbGwKPiA+Cj4gPiAtIEJ1aWxkIHBlcmYgdG9vbCBmb3Igc3VwcG9ydCBt dWx0aS1hcmNoczoKPiA+Cj4gPiAgICQgY2QgJExJTlVYL3Rvb2xzL3BlcmYKPiA+ICAgJCBtYWtl IFZGPTEgREVCVUc9MSBMSUJVTldJTkRfRElSPS9ob21lL2xlb3kvV29yay90b29scy9saWJ1bndp bmQvaW5zdGFsbAo+ID4KPiA+IEF0IHRoZSBlbmQsIEkgdmVyaWZpZWQgdGhlIHg4NiBwZXJmIHRv b2wgY2FuIGRvIGNyb3NzIGFuYWx5c2lzIGZvciBhYXJjaDY0J3MKPiA+IHBlcmYgZGF0YSBmaWxl Lgo+ID4KPiA+IE5vdGUsIEkgc3RpbGwgc2VlIHg4NiBwZXJmIHRvb2wgY2Fubm90IGRpc3BsYXkg dGhlIGNvbXBsZXRlIGNhbGxncmFwaAo+ID4gZm9yIGFhcmNoNjQsIGJ1dCBpdCBzaG91bGQgbm90 IHRoZSBpc3N1ZSBjYXVzZWQgYnkgdGhpcyBzZXJpZXMsIHdoaWNoCj4gPiB3aWxsIGJlIGFkZHJl c3NlZCBieSBzZXBhcmF0ZSBwYXRjaGVzLgo+ID4KPiA+IEkgYWxzbyBidWlsdCB0aGlzIHBhdGNo IHNlcmllcyBvbiBteSBBcm02NCBhbmQgeDg2IG1hY2hpbmVzLCBib3RoIGNhbgo+ID4gY29tcGls ZSBwZXJmIHRvb2wgc3VjY2Vzc2Z1bGx5OyBidXQgSSBoYXZlIG5vIGNoYW5jZSB0byBidWlsZCBv dGhlcgo+ID4gYXJjaHMgbmF0aXZlbHkuCj4gPgo+ID4gQ2hhbmdlcyBmcm9tIHYxOgo+ID4gLSBG b3Igc3VwcG9ydCBjcm9zcyBhbmFseXNpcyBmb3IgSVAvU1AgcmVnaXN0ZXJzLCBpbnRyb2R1Y2Vk IHBhdGNoIDAwMDIKPiA+ICAgKEphbWVzIENsYXJrLCBJYW4gUm9nZXJzKS4KPiA+Cj4gPgo+ID4g TGVvIFlhbiAoNik6Cj4gPiAgIHBlcmYgcGFyc2UtcmVnczogUmVmYWN0b3IgYXJjaCByZWdpc3Rl ciBwYXJzaW5nIGZ1bmN0aW9ucwo+ID4gICBwZXJmIHBhcnNlLXJlZ3M6IEludHJvZHVjZSBmdW5j dGlvbnMgcGVyZl9hcmNoX3JlZ197aXB8c3B9KCkKPiA+ICAgcGVyZiB1bndpbmQ6IFVzZSBwZXJm X2FyY2hfcmVnX3tpcHxzcH0oKSB0byBzdWJzdGl0dXRlIG1hY3Jvcwo+ID4gICBwZXJmIHBhcnNl LXJlZ3M6IFJlbW92ZSB1bnVzZWQgbWFjcm9zIFBFUkZfUkVHX3tJUHxTUH0KPiA+ICAgcGVyZiBw YXJzZS1yZWdzOiBSZW1vdmUgUEVSRl9SRUdTX3tNQVh8TUFTS30gZnJvbSBjb21tb24gY29kZQo+ ID4gICBwZXJmIHBhcnNlLXJlZ3M6IE1vdmUgb3V0IGFyY2ggc3BlY2lmaWMgaGVhZGVyIGZyb20g dXRpbC9wZXJmX3JlZ3MuaAo+IAo+IFNvcnJ5IGZvciB0aGUgc2xvdyByZXZpZXcuIEZvciB0aGUg c2VyaWVzOgo+IEFja2VkLWJ5OiBJYW4gUm9nZXJzIDxpcm9nZXJzQGdvb2dsZS5jb20+Cj4gCj4g U29tZSB0aG91Z2h0czoKPiB1aW50NjRfdCBfX3BlcmZfcmVnX2lwX2FybSh2b2lkKQo+IHVpbnQ2 NF90IHNlZW1zIGxpa2Ugd2UncmUgZ2l2aW5nIGEgbG90IG9mIHNwYWNlIGZvciBmdXR1cmUgcmVn aXN0ZXIKPiBlbmNvZGluZ3MuIEkgdGhpbmsgc29tZSBvZiB0aGUgb3RoZXIgZnVuY3Rpb25zIHVz ZSB0aGlzIHNpemUgb2YgdmFsdWUKPiBkdWUgdG8gcmV0dXJuaW5nIGEgYml0bWFwL21hc2ssIGJ1 dCBoZXJlIGl0IGlzbid0IGNsZWFyIGFuZCBqdXN0IGZlZWxzCj4gZXhjZXNzaXZlLgo+IAo+IERv IHdlIG5lZWQgdGhlICJfXyIgcHJlZml4IG9uIGFsbCB0aGUgZnVuY3Rpb25zPwo+IAo+IEluIE1h a2VmaWxlLmNvbmZpZyB0aGVyZSBhcmUgTk9fUEVSRl9SRUdTIGFuZCBDT05GSUdfUEVSRl9SRUdT IHRoZW4KPiB0aGUgZGVmaW5lIEhBVkVfUEVSRl9SRUdTX1NVUFBPUlQuIElzIHRoaXMgc3RpbGwg cmVsZXZhbnQ/IElmIHdlIGhhZAo+IGFuIGFyY2hpdGVjdHVyZSB3aXRoIG5vIHN1cHBvcnQsIGNv dWxkbid0IGl0IHN0aWxsIHJlYWQgYSBwZXJmLmRhdGEKPiBmaWxlIGZyb20gYSBzdXBwb3J0ZWQg YXJjaGl0ZWN0dXJlPyBJdCB3b3VsZCBiZSBuaWNlIHRvIHJlbW92ZSBhdAo+IGxlYXN0IE5PX1BF UkZfUkVHUyBhbmQgSEFWRV9QRVJGX1JFR1NfU1VQUE9SVC4KPiAKPiBUaGlzIGNoYW5nZSBpcyB2 ZXJ5IHdvcnRod2hpbGUgZml4IGFuZCBjbGVhbnVwLCBpdCBkaWRuJ3QgaW50cm9kdWNlCj4gd2hh dCBpcyBwb25kZXJlZCBhYm92ZSwgaGVuY2UgdGhlIGFja2VkLWJ5LgoKQWdyZWVkLCBhcHBsaWVk IHRvIHBlcmYtdG9vbHMtbmV4dCwgc29ycnkgZm9yIHRoZSBkZWxheS4KCi0gQXJuYWxkbwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=