From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 564B2C001B0 for ; Wed, 16 Aug 2023 11:47:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237192AbjHPLqt (ORCPT ); Wed, 16 Aug 2023 07:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244767AbjHPLqa (ORCPT ); Wed, 16 Aug 2023 07:46:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DE081FC3; Wed, 16 Aug 2023 04:46:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1672A63E4C; Wed, 16 Aug 2023 11:46:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAD44C433C7; Wed, 16 Aug 2023 11:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692186387; bh=pFV0gcMmGAKm6F4azY/qV8aRse57Y/S2iw8UPyRiuBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m47ipfglakvCFAbG6FQ+Mjb1GbW6GHpUq0RWmYro/2CF2GPC/IZetIhNczDIsatFE Du73VYXriB0jF9zzJCSp0k1RRSsvOjvTAY0kL4LQ4dazRN8l4tIFdPWtXmOmWEk8YU K1HR7OfqQSE4WSxbCSSddwgiZkYqujdKLfwq44dZtJUGFenOD+1tHDqSdTvjZ/lWX1 QBhXF+294jGfSx03QDeNudqIPFrHDihsOdnTyP0gvWulwk8RhY7LL8PZAEVl/00yp7 lS2VQB47DtVS2HFMB4a3Dd27sdI708rg6YRFFaqSha9T9UADcqWcWshmKZrB0LqilI e10HreI00wnOA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BAB72404DF; Wed, 16 Aug 2023 08:46:23 -0300 (-03) Date: Wed, 16 Aug 2023 08:46:23 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> <20230816020715.GA135657@leoy-huanghe.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230816020715.GA135657@leoy-huanghe.lan> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Em Wed, Aug 16, 2023 at 10:07:15AM +0800, Leo Yan escreveu: > On Tue, Aug 15, 2023 at 03:57:17PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 15, 2023 at 03:52:38PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Tue, Aug 15, 2023 at 03:45:27PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > > Agreed, applied to perf-tools-next, sorry for the delay. > > > > > > > > Had to add this to make 'perf test python' to work. Please run 'perf > > > > test' before sending patches. > > > > > > One more, please also do a 'make -C tools/perf build-test', with it I > > > caught this: > > > > > > make_no_libunwind_O: cd . && make NO_LIBUNWIND=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.yeEGyQq2HR DESTDIR=/tmp/tmp.ITgoO16jjH > > > cd . && make NO_LIBUNWIND=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.yeEGyQq2HR DESTDIR=/tmp/tmp.ITgoO16jjH > > > > +#include "util/env.h" > > > > As now we need it for perf_env__arch(ui->machine->env) > > Sorry for inconvenience. > > I saw this patch series has been picked into the branch: > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf-tools-next > > If want me to follow up, let me know. Thank you! Right, I'll fix this ones: [perfbuilder@five ~]$ grep "unused variable" dm.log/*:* dm.log/ubuntu:18.04-x-m68k:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] dm.log/ubuntu:18.04-x-riscv64:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] dm.log/ubuntu:18.04-x-sh4:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] dm.log/ubuntu:18.04-x-sparc64:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] [perfbuilder@five ~]$ And move that to perf-tools-next, we can go on from there. The above is because we don't define CONFIG_PERF_REGS for these architectures and thus that variable ends up not being used, so I'm fixing up like below, in the cset where you made DWARF_MINIMAL_REGS receive the arch parameter. Also I haven't checked how gracefully we react when processing a perf.data collected in one of those unsupported arches, can you please check? - Arnaldo diff --git a/tools/perf/util/perf_regs.h b/tools/perf/util/perf_regs.h index 790c1a26bbfe9b4b..de1673057e502de9 100644 --- a/tools/perf/util/perf_regs.h +++ b/tools/perf/util/perf_regs.h @@ -32,9 +32,6 @@ extern const struct sample_reg sample_reg_masks[]; #include -#define DWARF_MINIMAL_REGS(arch) \ - ((1ULL << perf_arch_reg_ip(arch)) | (1ULL << perf_arch_reg_sp(arch))) - const char *perf_reg_name(int id, const char *arch); int perf_reg_value(u64 *valp, struct regs_dump *regs, int id); uint64_t perf_arch_reg_ip(const char *arch); @@ -67,11 +64,19 @@ const char *__perf_reg_name_x86(int id); uint64_t __perf_reg_ip_x86(void); uint64_t __perf_reg_sp_x86(void); +static inline uint64_t DWARF_MINIMAL_REGS(const char *arch) +{ + return (1ULL << perf_arch_reg_ip(arch)) | (1ULL << perf_arch_reg_sp(arch)); +} + #else #define PERF_REGS_MASK 0 #define PERF_REGS_MAX 0 -#define DWARF_MINIMAL_REGS(arch) PERF_REGS_MASK +static inline uint64_t DWARF_MINIMAL_REGS(const char *arch __maybe_unused) +{ + return PERF_REGS_MASK; +} static inline const char *perf_reg_name(int id __maybe_unused, const char *arch __maybe_unused) { > > > CC /tmp/tmp.yeEGyQq2HR/util/expr-flex.o > > > util/unwind-libdw.c: In function ‘memory_read’: > > > util/unwind-libdw.c:173:28: error: implicit declaration of function ‘perf_env__arch’ [-Werror=implicit-function-declaration] > > > 173 | const char *arch = perf_env__arch(ui->machine->env); > > > | ^~~~~~~~~~~~~~ > > > util/unwind-libdw.c:173:28: error: initialization of ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] > > > util/unwind-libdw.c: In function ‘unwind__get_entries’: > > > util/unwind-libdw.c:258:28: error: initialization of ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] > > > 258 | const char *arch = perf_env__arch(ui_buf.machine->env); > > > | ^~~~~~~~~~~~~~ > > > cc1: all warnings being treated as errors > > > make[6]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:98: /tmp/tmp.yeEGyQq2HR/util/unwind-libdw.o] Error 1 > > > make[6]: *** Waiting for unfinished jobs.... > > > make[5]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:150: util] Error 2 > > > make[4]: *** [Makefile.perf:662: /tmp/tmp.yeEGyQq2HR/perf-in.o] Error 2 > > > make[4]: *** Waiting for unfinished jobs.... > > > CC /tmp/tmp.yeEGyQq2HR/pmu-events/pmu-events.o > > > LD /tmp/tmp.yeEGyQq2HR/pmu-events/pmu-events-in.o > > > make[3]: *** [Makefile.perf:238: sub-make] Error 2 > > > make[2]: *** [Makefile:70: all] Error 2 > > > make[1]: *** [tests/make:337: make_no_libunwind_O] Error 1 > > > make: *** [Makefile:103: build-test] Error 2 > > > make: Leaving directory '/var/home/acme/git/perf-tools-next/tools/perf' > > > > > > real 1m29.784s > > > user 10m41.597s > > > sys 2m55.948s > > > ⬢[acme@toolbox perf-tools-next]$ > > > > > > I'm trying to fix > > > > -- > > > > - Arnaldo -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCD14C001B0 for ; Wed, 16 Aug 2023 11:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6zy6oSNDqpgATnNcaUpa4cPa8iC7UbhGovf1YXjEahs=; b=Lmv/Ak1vCevm7J LfaP4D5EESvlRYNRGNCJ04jfnPr87SUwrryRi+HZeUWD9jgow9nCn+6zVquygDskBRA604jJIxJ5J 3qlMg2ET8OITAiJW0hCz+LnzgFmUQQnQFIMEniAUsKWJQ8+hAQxnq5ff4kqfXuFTul/mvTNnSFusx /mEWhsplA3Tjqceuc7JWiBXX6Aybp/fK2h8EOdd5OXbPG3j2bYQDaIF5Ye0hCCh0PaORWT1Bdbj2k spAYlalYbiTVsfQ2uSzFV913/S/+ktRPz9PGJ4Mds7qwP61eB5sIaYedBOKrJVdIETFtjmtoE8jGH hXUMjtBZNz8YmH6Jj4fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWEyt-0041Jr-25; Wed, 16 Aug 2023 11:46:31 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWEyr-0041JR-2c; Wed, 16 Aug 2023 11:46:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=YF5mSl89KgBBJBIQZnsazIATi9/SQ8Df7kxpYByyqOg=; b=jNwAYB5AyagoIDGvHENBzhvedM Z4kWK6ENGj1+Zas791SAyTIvhSBHRrJ3fgFSRAK9zbkq9gilZWgtc5UmlnFDZpiVWeNcyQ8qXh47N aHwi7g5Hwh0wiTs8yd6WGgrUDVbriY8GtEl/PTZ8yVvN6DXRB/TRNMO6HVQscXed0FcZ6eszplqEF 7bSotU76+B8RSbgOXwAje7lXiDlaogJEiV+PEG8fqbP/MqeIuUzMYcGdMvP6C2DrIHDov/V9TZEqr /+o3tswGtOIM3jRqI6J69kdoCmd7zJXpyyh/8dq6hPZtOXpZ8O4wyOUiUeHvE4XBoj3tSEQ2qcfV7 yw5axuGw==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qWEyp-00Cym1-2N; Wed, 16 Aug 2023 11:46:28 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BAB72404DF; Wed, 16 Aug 2023 08:46:23 -0300 (-03) Date: Wed, 16 Aug 2023 08:46:23 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> <20230816020715.GA135657@leoy-huanghe.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230816020715.GA135657@leoy-huanghe.lan> X-Url: http://acmel.wordpress.com X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org RW0gV2VkLCBBdWcgMTYsIDIwMjMgYXQgMTA6MDc6MTVBTSArMDgwMCwgTGVvIFlhbiBlc2NyZXZl dToKPiBPbiBUdWUsIEF1ZyAxNSwgMjAyMyBhdCAwMzo1NzoxN1BNIC0wMzAwLCBBcm5hbGRvIENh cnZhbGhvIGRlIE1lbG8gd3JvdGU6Cj4gPiBFbSBUdWUsIEF1ZyAxNSwgMjAyMyBhdCAwMzo1Mjoz OFBNIC0wMzAwLCBBcm5hbGRvIENhcnZhbGhvIGRlIE1lbG8gZXNjcmV2ZXU6Cj4gPiA+IEVtIFR1 ZSwgQXVnIDE1LCAyMDIzIGF0IDAzOjQ1OjI3UE0gLTAzMDAsIEFybmFsZG8gQ2FydmFsaG8gZGUg TWVsbyBlc2NyZXZldToKPiA+ID4gPiA+IEFncmVlZCwgYXBwbGllZCB0byBwZXJmLXRvb2xzLW5l eHQsIHNvcnJ5IGZvciB0aGUgZGVsYXkuCj4gPiA+ID4gCj4gPiA+ID4gSGFkIHRvIGFkZCB0aGlz IHRvIG1ha2UgJ3BlcmYgdGVzdCBweXRob24nIHRvIHdvcmsuIFBsZWFzZSBydW4gJ3BlcmYKPiA+ ID4gPiB0ZXN0JyBiZWZvcmUgc2VuZGluZyBwYXRjaGVzLgo+ID4gPiAKPiA+ID4gT25lIG1vcmUs IHBsZWFzZSBhbHNvIGRvIGEgJ21ha2UgLUMgdG9vbHMvcGVyZiBidWlsZC10ZXN0Jywgd2l0aCBp dCBJCj4gPiA+IGNhdWdodCB0aGlzOgo+ID4gPiAKPiA+ID4gICAgICAgICAgbWFrZV9ub19saWJ1 bndpbmRfTzogY2QgLiAmJiBtYWtlIE5PX0xJQlVOV0lORD0xIEZFQVRVUkVTX0RVTVA9L3Zhci9o b21lL2FjbWUvZ2l0L3BlcmYtdG9vbHMtbmV4dC90b29scy9wZXJmL0JVSUxEX1RFU1RfRkVBVFVS RV9EVU1QIC1qMzIgTz0vdG1wL3RtcC55ZUVHeVFxMkhSIERFU1RESVI9L3RtcC90bXAuSVRnb08x NmpqSAo+ID4gPiBjZCAuICYmIG1ha2UgTk9fTElCVU5XSU5EPTEgRkVBVFVSRVNfRFVNUD0vdmFy L2hvbWUvYWNtZS9naXQvcGVyZi10b29scy1uZXh0L3Rvb2xzL3BlcmYvQlVJTERfVEVTVF9GRUFU VVJFX0RVTVAgLWozMiBPPS90bXAvdG1wLnllRUd5UXEySFIgREVTVERJUj0vdG1wL3RtcC5JVGdv TzE2ampICj4gPiAKPiA+ICsjaW5jbHVkZSAidXRpbC9lbnYuaCIKPiA+IAo+ID4gQXMgbm93IHdl IG5lZWQgaXQgZm9yIHBlcmZfZW52X19hcmNoKHVpLT5tYWNoaW5lLT5lbnYpCj4gCj4gU29ycnkg Zm9yIGluY29udmVuaWVuY2UuCj4gCj4gSSBzYXcgdGhpcyBwYXRjaCBzZXJpZXMgaGFzIGJlZW4g cGlja2VkIGludG8gdGhlIGJyYW5jaDoKPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20v bGludXgva2VybmVsL2dpdC9hY21lL2xpbnV4LmdpdC9sb2cvP2g9dG1wLnBlcmYtdG9vbHMtbmV4 dAo+IAo+IElmIHdhbnQgbWUgdG8gZm9sbG93IHVwLCBsZXQgbWUga25vdy4gIFRoYW5rIHlvdSEK ClJpZ2h0LCBJJ2xsIGZpeCB0aGlzIG9uZXM6CgpbcGVyZmJ1aWxkZXJAZml2ZSB+XSQgZ3JlcCAi dW51c2VkIHZhcmlhYmxlIiBkbS5sb2cvKjoqCmRtLmxvZy91YnVudHU6MTguMDQteC1tNjhrOnV0 aWwvZXZzZWwuYzo4NDg6MTQ6IGVycm9yOiB1bnVzZWQgdmFyaWFibGUgJ2FyY2gnIFstV2Vycm9y PXVudXNlZC12YXJpYWJsZV0KZG0ubG9nL3VidW50dToxOC4wNC14LXJpc2N2NjQ6dXRpbC9ldnNl bC5jOjg0ODoxNDogZXJyb3I6IHVudXNlZCB2YXJpYWJsZSAnYXJjaCcgWy1XZXJyb3I9dW51c2Vk LXZhcmlhYmxlXQpkbS5sb2cvdWJ1bnR1OjE4LjA0LXgtc2g0OnV0aWwvZXZzZWwuYzo4NDg6MTQ6 IGVycm9yOiB1bnVzZWQgdmFyaWFibGUgJ2FyY2gnIFstV2Vycm9yPXVudXNlZC12YXJpYWJsZV0K ZG0ubG9nL3VidW50dToxOC4wNC14LXNwYXJjNjQ6dXRpbC9ldnNlbC5jOjg0ODoxNDogZXJyb3I6 IHVudXNlZCB2YXJpYWJsZSAnYXJjaCcgWy1XZXJyb3I9dW51c2VkLXZhcmlhYmxlXQpbcGVyZmJ1 aWxkZXJAZml2ZSB+XSQKCkFuZCBtb3ZlIHRoYXQgdG8gcGVyZi10b29scy1uZXh0LCB3ZSBjYW4g Z28gb24gZnJvbSB0aGVyZS4KClRoZSBhYm92ZSBpcyBiZWNhdXNlIHdlIGRvbid0IGRlZmluZSBD T05GSUdfUEVSRl9SRUdTIGZvciB0aGVzZQphcmNoaXRlY3R1cmVzIGFuZCB0aHVzIHRoYXQgdmFy aWFibGUgZW5kcyB1cCBub3QgYmVpbmcgdXNlZCwgc28gSSdtCmZpeGluZyB1cCBsaWtlIGJlbG93 LCBpbiB0aGUgY3NldCB3aGVyZSB5b3UgbWFkZSBEV0FSRl9NSU5JTUFMX1JFR1MKcmVjZWl2ZSB0 aGUgYXJjaCBwYXJhbWV0ZXIuCgpBbHNvIEkgaGF2ZW4ndCBjaGVja2VkIGhvdyBncmFjZWZ1bGx5 IHdlIHJlYWN0IHdoZW4gcHJvY2Vzc2luZyBhCnBlcmYuZGF0YSBjb2xsZWN0ZWQgaW4gb25lIG9m IHRob3NlIHVuc3VwcG9ydGVkIGFyY2hlcywgY2FuIHlvdSBwbGVhc2UKY2hlY2s/CgotIEFybmFs ZG8KCmRpZmYgLS1naXQgYS90b29scy9wZXJmL3V0aWwvcGVyZl9yZWdzLmggYi90b29scy9wZXJm L3V0aWwvcGVyZl9yZWdzLmgKaW5kZXggNzkwYzFhMjZiYmZlOWI0Yi4uZGUxNjczMDU3ZTUwMmRl OSAxMDA2NDQKLS0tIGEvdG9vbHMvcGVyZi91dGlsL3BlcmZfcmVncy5oCisrKyBiL3Rvb2xzL3Bl cmYvdXRpbC9wZXJmX3JlZ3MuaApAQCAtMzIsOSArMzIsNiBAQCBleHRlcm4gY29uc3Qgc3RydWN0 IHNhbXBsZV9yZWcgc2FtcGxlX3JlZ19tYXNrc1tdOwogCiAjaW5jbHVkZSA8cGVyZl9yZWdzLmg+ CiAKLSNkZWZpbmUgRFdBUkZfTUlOSU1BTF9SRUdTKGFyY2gpCVwKLQkoKDFVTEwgPDwgcGVyZl9h cmNoX3JlZ19pcChhcmNoKSkgfCAoMVVMTCA8PCBwZXJmX2FyY2hfcmVnX3NwKGFyY2gpKSkKLQog Y29uc3QgY2hhciAqcGVyZl9yZWdfbmFtZShpbnQgaWQsIGNvbnN0IGNoYXIgKmFyY2gpOwogaW50 IHBlcmZfcmVnX3ZhbHVlKHU2NCAqdmFscCwgc3RydWN0IHJlZ3NfZHVtcCAqcmVncywgaW50IGlk KTsKIHVpbnQ2NF90IHBlcmZfYXJjaF9yZWdfaXAoY29uc3QgY2hhciAqYXJjaCk7CkBAIC02Nywx MSArNjQsMTkgQEAgY29uc3QgY2hhciAqX19wZXJmX3JlZ19uYW1lX3g4NihpbnQgaWQpOwogdWlu dDY0X3QgX19wZXJmX3JlZ19pcF94ODYodm9pZCk7CiB1aW50NjRfdCBfX3BlcmZfcmVnX3NwX3g4 Nih2b2lkKTsKIAorc3RhdGljIGlubGluZSB1aW50NjRfdCBEV0FSRl9NSU5JTUFMX1JFR1MoY29u c3QgY2hhciAqYXJjaCkKK3sKKwlyZXR1cm4gKDFVTEwgPDwgcGVyZl9hcmNoX3JlZ19pcChhcmNo KSkgfCAoMVVMTCA8PCBwZXJmX2FyY2hfcmVnX3NwKGFyY2gpKTsKK30KKwogI2Vsc2UKICNkZWZp bmUgUEVSRl9SRUdTX01BU0sJMAogI2RlZmluZSBQRVJGX1JFR1NfTUFYCTAKIAotI2RlZmluZSBE V0FSRl9NSU5JTUFMX1JFR1MoYXJjaCkJUEVSRl9SRUdTX01BU0sKK3N0YXRpYyBpbmxpbmUgdWlu dDY0X3QgRFdBUkZfTUlOSU1BTF9SRUdTKGNvbnN0IGNoYXIgKmFyY2ggX19tYXliZV91bnVzZWQp Cit7CisJcmV0dXJuIFBFUkZfUkVHU19NQVNLOworfQogCiBzdGF0aWMgaW5saW5lIGNvbnN0IGNo YXIgKnBlcmZfcmVnX25hbWUoaW50IGlkIF9fbWF5YmVfdW51c2VkLCBjb25zdCBjaGFyICphcmNo IF9fbWF5YmVfdW51c2VkKQogewogCj4gPiA+ICAgQ0MgICAgICAvdG1wL3RtcC55ZUVHeVFxMkhS L3V0aWwvZXhwci1mbGV4Lm8KPiA+ID4gdXRpbC91bndpbmQtbGliZHcuYzogSW4gZnVuY3Rpb24g 4oCYbWVtb3J5X3JlYWTigJk6Cj4gPiA+IHV0aWwvdW53aW5kLWxpYmR3LmM6MTczOjI4OiBlcnJv cjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYcGVyZl9lbnZfX2FyY2jigJkg Wy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gPiA+ICAgMTczIHwgICAg ICAgICBjb25zdCBjaGFyICphcmNoID0gcGVyZl9lbnZfX2FyY2godWktPm1hY2hpbmUtPmVudik7 Cj4gPiA+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn4K PiA+ID4gdXRpbC91bndpbmQtbGliZHcuYzoxNzM6Mjg6IGVycm9yOiBpbml0aWFsaXphdGlvbiBv ZiDigJhjb25zdCBjaGFyICrigJkgZnJvbSDigJhpbnTigJkgbWFrZXMgcG9pbnRlciBmcm9tIGlu dGVnZXIgd2l0aG91dCBhIGNhc3QgWy1XZXJyb3I9aW50LWNvbnZlcnNpb25dCj4gPiA+IHV0aWwv dW53aW5kLWxpYmR3LmM6IEluIGZ1bmN0aW9uIOKAmHVud2luZF9fZ2V0X2VudHJpZXPigJk6Cj4g PiA+IHV0aWwvdW53aW5kLWxpYmR3LmM6MjU4OjI4OiBlcnJvcjogaW5pdGlhbGl6YXRpb24gb2Yg 4oCYY29uc3QgY2hhciAq4oCZIGZyb20g4oCYaW504oCZIG1ha2VzIHBvaW50ZXIgZnJvbSBpbnRl Z2VyIHdpdGhvdXQgYSBjYXN0IFstV2Vycm9yPWludC1jb252ZXJzaW9uXQo+ID4gPiAgIDI1OCB8 ICAgICAgICAgY29uc3QgY2hhciAqYXJjaCA9IHBlcmZfZW52X19hcmNoKHVpX2J1Zi5tYWNoaW5l LT5lbnYpOwo+ID4gPiAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+ fn5+fn5+Cj4gPiA+IGNjMTogYWxsIHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3JzCj4g PiA+IG1ha2VbNl06ICoqKiBbL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYtdG9vbHMtbmV4dC90b29s cy9idWlsZC9NYWtlZmlsZS5idWlsZDo5ODogL3RtcC90bXAueWVFR3lRcTJIUi91dGlsL3Vud2lu ZC1saWJkdy5vXSBFcnJvciAxCj4gPiA+IG1ha2VbNl06ICoqKiBXYWl0aW5nIGZvciB1bmZpbmlz aGVkIGpvYnMuLi4uCj4gPiA+IG1ha2VbNV06ICoqKiBbL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYt dG9vbHMtbmV4dC90b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDoxNTA6IHV0aWxdIEVycm9yIDIK PiA+ID4gbWFrZVs0XTogKioqIFtNYWtlZmlsZS5wZXJmOjY2MjogL3RtcC90bXAueWVFR3lRcTJI Ui9wZXJmLWluLm9dIEVycm9yIDIKPiA+ID4gbWFrZVs0XTogKioqIFdhaXRpbmcgZm9yIHVuZmlu aXNoZWQgam9icy4uLi4KPiA+ID4gICBDQyAgICAgIC90bXAvdG1wLnllRUd5UXEySFIvcG11LWV2 ZW50cy9wbXUtZXZlbnRzLm8KPiA+ID4gICBMRCAgICAgIC90bXAvdG1wLnllRUd5UXEySFIvcG11 LWV2ZW50cy9wbXUtZXZlbnRzLWluLm8KPiA+ID4gbWFrZVszXTogKioqIFtNYWtlZmlsZS5wZXJm OjIzODogc3ViLW1ha2VdIEVycm9yIDIKPiA+ID4gbWFrZVsyXTogKioqIFtNYWtlZmlsZTo3MDog YWxsXSBFcnJvciAyCj4gPiA+IG1ha2VbMV06ICoqKiBbdGVzdHMvbWFrZTozMzc6IG1ha2Vfbm9f bGlidW53aW5kX09dIEVycm9yIDEKPiA+ID4gbWFrZTogKioqIFtNYWtlZmlsZToxMDM6IGJ1aWxk LXRlc3RdIEVycm9yIDIKPiA+ID4gbWFrZTogTGVhdmluZyBkaXJlY3RvcnkgJy92YXIvaG9tZS9h Y21lL2dpdC9wZXJmLXRvb2xzLW5leHQvdG9vbHMvcGVyZicKPiA+ID4gCj4gPiA+IHJlYWwJMW0y OS43ODRzCj4gPiA+IHVzZXIJMTBtNDEuNTk3cwo+ID4gPiBzeXMJMm01NS45NDhzCj4gPiA+IOKs olthY21lQHRvb2xib3ggcGVyZi10b29scy1uZXh0XSQKPiA+ID4gCj4gPiA+IEknbSB0cnlpbmcg dG8gZml4Cj4gPiAKPiA+IC0tIAo+ID4gCj4gPiAtIEFybmFsZG8KCi0tIAoKLSBBcm5hbGRvCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNj diBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56B3CC001E0 for ; Wed, 16 Aug 2023 11:47:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qeCCc1NCm0GcMO8xxb/PBX/7BTsgaTELRcqXhzAPfHA=; b=49g5TdVrrxQihw JXso+qFVlrGVjg6Cngc2+0L8mlY2UqK0dM6xiCJtnbmp+612hTWzcLe0KEfwXgUlxkHXokCU+PSx8 IOWnuhubdss8XJJNU8Q6YNnIP1ejyYCoipJdtjLysQ1rW7pCjQQxOvosq9qdKZN7iLNPB9qRhESvg XWRmcMX4g7uvdcNu2BKoNC4ZkKV/nS+0OpM0VhbAISt9ObMftqiXgL31v6oqrIvaFXZ8y0BIfIsgF Ef3Mx1E/+byV8vgUMFuSZjxX7t3ZjcMXRTnE952GBi0l90GEEbt98qWjXDEsvkeZ6yc4uDS6NZXnR Wvg7r+/zqhj8HavqtxxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWEyt-0041Jk-0X; Wed, 16 Aug 2023 11:46:31 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWEyr-0041JR-2c; Wed, 16 Aug 2023 11:46:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=YF5mSl89KgBBJBIQZnsazIATi9/SQ8Df7kxpYByyqOg=; b=jNwAYB5AyagoIDGvHENBzhvedM Z4kWK6ENGj1+Zas791SAyTIvhSBHRrJ3fgFSRAK9zbkq9gilZWgtc5UmlnFDZpiVWeNcyQ8qXh47N aHwi7g5Hwh0wiTs8yd6WGgrUDVbriY8GtEl/PTZ8yVvN6DXRB/TRNMO6HVQscXed0FcZ6eszplqEF 7bSotU76+B8RSbgOXwAje7lXiDlaogJEiV+PEG8fqbP/MqeIuUzMYcGdMvP6C2DrIHDov/V9TZEqr /+o3tswGtOIM3jRqI6J69kdoCmd7zJXpyyh/8dq6hPZtOXpZ8O4wyOUiUeHvE4XBoj3tSEQ2qcfV7 yw5axuGw==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qWEyp-00Cym1-2N; Wed, 16 Aug 2023 11:46:28 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BAB72404DF; Wed, 16 Aug 2023 08:46:23 -0300 (-03) Date: Wed, 16 Aug 2023 08:46:23 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> <20230816020715.GA135657@leoy-huanghe.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230816020715.GA135657@leoy-huanghe.lan> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gV2VkLCBBdWcgMTYsIDIwMjMgYXQgMTA6MDc6MTVBTSArMDgwMCwgTGVvIFlhbiBlc2NyZXZl dToKPiBPbiBUdWUsIEF1ZyAxNSwgMjAyMyBhdCAwMzo1NzoxN1BNIC0wMzAwLCBBcm5hbGRvIENh cnZhbGhvIGRlIE1lbG8gd3JvdGU6Cj4gPiBFbSBUdWUsIEF1ZyAxNSwgMjAyMyBhdCAwMzo1Mjoz OFBNIC0wMzAwLCBBcm5hbGRvIENhcnZhbGhvIGRlIE1lbG8gZXNjcmV2ZXU6Cj4gPiA+IEVtIFR1 ZSwgQXVnIDE1LCAyMDIzIGF0IDAzOjQ1OjI3UE0gLTAzMDAsIEFybmFsZG8gQ2FydmFsaG8gZGUg TWVsbyBlc2NyZXZldToKPiA+ID4gPiA+IEFncmVlZCwgYXBwbGllZCB0byBwZXJmLXRvb2xzLW5l eHQsIHNvcnJ5IGZvciB0aGUgZGVsYXkuCj4gPiA+ID4gCj4gPiA+ID4gSGFkIHRvIGFkZCB0aGlz IHRvIG1ha2UgJ3BlcmYgdGVzdCBweXRob24nIHRvIHdvcmsuIFBsZWFzZSBydW4gJ3BlcmYKPiA+ ID4gPiB0ZXN0JyBiZWZvcmUgc2VuZGluZyBwYXRjaGVzLgo+ID4gPiAKPiA+ID4gT25lIG1vcmUs IHBsZWFzZSBhbHNvIGRvIGEgJ21ha2UgLUMgdG9vbHMvcGVyZiBidWlsZC10ZXN0Jywgd2l0aCBp dCBJCj4gPiA+IGNhdWdodCB0aGlzOgo+ID4gPiAKPiA+ID4gICAgICAgICAgbWFrZV9ub19saWJ1 bndpbmRfTzogY2QgLiAmJiBtYWtlIE5PX0xJQlVOV0lORD0xIEZFQVRVUkVTX0RVTVA9L3Zhci9o b21lL2FjbWUvZ2l0L3BlcmYtdG9vbHMtbmV4dC90b29scy9wZXJmL0JVSUxEX1RFU1RfRkVBVFVS RV9EVU1QIC1qMzIgTz0vdG1wL3RtcC55ZUVHeVFxMkhSIERFU1RESVI9L3RtcC90bXAuSVRnb08x NmpqSAo+ID4gPiBjZCAuICYmIG1ha2UgTk9fTElCVU5XSU5EPTEgRkVBVFVSRVNfRFVNUD0vdmFy L2hvbWUvYWNtZS9naXQvcGVyZi10b29scy1uZXh0L3Rvb2xzL3BlcmYvQlVJTERfVEVTVF9GRUFU VVJFX0RVTVAgLWozMiBPPS90bXAvdG1wLnllRUd5UXEySFIgREVTVERJUj0vdG1wL3RtcC5JVGdv TzE2ampICj4gPiAKPiA+ICsjaW5jbHVkZSAidXRpbC9lbnYuaCIKPiA+IAo+ID4gQXMgbm93IHdl IG5lZWQgaXQgZm9yIHBlcmZfZW52X19hcmNoKHVpLT5tYWNoaW5lLT5lbnYpCj4gCj4gU29ycnkg Zm9yIGluY29udmVuaWVuY2UuCj4gCj4gSSBzYXcgdGhpcyBwYXRjaCBzZXJpZXMgaGFzIGJlZW4g cGlja2VkIGludG8gdGhlIGJyYW5jaDoKPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20v bGludXgva2VybmVsL2dpdC9hY21lL2xpbnV4LmdpdC9sb2cvP2g9dG1wLnBlcmYtdG9vbHMtbmV4 dAo+IAo+IElmIHdhbnQgbWUgdG8gZm9sbG93IHVwLCBsZXQgbWUga25vdy4gIFRoYW5rIHlvdSEK ClJpZ2h0LCBJJ2xsIGZpeCB0aGlzIG9uZXM6CgpbcGVyZmJ1aWxkZXJAZml2ZSB+XSQgZ3JlcCAi dW51c2VkIHZhcmlhYmxlIiBkbS5sb2cvKjoqCmRtLmxvZy91YnVudHU6MTguMDQteC1tNjhrOnV0 aWwvZXZzZWwuYzo4NDg6MTQ6IGVycm9yOiB1bnVzZWQgdmFyaWFibGUgJ2FyY2gnIFstV2Vycm9y PXVudXNlZC12YXJpYWJsZV0KZG0ubG9nL3VidW50dToxOC4wNC14LXJpc2N2NjQ6dXRpbC9ldnNl bC5jOjg0ODoxNDogZXJyb3I6IHVudXNlZCB2YXJpYWJsZSAnYXJjaCcgWy1XZXJyb3I9dW51c2Vk LXZhcmlhYmxlXQpkbS5sb2cvdWJ1bnR1OjE4LjA0LXgtc2g0OnV0aWwvZXZzZWwuYzo4NDg6MTQ6 IGVycm9yOiB1bnVzZWQgdmFyaWFibGUgJ2FyY2gnIFstV2Vycm9yPXVudXNlZC12YXJpYWJsZV0K ZG0ubG9nL3VidW50dToxOC4wNC14LXNwYXJjNjQ6dXRpbC9ldnNlbC5jOjg0ODoxNDogZXJyb3I6 IHVudXNlZCB2YXJpYWJsZSAnYXJjaCcgWy1XZXJyb3I9dW51c2VkLXZhcmlhYmxlXQpbcGVyZmJ1 aWxkZXJAZml2ZSB+XSQKCkFuZCBtb3ZlIHRoYXQgdG8gcGVyZi10b29scy1uZXh0LCB3ZSBjYW4g Z28gb24gZnJvbSB0aGVyZS4KClRoZSBhYm92ZSBpcyBiZWNhdXNlIHdlIGRvbid0IGRlZmluZSBD T05GSUdfUEVSRl9SRUdTIGZvciB0aGVzZQphcmNoaXRlY3R1cmVzIGFuZCB0aHVzIHRoYXQgdmFy aWFibGUgZW5kcyB1cCBub3QgYmVpbmcgdXNlZCwgc28gSSdtCmZpeGluZyB1cCBsaWtlIGJlbG93 LCBpbiB0aGUgY3NldCB3aGVyZSB5b3UgbWFkZSBEV0FSRl9NSU5JTUFMX1JFR1MKcmVjZWl2ZSB0 aGUgYXJjaCBwYXJhbWV0ZXIuCgpBbHNvIEkgaGF2ZW4ndCBjaGVja2VkIGhvdyBncmFjZWZ1bGx5 IHdlIHJlYWN0IHdoZW4gcHJvY2Vzc2luZyBhCnBlcmYuZGF0YSBjb2xsZWN0ZWQgaW4gb25lIG9m IHRob3NlIHVuc3VwcG9ydGVkIGFyY2hlcywgY2FuIHlvdSBwbGVhc2UKY2hlY2s/CgotIEFybmFs ZG8KCmRpZmYgLS1naXQgYS90b29scy9wZXJmL3V0aWwvcGVyZl9yZWdzLmggYi90b29scy9wZXJm L3V0aWwvcGVyZl9yZWdzLmgKaW5kZXggNzkwYzFhMjZiYmZlOWI0Yi4uZGUxNjczMDU3ZTUwMmRl OSAxMDA2NDQKLS0tIGEvdG9vbHMvcGVyZi91dGlsL3BlcmZfcmVncy5oCisrKyBiL3Rvb2xzL3Bl cmYvdXRpbC9wZXJmX3JlZ3MuaApAQCAtMzIsOSArMzIsNiBAQCBleHRlcm4gY29uc3Qgc3RydWN0 IHNhbXBsZV9yZWcgc2FtcGxlX3JlZ19tYXNrc1tdOwogCiAjaW5jbHVkZSA8cGVyZl9yZWdzLmg+ CiAKLSNkZWZpbmUgRFdBUkZfTUlOSU1BTF9SRUdTKGFyY2gpCVwKLQkoKDFVTEwgPDwgcGVyZl9h cmNoX3JlZ19pcChhcmNoKSkgfCAoMVVMTCA8PCBwZXJmX2FyY2hfcmVnX3NwKGFyY2gpKSkKLQog Y29uc3QgY2hhciAqcGVyZl9yZWdfbmFtZShpbnQgaWQsIGNvbnN0IGNoYXIgKmFyY2gpOwogaW50 IHBlcmZfcmVnX3ZhbHVlKHU2NCAqdmFscCwgc3RydWN0IHJlZ3NfZHVtcCAqcmVncywgaW50IGlk KTsKIHVpbnQ2NF90IHBlcmZfYXJjaF9yZWdfaXAoY29uc3QgY2hhciAqYXJjaCk7CkBAIC02Nywx MSArNjQsMTkgQEAgY29uc3QgY2hhciAqX19wZXJmX3JlZ19uYW1lX3g4NihpbnQgaWQpOwogdWlu dDY0X3QgX19wZXJmX3JlZ19pcF94ODYodm9pZCk7CiB1aW50NjRfdCBfX3BlcmZfcmVnX3NwX3g4 Nih2b2lkKTsKIAorc3RhdGljIGlubGluZSB1aW50NjRfdCBEV0FSRl9NSU5JTUFMX1JFR1MoY29u c3QgY2hhciAqYXJjaCkKK3sKKwlyZXR1cm4gKDFVTEwgPDwgcGVyZl9hcmNoX3JlZ19pcChhcmNo KSkgfCAoMVVMTCA8PCBwZXJmX2FyY2hfcmVnX3NwKGFyY2gpKTsKK30KKwogI2Vsc2UKICNkZWZp bmUgUEVSRl9SRUdTX01BU0sJMAogI2RlZmluZSBQRVJGX1JFR1NfTUFYCTAKIAotI2RlZmluZSBE V0FSRl9NSU5JTUFMX1JFR1MoYXJjaCkJUEVSRl9SRUdTX01BU0sKK3N0YXRpYyBpbmxpbmUgdWlu dDY0X3QgRFdBUkZfTUlOSU1BTF9SRUdTKGNvbnN0IGNoYXIgKmFyY2ggX19tYXliZV91bnVzZWQp Cit7CisJcmV0dXJuIFBFUkZfUkVHU19NQVNLOworfQogCiBzdGF0aWMgaW5saW5lIGNvbnN0IGNo YXIgKnBlcmZfcmVnX25hbWUoaW50IGlkIF9fbWF5YmVfdW51c2VkLCBjb25zdCBjaGFyICphcmNo IF9fbWF5YmVfdW51c2VkKQogewogCj4gPiA+ICAgQ0MgICAgICAvdG1wL3RtcC55ZUVHeVFxMkhS L3V0aWwvZXhwci1mbGV4Lm8KPiA+ID4gdXRpbC91bndpbmQtbGliZHcuYzogSW4gZnVuY3Rpb24g 4oCYbWVtb3J5X3JlYWTigJk6Cj4gPiA+IHV0aWwvdW53aW5kLWxpYmR3LmM6MTczOjI4OiBlcnJv cjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYcGVyZl9lbnZfX2FyY2jigJkg Wy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gPiA+ICAgMTczIHwgICAg ICAgICBjb25zdCBjaGFyICphcmNoID0gcGVyZl9lbnZfX2FyY2godWktPm1hY2hpbmUtPmVudik7 Cj4gPiA+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn4K PiA+ID4gdXRpbC91bndpbmQtbGliZHcuYzoxNzM6Mjg6IGVycm9yOiBpbml0aWFsaXphdGlvbiBv ZiDigJhjb25zdCBjaGFyICrigJkgZnJvbSDigJhpbnTigJkgbWFrZXMgcG9pbnRlciBmcm9tIGlu dGVnZXIgd2l0aG91dCBhIGNhc3QgWy1XZXJyb3I9aW50LWNvbnZlcnNpb25dCj4gPiA+IHV0aWwv dW53aW5kLWxpYmR3LmM6IEluIGZ1bmN0aW9uIOKAmHVud2luZF9fZ2V0X2VudHJpZXPigJk6Cj4g PiA+IHV0aWwvdW53aW5kLWxpYmR3LmM6MjU4OjI4OiBlcnJvcjogaW5pdGlhbGl6YXRpb24gb2Yg 4oCYY29uc3QgY2hhciAq4oCZIGZyb20g4oCYaW504oCZIG1ha2VzIHBvaW50ZXIgZnJvbSBpbnRl Z2VyIHdpdGhvdXQgYSBjYXN0IFstV2Vycm9yPWludC1jb252ZXJzaW9uXQo+ID4gPiAgIDI1OCB8 ICAgICAgICAgY29uc3QgY2hhciAqYXJjaCA9IHBlcmZfZW52X19hcmNoKHVpX2J1Zi5tYWNoaW5l LT5lbnYpOwo+ID4gPiAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+ fn5+fn5+Cj4gPiA+IGNjMTogYWxsIHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3JzCj4g PiA+IG1ha2VbNl06ICoqKiBbL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYtdG9vbHMtbmV4dC90b29s cy9idWlsZC9NYWtlZmlsZS5idWlsZDo5ODogL3RtcC90bXAueWVFR3lRcTJIUi91dGlsL3Vud2lu ZC1saWJkdy5vXSBFcnJvciAxCj4gPiA+IG1ha2VbNl06ICoqKiBXYWl0aW5nIGZvciB1bmZpbmlz aGVkIGpvYnMuLi4uCj4gPiA+IG1ha2VbNV06ICoqKiBbL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYt dG9vbHMtbmV4dC90b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDoxNTA6IHV0aWxdIEVycm9yIDIK PiA+ID4gbWFrZVs0XTogKioqIFtNYWtlZmlsZS5wZXJmOjY2MjogL3RtcC90bXAueWVFR3lRcTJI Ui9wZXJmLWluLm9dIEVycm9yIDIKPiA+ID4gbWFrZVs0XTogKioqIFdhaXRpbmcgZm9yIHVuZmlu aXNoZWQgam9icy4uLi4KPiA+ID4gICBDQyAgICAgIC90bXAvdG1wLnllRUd5UXEySFIvcG11LWV2 ZW50cy9wbXUtZXZlbnRzLm8KPiA+ID4gICBMRCAgICAgIC90bXAvdG1wLnllRUd5UXEySFIvcG11 LWV2ZW50cy9wbXUtZXZlbnRzLWluLm8KPiA+ID4gbWFrZVszXTogKioqIFtNYWtlZmlsZS5wZXJm OjIzODogc3ViLW1ha2VdIEVycm9yIDIKPiA+ID4gbWFrZVsyXTogKioqIFtNYWtlZmlsZTo3MDog YWxsXSBFcnJvciAyCj4gPiA+IG1ha2VbMV06ICoqKiBbdGVzdHMvbWFrZTozMzc6IG1ha2Vfbm9f bGlidW53aW5kX09dIEVycm9yIDEKPiA+ID4gbWFrZTogKioqIFtNYWtlZmlsZToxMDM6IGJ1aWxk LXRlc3RdIEVycm9yIDIKPiA+ID4gbWFrZTogTGVhdmluZyBkaXJlY3RvcnkgJy92YXIvaG9tZS9h Y21lL2dpdC9wZXJmLXRvb2xzLW5leHQvdG9vbHMvcGVyZicKPiA+ID4gCj4gPiA+IHJlYWwJMW0y OS43ODRzCj4gPiA+IHVzZXIJMTBtNDEuNTk3cwo+ID4gPiBzeXMJMm01NS45NDhzCj4gPiA+IOKs olthY21lQHRvb2xib3ggcGVyZi10b29scy1uZXh0XSQKPiA+ID4gCj4gPiA+IEknbSB0cnlpbmcg dG8gZml4Cj4gPiAKPiA+IC0tIAo+ID4gCj4gPiAtIEFybmFsZG8KCi0tIAoKLSBBcm5hbGRvCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==