From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58440C41513 for ; Wed, 16 Aug 2023 11:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242848AbjHPLs6 (ORCPT ); Wed, 16 Aug 2023 07:48:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244774AbjHPLsg (ORCPT ); Wed, 16 Aug 2023 07:48:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B3B3E68; Wed, 16 Aug 2023 04:48:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E7D9C666EE; Wed, 16 Aug 2023 11:48:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4427C433C8; Wed, 16 Aug 2023 11:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692186514; bh=v2m2BK3GGd11X74j40insUcmDxokoIf6Czvuxm4GLe0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kIQ+3GZqZqX0YR2G3PxIKU4z7PLWBtwM1cFVVGQ7TYpvNN9lOIKya5TYcEllvV5/r +W8yXiXqVRP/pyu1E7I1vsZS3Jmp1oPKegOA3D++BcgVc2hV56aJ/5pykDa8EoW5RM pn1sIBsV+LvX31A82MRtST79dD+bQ4uCQ6zuHoF9bLeJWYVhMYnHiEsAM3ZE+A5xhP OlEOpJtaeMdzzlm7S5bBj8a/ri7rIyXml8SPM1N3iPUt7Pr4hNL9zEtmTp2QT6Jsj7 o/nDUGMASQ/yVc/jLwynWG2VYzo1rluHDyXfJ0BrGMmMW0oFDUNL9ETcMIMJlZfEuF sn8f0KkVIYj8A== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 00D32404DF; Wed, 16 Aug 2023 08:48:30 -0300 (-03) Date: Wed, 16 Aug 2023 08:48:30 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> <20230816020715.GA135657@leoy-huanghe.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Em Wed, Aug 16, 2023 at 08:46:23AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 16, 2023 at 10:07:15AM +0800, Leo Yan escreveu: > > On Tue, Aug 15, 2023 at 03:57:17PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Aug 15, 2023 at 03:52:38PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Tue, Aug 15, 2023 at 03:45:27PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > > > Agreed, applied to perf-tools-next, sorry for the delay. > > > > > > > > > > Had to add this to make 'perf test python' to work. Please run 'perf > > > > > test' before sending patches. > > > > > > > > One more, please also do a 'make -C tools/perf build-test', with it I > > > > caught this: > > > > > > > > make_no_libunwind_O: cd . && make NO_LIBUNWIND=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.yeEGyQq2HR DESTDIR=/tmp/tmp.ITgoO16jjH > > > > cd . && make NO_LIBUNWIND=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.yeEGyQq2HR DESTDIR=/tmp/tmp.ITgoO16jjH > > > > > > +#include "util/env.h" > > > > > > As now we need it for perf_env__arch(ui->machine->env) > > > > Sorry for inconvenience. > > > > I saw this patch series has been picked into the branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf-tools-next > > > > If want me to follow up, let me know. Thank you! > > Right, I'll fix this ones: > > [perfbuilder@five ~]$ grep "unused variable" dm.log/*:* > dm.log/ubuntu:18.04-x-m68k:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] > dm.log/ubuntu:18.04-x-riscv64:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] > dm.log/ubuntu:18.04-x-sh4:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] > dm.log/ubuntu:18.04-x-sparc64:util/evsel.c:848:14: error: unused variable 'arch' [-Werror=unused-variable] > [perfbuilder@five ~]$ > > And move that to perf-tools-next, we can go on from there. > > The above is because we don't define CONFIG_PERF_REGS for these > architectures and thus that variable ends up not being used, so I'm > fixing up like below, in the cset where you made DWARF_MINIMAL_REGS > receive the arch parameter. I added this to the cset commit message: Committer notes: Make DWARF_MINIMAL_REGS() an inline function, so that we can use the __maybe_unused attribute for the 'arch' parameter, as this will avoid a build failure when that variable is unused in the callers. That happens when building on unsupported architectures, the ones without HAVE_PERF_REGS_SUPPORT defined. > Also I haven't checked how gracefully we react when processing a > perf.data collected in one of those unsupported arches, can you please > check? > > - Arnaldo > > diff --git a/tools/perf/util/perf_regs.h b/tools/perf/util/perf_regs.h > index 790c1a26bbfe9b4b..de1673057e502de9 100644 > --- a/tools/perf/util/perf_regs.h > +++ b/tools/perf/util/perf_regs.h > @@ -32,9 +32,6 @@ extern const struct sample_reg sample_reg_masks[]; > > #include > > -#define DWARF_MINIMAL_REGS(arch) \ > - ((1ULL << perf_arch_reg_ip(arch)) | (1ULL << perf_arch_reg_sp(arch))) > - > const char *perf_reg_name(int id, const char *arch); > int perf_reg_value(u64 *valp, struct regs_dump *regs, int id); > uint64_t perf_arch_reg_ip(const char *arch); > @@ -67,11 +64,19 @@ const char *__perf_reg_name_x86(int id); > uint64_t __perf_reg_ip_x86(void); > uint64_t __perf_reg_sp_x86(void); > > +static inline uint64_t DWARF_MINIMAL_REGS(const char *arch) > +{ > + return (1ULL << perf_arch_reg_ip(arch)) | (1ULL << perf_arch_reg_sp(arch)); > +} > + > #else > #define PERF_REGS_MASK 0 > #define PERF_REGS_MAX 0 > > -#define DWARF_MINIMAL_REGS(arch) PERF_REGS_MASK > +static inline uint64_t DWARF_MINIMAL_REGS(const char *arch __maybe_unused) > +{ > + return PERF_REGS_MASK; > +} > > static inline const char *perf_reg_name(int id __maybe_unused, const char *arch __maybe_unused) > { > > > > > CC /tmp/tmp.yeEGyQq2HR/util/expr-flex.o > > > > util/unwind-libdw.c: In function ‘memory_read’: > > > > util/unwind-libdw.c:173:28: error: implicit declaration of function ‘perf_env__arch’ [-Werror=implicit-function-declaration] > > > > 173 | const char *arch = perf_env__arch(ui->machine->env); > > > > | ^~~~~~~~~~~~~~ > > > > util/unwind-libdw.c:173:28: error: initialization of ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] > > > > util/unwind-libdw.c: In function ‘unwind__get_entries’: > > > > util/unwind-libdw.c:258:28: error: initialization of ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] > > > > 258 | const char *arch = perf_env__arch(ui_buf.machine->env); > > > > | ^~~~~~~~~~~~~~ > > > > cc1: all warnings being treated as errors > > > > make[6]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:98: /tmp/tmp.yeEGyQq2HR/util/unwind-libdw.o] Error 1 > > > > make[6]: *** Waiting for unfinished jobs.... > > > > make[5]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:150: util] Error 2 > > > > make[4]: *** [Makefile.perf:662: /tmp/tmp.yeEGyQq2HR/perf-in.o] Error 2 > > > > make[4]: *** Waiting for unfinished jobs.... > > > > CC /tmp/tmp.yeEGyQq2HR/pmu-events/pmu-events.o > > > > LD /tmp/tmp.yeEGyQq2HR/pmu-events/pmu-events-in.o > > > > make[3]: *** [Makefile.perf:238: sub-make] Error 2 > > > > make[2]: *** [Makefile:70: all] Error 2 > > > > make[1]: *** [tests/make:337: make_no_libunwind_O] Error 1 > > > > make: *** [Makefile:103: build-test] Error 2 > > > > make: Leaving directory '/var/home/acme/git/perf-tools-next/tools/perf' > > > > > > > > real 1m29.784s > > > > user 10m41.597s > > > > sys 2m55.948s > > > > ⬢[acme@toolbox perf-tools-next]$ > > > > > > > > I'm trying to fix > > > > > > -- > > > > > > - Arnaldo > > -- > > - Arnaldo -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CB98C001B0 for ; Wed, 16 Aug 2023 11:48:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=srnkrs853J7YIjWVCJ5MNPsj/ymTtMBj8k+9vG339k8=; b=YH1fSRJfVWhsh1 v0m3Rtq9fV0QUEdLv+A+u/y+tGSX0dizPYVkCVzKXUifLW8+lJQPCGmXfH7hI0uNOUQhhG7eztIZx pCvxW3Ng8FXL3B0X8ZuQsGVYf/nxPp5SQKNqFnWgDepueXU7mjcIAdPc57wyMdSvOVUQfMqe1gBhu AB2HxT+gKm78PjPtFHfWmzSqvuCCk0shgw8xPsGKwgAsSA33s0wRgv1R3obQ2iSHtOUfGKTLX5c/O hifR4D4h+buvZlY/mfLIZSLP7HlKpu+v88MLuC64uu3LmpU43avcNMYFv1oLBdcv8pO0hmwNNYf5i RgsSCTl8MD+j6alNsq+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWF11-0041al-2K; Wed, 16 Aug 2023 11:48:43 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWF0z-0041aL-2p; Wed, 16 Aug 2023 11:48:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=mZdydCidZXFJb9y9DR3Oz92wcs8I7ilo2/AI5V/H+40=; b=S8ISDbCJ4aLNAFmgZzZsMQ70YI TpmZHX9vKbzZndVw/9wn0OiD1NXVCq3xDCT3WKfNlV6LpHpebT40p0zq2fINhXU0Pyo2OpwyMfo51 PJJMBVQ5nnO2u64j5MoIpWRPaqkZAFLeFXP3wErb59dP/YI6TA6jh40Efjrfo/niFL3jWq/pfp+6C 9bwLT1Iqf+v90N/q86z9PnhgM3UpBw8zPfFLyTbtKJZMKRc7oGI2X1DsTakNX1s/xUKBmLC/3l13s qCGg4hCmVF4MCRAyRp7PbzuiwgZbZON7qwKusKFCUzE5HD2h1k8Xzpgg+sDc6ngnNP+y7Tb/2w2v2 iaV+Q80Q==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qWF0w-00ET8d-4q; Wed, 16 Aug 2023 11:48:39 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 00D32404DF; Wed, 16 Aug 2023 08:48:30 -0300 (-03) Date: Wed, 16 Aug 2023 08:48:30 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> <20230816020715.GA135657@leoy-huanghe.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org RW0gV2VkLCBBdWcgMTYsIDIwMjMgYXQgMDg6NDY6MjNBTSAtMDMwMCwgQXJuYWxkbyBDYXJ2YWxo byBkZSBNZWxvIGVzY3JldmV1Ogo+IEVtIFdlZCwgQXVnIDE2LCAyMDIzIGF0IDEwOjA3OjE1QU0g KzA4MDAsIExlbyBZYW4gZXNjcmV2ZXU6Cj4gPiBPbiBUdWUsIEF1ZyAxNSwgMjAyMyBhdCAwMzo1 NzoxN1BNIC0wMzAwLCBBcm5hbGRvIENhcnZhbGhvIGRlIE1lbG8gd3JvdGU6Cj4gPiA+IEVtIFR1 ZSwgQXVnIDE1LCAyMDIzIGF0IDAzOjUyOjM4UE0gLTAzMDAsIEFybmFsZG8gQ2FydmFsaG8gZGUg TWVsbyBlc2NyZXZldToKPiA+ID4gPiBFbSBUdWUsIEF1ZyAxNSwgMjAyMyBhdCAwMzo0NToyN1BN IC0wMzAwLCBBcm5hbGRvIENhcnZhbGhvIGRlIE1lbG8gZXNjcmV2ZXU6Cj4gPiA+ID4gPiA+IEFn cmVlZCwgYXBwbGllZCB0byBwZXJmLXRvb2xzLW5leHQsIHNvcnJ5IGZvciB0aGUgZGVsYXkuCj4g PiA+ID4gPiAKPiA+ID4gPiA+IEhhZCB0byBhZGQgdGhpcyB0byBtYWtlICdwZXJmIHRlc3QgcHl0 aG9uJyB0byB3b3JrLiBQbGVhc2UgcnVuICdwZXJmCj4gPiA+ID4gPiB0ZXN0JyBiZWZvcmUgc2Vu ZGluZyBwYXRjaGVzLgo+ID4gPiA+IAo+ID4gPiA+IE9uZSBtb3JlLCBwbGVhc2UgYWxzbyBkbyBh ICdtYWtlIC1DIHRvb2xzL3BlcmYgYnVpbGQtdGVzdCcsIHdpdGggaXQgSQo+ID4gPiA+IGNhdWdo dCB0aGlzOgo+ID4gPiA+IAo+ID4gPiA+ICAgICAgICAgIG1ha2Vfbm9fbGlidW53aW5kX086IGNk IC4gJiYgbWFrZSBOT19MSUJVTldJTkQ9MSBGRUFUVVJFU19EVU1QPS92YXIvaG9tZS9hY21lL2dp dC9wZXJmLXRvb2xzLW5leHQvdG9vbHMvcGVyZi9CVUlMRF9URVNUX0ZFQVRVUkVfRFVNUCAtajMy IE89L3RtcC90bXAueWVFR3lRcTJIUiBERVNURElSPS90bXAvdG1wLklUZ29PMTZqakgKPiA+ID4g PiBjZCAuICYmIG1ha2UgTk9fTElCVU5XSU5EPTEgRkVBVFVSRVNfRFVNUD0vdmFyL2hvbWUvYWNt ZS9naXQvcGVyZi10b29scy1uZXh0L3Rvb2xzL3BlcmYvQlVJTERfVEVTVF9GRUFUVVJFX0RVTVAg LWozMiBPPS90bXAvdG1wLnllRUd5UXEySFIgREVTVERJUj0vdG1wL3RtcC5JVGdvTzE2ampICj4g PiA+IAo+ID4gPiArI2luY2x1ZGUgInV0aWwvZW52LmgiCj4gPiA+IAo+ID4gPiBBcyBub3cgd2Ug bmVlZCBpdCBmb3IgcGVyZl9lbnZfX2FyY2godWktPm1hY2hpbmUtPmVudikKPiA+IAo+ID4gU29y cnkgZm9yIGluY29udmVuaWVuY2UuCj4gPiAKPiA+IEkgc2F3IHRoaXMgcGF0Y2ggc2VyaWVzIGhh cyBiZWVuIHBpY2tlZCBpbnRvIHRoZSBicmFuY2g6Cj4gPiBodHRwczovL2dpdC5rZXJuZWwub3Jn L3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9hY21lL2xpbnV4LmdpdC9sb2cvP2g9dG1wLnBlcmYt dG9vbHMtbmV4dAo+ID4gCj4gPiBJZiB3YW50IG1lIHRvIGZvbGxvdyB1cCwgbGV0IG1lIGtub3cu ICBUaGFuayB5b3UhCj4gCj4gUmlnaHQsIEknbGwgZml4IHRoaXMgb25lczoKPiAKPiBbcGVyZmJ1 aWxkZXJAZml2ZSB+XSQgZ3JlcCAidW51c2VkIHZhcmlhYmxlIiBkbS5sb2cvKjoqCj4gZG0ubG9n L3VidW50dToxOC4wNC14LW02OGs6dXRpbC9ldnNlbC5jOjg0ODoxNDogZXJyb3I6IHVudXNlZCB2 YXJpYWJsZSAnYXJjaCcgWy1XZXJyb3I9dW51c2VkLXZhcmlhYmxlXQo+IGRtLmxvZy91YnVudHU6 MTguMDQteC1yaXNjdjY0OnV0aWwvZXZzZWwuYzo4NDg6MTQ6IGVycm9yOiB1bnVzZWQgdmFyaWFi bGUgJ2FyY2gnIFstV2Vycm9yPXVudXNlZC12YXJpYWJsZV0KPiBkbS5sb2cvdWJ1bnR1OjE4LjA0 LXgtc2g0OnV0aWwvZXZzZWwuYzo4NDg6MTQ6IGVycm9yOiB1bnVzZWQgdmFyaWFibGUgJ2FyY2gn IFstV2Vycm9yPXVudXNlZC12YXJpYWJsZV0KPiBkbS5sb2cvdWJ1bnR1OjE4LjA0LXgtc3BhcmM2 NDp1dGlsL2V2c2VsLmM6ODQ4OjE0OiBlcnJvcjogdW51c2VkIHZhcmlhYmxlICdhcmNoJyBbLVdl cnJvcj11bnVzZWQtdmFyaWFibGVdCj4gW3BlcmZidWlsZGVyQGZpdmUgfl0kCj4gCj4gQW5kIG1v dmUgdGhhdCB0byBwZXJmLXRvb2xzLW5leHQsIHdlIGNhbiBnbyBvbiBmcm9tIHRoZXJlLgo+IAo+ IFRoZSBhYm92ZSBpcyBiZWNhdXNlIHdlIGRvbid0IGRlZmluZSBDT05GSUdfUEVSRl9SRUdTIGZv ciB0aGVzZQo+IGFyY2hpdGVjdHVyZXMgYW5kIHRodXMgdGhhdCB2YXJpYWJsZSBlbmRzIHVwIG5v dCBiZWluZyB1c2VkLCBzbyBJJ20KPiBmaXhpbmcgdXAgbGlrZSBiZWxvdywgaW4gdGhlIGNzZXQg d2hlcmUgeW91IG1hZGUgRFdBUkZfTUlOSU1BTF9SRUdTCj4gcmVjZWl2ZSB0aGUgYXJjaCBwYXJh bWV0ZXIuCgpJIGFkZGVkIHRoaXMgdG8gdGhlIGNzZXQgY29tbWl0IG1lc3NhZ2U6CgpDb21taXR0 ZXIgbm90ZXM6CgpNYWtlIERXQVJGX01JTklNQUxfUkVHUygpIGFuIGlubGluZSBmdW5jdGlvbiwg c28gdGhhdCB3ZSBjYW4gdXNlIHRoZQpfX21heWJlX3VudXNlZCBhdHRyaWJ1dGUgZm9yIHRoZSAn YXJjaCcgcGFyYW1ldGVyLCBhcyB0aGlzIHdpbGwgYXZvaWQgYQpidWlsZCBmYWlsdXJlIHdoZW4g dGhhdCB2YXJpYWJsZSBpcyB1bnVzZWQgaW4gdGhlIGNhbGxlcnMuIFRoYXQgaGFwcGVucwp3aGVu IGJ1aWxkaW5nIG9uIHVuc3VwcG9ydGVkIGFyY2hpdGVjdHVyZXMsIHRoZSBvbmVzIHdpdGhvdXQK SEFWRV9QRVJGX1JFR1NfU1VQUE9SVCBkZWZpbmVkLgoKIAo+IEFsc28gSSBoYXZlbid0IGNoZWNr ZWQgaG93IGdyYWNlZnVsbHkgd2UgcmVhY3Qgd2hlbiBwcm9jZXNzaW5nIGEKPiBwZXJmLmRhdGEg Y29sbGVjdGVkIGluIG9uZSBvZiB0aG9zZSB1bnN1cHBvcnRlZCBhcmNoZXMsIGNhbiB5b3UgcGxl YXNlCj4gY2hlY2s/Cj4gCj4gLSBBcm5hbGRvCj4gCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3BlcmYv dXRpbC9wZXJmX3JlZ3MuaCBiL3Rvb2xzL3BlcmYvdXRpbC9wZXJmX3JlZ3MuaAo+IGluZGV4IDc5 MGMxYTI2YmJmZTliNGIuLmRlMTY3MzA1N2U1MDJkZTkgMTAwNjQ0Cj4gLS0tIGEvdG9vbHMvcGVy Zi91dGlsL3BlcmZfcmVncy5oCj4gKysrIGIvdG9vbHMvcGVyZi91dGlsL3BlcmZfcmVncy5oCj4g QEAgLTMyLDkgKzMyLDYgQEAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBzYW1wbGVfcmVnIHNhbXBsZV9y ZWdfbWFza3NbXTsKPiAgCj4gICNpbmNsdWRlIDxwZXJmX3JlZ3MuaD4KPiAgCj4gLSNkZWZpbmUg RFdBUkZfTUlOSU1BTF9SRUdTKGFyY2gpCVwKPiAtCSgoMVVMTCA8PCBwZXJmX2FyY2hfcmVnX2lw KGFyY2gpKSB8ICgxVUxMIDw8IHBlcmZfYXJjaF9yZWdfc3AoYXJjaCkpKQo+IC0KPiAgY29uc3Qg Y2hhciAqcGVyZl9yZWdfbmFtZShpbnQgaWQsIGNvbnN0IGNoYXIgKmFyY2gpOwo+ICBpbnQgcGVy Zl9yZWdfdmFsdWUodTY0ICp2YWxwLCBzdHJ1Y3QgcmVnc19kdW1wICpyZWdzLCBpbnQgaWQpOwo+ ICB1aW50NjRfdCBwZXJmX2FyY2hfcmVnX2lwKGNvbnN0IGNoYXIgKmFyY2gpOwo+IEBAIC02Nywx MSArNjQsMTkgQEAgY29uc3QgY2hhciAqX19wZXJmX3JlZ19uYW1lX3g4NihpbnQgaWQpOwo+ICB1 aW50NjRfdCBfX3BlcmZfcmVnX2lwX3g4Nih2b2lkKTsKPiAgdWludDY0X3QgX19wZXJmX3JlZ19z cF94ODYodm9pZCk7Cj4gIAo+ICtzdGF0aWMgaW5saW5lIHVpbnQ2NF90IERXQVJGX01JTklNQUxf UkVHUyhjb25zdCBjaGFyICphcmNoKQo+ICt7Cj4gKwlyZXR1cm4gKDFVTEwgPDwgcGVyZl9hcmNo X3JlZ19pcChhcmNoKSkgfCAoMVVMTCA8PCBwZXJmX2FyY2hfcmVnX3NwKGFyY2gpKTsKPiArfQo+ ICsKPiAgI2Vsc2UKPiAgI2RlZmluZSBQRVJGX1JFR1NfTUFTSwkwCj4gICNkZWZpbmUgUEVSRl9S RUdTX01BWAkwCj4gIAo+IC0jZGVmaW5lIERXQVJGX01JTklNQUxfUkVHUyhhcmNoKQlQRVJGX1JF R1NfTUFTSwo+ICtzdGF0aWMgaW5saW5lIHVpbnQ2NF90IERXQVJGX01JTklNQUxfUkVHUyhjb25z dCBjaGFyICphcmNoIF9fbWF5YmVfdW51c2VkKQo+ICt7Cj4gKwlyZXR1cm4gUEVSRl9SRUdTX01B U0s7Cj4gK30KPiAgCj4gIHN0YXRpYyBpbmxpbmUgY29uc3QgY2hhciAqcGVyZl9yZWdfbmFtZShp bnQgaWQgX19tYXliZV91bnVzZWQsIGNvbnN0IGNoYXIgKmFyY2ggX19tYXliZV91bnVzZWQpCj4g IHsKPiAgCj4gPiA+ID4gICBDQyAgICAgIC90bXAvdG1wLnllRUd5UXEySFIvdXRpbC9leHByLWZs ZXgubwo+ID4gPiA+IHV0aWwvdW53aW5kLWxpYmR3LmM6IEluIGZ1bmN0aW9uIOKAmG1lbW9yeV9y ZWFk4oCZOgo+ID4gPiA+IHV0aWwvdW53aW5kLWxpYmR3LmM6MTczOjI4OiBlcnJvcjogaW1wbGlj aXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYcGVyZl9lbnZfX2FyY2jigJkgWy1XZXJyb3I9 aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gPiA+ID4gICAxNzMgfCAgICAgICAgIGNv bnN0IGNoYXIgKmFyY2ggPSBwZXJmX2Vudl9fYXJjaCh1aS0+bWFjaGluZS0+ZW52KTsKPiA+ID4g PiAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+Cj4gPiA+ ID4gdXRpbC91bndpbmQtbGliZHcuYzoxNzM6Mjg6IGVycm9yOiBpbml0aWFsaXphdGlvbiBvZiDi gJhjb25zdCBjaGFyICrigJkgZnJvbSDigJhpbnTigJkgbWFrZXMgcG9pbnRlciBmcm9tIGludGVn ZXIgd2l0aG91dCBhIGNhc3QgWy1XZXJyb3I9aW50LWNvbnZlcnNpb25dCj4gPiA+ID4gdXRpbC91 bndpbmQtbGliZHcuYzogSW4gZnVuY3Rpb24g4oCYdW53aW5kX19nZXRfZW50cmllc+KAmToKPiA+ ID4gPiB1dGlsL3Vud2luZC1saWJkdy5jOjI1ODoyODogZXJyb3I6IGluaXRpYWxpemF0aW9uIG9m IOKAmGNvbnN0IGNoYXIgKuKAmSBmcm9tIOKAmGludOKAmSBtYWtlcyBwb2ludGVyIGZyb20gaW50 ZWdlciB3aXRob3V0IGEgY2FzdCBbLVdlcnJvcj1pbnQtY29udmVyc2lvbl0KPiA+ID4gPiAgIDI1 OCB8ICAgICAgICAgY29uc3QgY2hhciAqYXJjaCA9IHBlcmZfZW52X19hcmNoKHVpX2J1Zi5tYWNo aW5lLT5lbnYpOwo+ID4gPiA+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+ fn5+fn5+fn5+fn4KPiA+ID4gPiBjYzE6IGFsbCB3YXJuaW5ncyBiZWluZyB0cmVhdGVkIGFzIGVy cm9ycwo+ID4gPiA+IG1ha2VbNl06ICoqKiBbL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYtdG9vbHMt bmV4dC90b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDo5ODogL3RtcC90bXAueWVFR3lRcTJIUi91 dGlsL3Vud2luZC1saWJkdy5vXSBFcnJvciAxCj4gPiA+ID4gbWFrZVs2XTogKioqIFdhaXRpbmcg Zm9yIHVuZmluaXNoZWQgam9icy4uLi4KPiA+ID4gPiBtYWtlWzVdOiAqKiogWy92YXIvaG9tZS9h Y21lL2dpdC9wZXJmLXRvb2xzLW5leHQvdG9vbHMvYnVpbGQvTWFrZWZpbGUuYnVpbGQ6MTUwOiB1 dGlsXSBFcnJvciAyCj4gPiA+ID4gbWFrZVs0XTogKioqIFtNYWtlZmlsZS5wZXJmOjY2MjogL3Rt cC90bXAueWVFR3lRcTJIUi9wZXJmLWluLm9dIEVycm9yIDIKPiA+ID4gPiBtYWtlWzRdOiAqKiog V2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgo+ID4gPiA+ICAgQ0MgICAgICAvdG1wL3Rt cC55ZUVHeVFxMkhSL3BtdS1ldmVudHMvcG11LWV2ZW50cy5vCj4gPiA+ID4gICBMRCAgICAgIC90 bXAvdG1wLnllRUd5UXEySFIvcG11LWV2ZW50cy9wbXUtZXZlbnRzLWluLm8KPiA+ID4gPiBtYWtl WzNdOiAqKiogW01ha2VmaWxlLnBlcmY6MjM4OiBzdWItbWFrZV0gRXJyb3IgMgo+ID4gPiA+IG1h a2VbMl06ICoqKiBbTWFrZWZpbGU6NzA6IGFsbF0gRXJyb3IgMgo+ID4gPiA+IG1ha2VbMV06ICoq KiBbdGVzdHMvbWFrZTozMzc6IG1ha2Vfbm9fbGlidW53aW5kX09dIEVycm9yIDEKPiA+ID4gPiBt YWtlOiAqKiogW01ha2VmaWxlOjEwMzogYnVpbGQtdGVzdF0gRXJyb3IgMgo+ID4gPiA+IG1ha2U6 IExlYXZpbmcgZGlyZWN0b3J5ICcvdmFyL2hvbWUvYWNtZS9naXQvcGVyZi10b29scy1uZXh0L3Rv b2xzL3BlcmYnCj4gPiA+ID4gCj4gPiA+ID4gcmVhbAkxbTI5Ljc4NHMKPiA+ID4gPiB1c2VyCTEw bTQxLjU5N3MKPiA+ID4gPiBzeXMJMm01NS45NDhzCj4gPiA+ID4g4qyiW2FjbWVAdG9vbGJveCBw ZXJmLXRvb2xzLW5leHRdJAo+ID4gPiA+IAo+ID4gPiA+IEknbSB0cnlpbmcgdG8gZml4Cj4gPiA+ IAo+ID4gPiAtLSAKPiA+ID4gCj4gPiA+IC0gQXJuYWxkbwo+IAo+IC0tIAo+IAo+IC0gQXJuYWxk bwoKLS0gCgotIEFybmFsZG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5A40C001B0 for ; Wed, 16 Aug 2023 11:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bnx1ZpkavmfehEzJ1JnkACqWzZzP2cs3MDOdVPz5kSo=; b=osH22UXxXlvijR aH91pzmvXc7NelxCuisb6fAQzotkrIeWGXPrechMsN0S4CZtNIi3OJ+beI9tPCjt7Z804orbMbcc7 C45iTxECJZ4G56WjfWQm+L9TCmsDq0TsUT+Zvqmlvt7XHSPrjwxk7hiEUpk5xXDBthDtdu9znKf1m V44y8wRHE8tqItU1Ke1X1dxkaok4ZG0bYSPwypSNupXrK5VC+z7zDL7gHDxdlc0DXtglN1ZAEAEYZ cs2fuSAFzCX87RegqNAecTNYsvRvggvA8BZX+HFWdzMQpnuj91kgDgxiihvde8WLbnYbk0EVCJIDN Fb2zsbDCd27S3v4d4maA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWF11-0041ag-0t; Wed, 16 Aug 2023 11:48:43 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWF0z-0041aL-2p; Wed, 16 Aug 2023 11:48:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=mZdydCidZXFJb9y9DR3Oz92wcs8I7ilo2/AI5V/H+40=; b=S8ISDbCJ4aLNAFmgZzZsMQ70YI TpmZHX9vKbzZndVw/9wn0OiD1NXVCq3xDCT3WKfNlV6LpHpebT40p0zq2fINhXU0Pyo2OpwyMfo51 PJJMBVQ5nnO2u64j5MoIpWRPaqkZAFLeFXP3wErb59dP/YI6TA6jh40Efjrfo/niFL3jWq/pfp+6C 9bwLT1Iqf+v90N/q86z9PnhgM3UpBw8zPfFLyTbtKJZMKRc7oGI2X1DsTakNX1s/xUKBmLC/3l13s qCGg4hCmVF4MCRAyRp7PbzuiwgZbZON7qwKusKFCUzE5HD2h1k8Xzpgg+sDc6ngnNP+y7Tb/2w2v2 iaV+Q80Q==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qWF0w-00ET8d-4q; Wed, 16 Aug 2023 11:48:39 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 00D32404DF; Wed, 16 Aug 2023 08:48:30 -0300 (-03) Date: Wed, 16 Aug 2023 08:48:30 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> <20230816020715.GA135657@leoy-huanghe.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gV2VkLCBBdWcgMTYsIDIwMjMgYXQgMDg6NDY6MjNBTSAtMDMwMCwgQXJuYWxkbyBDYXJ2YWxo byBkZSBNZWxvIGVzY3JldmV1Ogo+IEVtIFdlZCwgQXVnIDE2LCAyMDIzIGF0IDEwOjA3OjE1QU0g KzA4MDAsIExlbyBZYW4gZXNjcmV2ZXU6Cj4gPiBPbiBUdWUsIEF1ZyAxNSwgMjAyMyBhdCAwMzo1 NzoxN1BNIC0wMzAwLCBBcm5hbGRvIENhcnZhbGhvIGRlIE1lbG8gd3JvdGU6Cj4gPiA+IEVtIFR1 ZSwgQXVnIDE1LCAyMDIzIGF0IDAzOjUyOjM4UE0gLTAzMDAsIEFybmFsZG8gQ2FydmFsaG8gZGUg TWVsbyBlc2NyZXZldToKPiA+ID4gPiBFbSBUdWUsIEF1ZyAxNSwgMjAyMyBhdCAwMzo0NToyN1BN IC0wMzAwLCBBcm5hbGRvIENhcnZhbGhvIGRlIE1lbG8gZXNjcmV2ZXU6Cj4gPiA+ID4gPiA+IEFn cmVlZCwgYXBwbGllZCB0byBwZXJmLXRvb2xzLW5leHQsIHNvcnJ5IGZvciB0aGUgZGVsYXkuCj4g PiA+ID4gPiAKPiA+ID4gPiA+IEhhZCB0byBhZGQgdGhpcyB0byBtYWtlICdwZXJmIHRlc3QgcHl0 aG9uJyB0byB3b3JrLiBQbGVhc2UgcnVuICdwZXJmCj4gPiA+ID4gPiB0ZXN0JyBiZWZvcmUgc2Vu ZGluZyBwYXRjaGVzLgo+ID4gPiA+IAo+ID4gPiA+IE9uZSBtb3JlLCBwbGVhc2UgYWxzbyBkbyBh ICdtYWtlIC1DIHRvb2xzL3BlcmYgYnVpbGQtdGVzdCcsIHdpdGggaXQgSQo+ID4gPiA+IGNhdWdo dCB0aGlzOgo+ID4gPiA+IAo+ID4gPiA+ICAgICAgICAgIG1ha2Vfbm9fbGlidW53aW5kX086IGNk IC4gJiYgbWFrZSBOT19MSUJVTldJTkQ9MSBGRUFUVVJFU19EVU1QPS92YXIvaG9tZS9hY21lL2dp dC9wZXJmLXRvb2xzLW5leHQvdG9vbHMvcGVyZi9CVUlMRF9URVNUX0ZFQVRVUkVfRFVNUCAtajMy IE89L3RtcC90bXAueWVFR3lRcTJIUiBERVNURElSPS90bXAvdG1wLklUZ29PMTZqakgKPiA+ID4g PiBjZCAuICYmIG1ha2UgTk9fTElCVU5XSU5EPTEgRkVBVFVSRVNfRFVNUD0vdmFyL2hvbWUvYWNt ZS9naXQvcGVyZi10b29scy1uZXh0L3Rvb2xzL3BlcmYvQlVJTERfVEVTVF9GRUFUVVJFX0RVTVAg LWozMiBPPS90bXAvdG1wLnllRUd5UXEySFIgREVTVERJUj0vdG1wL3RtcC5JVGdvTzE2ampICj4g PiA+IAo+ID4gPiArI2luY2x1ZGUgInV0aWwvZW52LmgiCj4gPiA+IAo+ID4gPiBBcyBub3cgd2Ug bmVlZCBpdCBmb3IgcGVyZl9lbnZfX2FyY2godWktPm1hY2hpbmUtPmVudikKPiA+IAo+ID4gU29y cnkgZm9yIGluY29udmVuaWVuY2UuCj4gPiAKPiA+IEkgc2F3IHRoaXMgcGF0Y2ggc2VyaWVzIGhh cyBiZWVuIHBpY2tlZCBpbnRvIHRoZSBicmFuY2g6Cj4gPiBodHRwczovL2dpdC5rZXJuZWwub3Jn L3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9hY21lL2xpbnV4LmdpdC9sb2cvP2g9dG1wLnBlcmYt dG9vbHMtbmV4dAo+ID4gCj4gPiBJZiB3YW50IG1lIHRvIGZvbGxvdyB1cCwgbGV0IG1lIGtub3cu ICBUaGFuayB5b3UhCj4gCj4gUmlnaHQsIEknbGwgZml4IHRoaXMgb25lczoKPiAKPiBbcGVyZmJ1 aWxkZXJAZml2ZSB+XSQgZ3JlcCAidW51c2VkIHZhcmlhYmxlIiBkbS5sb2cvKjoqCj4gZG0ubG9n L3VidW50dToxOC4wNC14LW02OGs6dXRpbC9ldnNlbC5jOjg0ODoxNDogZXJyb3I6IHVudXNlZCB2 YXJpYWJsZSAnYXJjaCcgWy1XZXJyb3I9dW51c2VkLXZhcmlhYmxlXQo+IGRtLmxvZy91YnVudHU6 MTguMDQteC1yaXNjdjY0OnV0aWwvZXZzZWwuYzo4NDg6MTQ6IGVycm9yOiB1bnVzZWQgdmFyaWFi bGUgJ2FyY2gnIFstV2Vycm9yPXVudXNlZC12YXJpYWJsZV0KPiBkbS5sb2cvdWJ1bnR1OjE4LjA0 LXgtc2g0OnV0aWwvZXZzZWwuYzo4NDg6MTQ6IGVycm9yOiB1bnVzZWQgdmFyaWFibGUgJ2FyY2gn IFstV2Vycm9yPXVudXNlZC12YXJpYWJsZV0KPiBkbS5sb2cvdWJ1bnR1OjE4LjA0LXgtc3BhcmM2 NDp1dGlsL2V2c2VsLmM6ODQ4OjE0OiBlcnJvcjogdW51c2VkIHZhcmlhYmxlICdhcmNoJyBbLVdl cnJvcj11bnVzZWQtdmFyaWFibGVdCj4gW3BlcmZidWlsZGVyQGZpdmUgfl0kCj4gCj4gQW5kIG1v dmUgdGhhdCB0byBwZXJmLXRvb2xzLW5leHQsIHdlIGNhbiBnbyBvbiBmcm9tIHRoZXJlLgo+IAo+ IFRoZSBhYm92ZSBpcyBiZWNhdXNlIHdlIGRvbid0IGRlZmluZSBDT05GSUdfUEVSRl9SRUdTIGZv ciB0aGVzZQo+IGFyY2hpdGVjdHVyZXMgYW5kIHRodXMgdGhhdCB2YXJpYWJsZSBlbmRzIHVwIG5v dCBiZWluZyB1c2VkLCBzbyBJJ20KPiBmaXhpbmcgdXAgbGlrZSBiZWxvdywgaW4gdGhlIGNzZXQg d2hlcmUgeW91IG1hZGUgRFdBUkZfTUlOSU1BTF9SRUdTCj4gcmVjZWl2ZSB0aGUgYXJjaCBwYXJh bWV0ZXIuCgpJIGFkZGVkIHRoaXMgdG8gdGhlIGNzZXQgY29tbWl0IG1lc3NhZ2U6CgpDb21taXR0 ZXIgbm90ZXM6CgpNYWtlIERXQVJGX01JTklNQUxfUkVHUygpIGFuIGlubGluZSBmdW5jdGlvbiwg c28gdGhhdCB3ZSBjYW4gdXNlIHRoZQpfX21heWJlX3VudXNlZCBhdHRyaWJ1dGUgZm9yIHRoZSAn YXJjaCcgcGFyYW1ldGVyLCBhcyB0aGlzIHdpbGwgYXZvaWQgYQpidWlsZCBmYWlsdXJlIHdoZW4g dGhhdCB2YXJpYWJsZSBpcyB1bnVzZWQgaW4gdGhlIGNhbGxlcnMuIFRoYXQgaGFwcGVucwp3aGVu IGJ1aWxkaW5nIG9uIHVuc3VwcG9ydGVkIGFyY2hpdGVjdHVyZXMsIHRoZSBvbmVzIHdpdGhvdXQK SEFWRV9QRVJGX1JFR1NfU1VQUE9SVCBkZWZpbmVkLgoKIAo+IEFsc28gSSBoYXZlbid0IGNoZWNr ZWQgaG93IGdyYWNlZnVsbHkgd2UgcmVhY3Qgd2hlbiBwcm9jZXNzaW5nIGEKPiBwZXJmLmRhdGEg Y29sbGVjdGVkIGluIG9uZSBvZiB0aG9zZSB1bnN1cHBvcnRlZCBhcmNoZXMsIGNhbiB5b3UgcGxl YXNlCj4gY2hlY2s/Cj4gCj4gLSBBcm5hbGRvCj4gCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3BlcmYv dXRpbC9wZXJmX3JlZ3MuaCBiL3Rvb2xzL3BlcmYvdXRpbC9wZXJmX3JlZ3MuaAo+IGluZGV4IDc5 MGMxYTI2YmJmZTliNGIuLmRlMTY3MzA1N2U1MDJkZTkgMTAwNjQ0Cj4gLS0tIGEvdG9vbHMvcGVy Zi91dGlsL3BlcmZfcmVncy5oCj4gKysrIGIvdG9vbHMvcGVyZi91dGlsL3BlcmZfcmVncy5oCj4g QEAgLTMyLDkgKzMyLDYgQEAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBzYW1wbGVfcmVnIHNhbXBsZV9y ZWdfbWFza3NbXTsKPiAgCj4gICNpbmNsdWRlIDxwZXJmX3JlZ3MuaD4KPiAgCj4gLSNkZWZpbmUg RFdBUkZfTUlOSU1BTF9SRUdTKGFyY2gpCVwKPiAtCSgoMVVMTCA8PCBwZXJmX2FyY2hfcmVnX2lw KGFyY2gpKSB8ICgxVUxMIDw8IHBlcmZfYXJjaF9yZWdfc3AoYXJjaCkpKQo+IC0KPiAgY29uc3Qg Y2hhciAqcGVyZl9yZWdfbmFtZShpbnQgaWQsIGNvbnN0IGNoYXIgKmFyY2gpOwo+ICBpbnQgcGVy Zl9yZWdfdmFsdWUodTY0ICp2YWxwLCBzdHJ1Y3QgcmVnc19kdW1wICpyZWdzLCBpbnQgaWQpOwo+ ICB1aW50NjRfdCBwZXJmX2FyY2hfcmVnX2lwKGNvbnN0IGNoYXIgKmFyY2gpOwo+IEBAIC02Nywx MSArNjQsMTkgQEAgY29uc3QgY2hhciAqX19wZXJmX3JlZ19uYW1lX3g4NihpbnQgaWQpOwo+ICB1 aW50NjRfdCBfX3BlcmZfcmVnX2lwX3g4Nih2b2lkKTsKPiAgdWludDY0X3QgX19wZXJmX3JlZ19z cF94ODYodm9pZCk7Cj4gIAo+ICtzdGF0aWMgaW5saW5lIHVpbnQ2NF90IERXQVJGX01JTklNQUxf UkVHUyhjb25zdCBjaGFyICphcmNoKQo+ICt7Cj4gKwlyZXR1cm4gKDFVTEwgPDwgcGVyZl9hcmNo X3JlZ19pcChhcmNoKSkgfCAoMVVMTCA8PCBwZXJmX2FyY2hfcmVnX3NwKGFyY2gpKTsKPiArfQo+ ICsKPiAgI2Vsc2UKPiAgI2RlZmluZSBQRVJGX1JFR1NfTUFTSwkwCj4gICNkZWZpbmUgUEVSRl9S RUdTX01BWAkwCj4gIAo+IC0jZGVmaW5lIERXQVJGX01JTklNQUxfUkVHUyhhcmNoKQlQRVJGX1JF R1NfTUFTSwo+ICtzdGF0aWMgaW5saW5lIHVpbnQ2NF90IERXQVJGX01JTklNQUxfUkVHUyhjb25z dCBjaGFyICphcmNoIF9fbWF5YmVfdW51c2VkKQo+ICt7Cj4gKwlyZXR1cm4gUEVSRl9SRUdTX01B U0s7Cj4gK30KPiAgCj4gIHN0YXRpYyBpbmxpbmUgY29uc3QgY2hhciAqcGVyZl9yZWdfbmFtZShp bnQgaWQgX19tYXliZV91bnVzZWQsIGNvbnN0IGNoYXIgKmFyY2ggX19tYXliZV91bnVzZWQpCj4g IHsKPiAgCj4gPiA+ID4gICBDQyAgICAgIC90bXAvdG1wLnllRUd5UXEySFIvdXRpbC9leHByLWZs ZXgubwo+ID4gPiA+IHV0aWwvdW53aW5kLWxpYmR3LmM6IEluIGZ1bmN0aW9uIOKAmG1lbW9yeV9y ZWFk4oCZOgo+ID4gPiA+IHV0aWwvdW53aW5kLWxpYmR3LmM6MTczOjI4OiBlcnJvcjogaW1wbGlj aXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYcGVyZl9lbnZfX2FyY2jigJkgWy1XZXJyb3I9 aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gPiA+ID4gICAxNzMgfCAgICAgICAgIGNv bnN0IGNoYXIgKmFyY2ggPSBwZXJmX2Vudl9fYXJjaCh1aS0+bWFjaGluZS0+ZW52KTsKPiA+ID4g PiAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+Cj4gPiA+ ID4gdXRpbC91bndpbmQtbGliZHcuYzoxNzM6Mjg6IGVycm9yOiBpbml0aWFsaXphdGlvbiBvZiDi gJhjb25zdCBjaGFyICrigJkgZnJvbSDigJhpbnTigJkgbWFrZXMgcG9pbnRlciBmcm9tIGludGVn ZXIgd2l0aG91dCBhIGNhc3QgWy1XZXJyb3I9aW50LWNvbnZlcnNpb25dCj4gPiA+ID4gdXRpbC91 bndpbmQtbGliZHcuYzogSW4gZnVuY3Rpb24g4oCYdW53aW5kX19nZXRfZW50cmllc+KAmToKPiA+ ID4gPiB1dGlsL3Vud2luZC1saWJkdy5jOjI1ODoyODogZXJyb3I6IGluaXRpYWxpemF0aW9uIG9m IOKAmGNvbnN0IGNoYXIgKuKAmSBmcm9tIOKAmGludOKAmSBtYWtlcyBwb2ludGVyIGZyb20gaW50 ZWdlciB3aXRob3V0IGEgY2FzdCBbLVdlcnJvcj1pbnQtY29udmVyc2lvbl0KPiA+ID4gPiAgIDI1 OCB8ICAgICAgICAgY29uc3QgY2hhciAqYXJjaCA9IHBlcmZfZW52X19hcmNoKHVpX2J1Zi5tYWNo aW5lLT5lbnYpOwo+ID4gPiA+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+ fn5+fn5+fn5+fn4KPiA+ID4gPiBjYzE6IGFsbCB3YXJuaW5ncyBiZWluZyB0cmVhdGVkIGFzIGVy cm9ycwo+ID4gPiA+IG1ha2VbNl06ICoqKiBbL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYtdG9vbHMt bmV4dC90b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDo5ODogL3RtcC90bXAueWVFR3lRcTJIUi91 dGlsL3Vud2luZC1saWJkdy5vXSBFcnJvciAxCj4gPiA+ID4gbWFrZVs2XTogKioqIFdhaXRpbmcg Zm9yIHVuZmluaXNoZWQgam9icy4uLi4KPiA+ID4gPiBtYWtlWzVdOiAqKiogWy92YXIvaG9tZS9h Y21lL2dpdC9wZXJmLXRvb2xzLW5leHQvdG9vbHMvYnVpbGQvTWFrZWZpbGUuYnVpbGQ6MTUwOiB1 dGlsXSBFcnJvciAyCj4gPiA+ID4gbWFrZVs0XTogKioqIFtNYWtlZmlsZS5wZXJmOjY2MjogL3Rt cC90bXAueWVFR3lRcTJIUi9wZXJmLWluLm9dIEVycm9yIDIKPiA+ID4gPiBtYWtlWzRdOiAqKiog V2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgo+ID4gPiA+ICAgQ0MgICAgICAvdG1wL3Rt cC55ZUVHeVFxMkhSL3BtdS1ldmVudHMvcG11LWV2ZW50cy5vCj4gPiA+ID4gICBMRCAgICAgIC90 bXAvdG1wLnllRUd5UXEySFIvcG11LWV2ZW50cy9wbXUtZXZlbnRzLWluLm8KPiA+ID4gPiBtYWtl WzNdOiAqKiogW01ha2VmaWxlLnBlcmY6MjM4OiBzdWItbWFrZV0gRXJyb3IgMgo+ID4gPiA+IG1h a2VbMl06ICoqKiBbTWFrZWZpbGU6NzA6IGFsbF0gRXJyb3IgMgo+ID4gPiA+IG1ha2VbMV06ICoq KiBbdGVzdHMvbWFrZTozMzc6IG1ha2Vfbm9fbGlidW53aW5kX09dIEVycm9yIDEKPiA+ID4gPiBt YWtlOiAqKiogW01ha2VmaWxlOjEwMzogYnVpbGQtdGVzdF0gRXJyb3IgMgo+ID4gPiA+IG1ha2U6 IExlYXZpbmcgZGlyZWN0b3J5ICcvdmFyL2hvbWUvYWNtZS9naXQvcGVyZi10b29scy1uZXh0L3Rv b2xzL3BlcmYnCj4gPiA+ID4gCj4gPiA+ID4gcmVhbAkxbTI5Ljc4NHMKPiA+ID4gPiB1c2VyCTEw bTQxLjU5N3MKPiA+ID4gPiBzeXMJMm01NS45NDhzCj4gPiA+ID4g4qyiW2FjbWVAdG9vbGJveCBw ZXJmLXRvb2xzLW5leHRdJAo+ID4gPiA+IAo+ID4gPiA+IEknbSB0cnlpbmcgdG8gZml4Cj4gPiA+ IAo+ID4gPiAtLSAKPiA+ID4gCj4gPiA+IC0gQXJuYWxkbwo+IAo+IC0tIAo+IAo+IC0gQXJuYWxk bwoKLS0gCgotIEFybmFsZG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK