From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A1EFC001E0 for ; Wed, 16 Aug 2023 16:12:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233983AbjHPQL4 (ORCPT ); Wed, 16 Aug 2023 12:11:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234312AbjHPQLZ (ORCPT ); Wed, 16 Aug 2023 12:11:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5FC4E2; Wed, 16 Aug 2023 09:11:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A95264A17; Wed, 16 Aug 2023 16:11:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88A8FC433C7; Wed, 16 Aug 2023 16:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692202283; bh=l0J8yDMBc74nmT7gwZGggcXqRVTFJWQG2J54M7XA4UI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BPp0q5QqydyqEXh/RKGyCfuudu+haCSzEXo8u/ua6uYq8RgUjltDdIFycod4kJCTz wY3Ml5pwlnFsI9dJgfIhOnzXzK2u6NbP1XZBby9cLzY/IJYiwylv8aJYaPTz0x7F2/ YFn+D40+ZYw7aP0iMym2qVoBRyQ5raJUMDztW96kPHz/58DnMl4Pqn0BJkJ58zXhTm 95D2m3ysSi2K+YNtDpffRR66V2DflNFOXqC668ykO5yNWSFZ2XM2EQ7+9cr0shykPk GDA15EOwoKnlG7FhLiUEbK5L0y5Of4I6PgYkcQI0h5XDrCX1Zw6fjBHci1NjcRxcpu M03bniOi6LiXw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E6BD6404DF; Wed, 16 Aug 2023 13:11:20 -0300 (-03) Date: Wed, 16 Aug 2023 13:11:20 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-perf-users@vger.kernel.org, irogers@google.com, john.g.garry@oracle.com, renyu.zj@linux.alibaba.com, Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Haixin Yu , Nick Forrington , Kajol Jain , Eduard Zingerman , Sohom Datta , Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 2/6] perf test: Add a test for the new Arm CPU ID comparison behavior Message-ID: References: <20230816114841.1679234-1-james.clark@arm.com> <20230816114841.1679234-3-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230816114841.1679234-3-james.clark@arm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, Aug 16, 2023 at 12:47:44PM +0100, James Clark escreveu: > +++ b/tools/perf/arch/arm64/tests/cpuid-match.c > @@ -0,0 +1,38 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include > + > +#include "arch-tests.h" > +#include "tests/tests.h" > +#include "util/header.h" > + > +int test__cpuid_match(struct test_suite *test __maybe_unused, > + int subtest __maybe_unused) > +{ > + /* midr with no leading zeros matches */ > + if (strcmp_cpuid_str("0x410fd0c0", "0x00000000410fd0c0")) > + return -1; > + /* Upper case matches */ > + if (strcmp_cpuid_str("0x410fd0c0", "0x00000000410FD0C0")) > + return -1; > + /* r0p0 = r0p0 matches */ > + if (strcmp_cpuid_str("0x00000000410fd480", "0x00000000410fd480")) > + return -1; > + /* r0p1 > r0p0 matches */ > + if (strcmp_cpuid_str("0x00000000410fd480", "0x00000000410fd481")) > + return -1; > + /* r1p0 > r0p0 matches*/ > + if (strcmp_cpuid_str("0x00000000410fd480", "0x00000000411fd480")) > + return -1; > + /* r0p0 < r0p1 doesn't match */ > + if (!strcmp_cpuid_str("0x00000000410fd481", "0x00000000410fd480")) > + return -1; > + /* r0p0 < r1p0 doesn't match */ > + if (!strcmp_cpuid_str("0x00000000411fd480", "0x00000000410fd480")) > + return -1; > + /* Different CPU doesn't match */ > + if (!strcmp_cpuid_str("0x00000000410fd4c0", "0x00000000430f0af0")) > + return -1; > + > + return 0; > +} > + > -- > 2.34.1 > ⬢[acme@toolbox perf-tools-next]$ git am ./v6_20230816_james_clark_perf_vendor_events_arm64_update_n2_and_v2_metrics_and_events_using_arm_telem.mbx Applying: perf test: Add a test for the new Arm CPU ID comparison behavior .git/rebase-apply/patch:93: new blank line at EOF. + warning: 1 line adds whitespace errors. ⬢[acme@toolbox perf-tools-next]$ I'm removing it From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F0C1C001E0 for ; Wed, 16 Aug 2023 16:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Och5untvqvyb+GuNffFSCTgI3pdNw+Jm8L+wXZSZsw8=; b=vRnE04jOu17QPJ kp4NXYorH1wZsA5ja7nyKWGz1h+/V2sT8N4rDx+ehyrT2GG9WcIgJoUZ1zbNZU0yvxcH5kOwkTDd2 LPi7QVnnju29U8JqFgtBrnoYQfofzY9900cFfMvgx3x2rzhx/+qnt1idCTnHXcyHF69YhLrcKji/O uSIAfDv8SwBioMEMI/VbAV1UkM9FvxwUW/Qa/dNxEeEndbZ35OVW7ehm/sZV09FUa9IUSfm+Nu5df +8NpUFXTndICz6llyHsOZC2Tf0piqIqdy8KChH+t+jpTkhv15v/54c+9MCdmjfYLNTckf9Fa3Paxn 4EPt7qftjIL+KXSnsIJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWJ7G-004a0L-30; Wed, 16 Aug 2023 16:11:26 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWJ7F-004a02-0l for linux-arm-kernel@bombadil.infradead.org; Wed, 16 Aug 2023 16:11:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=n840wiZm9Jtnxsg9MlJYtYvdfLJG9glGHna+dgI7Kkk=; b=dSiBh97+kE+rpPmiFQm96FHcyd YelYnzY+Lkf+jn7IaChDh6lsam4FKrFu5mTBthtSogKdAHbxk1Q+t3dBFq9VF0o77cogTg/u0GYp2 XGDmd2nprmf62J/3ikF942iwpoIninXyTVTzxwnJaK7EFLoISOAZQeNrhkQhGKs63uTOWcGilAaXh NO7b0SPwKXflyOmYajlsOGJqQAFVOJp+60HNL+u9T5lXOuqtIHxkEVeRm9/8U9eMsQF02reKij8i/ v85g9OBwFfbk8grNKigJlbdIjYxt0JIROC9/w2eMkj+nTuhz4aq3qLMDgIXEx5hpuHzu+9zFLqc11 fcPrSSgw==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qWJ7D-00FbKV-C0; Wed, 16 Aug 2023 16:11:23 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E6BD6404DF; Wed, 16 Aug 2023 13:11:20 -0300 (-03) Date: Wed, 16 Aug 2023 13:11:20 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-perf-users@vger.kernel.org, irogers@google.com, john.g.garry@oracle.com, renyu.zj@linux.alibaba.com, Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Haixin Yu , Nick Forrington , Kajol Jain , Eduard Zingerman , Sohom Datta , Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 2/6] perf test: Add a test for the new Arm CPU ID comparison behavior Message-ID: References: <20230816114841.1679234-1-james.clark@arm.com> <20230816114841.1679234-3-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230816114841.1679234-3-james.clark@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gV2VkLCBBdWcgMTYsIDIwMjMgYXQgMTI6NDc6NDRQTSArMDEwMCwgSmFtZXMgQ2xhcmsgZXNj cmV2ZXU6Cj4gKysrIGIvdG9vbHMvcGVyZi9hcmNoL2FybTY0L3Rlc3RzL2NwdWlkLW1hdGNoLmMK PiBAQCAtMCwwICsxLDM4IEBACj4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4w Cj4gKyNpbmNsdWRlIDxsaW51eC9jb21waWxlci5oPgo+ICsKPiArI2luY2x1ZGUgImFyY2gtdGVz dHMuaCIKPiArI2luY2x1ZGUgInRlc3RzL3Rlc3RzLmgiCj4gKyNpbmNsdWRlICJ1dGlsL2hlYWRl ci5oIgo+ICsKPiAraW50IHRlc3RfX2NwdWlkX21hdGNoKHN0cnVjdCB0ZXN0X3N1aXRlICp0ZXN0 IF9fbWF5YmVfdW51c2VkLAo+ICsJCQkgICAgIGludCBzdWJ0ZXN0IF9fbWF5YmVfdW51c2VkKQo+ ICt7Cj4gKwkvKiBtaWRyIHdpdGggbm8gbGVhZGluZyB6ZXJvcyBtYXRjaGVzICovCj4gKwlpZiAo c3RyY21wX2NwdWlkX3N0cigiMHg0MTBmZDBjMCIsICIweDAwMDAwMDAwNDEwZmQwYzAiKSkKPiAr CQlyZXR1cm4gLTE7Cj4gKwkvKiBVcHBlciBjYXNlIG1hdGNoZXMgKi8KPiArCWlmIChzdHJjbXBf Y3B1aWRfc3RyKCIweDQxMGZkMGMwIiwgIjB4MDAwMDAwMDA0MTBGRDBDMCIpKQo+ICsJCXJldHVy biAtMTsKPiArCS8qIHIwcDAgPSByMHAwIG1hdGNoZXMgKi8KPiArCWlmIChzdHJjbXBfY3B1aWRf c3RyKCIweDAwMDAwMDAwNDEwZmQ0ODAiLCAiMHgwMDAwMDAwMDQxMGZkNDgwIikpCj4gKwkJcmV0 dXJuIC0xOwo+ICsJLyogcjBwMSA+IHIwcDAgbWF0Y2hlcyAqLwo+ICsJaWYgKHN0cmNtcF9jcHVp ZF9zdHIoIjB4MDAwMDAwMDA0MTBmZDQ4MCIsICIweDAwMDAwMDAwNDEwZmQ0ODEiKSkKPiArCQly ZXR1cm4gLTE7Cj4gKwkvKiByMXAwID4gcjBwMCBtYXRjaGVzKi8KPiArCWlmIChzdHJjbXBfY3B1 aWRfc3RyKCIweDAwMDAwMDAwNDEwZmQ0ODAiLCAiMHgwMDAwMDAwMDQxMWZkNDgwIikpCj4gKwkJ cmV0dXJuIC0xOwo+ICsJLyogcjBwMCA8IHIwcDEgZG9lc24ndCBtYXRjaCAqLwo+ICsJaWYgKCFz dHJjbXBfY3B1aWRfc3RyKCIweDAwMDAwMDAwNDEwZmQ0ODEiLCAiMHgwMDAwMDAwMDQxMGZkNDgw IikpCj4gKwkJcmV0dXJuIC0xOwo+ICsJLyogcjBwMCA8IHIxcDAgZG9lc24ndCBtYXRjaCAqLwo+ ICsJaWYgKCFzdHJjbXBfY3B1aWRfc3RyKCIweDAwMDAwMDAwNDExZmQ0ODAiLCAiMHgwMDAwMDAw MDQxMGZkNDgwIikpCj4gKwkJcmV0dXJuIC0xOwo+ICsJLyogRGlmZmVyZW50IENQVSBkb2Vzbid0 IG1hdGNoICovCj4gKwlpZiAoIXN0cmNtcF9jcHVpZF9zdHIoIjB4MDAwMDAwMDA0MTBmZDRjMCIs ICIweDAwMDAwMDAwNDMwZjBhZjAiKSkKPiArCQlyZXR1cm4gLTE7Cj4gKwo+ICsJcmV0dXJuIDA7 Cj4gK30KPiArCj4gLS0gCj4gMi4zNC4xCj4gCuKsolthY21lQHRvb2xib3ggcGVyZi10b29scy1u ZXh0XSQgICAgICAgIGdpdCBhbSAuL3Y2XzIwMjMwODE2X2phbWVzX2NsYXJrX3BlcmZfdmVuZG9y X2V2ZW50c19hcm02NF91cGRhdGVfbjJfYW5kX3YyX21ldHJpY3NfYW5kX2V2ZW50c191c2luZ19h cm1fdGVsZW0ubWJ4CkFwcGx5aW5nOiBwZXJmIHRlc3Q6IEFkZCBhIHRlc3QgZm9yIHRoZSBuZXcg QXJtIENQVSBJRCBjb21wYXJpc29uIGJlaGF2aW9yCi5naXQvcmViYXNlLWFwcGx5L3BhdGNoOjkz OiBuZXcgYmxhbmsgbGluZSBhdCBFT0YuCisKd2FybmluZzogMSBsaW5lIGFkZHMgd2hpdGVzcGFj ZSBlcnJvcnMuCuKsolthY21lQHRvb2xib3ggcGVyZi10b29scy1uZXh0XSQKCkknbSByZW1vdmlu ZyBpdAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=