From: Wolfram Sang <wsa@kernel.org>
To: Wentong Wu <wentong.wu@intel.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de, mka@chromium.org,
oneukum@suse.com, lee@kernel.org, kfting@nuvoton.com,
broonie@kernel.org, linus.walleij@linaro.org, maz@kernel.org,
brgl@bgdev.pl, linux-usb@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
linux-gpio@vger.kernel.org, andriy.shevchenko@linux.intel.com,
heikki.krogerus@linux.intel.com, andi.shyti@linux.intel.com,
sakari.ailus@linux.intel.com, bartosz.golaszewski@linaro.org,
srinivas.pandruvada@intel.com, zhifeng.wang@intel.com
Subject: Re: [PATCH v11 2/4] i2c: Add support for Intel LJCA USB I2C driver
Date: Wed, 30 Aug 2023 21:12:57 +0200 [thread overview]
Message-ID: <ZO+UucQM++smFBpR@shikoro> (raw)
In-Reply-To: <1693284848-29269-3-git-send-email-wentong.wu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On Tue, Aug 29, 2023 at 12:54:06PM +0800, Wentong Wu wrote:
> Implements the I2C function of Intel USB-I2C/GPIO/SPI adapter device
> named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA I2C
> module with specific protocol through interfaces exported by LJCA
> USB driver.
>
> Signed-off-by: Wentong Wu <wentong.wu@intel.com>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Basically good...
> + if (ret < 0 || ret < sizeof(*r_packet)) {
> + dev_err(&ljca_i2c->adap.dev,
> + "i2c stop failed ret: %d id: %d\n",
> + ret, w_packet->id);
This was forgotten to be turned into dev_dbg. I could fix it while
applying. But shall I take this patch via i2c? Or shall all the patches
go via some other tree? I'd assume the dependencies are hidden away by
auxiliary_bus but I am not 100% sure.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-31 0:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 4:54 [PATCH v11 0/4] Add Intel LJCA device driver Wentong Wu
2023-08-29 4:54 ` [PATCH v11 1/4] usb: Add support for Intel LJCA device Wentong Wu
2023-08-31 11:16 ` Oliver Neukum
2023-08-31 12:39 ` Wu, Wentong
2023-08-29 4:54 ` [PATCH v11 2/4] i2c: Add support for Intel LJCA USB I2C driver Wentong Wu
2023-08-30 19:12 ` Wolfram Sang [this message]
2023-08-30 20:08 ` Wu, Wentong
2023-08-29 4:54 ` [PATCH v11 3/4] spi: Add support for Intel LJCA USB SPI driver Wentong Wu
2023-08-29 4:54 ` [PATCH v11 4/4] gpio: update Intel LJCA USB GPIO driver Wentong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO+UucQM++smFBpR@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfting@nuvoton.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mka@chromium.org \
--cc=oneukum@suse.com \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@intel.com \
--cc=wentong.wu@intel.com \
--cc=zhifeng.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.