All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Add epoll_wait05 test
Date: Tue, 29 Aug 2023 09:25:51 +0200	[thread overview]
Message-ID: <ZO2dfwOM0pK8xz1j@rei> (raw)
In-Reply-To: <20230823130904.26051-1-andrea.cervesato@suse.de>

Hi!
> This test verifies that epoll receives EPOLLRDHUP event when we hang
> a reading half-socket we are polling on.
> 
> Implements: https://github.com/linux-test-project/ltp/issues/860
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>

...

> +/*\
> + * [Description]
> + *
> + * Verify that epoll receives EPOLLRDHUP event when we hang a reading
> + * half-socket we are polling on.
> + *
> + * As reference please check https://lwn.net/Articles/864947/

I'm a bit confused here, the test itself looks good, but it references
an article and a kernel commit that changed how polling on _pipe_ works.
The kernel change literally changes only pipe_write() in fs/pipe.c and
this test actually tests inet sockets.

I guess that the confusion is caused by the fact that the github issue
referenced the lwn.net article as a reason why we need more epoll
coverage, but these tests are not directly related to that commit at
all.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-08-29  7:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 13:09 [LTP] [PATCH v4] Add epoll_wait05 test Andrea Cervesato
2023-08-29  7:25 ` Cyril Hrubis [this message]
2023-08-29  7:52   ` Andrea Cervesato via ltp
2023-08-29 10:07     ` Cyril Hrubis
2023-08-29 10:41     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZO2dfwOM0pK8xz1j@rei \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.