All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yury Norov <yury.norov@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v4 8/8] bitmap: move bitmap_*_region() functions to bitmap.h
Date: Tue, 29 Aug 2023 03:07:07 -0700	[thread overview]
Message-ID: <ZO3DS4OrKeN78qLU@yury-ThinkPad> (raw)
In-Reply-To: <20230829023911.64335-9-yury.norov@gmail.com>

> +/**
> + * bitmap_release_region - release allocated bitmap region
> + *	@bitmap: array of unsigned longs corresponding to the bitmap
> + *	@pos: beginning of bit region to release
> + *	@order: region size (log base 2 of number of bits) to release
> + *
> + * This is the complement to __bitmap_find_free_region() and releases
> + * the found region (by clearing it in the bitmap).
> + */
> +static inline void bitmap_release_region(unsigned long *bitmap, unsigned int pos, int order)
> +{
> +	bitmap_clear(bitmap, pos, pos + BIT(order));
> +}

This is a leftover after wrong rebase from previous buggy version. It
should be:

        bitmap_clear(bitmap, pos, BIT(order));

Please igonre the patch, I'll resend it shourtly.

Sorry for noise.

      reply	other threads:[~2023-08-29 10:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  2:39 [PATCH v4 0/8] bitmap: cleanup bitmap_*_region() implementation Yury Norov
2023-08-29  2:39 ` [PATCH v4 1/8] bitmap: align __reg_op() wrappers with modern coding style Yury Norov
2023-08-29 15:26   ` Andy Shevchenko
2023-08-29  2:39 ` [PATCH v4 2/8] bitmap: add test for bitmap_*_region() functions Yury Norov
2023-08-29 15:29   ` Andy Shevchenko
2023-08-29  2:39 ` [PATCH v4 3/8] bitmap: fix opencoded bitmap_allocate_region() Yury Norov
2023-08-29 15:30   ` Andy Shevchenko
2023-08-29  2:39 ` [PATCH v4 4/8] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set() Yury Norov
2023-08-29  2:39 ` [PATCH v4 5/8] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear() Yury Norov
2023-08-29 15:32   ` Andy Shevchenko
2023-08-29  2:39 ` [PATCH v4 6/8] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit() Yury Norov
2023-08-29  2:39 ` [PATCH v4 7/8] bitmap: drop _reg_op() function Yury Norov
2023-08-29  2:39 ` [PATCH v4 8/8] bitmap: move bitmap_*_region() functions to bitmap.h Yury Norov
2023-08-29 10:07   ` Yury Norov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZO3DS4OrKeN78qLU@yury-ThinkPad \
    --to=yury.norov@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.