All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: hongmianquan <hongmianquan@bytedance.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, david@redhat.com,
	philmd@linaro.org
Subject: Re: [RESEND] memory: avoid updating ioeventfds for some address_space
Date: Tue, 29 Aug 2023 11:22:12 -0400	[thread overview]
Message-ID: <ZO4NJKDsIGYWQz5j@x1n> (raw)
In-Reply-To: <20230829022354.94149-1-hongmianquan@bytedance.com>

Hongmianquan,

On Tue, Aug 29, 2023 at 10:23:54AM +0800, hongmianquan wrote:
> When updating ioeventfds, we need to iterate all address spaces,
> but some address spaces do not register eventfd_add|del call when
> memory_listener_register() and they do nothing when updating ioeventfds.
> So we can skip these AS in address_space_update_ioeventfds().
> 
> The overhead of memory_region_transaction_commit() can be significantly
> reduced. For example, a VM with 8 vhost net devices and each one has
> 64 vectors, can reduce the time spent on memory_region_transaction_commit by 20%.
> 
> Signed-off-by: hongmianquan <hongmianquan@bytedance.com>

Please feel free to take my R-b with the patch if the patch didn't change.

Thanks,

-- 
Peter Xu



      reply	other threads:[~2023-08-29 15:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  2:23 [RESEND] memory: avoid updating ioeventfds for some address_space hongmianquan
2023-08-29 15:22 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZO4NJKDsIGYWQz5j@x1n \
    --to=peterx@redhat.com \
    --cc=david@redhat.com \
    --cc=hongmianquan@bytedance.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.