All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Zhipeng Wang <zhipeng.wang_1@nxp.com>
Cc: rafael@kernel.org, viresh.kumar@linaro.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] cpufreq: dt-platdev: Support building cpufreq platdev driver as module
Date: Tue, 29 Aug 2023 20:00:45 +0200	[thread overview]
Message-ID: <ZO4yTQAV9EYA4erZ@aurel32.net> (raw)
In-Reply-To: <20230524153417.2738448-2-zhipeng.wang_1@nxp.com>

Hi,

On 2023-05-24 15:34, Zhipeng Wang wrote:
> Make the cpufreq platdev driver as tristate so that it can be built
> as loadable module.
> 
> Signed-off-by: Zhipeng Wang <zhipeng.wang_1@nxp.com>
> ---
>  drivers/cpufreq/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2c839bd2b051..dda3a78bfd5c 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -218,7 +218,7 @@ config CPUFREQ_DT
>  	  If in doubt, say N.
>  
>  config CPUFREQ_DT_PLATDEV
> -	bool
> +	tristate "Generic DT based cpufreq platdev driver"
>  	help
>  	  This adds a generic DT based cpufreq platdev driver for frequency
>  	  management.  This creates a 'cpufreq-dt' platform device, on the

It seems that this new module is missing support for autoloading,
causing issues with CPUFREQ_DT=m.

Before that change, CPUFREQ_DT_PLATDEV ended up selected as =y. Now,
CPUFREQ_DT_PLATDEV ends up selected as =m. As it is not autoloaded, it
means that cpufreq-dt is not working anymore unless manually running
"modprobe cpufreq-dt-platdev".

Could you therefore please add support for autoloading?

Thanks,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

  reply	other threads:[~2023-08-29 18:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 15:34 [PATCH 1/2] cpufreq: dt-platdev: Add MODULE_LICENSE Zhipeng Wang
2023-05-24 10:45 ` Viresh Kumar
2023-05-24 11:32   ` [EXT] " Zhipeng Wang
2023-05-24 15:34 ` [PATCH 2/2] cpufreq: dt-platdev: Support building cpufreq platdev driver as module Zhipeng Wang
2023-08-29 18:00   ` Aurelien Jarno [this message]
2023-08-30  3:09     ` [EXT] " Zhipeng Wang
2023-08-30  5:08       ` Aurelien Jarno
2023-08-31 10:50         ` Viresh Kumar
2023-06-02  4:12 ` [PATCH 1/2] cpufreq: dt-platdev: Add MODULE_LICENSE Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZO4yTQAV9EYA4erZ@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=zhipeng.wang_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.