Re: [rmk-arm:vcpu-rmk 31/33] acpi_processor.c:undefined reference to `arch_unregister_cpu'

["Russell King (Oracle)" <linux@armlinux.org.uk>]

Hi,

I don't think this is a "new" issue as such, I think it's just that
the error context has changed.

Looking at the blamed commit, it's merely moving the call to
arch_unregister_cpu() from inside acpi_processor_get_info() to a new
function acpi_processor_make_enabled(), which now calls
arch_unregister_cpu() from two locations. Hence, I suppose it's one
more error that wasn't there before, but there was always one reference
to arch_unregister_cpu() that would've caused the reported error.

So, I don't think any action is required due to the changes that James'
patches make - riscv is no more broken before the patch than it is
after.

Thanks anyway.

On Wed, Aug 30, 2023 at 05:02:05AM +0800, kernel test robot wrote:
> tree:   git://git.armlinux.org.uk/~rmk/linux-arm vcpu-rmk
> head:   b74a4ba60fbf9e3f5fbcca347176c214dee19a68
> commit: 2cffbed2eaeecbf929d5c36313f2f90de5db8702 [31/33] ACPI: add support to register CPUs based on the _STA enabled bit
> config: riscv-defconfig (https://download.01.org/0day-ci/archive/20230830/202308300439.Cdlb0WA9-lkp@intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230830/202308300439.Cdlb0WA9-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308300439.Cdlb0WA9-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    riscv64-linux-ld: drivers/acpi/acpi_processor.o: in function `.L38':
>    acpi_processor.c:(.text+0x1a8): undefined reference to `arch_register_cpu'
>    riscv64-linux-ld: drivers/acpi/acpi_processor.o: in function `.L0 ':
>    acpi_processor.c:(.text+0x560): undefined reference to `arch_register_cpu'
>    riscv64-linux-ld: drivers/acpi/acpi_processor.o: in function `acpi_processor_post_eject':
> >> acpi_processor.c:(.text+0x95c): undefined reference to `arch_unregister_cpu'
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!