From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21E0EE4996 for ; Mon, 21 Aug 2023 14:42:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236095AbjHUOmT (ORCPT ); Mon, 21 Aug 2023 10:42:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236096AbjHUOmR (ORCPT ); Mon, 21 Aug 2023 10:42:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13086F0; Mon, 21 Aug 2023 07:42:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 655D563A5F; Mon, 21 Aug 2023 14:42:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF976C433C7; Mon, 21 Aug 2023 14:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692628932; bh=52OKjdLnV3pWDyoccRcefrV4SrypcfY1Bxxz8eiiXcw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=key8/FoxfX/Cfe3tNBW4IoMMuBqGOTSFlcN9Mplhx1Ln1eR3+jgv+0n+9YvOHaQk1 n60IZ+xZod07cPxz58E21zZ2Ra0rTd5R9Jv926H7aNUI79R6F288GGkTJZxW3WdLVx oGp2hEF8xeCkWcQDWR3JA5Mj4NGGCkNDuwB7bqSJY4tBhpPKMc7BB44Gw5stcqvx4m UuI26qmvFHSPwRixC44a6v15jHrhLf2Ldc5kI9qUQvAuImnRDkh6mBPQC/3VC/fPDT kBgVUmaq78SYChr+hrauXEYzYjgmM3f7lVFBkTbHVYnihVM66UVyruGOWQ2qZNmTi1 NSRvSGFomGvAw== Date: Mon, 21 Aug 2023 16:42:05 +0200 From: Lorenzo Pieralisi To: Jim Quinlan , robh@kernel.org Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Conor Dooley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" Subject: Re: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Message-ID: References: <20230623144100.34196-1-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Aug 21, 2023 at 08:15:02AM -0400, Jim Quinlan wrote: > On Mon, Aug 21, 2023 at 4:35 AM Lorenzo Pieralisi wrote: > > > > On Fri, Jun 23, 2023 at 10:40:53AM -0400, Jim Quinlan wrote: > > > v6 -- No code has been changed. > > > -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril) > > > -- Changed sign-off and author email address for all commits. > > > This was due to a change in Broadcom's upstreaming policy. > > > > > > v5 -- Remove DT property "brcm,completion-timeout-us" from > > > "DT bindings" commit. Although this error may be reported > > > as a completion timeout, its cause was traced to an > > > internal bus timeout which may occur even when there is > > > no PCIe access being processed. We set a timeout of four > > > seconds only if we are operating in "L1SS CLKREQ#" mode. > > > -- Correct CEM 2.0 reference provided by HW engineer, > > > s/3.2.5.2.5/3.2.5.2.2/ (Bjorn) > > > -- Add newline to dev_info() string (Stefan) > > > -- Change variable rval to unsigned (Stefan) > > > -- s/implementaion/implementation/ (Bjorn) > > > -- s/superpowersave/powersupersave/ (Bjorn) > > > -- Slightly modify message on "PERST#" commit. > > > -- Rebase to torvalds master > > > > > > v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC > > > driver probe() time. This is done in Raspian Linux and its > > > absence may be the cause of a failing test case. > > > -- New commit that removes stale comment. > > > > > > v3 -- Rewrote commit msgs and comments refering panics if L1SS > > > is enabled/disabled; the code snippet that unadvertises L1SS > > > eliminates the panic scenario. (Bjorn) > > > -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn) > > > -- Put binding names in DT commit Subject (Bjorn) > > > -- Add a verb to a commit's subject line (Bjorn) > > > -- s/accomodat(\w+)/accommodat$1/g (Bjorn) > > > -- Rewrote commit msgs and comments refering panics if L1SS > > > is enabled/disabled; the code snippet that unadvertises L1SS > > > eliminates the panic scenario. (Bjorn) > > > > > > v2 -- Changed binding property 'brcm,completion-timeout-msec' to > > > 'brcm,completion-timeout-us'. (StefanW for standard suffix). > > > -- Warn when clamping timeout value, and include clamped > > > region in message. Also add min and max in YAML. (StefanW) > > > -- Qualify description of "brcm,completion-timeout-us" so that > > > it refers to PCIe transactions. (StefanW) > > > -- Remvove mention of Linux specifics in binding description. (StefanW) > > > -- s/clkreq#/CLKREQ#/g (Bjorn) > > > -- Refactor completion-timeout-us code to compare max and min to > > > value given by the property (as opposed to the computed value). > > > > > > v1 -- The current driver assumes the downstream devices can > > > provide CLKREQ# for ASPM. These commits accomodate devices > > > w/ or w/o clkreq# and also handle L1SS-capable devices. > > > > > > -- The Raspian Linux folks have already been using a PCIe RC > > > property "brcm,enable-l1ss". These commits use the same > > > property, in a backward-compatible manner, and the implementaion > > > adds more detail and also automatically identifies devices w/o > > > a clkreq# signal, i.e. most devices plugged into an RPi CM4 > > > IO board. > > > > > > > > > Jim Quinlan (5): > > > dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property > > > PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream > > > device > > > > I am not merging the first two patches since the discussion thread > > is still open and I'd like to understand better what can/should be > > done, sorry. > > Hello Lorenzo, > > This patch-set has been stable for months, V5 was out early May and > the V6 changes > did not involve code. I'm a little surprised that you are voicing > concern at this stage. > > The previous discussions covered all aspects of these commits AFAICT. > Please review > them and the commit messages and let me know what issues you do not understand > or any topics that were not considered. I disagree with the reasoning behind "brcm,enable-l1ss" property usage instead of a command line option - at least I would like to get a comment from DT maintainers about it. I think Bjorn made the point consistently and I also think he is right. I would like to get Rob's opinion on this. I know he acked the DT bindings (I have a comment on those too) but regardless, it is clearly a property used for what is a command line configuration parameter, no two ways about it. Thanks, Lorenzo > > Are you concerned about the Broadcom STB/CM community or the RPi community? > For the former, I have direct communication w/ our customers and none of them > are even close to using upstream (they may backport my commits). For > the latter, I have > tested these commits on the official RPi4 and CM4 IO platforms, and > Cyril has also put in > an admiral amount of testing. > > Note that I have on my desk a CM4 IO board w/ a conventional PCIe > device, and it does not boot > upstream master Linux until these patches are applied. > > Further, Raspian OS has already introduced the "brcm,enable-l1ss" > property but did not upstream it, and > my commits are backwards compatible with this. > > > > > > PCI: brcmstb: Set higher value for internal bus timeout > > > PCI: brcmstb: Assert PERST# on BCM2711 > > > PCI: brcmstb: Remove stale comment > > > > Is it OK to apply these three on their own ? Overall it would be > > great to avoid mixing patches with different end goals in a single > > series. > > Well, they are related for one customer who wants to use L1SS power > savings AND require > a long period for the internal timeout. But, yes, these commits are > fine to apply > independently. > > Regards, > Jim Quinlan > Broadcom STB > > > > > Thanks, > > Lorenzo > > > > > .../bindings/pci/brcm,stb-pcie.yaml | 9 ++ > > > drivers/pci/controller/pcie-brcmstb.c | 91 ++++++++++++++++--- > > > 2 files changed, 89 insertions(+), 11 deletions(-) > > > > > > > > > base-commit: 8a28a0b6f1a1dcbf5a834600a9acfbe2ba51e5eb > > > -- > > > 2.17.1 > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE3F4EE4996 for ; Mon, 21 Aug 2023 14:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dUpa/MzKxIHd0IVF3VwlYRtHHkAP6iasK578q25MFTQ=; b=MfcF1PRSP0xrsk JLpSXo4PcPEym8VQ67OHQeNPXMPO9h/yyJN/2T44OCjmiwDUtBxnEXiQLNJR62I1Tar3893KpWwbx eLCyZzv+j3EITAh6UrJzuxTsvadDQnHRCTwRaGczn+HRjK/w6z2MV+HWyG3Ao1TBV+hJHqukmWVOW owA1fX6D5192RIiihs1pTvWTfGD+cEnk0QALD0XDYMNo+6h4cMLv+UJNpdi53B7pGGNX0kMI8h5Qj uVr8Vc0XAb08+MOrAoCmi/7dk3oWHmPa3B7FkoAQqp8OqrYovtI5FHAk87L5cUmwhZ3WvN9VQuwQ4 hWH5b/P131dXrSG4GuFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY66j-00ECSF-0l; Mon, 21 Aug 2023 14:42:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qY66g-00ECQY-0A; Mon, 21 Aug 2023 14:42:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C65F63A60; Mon, 21 Aug 2023 14:42:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF976C433C7; Mon, 21 Aug 2023 14:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692628932; bh=52OKjdLnV3pWDyoccRcefrV4SrypcfY1Bxxz8eiiXcw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=key8/FoxfX/Cfe3tNBW4IoMMuBqGOTSFlcN9Mplhx1Ln1eR3+jgv+0n+9YvOHaQk1 n60IZ+xZod07cPxz58E21zZ2Ra0rTd5R9Jv926H7aNUI79R6F288GGkTJZxW3WdLVx oGp2hEF8xeCkWcQDWR3JA5Mj4NGGCkNDuwB7bqSJY4tBhpPKMc7BB44Gw5stcqvx4m UuI26qmvFHSPwRixC44a6v15jHrhLf2Ldc5kI9qUQvAuImnRDkh6mBPQC/3VC/fPDT kBgVUmaq78SYChr+hrauXEYzYjgmM3f7lVFBkTbHVYnihVM66UVyruGOWQ2qZNmTi1 NSRvSGFomGvAw== Date: Mon, 21 Aug 2023 16:42:05 +0200 From: Lorenzo Pieralisi To: Jim Quinlan , robh@kernel.org Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Conor Dooley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" Subject: Re: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Message-ID: References: <20230623144100.34196-1-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_074214_176484_733D7925 X-CRM114-Status: GOOD ( 48.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMjEsIDIwMjMgYXQgMDg6MTU6MDJBTSAtMDQwMCwgSmltIFF1aW5sYW4gd3Jv dGU6Cj4gT24gTW9uLCBBdWcgMjEsIDIwMjMgYXQgNDozNeKAr0FNIExvcmVuem8gUGllcmFsaXNp IDxscGllcmFsaXNpQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSwgSnVuIDIzLCAy MDIzIGF0IDEwOjQwOjUzQU0gLTA0MDAsIEppbSBRdWlubGFuIHdyb3RlOgo+ID4gPiB2NiAtLSBO byBjb2RlIGhhcyBiZWVuIGNoYW5nZWQuCj4gPiA+ICAgIC0tIENoYW5nZWQgY29tbWl0IHN1Ympl Y3QgYW5kIGNvbW1lbnQgaW4gIiNQRVJTVCIgY29tbWl0IChCam9ybiwgQ3lyaWwpCj4gPiA+ICAg IC0tIENoYW5nZWQgc2lnbi1vZmYgYW5kIGF1dGhvciBlbWFpbCBhZGRyZXNzIGZvciBhbGwgY29t bWl0cy4KPiA+ID4gICAgICAgVGhpcyB3YXMgZHVlIHRvIGEgY2hhbmdlIGluIEJyb2FkY29tJ3Mg dXBzdHJlYW1pbmcgcG9saWN5Lgo+ID4gPgo+ID4gPiB2NSAtLSBSZW1vdmUgRFQgcHJvcGVydHkg ImJyY20sY29tcGxldGlvbi10aW1lb3V0LXVzIiBmcm9tCj4gPiA+ICAgICAgICJEVCBiaW5kaW5n cyIgY29tbWl0LiAgQWx0aG91Z2ggdGhpcyBlcnJvciBtYXkgYmUgcmVwb3J0ZWQKPiA+ID4gICAg ICAgYXMgYSBjb21wbGV0aW9uIHRpbWVvdXQsIGl0cyBjYXVzZSB3YXMgdHJhY2VkIHRvIGFuCj4g PiA+ICAgICAgIGludGVybmFsIGJ1cyB0aW1lb3V0IHdoaWNoIG1heSBvY2N1ciBldmVuIHdoZW4g dGhlcmUgaXMKPiA+ID4gICAgICAgbm8gUENJZSBhY2Nlc3MgYmVpbmcgcHJvY2Vzc2VkLiAgV2Ug c2V0IGEgdGltZW91dCBvZiBmb3VyCj4gPiA+ICAgICAgIHNlY29uZHMgb25seSBpZiB3ZSBhcmUg b3BlcmF0aW5nIGluICJMMVNTIENMS1JFUSMiIG1vZGUuCj4gPiA+ICAgIC0tIENvcnJlY3QgQ0VN IDIuMCByZWZlcmVuY2UgcHJvdmlkZWQgYnkgSFcgZW5naW5lZXIsCj4gPiA+ICAgICAgIHMvMy4y LjUuMi41LzMuMi41LjIuMi8gKEJqb3JuKQo+ID4gPiAgICAtLSBBZGQgbmV3bGluZSB0byBkZXZf aW5mbygpIHN0cmluZyAoU3RlZmFuKQo+ID4gPiAgICAtLSBDaGFuZ2UgdmFyaWFibGUgcnZhbCB0 byB1bnNpZ25lZCAoU3RlZmFuKQo+ID4gPiAgICAtLSBzL2ltcGxlbWVudGFpb24vaW1wbGVtZW50 YXRpb24vIChCam9ybikKPiA+ID4gICAgLS0gcy9zdXBlcnBvd2Vyc2F2ZS9wb3dlcnN1cGVyc2F2 ZS8gKEJqb3JuKQo+ID4gPiAgICAtLSBTbGlnaHRseSBtb2RpZnkgbWVzc2FnZSBvbiAiUEVSU1Qj IiBjb21taXQuCj4gPiA+ICAgIC0tIFJlYmFzZSB0byB0b3J2YWxkcyBtYXN0ZXIKPiA+ID4KPiA+ ID4gdjQgLS0gTmV3IGNvbW1pdCB0aGF0IGFzc2VydHMgUEVSU1QjIGZvciAyNzExL1JQaSBTT0Nz IGF0IFBDSWUgUkMKPiA+ID4gICAgICAgZHJpdmVyIHByb2JlKCkgdGltZS4gIFRoaXMgaXMgZG9u ZSBpbiBSYXNwaWFuIExpbnV4IGFuZCBpdHMKPiA+ID4gICAgICAgYWJzZW5jZSBtYXkgYmUgdGhl IGNhdXNlIG9mIGEgZmFpbGluZyB0ZXN0IGNhc2UuCj4gPiA+ICAgIC0tIE5ldyBjb21taXQgdGhh dCByZW1vdmVzIHN0YWxlIGNvbW1lbnQuCj4gPiA+Cj4gPiA+IHYzIC0tIFJld3JvdGUgY29tbWl0 IG1zZ3MgYW5kIGNvbW1lbnRzIHJlZmVyaW5nIHBhbmljcyBpZiBMMVNTCj4gPiA+ICAgICAgIGlz IGVuYWJsZWQvZGlzYWJsZWQ7IHRoZSBjb2RlIHNuaXBwZXQgdGhhdCB1bmFkdmVydGlzZXMgTDFT Uwo+ID4gPiAgICAgICBlbGltaW5hdGVzIHRoZSBwYW5pYyBzY2VuYXJpby4gKEJqb3JuKQo+ID4g PiAgICAtLSBBZGQgcmVmZXJlbmNlIGZvciAiNDAwbnMgb2YgQ0xLUkVRIyBhc3NlcnRpb24iIGJs dXJiIChCam9ybikKPiA+ID4gICAgLS0gUHV0IGJpbmRpbmcgbmFtZXMgaW4gRFQgY29tbWl0IFN1 YmplY3QgKEJqb3JuKQo+ID4gPiAgICAtLSBBZGQgYSB2ZXJiIHRvIGEgY29tbWl0J3Mgc3ViamVj dCBsaW5lIChCam9ybikKPiA+ID4gICAgLS0gcy9hY2NvbW9kYXQoXHcrKS9hY2NvbW1vZGF0JDEv ZyAoQmpvcm4pCj4gPiA+ICAgIC0tIFJld3JvdGUgY29tbWl0IG1zZ3MgYW5kIGNvbW1lbnRzIHJl ZmVyaW5nIHBhbmljcyBpZiBMMVNTCj4gPiA+ICAgICAgIGlzIGVuYWJsZWQvZGlzYWJsZWQ7IHRo ZSBjb2RlIHNuaXBwZXQgdGhhdCB1bmFkdmVydGlzZXMgTDFTUwo+ID4gPiAgICAgICBlbGltaW5h dGVzIHRoZSBwYW5pYyBzY2VuYXJpby4gKEJqb3JuKQo+ID4gPgo+ID4gPiB2MiAtLSBDaGFuZ2Vk IGJpbmRpbmcgcHJvcGVydHkgJ2JyY20sY29tcGxldGlvbi10aW1lb3V0LW1zZWMnIHRvCj4gPiA+ ICAgICAgICdicmNtLGNvbXBsZXRpb24tdGltZW91dC11cycuICAoU3RlZmFuVyBmb3Igc3RhbmRh cmQgc3VmZml4KS4KPiA+ID4gICAgLS0gV2FybiB3aGVuIGNsYW1waW5nIHRpbWVvdXQgdmFsdWUs IGFuZCBpbmNsdWRlIGNsYW1wZWQKPiA+ID4gICAgICAgcmVnaW9uIGluIG1lc3NhZ2UuIEFsc28g YWRkIG1pbiBhbmQgbWF4IGluIFlBTUwuIChTdGVmYW5XKQo+ID4gPiAgICAtLSBRdWFsaWZ5IGRl c2NyaXB0aW9uIG9mICJicmNtLGNvbXBsZXRpb24tdGltZW91dC11cyIgc28gdGhhdAo+ID4gPiAg ICAgICBpdCByZWZlcnMgdG8gUENJZSB0cmFuc2FjdGlvbnMuIChTdGVmYW5XKQo+ID4gPiAgICAt LSBSZW12b3ZlIG1lbnRpb24gb2YgTGludXggc3BlY2lmaWNzIGluIGJpbmRpbmcgZGVzY3JpcHRp b24uIChTdGVmYW5XKQo+ID4gPiAgICAtLSBzL2Nsa3JlcSMvQ0xLUkVRIy9nIChCam9ybikKPiA+ ID4gICAgLS0gUmVmYWN0b3IgY29tcGxldGlvbi10aW1lb3V0LXVzIGNvZGUgdG8gY29tcGFyZSBt YXggYW5kIG1pbiB0bwo+ID4gPiAgICAgICB2YWx1ZSBnaXZlbiBieSB0aGUgcHJvcGVydHkgKGFz IG9wcG9zZWQgdG8gdGhlIGNvbXB1dGVkIHZhbHVlKS4KPiA+ID4KPiA+ID4gdjEgLS0gVGhlIGN1 cnJlbnQgZHJpdmVyIGFzc3VtZXMgdGhlIGRvd25zdHJlYW0gZGV2aWNlcyBjYW4KPiA+ID4gICAg ICAgcHJvdmlkZSBDTEtSRVEjIGZvciBBU1BNLiAgVGhlc2UgY29tbWl0cyBhY2NvbW9kYXRlIGRl dmljZXMKPiA+ID4gICAgICAgdy8gb3Igdy9vIGNsa3JlcSMgYW5kIGFsc28gaGFuZGxlIEwxU1Mt Y2FwYWJsZSBkZXZpY2VzLgo+ID4gPgo+ID4gPiAgICAtLSBUaGUgUmFzcGlhbiBMaW51eCBmb2xr cyBoYXZlIGFscmVhZHkgYmVlbiB1c2luZyBhIFBDSWUgUkMKPiA+ID4gICAgICAgcHJvcGVydHkg ImJyY20sZW5hYmxlLWwxc3MiLiAgVGhlc2UgY29tbWl0cyB1c2UgdGhlIHNhbWUKPiA+ID4gICAg ICAgcHJvcGVydHksIGluIGEgYmFja3dhcmQtY29tcGF0aWJsZSBtYW5uZXIsIGFuZCB0aGUgaW1w bGVtZW50YWlvbgo+ID4gPiAgICAgICBhZGRzIG1vcmUgZGV0YWlsIGFuZCBhbHNvIGF1dG9tYXRp Y2FsbHkgaWRlbnRpZmllcyBkZXZpY2VzIHcvbwo+ID4gPiAgICAgICBhIGNsa3JlcSMgc2lnbmFs LCBpLmUuIG1vc3QgZGV2aWNlcyBwbHVnZ2VkIGludG8gYW4gUlBpIENNNAo+ID4gPiAgICAgICBJ TyBib2FyZC4KPiA+ID4KPiA+ID4KPiA+ID4gSmltIFF1aW5sYW4gKDUpOgo+ID4gPiAgIGR0LWJp bmRpbmdzOiBQQ0k6IGJyY21zdGI6IEFkZCBicmNtLGVuYWJsZS1sMXNzIHByb3BlcnR5Cj4gPiA+ ICAgUENJOiBicmNtc3RiOiBDb25maWd1cmUgSFcgQ0xLUkVRIyBtb2RlIGFwcHJvcHJpYXRlIGZv ciBkb3duc3RyZWFtCj4gPiA+ICAgICBkZXZpY2UKPiA+Cj4gPiBJIGFtIG5vdCBtZXJnaW5nIHRo ZSBmaXJzdCB0d28gcGF0Y2hlcyBzaW5jZSB0aGUgZGlzY3Vzc2lvbiB0aHJlYWQKPiA+IGlzIHN0 aWxsIG9wZW4gYW5kIEknZCBsaWtlIHRvIHVuZGVyc3RhbmQgYmV0dGVyIHdoYXQgY2FuL3Nob3Vs ZCBiZQo+ID4gZG9uZSwgc29ycnkuCj4gCj4gSGVsbG8gTG9yZW56bywKPiAKPiBUaGlzIHBhdGNo LXNldCBoYXMgYmVlbiBzdGFibGUgZm9yIG1vbnRocywgVjUgd2FzIG91dCBlYXJseSBNYXkgYW5k Cj4gdGhlIFY2IGNoYW5nZXMKPiBkaWQgbm90IGludm9sdmUgY29kZS4gIEknbSBhIGxpdHRsZSBz dXJwcmlzZWQgdGhhdCB5b3UgYXJlIHZvaWNpbmcKPiBjb25jZXJuIGF0IHRoaXMgc3RhZ2UuCj4g Cj4gVGhlIHByZXZpb3VzIGRpc2N1c3Npb25zIGNvdmVyZWQgYWxsIGFzcGVjdHMgb2YgdGhlc2Ug Y29tbWl0cyBBRkFJQ1QuCj4gUGxlYXNlICByZXZpZXcKPiB0aGVtIGFuZCB0aGUgY29tbWl0IG1l c3NhZ2VzIGFuZCBsZXQgbWUga25vdyB3aGF0IGlzc3VlcyB5b3UgZG8gbm90IHVuZGVyc3RhbmQK PiBvciBhbnkgdG9waWNzIHRoYXQgd2VyZSBub3QgY29uc2lkZXJlZC4KCkkgZGlzYWdyZWUgd2l0 aCB0aGUgcmVhc29uaW5nIGJlaGluZCAiYnJjbSxlbmFibGUtbDFzcyIgcHJvcGVydHkgdXNhZ2UK aW5zdGVhZCBvZiBhIGNvbW1hbmQgbGluZSBvcHRpb24gLSBhdCBsZWFzdCBJIHdvdWxkIGxpa2Ug dG8gZ2V0IGEKY29tbWVudCBmcm9tIERUIG1haW50YWluZXJzIGFib3V0IGl0LgoKSSB0aGluayBC am9ybiBtYWRlIHRoZSBwb2ludCBjb25zaXN0ZW50bHkgYW5kIEkgYWxzbyB0aGluayBoZSBpcyBy aWdodC4KCkkgd291bGQgbGlrZSB0byBnZXQgUm9iJ3Mgb3BpbmlvbiBvbiB0aGlzLiBJIGtub3cg aGUgYWNrZWQgdGhlIERUCmJpbmRpbmdzIChJIGhhdmUgYSBjb21tZW50IG9uIHRob3NlIHRvbykg YnV0IHJlZ2FyZGxlc3MsIGl0IGlzIGNsZWFybHkgYQpwcm9wZXJ0eSB1c2VkIGZvciB3aGF0IGlz IGEgY29tbWFuZCBsaW5lIGNvbmZpZ3VyYXRpb24gcGFyYW1ldGVyLApubyB0d28gd2F5cyBhYm91 dCBpdC4KClRoYW5rcywKTG9yZW56bwoKPiAKPiBBcmUgeW91IGNvbmNlcm5lZCBhYm91dCB0aGUg QnJvYWRjb20gU1RCL0NNIGNvbW11bml0eSAgb3IgdGhlIFJQaSBjb21tdW5pdHk/Cj4gRm9yIHRo ZSBmb3JtZXIsIEkgaGF2ZSBkaXJlY3QgY29tbXVuaWNhdGlvbiB3LyBvdXIgY3VzdG9tZXJzIGFu ZCBub25lIG9mIHRoZW0KPiBhcmUgZXZlbiBjbG9zZSB0byB1c2luZyB1cHN0cmVhbSAodGhleSBt YXkgYmFja3BvcnQgbXkgY29tbWl0cykuICBGb3IKPiB0aGUgbGF0dGVyLCBJIGhhdmUKPiB0ZXN0 ZWQgdGhlc2UgY29tbWl0cyBvbiB0aGUgb2ZmaWNpYWwgUlBpNCBhbmQgQ000IElPIHBsYXRmb3Jt cywgYW5kCj4gQ3lyaWwgaGFzIGFsc28gcHV0IGluCj4gYW4gYWRtaXJhbCBhbW91bnQgb2YgdGVz dGluZy4KPiAKPiBOb3RlIHRoYXQgSSBoYXZlIG9uIG15IGRlc2sgYSBDTTQgSU8gYm9hcmQgdy8g YSBjb252ZW50aW9uYWwgUENJZQo+IGRldmljZSwgYW5kIGl0IGRvZXMgbm90IGJvb3QKPiB1cHN0 cmVhbSBtYXN0ZXIgTGludXggdW50aWwgdGhlc2UgcGF0Y2hlcyBhcmUgYXBwbGllZC4KPiAKPiBG dXJ0aGVyLCBSYXNwaWFuIE9TIGhhcyBhbHJlYWR5IGludHJvZHVjZWQgdGhlICJicmNtLGVuYWJs ZS1sMXNzIgo+IHByb3BlcnR5IGJ1dCBkaWQgbm90IHVwc3RyZWFtIGl0LCBhbmQKPiBteSBjb21t aXRzIGFyZSBiYWNrd2FyZHMgY29tcGF0aWJsZSB3aXRoIHRoaXMuCj4gCj4gPgo+ID4gPiAgIFBD STogYnJjbXN0YjogU2V0IGhpZ2hlciB2YWx1ZSBmb3IgaW50ZXJuYWwgYnVzIHRpbWVvdXQKPiA+ ID4gICBQQ0k6IGJyY21zdGI6IEFzc2VydCBQRVJTVCMgb24gQkNNMjcxMQo+ID4gPiAgIFBDSTog YnJjbXN0YjogUmVtb3ZlIHN0YWxlIGNvbW1lbnQKPiA+Cj4gPiBJcyBpdCBPSyB0byBhcHBseSB0 aGVzZSB0aHJlZSBvbiB0aGVpciBvd24gPyBPdmVyYWxsIGl0IHdvdWxkIGJlCj4gPiBncmVhdCB0 byBhdm9pZCBtaXhpbmcgcGF0Y2hlcyB3aXRoIGRpZmZlcmVudCBlbmQgZ29hbHMgaW4gYSBzaW5n bGUKPiA+IHNlcmllcy4KPiAKPiBXZWxsLCB0aGV5IGFyZSByZWxhdGVkIGZvciBvbmUgY3VzdG9t ZXIgd2hvIHdhbnRzIHRvIHVzZSBMMVNTIHBvd2VyCj4gc2F2aW5ncyBBTkQgcmVxdWlyZQo+IGEg bG9uZyAgcGVyaW9kIGZvciB0aGUgaW50ZXJuYWwgdGltZW91dC4gIEJ1dCwgeWVzLCB0aGVzZSBj b21taXRzIGFyZQo+IGZpbmUgIHRvIGFwcGx5Cj4gaW5kZXBlbmRlbnRseS4KPiAKPiBSZWdhcmRz LAo+IEppbSBRdWlubGFuCj4gQnJvYWRjb20gU1RCCj4gCj4gPgo+ID4gVGhhbmtzLAo+ID4gTG9y ZW56bwo+ID4KPiA+ID4gIC4uLi9iaW5kaW5ncy9wY2kvYnJjbSxzdGItcGNpZS55YW1sICAgICAg ICAgICB8ICA5ICsrCj4gPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtYnJjbXN0Yi5j ICAgICAgICAgfCA5MSArKysrKysrKysrKysrKysrLS0tCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQs IDg5IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPgo+ID4gPiBiYXNl LWNvbW1pdDogOGEyOGEwYjZmMWExZGNiZjVhODM0NjAwYTlhY2ZiZTJiYTUxZTVlYgo+ID4gPiAt LQo+ID4gPiAyLjE3LjEKPiA+ID4KPiA+Cj4gPgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==