From: Ido Schimmel <idosch@idosch.org>
To: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 1/3] ipv4: ignore dst hint for multipath routes
Date: Mon, 21 Aug 2023 14:39:24 +0300 [thread overview]
Message-ID: <ZONM7BkQPuPGaYz0@shredder> (raw)
In-Reply-To: <20230819114825.30867-2-sriram.yagnaraman@est.tech>
On Sat, Aug 19, 2023 at 01:48:23PM +0200, Sriram Yagnaraman wrote:
> Route hints when the next hop is part of a multipath group causes
> packets in the same receive batch to the same next hop irrespective of
Looks like you are missing a word here. "causes packets in the same
receive batch to the same next hop" ?
> multipath hash of the packet. So, do not extract route hint for packets
> whose destination is part of multipath group.
The commit message should also explain how this is done.
>
> Fixes: 02b24941619f ("ipv4: use dst hint for ipv4 list receive")
>
No blank line between the fixes tag and the SoB.
In addition, patch prefix should be "PATCH net". See:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Same comments for the IPv6 patch.
Thanks
> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
next prev parent reply other threads:[~2023-08-21 11:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 11:48 [PATCH 0/3] Avoid TCP resets when using ECMP for load-balancing between multiple servers Sriram Yagnaraman
2023-08-19 11:48 ` Sriram Yagnaraman
2023-08-19 11:48 ` [PATCH 1/3] ipv4: ignore dst hint for multipath routes Sriram Yagnaraman
2023-08-19 11:48 ` Sriram Yagnaraman
2023-08-21 11:39 ` Ido Schimmel [this message]
2023-08-19 11:48 ` [PATCH 2/3] ipv6: " Sriram Yagnaraman
2023-08-19 11:48 ` Sriram Yagnaraman
2023-08-19 11:48 ` [PATCH 3/3] selftests: forwarding: Add test for load-balancing between multiple servers Sriram Yagnaraman
2023-08-19 11:48 ` Sriram Yagnaraman
2023-08-21 11:34 ` Ido Schimmel
2023-08-21 19:36 ` Sriram Yagnaraman
2023-08-22 18:57 ` Ido Schimmel
2023-08-23 12:55 ` Sriram Yagnaraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZONM7BkQPuPGaYz0@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=sriram.yagnaraman@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.