From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D48E8C7113B for ; Thu, 24 Aug 2023 07:33:37 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E73F2844; Thu, 24 Aug 2023 09:32:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E73F2844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692862416; bh=FixGPDbY1JGUzoXJGnGCpBH8LX7vfPyc85NTwmVIvZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=c6pPuvo02JEb5emBcSS1WpCAFBWgYbPxL2+L+b04ef8F1kMRvYTPkRNDrki5+BmWn mvNePtXKxAUdY58widgXUjEI8Vs5BUhb6nQMB37+1IS1RVhOwBM3CXpRkULRMu9e9I LY1N1VjopksmIuq+gG7gw7GAZcuYQG/NGI/GWok4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D895F80158; Thu, 24 Aug 2023 09:32:17 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A3487F80074; Thu, 24 Aug 2023 09:32:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 27CE1F80199; Mon, 21 Aug 2023 14:27:55 +0200 (CEST) Received: from mail.8bytes.org (mail.8bytes.org [IPv6:2a01:238:42d9:3f00:e505:6202:4f0c:f051]) by alsa1.perex.cz (Postfix) with ESMTP id C485BF800F8 for ; Mon, 21 Aug 2023 14:27:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C485BF800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=8bytes.org header.i=@8bytes.org header.a=rsa-sha256 header.s=default header.b=1GNfM2qX Received: from 8bytes.org (pd9fe95be.dip0.t-ipconnect.de [217.254.149.190]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 14D6D28194F; Mon, 21 Aug 2023 14:27:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1692620870; bh=FixGPDbY1JGUzoXJGnGCpBH8LX7vfPyc85NTwmVIvZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1GNfM2qXUHu69LlGLcBH8KY7o7o7XmY+SCrGkW/UUIs2KGTpDHXZZbMpPGz6QSYZs UPnFUxDcsVEY3pjS1DruthDw9f83ySojUQCSB+rWg+GUD0/AhHwU/y7CvGp4ChZNfv PF0U1t4Yrw0S3cKVt3Z1VBJMi6C4Yubn+JBgQ0h8akaCgHt2/SoukE6zqp52PyQtal mSBFlaAtIaUSfX6biqD/5UJPh1qGAUoCalqefQ1b2bqiPcVjHwugqG0e+YrG5Eef+K UDBnBPokoAbTS28F+RA/gZgu4I/tGuWG+hC4PlSSGwOqv9iwEYEE1WLsVZflD78r+Z CJt+ubMPFXzmw== Date: Mon, 21 Aug 2023 14:27:47 +0200 From: Joerg Roedel To: Robin Murphy Cc: Jason Gunthorpe , Andy Gross , David Airlie , alsa-devel@alsa-project.org, Bjorn Andersson , Andrzej Hajda , ath10k@lists.infradead.org, ath11k@lists.infradead.org, Mark Brown , Bryan O'Donoghue , Christian Gmeiner , Daniel Vetter , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Emma Anholt , etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org, Frank Rowand , iommu@lists.linux.dev, Jernej Skrabec , Konrad Dybcio , Kalle Valo , Lucas Stach , Liam Girdwood , Russell King , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-wireless@vger.kernel.org, Marijn Suijten , Mauro Carvalho Chehab , Mikko Perttunen , Maxime Ripard , Sinan Kaya , Jaroslav Kysela , Abhinav Kumar , Jeff Johnson , Vikash Garodia , Rob Clark , Rob Herring , Samuel Holland , Sean Paul , Stanimir Varbanov , Thierry Reding , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , Will Deacon , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Lu Baolu , Joerg Roedel , Kevin Tian , Marek Szyprowski , Chen-Yu Tsai Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> X-MailFrom: joro@8bytes.org X-Mailman-Rule-Hits: max-recipients X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: SPFGSTYL5VZXI7DBARBXROSW5CKRXJTE X-Message-ID-Hash: SPFGSTYL5VZXI7DBARBXROSW5CKRXJTE X-Mailman-Approved-At: Thu, 24 Aug 2023 07:29:53 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > The solution is to drop those locking patches entirely and rethink the whole > thing. Agreed, that was exactly what I thought when looking at this patch. I dropped the original 10 patches and the 4 fixes on-top from the IOMMU tree. This needs more investigation and adaption of the actual API users before it can be reconsidered. Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B865EE4996 for ; Mon, 21 Aug 2023 12:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n/d3iEzjklfOIbVJo8MZg+rv6dpz8Gb0h+5pJqcMAus=; b=mmoSqZoyU0bxIN w9EbdhprvKYmjdYwvEQHCHYtD0WiupfxjAEhpPUwn0ABb5NifF8ZYGX+YLbBqKDBC5pjRJItZvs4b dhKUWN+/22a1gcIZdYvobiZHbbaDdEay6pGbu5Cwmj3X8BXQE3Vb4qAOXZ00W7H8QEXH99W12heLJ pT3rdnY4pSKR14F1mkQ526stOZV5zUiRvJDlKytJpnL1aT2N6lqPYCG/WqmfW+LO46tskoTNyj9CE ubg8HZJiGgviN33mbb13Tgts5VWupDYXdz439kI2WN6XrR34s8AgpU3Ex3BEvreYqSzTe6n81Rwiw 2L0HJxzcyd+sUgj5arkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY40j-00DyTH-1U; Mon, 21 Aug 2023 12:27:57 +0000 Received: from mail.8bytes.org ([85.214.250.239]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY40g-00DyS5-1i; Mon, 21 Aug 2023 12:27:55 +0000 Received: from 8bytes.org (pd9fe95be.dip0.t-ipconnect.de [217.254.149.190]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 14D6D28194F; Mon, 21 Aug 2023 14:27:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1692620870; bh=FixGPDbY1JGUzoXJGnGCpBH8LX7vfPyc85NTwmVIvZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1GNfM2qXUHu69LlGLcBH8KY7o7o7XmY+SCrGkW/UUIs2KGTpDHXZZbMpPGz6QSYZs UPnFUxDcsVEY3pjS1DruthDw9f83ySojUQCSB+rWg+GUD0/AhHwU/y7CvGp4ChZNfv PF0U1t4Yrw0S3cKVt3Z1VBJMi6C4Yubn+JBgQ0h8akaCgHt2/SoukE6zqp52PyQtal mSBFlaAtIaUSfX6biqD/5UJPh1qGAUoCalqefQ1b2bqiPcVjHwugqG0e+YrG5Eef+K UDBnBPokoAbTS28F+RA/gZgu4I/tGuWG+hC4PlSSGwOqv9iwEYEE1WLsVZflD78r+Z CJt+ubMPFXzmw== Date: Mon, 21 Aug 2023 14:27:47 +0200 From: Joerg Roedel To: Robin Murphy Cc: Jason Gunthorpe , Andy Gross , David Airlie , alsa-devel@alsa-project.org, Bjorn Andersson , Andrzej Hajda , ath10k@lists.infradead.org, ath11k@lists.infradead.org, Mark Brown , Bryan O'Donoghue , Christian Gmeiner , Daniel Vetter , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Emma Anholt , etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org, Frank Rowand , iommu@lists.linux.dev, Jernej Skrabec , Konrad Dybcio , Kalle Valo , Lucas Stach , Liam Girdwood , Russell King , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-wireless@vger.kernel.org, Marijn Suijten , Mauro Carvalho Chehab , Mikko Perttunen , Maxime Ripard , Sinan Kaya , Jaroslav Kysela , Abhinav Kumar , Jeff Johnson , Vikash Garodia , Rob Clark , Rob Herring , Samuel Holland , Sean Paul , Stanimir Varbanov , Thierry Reding , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , Will Deacon , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Lu Baolu , Joerg Roedel , Kevin Tian , Marek Szyprowski , Chen-Yu Tsai Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_052754_737837_CAF3C49F X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > The solution is to drop those locking patches entirely and rethink the whole > thing. Agreed, that was exactly what I thought when looking at this patch. I dropped the original 10 patches and the 4 fixes on-top from the IOMMU tree. This needs more investigation and adaption of the actual API users before it can be reconsidered. Regards, Joerg _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBC7CEE4996 for ; Mon, 21 Aug 2023 12:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DY37/lUrOMrVXMRN+ZbcwPBaybHH5Ti4ySC+h7s97XQ=; b=bIQprtcL9J4Pq/ 6oJZKWJKr2cBKYNcFf3/eRNtgoCOcshPGMJ4hBjQJVyDSvHpYt757cS1ew3tcrWe2QsPXl8kA5FEI A03FNplmqjs4POW1MmwKLa2m8bAA2agTNpqs1hXQ4LW72Bru9Pm6CVdXidNJILuQOwdAgFxRumSAN XY8tOEj9ux/mtCJZr3AseTotLQMczwURBEb9zJlml7NSyfzxojl20AgxhT7saj8/QGZMgWftQa2GE 8yD39upRvIPLhw+dvDkwhJ7rXmd/8+//2oZstxOqMJZGYujIjOuYeLWkqoX+BdDE221FmIu2M9ky1 wg8MmImnI+MEYOZAynkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY40k-00DyTN-03; Mon, 21 Aug 2023 12:27:58 +0000 Received: from mail.8bytes.org ([85.214.250.239]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY40g-00DyS5-1i; Mon, 21 Aug 2023 12:27:55 +0000 Received: from 8bytes.org (pd9fe95be.dip0.t-ipconnect.de [217.254.149.190]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 14D6D28194F; Mon, 21 Aug 2023 14:27:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1692620870; bh=FixGPDbY1JGUzoXJGnGCpBH8LX7vfPyc85NTwmVIvZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1GNfM2qXUHu69LlGLcBH8KY7o7o7XmY+SCrGkW/UUIs2KGTpDHXZZbMpPGz6QSYZs UPnFUxDcsVEY3pjS1DruthDw9f83ySojUQCSB+rWg+GUD0/AhHwU/y7CvGp4ChZNfv PF0U1t4Yrw0S3cKVt3Z1VBJMi6C4Yubn+JBgQ0h8akaCgHt2/SoukE6zqp52PyQtal mSBFlaAtIaUSfX6biqD/5UJPh1qGAUoCalqefQ1b2bqiPcVjHwugqG0e+YrG5Eef+K UDBnBPokoAbTS28F+RA/gZgu4I/tGuWG+hC4PlSSGwOqv9iwEYEE1WLsVZflD78r+Z CJt+ubMPFXzmw== Date: Mon, 21 Aug 2023 14:27:47 +0200 From: Joerg Roedel To: Robin Murphy Cc: Jason Gunthorpe , Andy Gross , David Airlie , alsa-devel@alsa-project.org, Bjorn Andersson , Andrzej Hajda , ath10k@lists.infradead.org, ath11k@lists.infradead.org, Mark Brown , Bryan O'Donoghue , Christian Gmeiner , Daniel Vetter , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Emma Anholt , etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org, Frank Rowand , iommu@lists.linux.dev, Jernej Skrabec , Konrad Dybcio , Kalle Valo , Lucas Stach , Liam Girdwood , Russell King , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-wireless@vger.kernel.org, Marijn Suijten , Mauro Carvalho Chehab , Mikko Perttunen , Maxime Ripard , Sinan Kaya , Jaroslav Kysela , Abhinav Kumar , Jeff Johnson , Vikash Garodia , Rob Clark , Rob Herring , Samuel Holland , Sean Paul , Stanimir Varbanov , Thierry Reding , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , Will Deacon , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Lu Baolu , Joerg Roedel , Kevin Tian , Marek Szyprowski , Chen-Yu Tsai Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_052754_737837_CAF3C49F X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > The solution is to drop those locking patches entirely and rethink the whole > thing. Agreed, that was exactly what I thought when looking at this patch. I dropped the original 10 patches and the 4 fixes on-top from the IOMMU tree. This needs more investigation and adaption of the actual API users before it can be reconsidered. Regards, Joerg -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6BBCEE49AA for ; Mon, 21 Aug 2023 12:35:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF7F310E23D; Mon, 21 Aug 2023 12:35:37 +0000 (UTC) X-Greylist: delayed 464 seconds by postgrey-1.36 at gabe; Mon, 21 Aug 2023 12:35:35 UTC Received: from mail.8bytes.org (mail.8bytes.org [IPv6:2a01:238:42d9:3f00:e505:6202:4f0c:f051]) by gabe.freedesktop.org (Postfix) with ESMTP id 00E0210E23D; Mon, 21 Aug 2023 12:35:35 +0000 (UTC) Received: from 8bytes.org (pd9fe95be.dip0.t-ipconnect.de [217.254.149.190]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 14D6D28194F; Mon, 21 Aug 2023 14:27:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1692620870; bh=FixGPDbY1JGUzoXJGnGCpBH8LX7vfPyc85NTwmVIvZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1GNfM2qXUHu69LlGLcBH8KY7o7o7XmY+SCrGkW/UUIs2KGTpDHXZZbMpPGz6QSYZs UPnFUxDcsVEY3pjS1DruthDw9f83ySojUQCSB+rWg+GUD0/AhHwU/y7CvGp4ChZNfv PF0U1t4Yrw0S3cKVt3Z1VBJMi6C4Yubn+JBgQ0h8akaCgHt2/SoukE6zqp52PyQtal mSBFlaAtIaUSfX6biqD/5UJPh1qGAUoCalqefQ1b2bqiPcVjHwugqG0e+YrG5Eef+K UDBnBPokoAbTS28F+RA/gZgu4I/tGuWG+hC4PlSSGwOqv9iwEYEE1WLsVZflD78r+Z CJt+ubMPFXzmw== Date: Mon, 21 Aug 2023 14:27:47 +0200 From: Joerg Roedel To: Robin Murphy Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Emma Anholt , Kevin Tian , dri-devel@lists.freedesktop.org, Mikko Perttunen , Vikash Garodia , Chen-Yu Tsai , Thierry Reding , ath10k@lists.infradead.org, Andrzej Hajda , Marijn Suijten , Frank Rowand , Marek Szyprowski , Samuel Holland , Takashi Iwai , Sinan Kaya , Vinod Koul , Jernej Skrabec , iommu@lists.linux.dev, Andy Gross , Jason Gunthorpe , Russell King , Bryan O'Donoghue , ath11k@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Jaroslav Kysela , Joerg Roedel , Will Deacon , linux-arm-msm@vger.kernel.org, Kalle Valo , Chen-Yu Tsai , etnaviv@lists.freedesktop.org, Maxime Ripard , Abhinav Kumar , dmaengine@vger.kernel.org, Mark Brown , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Sean Paul , linux-arm-kernel@lists.infradead.org, Jeff Johnson , Bjorn Andersson , Stanimir Varbanov , linux-wireless@vger.kernel.org, Liam Girdwood , linux-sunxi@lists.linux.dev, Konrad Dybcio , Rob Herring , Dmitry Baryshkov , Lu Baolu , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > The solution is to drop those locking patches entirely and rethink the whole > thing. Agreed, that was exactly what I thought when looking at this patch. I dropped the original 10 patches and the 4 fixes on-top from the IOMMU tree. This needs more investigation and adaption of the actual API users before it can be reconsidered. Regards, Joerg