From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B81DC7113B for ; Thu, 24 Aug 2023 07:34:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8BFA984C; Thu, 24 Aug 2023 09:33:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8BFA984C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692862438; bh=abTBiCiZpzMkpXKl9kWJdppxBuyTEAH9dVUTya2y2Ac=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=LVvI5jGs8Bqs1ODGuDETBfhRe45XZNVKaKtvbBRcpX2AvXtU+QWX3QsGvhXAAExBW BHwCAzilFYaQniWxhEljIfSWweDcIHVfy6RO4f88ZZ1b+10D56SwhzcSDfmxQblxbt xCLgXvo2BrjqF6BNkIJbAAf2BtQsxBJxilucldJQ= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5C920F8055A; Thu, 24 Aug 2023 09:32:20 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5FB32F80551; Thu, 24 Aug 2023 09:32:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BB59CF80199; Mon, 21 Aug 2023 14:48:01 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20628.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::628]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 140C5F800BF for ; Mon, 21 Aug 2023 14:47:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 140C5F800BF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=dKCEZ9XM ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dUmLK/nmIMWHYgvdCuAf//JphfntRaXlUEjVbnjbHt/PUruU8tFzJhjoGbf2dsqtDCyueD47QuO7dq+obzHSmFeUdCwxDNfC81lSrQ5umnO+ahr73MdgancaVvxym4vsLDzIUk1dCy3gmBDub25NPcAAQxWnCb5U1yWqRFHNc38LHcyW7dRXOqIkli45lCWgLrsyoYLen1BC5qp1x990d740tAuakyxOVZpfff6lCuKKuBXwIZOIKXNMgoSksx5I9uVV8YFqU6dWYaDuXEavasPA5jo8nCSlwFjQBVcyq5D3DNzRiBSKiMMVxpkyjStVzsUp4HG3R2dbLQUZ/uIjWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i5GsFyI5GJmuujrW0DUtJ8taZ70zjMgaQ0pdfSIUmQI=; b=MSmZsTn0suSrDgkHKmD4Nn3Vo+YNcMXsbx3uVMAOOc/dZc33r01kJO/m5WL3T1sl/ZmOjuPYoB2g6ymrhpxXlOUcn/PX5m5YfytBRCQX5ht9MKbUsZ/EyjEMikEX5QLQl516QTjefaVUbHPYmjfJtyI7gRqpTmjKqtiSvD/zV6LHIDxT+3NKxAQ28dKtgpY5270pbo9YsZMJmTJza6oHAnTZg0ZlT3DVm0DcNsH6vA23vmQ0haptQUbuozhn4xngHNmkL3hI2P4RybmtzarXKI997d3894g/zBb+sXF7lltQUuxFJbACy33FiworplFpApIa2Nt3tUQ2XbP6p6IhHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i5GsFyI5GJmuujrW0DUtJ8taZ70zjMgaQ0pdfSIUmQI=; b=dKCEZ9XMExO+U64YpfZ899mI38wOmX1KZg5I0QsUt9dDR2XIz6fljoqIozNO88agt9bmrgdbuDiCM+jYlZyawimAu6zchOlUT1v3fX5uG6gnGBLXe6tfqJzJR0cj6q/jP8j6ZPGYMd24lT1Md1yO7M6Aei5iPG3NGTgYQx2MgOX2WddCi2juZ3GJpWBACTpeJDPZWRe3NPgeBs8/wXIYiKfS7S8cDMUZ3gqpkeZe81QXX9U8i4ALow4uQut7mFgdLDyL8bPyH6wOzZ0m9BSOxfAnrhL71iEOliogbmGbdeZFHZZVnt85RlMNFk29c4Sgvu5BoOmcU7A9BfOv6MxnwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by DS0PR12MB8341.namprd12.prod.outlook.com (2603:10b6:8:f8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 12:47:47 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1%6]) with mapi id 15.20.6699.020; Mon, 21 Aug 2023 12:47:47 +0000 Date: Mon, 21 Aug 2023 09:47:46 -0300 From: Jason Gunthorpe To: Joerg Roedel Cc: Robin Murphy , Andy Gross , David Airlie , alsa-devel@alsa-project.org, Bjorn Andersson , Andrzej Hajda , ath10k@lists.infradead.org, ath11k@lists.infradead.org, Mark Brown , Bryan O'Donoghue , Christian Gmeiner , Daniel Vetter , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Emma Anholt , etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org, Frank Rowand , iommu@lists.linux.dev, Jernej Skrabec , Konrad Dybcio , Kalle Valo , Lucas Stach , Liam Girdwood , Russell King , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-wireless@vger.kernel.org, Marijn Suijten , Mauro Carvalho Chehab , Mikko Perttunen , Maxime Ripard , Sinan Kaya , Jaroslav Kysela , Abhinav Kumar , Jeff Johnson , Vikash Garodia , Rob Clark , Rob Herring , Samuel Holland , Sean Paul , Stanimir Varbanov , Thierry Reding , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , Will Deacon , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Lu Baolu , Joerg Roedel , Kevin Tian , Marek Szyprowski , Chen-Yu Tsai Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN2PR20CA0065.namprd20.prod.outlook.com (2603:10b6:208:235::34) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|DS0PR12MB8341:EE_ X-MS-Office365-Filtering-Correlation-Id: b5aa5770-4f00-429f-1466-08dba244d248 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CGF8zel1taRlADL03+zpPzjaQXOoChnNhkSfrWMPOxDtKVuRhd1RtIocUOvCPW0Gnki0Zd+tURdQvBZVGt0wNmYeANR0Dl9BsHNm0MuklqaYI7UgyWMrVuXVahDUyb/dLkHEaB3JY05fqnvntop1/MZezqfTCTXwDBn5pfHgb/BZiC0OxI52/LO1g/1m5IpHsXr+ozrH1ZVwOtApgVV7z9w/cxNhKGNjGqYU8WdcpCDOwyDLvSsvCP16l3faRlGWF2iUjE7Xy3UDkc51q7QxjszqJ/zqZ+jaQmUUWubEi4hsOzVENB/7vLRgoZdiy10wrRt+AaXjN0/6xnXCVqO/E3+3qU6wPfSNOBT2ivoJzNQaCQC6WPPdQZC8/TdfzhHpe4+eNrs4+AjZ5JAe/DPJny1rmxB4d3pM8J43srXWKTRrTTgqVf8Yn0VPzs+pMw4Nc4yfG8lD1ITlWbP36BLClxuMqJr8eKCDPJhcMFMWE1RJjM6Y3TSqMyu6qWKmeUbVEkozxUYwUOdCvg/us5AuGhGh23Hk7tCZbvTAiqOJcTrGhyArKozypA2/lbXvgSm0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199024)(186009)(1800799009)(2906002)(4744005)(7416002)(7366002)(7406005)(38100700002)(6506007)(6486002)(83380400001)(5660300002)(26005)(86362001)(8676002)(2616005)(8936002)(4326008)(316002)(66946007)(6512007)(54906003)(6916009)(66556008)(66476007)(478600001)(36756003)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W8ahnWSFdLqj3/2FrxKcJRUBtTV+iTAW5m9zZr18g1KUns9xgwW1e1A5VRVT?= =?us-ascii?Q?x5fUDGPYJGgEIfOsaVqqIr86tfLoBzzZqzGASpypPIiRzafvbnD/FEdeOeTe?= =?us-ascii?Q?JF+GMm9rz2elCO8lJ59TRStXeS9IPTlbGX7xVj/XfgIevhoTSYNHsM/+jUKx?= =?us-ascii?Q?eIVkGRnQEf4QmqbqomeTDhQswcTCM+BLyAh8NmV5E0WLQYHR7djpdesjHkAU?= =?us-ascii?Q?WaTNsUIM5nHZFwrF6uTBwkSHCSBRbcYmggFh7rstw6KXfpiK49VB8lNlr3TZ?= =?us-ascii?Q?dLUFd1SmmCDmLaGiWmwCwD2p+J43Jilg8OdczFx9q/KudByJa2Gut+6MnctP?= =?us-ascii?Q?T2H9epO9edOn7s9/zltqsVuT1JsxnZK24Om7nbPeHnPxdrEzWumPai/BkO/f?= =?us-ascii?Q?eMtjhcUs9XPznRIjl2AJzDGxm19sih5EZQ5JCmCUtoSiqaZIp5CLo7cnaUWV?= =?us-ascii?Q?s++B2KVmww2Bv5MOYVBg8UyajVfwEbx0/b/QZ3vwJeudZQ/fS5y1Wmov+wmN?= =?us-ascii?Q?9q0aABLaRFeSmeEBmR0l+KltrJOsZ/cdum8d8BOm2dOX5TZhhyqdL1lQEuRx?= =?us-ascii?Q?POAv1guAfwEOV+gWe4wR7MjeApPEnqKohodtHAPuzkTWm1mQXnIpvgXtNsPA?= =?us-ascii?Q?t2wAz9HxRbAbyXXao2GcoeNgVJK+xVvjhjity/mdyNC117ZWrSMBYaEGyePb?= =?us-ascii?Q?sPIybVXSTlT9iDelE07U85c7KrkOvgliv2kM77fj1hg8k3DMCVQyKmnzY/yo?= =?us-ascii?Q?yv8pQMoRzdU4wemAZ0i4Aw4Lrszr8aoWOMY0hG/Xf1wr5OXDITzXOmKmoWOZ?= =?us-ascii?Q?Od0/Y81XTXYJ7cSKedn6sUbTGz8VfX4UMNG8tlSkqgcKBkNdXbRI9rFn1g0j?= =?us-ascii?Q?jXx8gSpWXqNGIcvfA6SSnN7G7NOGevMxF3WD45wvzZXieW6p1y2NUCWaDixM?= =?us-ascii?Q?48IhP2fpqvDRUx79zZrBFchLf58wZzqZ8dm2qMdrLJczD/0RRhgs1VVvULhM?= =?us-ascii?Q?TUBI3CdojgxxLLfoxAyYr+ZACZtlNRRcZV/bGUdEQaTjEmmhtf4nLGhrhjEY?= =?us-ascii?Q?K9uue4dEJH7k5CDiSdOAFkidpTi6uRLfvdO+cTYfEf9m1IOxmPvaL993uVlb?= =?us-ascii?Q?QMueK6OzFgvxV2rNJe5Dsee1lXWVXMcf6/YR8wQTio+3KtAOKz7MKR0UZYXp?= =?us-ascii?Q?2cvrb3KJflAzdxivD470bJZg+X7UFoJttkoy5fI2SHTlovYc3uAE2skmZZ3v?= =?us-ascii?Q?xi4yKDuKYej1mgiS+tac97uvgpRFL6CBWcT7DYkJ9URRLiA/GZAYLB1h4BzO?= =?us-ascii?Q?KfBYpzgGUUSBoEDw7r6GnLnZHq1ntP8DKmEYYei3xNk120DtHRRfEqR9RsQq?= =?us-ascii?Q?PZIbhgG5+6m5utQBP87o6Cxdj7haMxTJ+xcdaL2C9AB4JgEAGNI6m2AveaUX?= =?us-ascii?Q?dKwXWOH7HG2HWgS9sIdHTgBpbH38Lh9ud21yvoyFv9jedabbDJBdHU9Ibtmp?= =?us-ascii?Q?bO6MPmfKFv3pnh68MlcT95ORcuJp4nhCWlDGFQL/jDmQeLdR/sVKxHq6xDP1?= =?us-ascii?Q?PwzaOa8VVCG2HmRQOwKw1ROZY93Duo6WOvWAtJw7?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5aa5770-4f00-429f-1466-08dba244d248 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 12:47:47.5545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j9LDXsRLWNFEJxLIhFjHq/MXAkLThR3n/3J7GHPZ13/ftt9AIhg4pymIazkmRRfo X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8341 X-MailFrom: jgg@nvidia.com X-Mailman-Rule-Hits: max-recipients X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: LNBYTLRRCWAADO4NJB2B3QRE6PXVHRKG X-Message-ID-Hash: LNBYTLRRCWAADO4NJB2B3QRE6PXVHRKG X-Mailman-Approved-At: Thu, 24 Aug 2023 07:29:54 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote: > On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > > The solution is to drop those locking patches entirely and rethink the whole > > thing. > > Agreed, that was exactly what I thought when looking at this patch. > > I dropped the original 10 patches and the 4 fixes on-top from the IOMMU > tree. This needs more investigation and adaption of the actual API users > before it can be reconsidered. Why did you drop the whole series? The group changes are fine Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B283AEE49A6 for ; Mon, 21 Aug 2023 12:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VzMdNSbpqJSk3KRObSPeF4pUwaIzYGwQATBhwRdsQeg=; b=nfwFtONjNaU59T rqLhGK348+2anHKF9bdRPsv9L/GQANRoRwrfrvdcGsPS114SG/q9cRmidDnWGKWa+SlL2lM8dqigg 0mZ/+x0VtEKVs7cuYpAjkGmHylCiAiRsNlBCb56S/b7hcdRRUrrWXgazOsth9gmdDqMNqUK47L3pn I/6AzpOtfdO2wRNb2LQ9QW4esFnR96fB1H7+YEMrim5S1TmFekC+nYTcizD9VjK8Aps4IiEoxrGZD KLaIjRZDOjZIMiUGQ13CttbydG0XxSiOv54UqsicHQIuHwd9uMm4TAaM7nafPY5umtq7IU+no1YLe NwUzR77nxDJeuyK8cF+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY4KA-00E1iu-20; Mon, 21 Aug 2023 12:48:02 +0000 Received: from mail-bn8nam12on20626.outbound.protection.outlook.com ([2a01:111:f400:fe5b::626] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qY4K7-00E1hM-1B; Mon, 21 Aug 2023 12:48:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dUmLK/nmIMWHYgvdCuAf//JphfntRaXlUEjVbnjbHt/PUruU8tFzJhjoGbf2dsqtDCyueD47QuO7dq+obzHSmFeUdCwxDNfC81lSrQ5umnO+ahr73MdgancaVvxym4vsLDzIUk1dCy3gmBDub25NPcAAQxWnCb5U1yWqRFHNc38LHcyW7dRXOqIkli45lCWgLrsyoYLen1BC5qp1x990d740tAuakyxOVZpfff6lCuKKuBXwIZOIKXNMgoSksx5I9uVV8YFqU6dWYaDuXEavasPA5jo8nCSlwFjQBVcyq5D3DNzRiBSKiMMVxpkyjStVzsUp4HG3R2dbLQUZ/uIjWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i5GsFyI5GJmuujrW0DUtJ8taZ70zjMgaQ0pdfSIUmQI=; b=MSmZsTn0suSrDgkHKmD4Nn3Vo+YNcMXsbx3uVMAOOc/dZc33r01kJO/m5WL3T1sl/ZmOjuPYoB2g6ymrhpxXlOUcn/PX5m5YfytBRCQX5ht9MKbUsZ/EyjEMikEX5QLQl516QTjefaVUbHPYmjfJtyI7gRqpTmjKqtiSvD/zV6LHIDxT+3NKxAQ28dKtgpY5270pbo9YsZMJmTJza6oHAnTZg0ZlT3DVm0DcNsH6vA23vmQ0haptQUbuozhn4xngHNmkL3hI2P4RybmtzarXKI997d3894g/zBb+sXF7lltQUuxFJbACy33FiworplFpApIa2Nt3tUQ2XbP6p6IhHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i5GsFyI5GJmuujrW0DUtJ8taZ70zjMgaQ0pdfSIUmQI=; b=dKCEZ9XMExO+U64YpfZ899mI38wOmX1KZg5I0QsUt9dDR2XIz6fljoqIozNO88agt9bmrgdbuDiCM+jYlZyawimAu6zchOlUT1v3fX5uG6gnGBLXe6tfqJzJR0cj6q/jP8j6ZPGYMd24lT1Md1yO7M6Aei5iPG3NGTgYQx2MgOX2WddCi2juZ3GJpWBACTpeJDPZWRe3NPgeBs8/wXIYiKfS7S8cDMUZ3gqpkeZe81QXX9U8i4ALow4uQut7mFgdLDyL8bPyH6wOzZ0m9BSOxfAnrhL71iEOliogbmGbdeZFHZZVnt85RlMNFk29c4Sgvu5BoOmcU7A9BfOv6MxnwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by DS0PR12MB8341.namprd12.prod.outlook.com (2603:10b6:8:f8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 12:47:47 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1%6]) with mapi id 15.20.6699.020; Mon, 21 Aug 2023 12:47:47 +0000 Date: Mon, 21 Aug 2023 09:47:46 -0300 From: Jason Gunthorpe To: Joerg Roedel Cc: Robin Murphy , Andy Gross , David Airlie , alsa-devel@alsa-project.org, Bjorn Andersson , Andrzej Hajda , ath10k@lists.infradead.org, ath11k@lists.infradead.org, Mark Brown , Bryan O'Donoghue , Christian Gmeiner , Daniel Vetter , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Emma Anholt , etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org, Frank Rowand , iommu@lists.linux.dev, Jernej Skrabec , Konrad Dybcio , Kalle Valo , Lucas Stach , Liam Girdwood , Russell King , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-wireless@vger.kernel.org, Marijn Suijten , Mauro Carvalho Chehab , Mikko Perttunen , Maxime Ripard , Sinan Kaya , Jaroslav Kysela , Abhinav Kumar , Jeff Johnson , Vikash Garodia , Rob Clark , Rob Herring , Samuel Holland , Sean Paul , Stanimir Varbanov , Thierry Reding , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , Will Deacon , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Lu Baolu , Joerg Roedel , Kevin Tian , Marek Szyprowski , Chen-Yu Tsai Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN2PR20CA0065.namprd20.prod.outlook.com (2603:10b6:208:235::34) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|DS0PR12MB8341:EE_ X-MS-Office365-Filtering-Correlation-Id: b5aa5770-4f00-429f-1466-08dba244d248 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CGF8zel1taRlADL03+zpPzjaQXOoChnNhkSfrWMPOxDtKVuRhd1RtIocUOvCPW0Gnki0Zd+tURdQvBZVGt0wNmYeANR0Dl9BsHNm0MuklqaYI7UgyWMrVuXVahDUyb/dLkHEaB3JY05fqnvntop1/MZezqfTCTXwDBn5pfHgb/BZiC0OxI52/LO1g/1m5IpHsXr+ozrH1ZVwOtApgVV7z9w/cxNhKGNjGqYU8WdcpCDOwyDLvSsvCP16l3faRlGWF2iUjE7Xy3UDkc51q7QxjszqJ/zqZ+jaQmUUWubEi4hsOzVENB/7vLRgoZdiy10wrRt+AaXjN0/6xnXCVqO/E3+3qU6wPfSNOBT2ivoJzNQaCQC6WPPdQZC8/TdfzhHpe4+eNrs4+AjZ5JAe/DPJny1rmxB4d3pM8J43srXWKTRrTTgqVf8Yn0VPzs+pMw4Nc4yfG8lD1ITlWbP36BLClxuMqJr8eKCDPJhcMFMWE1RJjM6Y3TSqMyu6qWKmeUbVEkozxUYwUOdCvg/us5AuGhGh23Hk7tCZbvTAiqOJcTrGhyArKozypA2/lbXvgSm0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199024)(186009)(1800799009)(2906002)(4744005)(7416002)(7366002)(7406005)(38100700002)(6506007)(6486002)(83380400001)(5660300002)(26005)(86362001)(8676002)(2616005)(8936002)(4326008)(316002)(66946007)(6512007)(54906003)(6916009)(66556008)(66476007)(478600001)(36756003)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W8ahnWSFdLqj3/2FrxKcJRUBtTV+iTAW5m9zZr18g1KUns9xgwW1e1A5VRVT?= =?us-ascii?Q?x5fUDGPYJGgEIfOsaVqqIr86tfLoBzzZqzGASpypPIiRzafvbnD/FEdeOeTe?= =?us-ascii?Q?JF+GMm9rz2elCO8lJ59TRStXeS9IPTlbGX7xVj/XfgIevhoTSYNHsM/+jUKx?= =?us-ascii?Q?eIVkGRnQEf4QmqbqomeTDhQswcTCM+BLyAh8NmV5E0WLQYHR7djpdesjHkAU?= =?us-ascii?Q?WaTNsUIM5nHZFwrF6uTBwkSHCSBRbcYmggFh7rstw6KXfpiK49VB8lNlr3TZ?= =?us-ascii?Q?dLUFd1SmmCDmLaGiWmwCwD2p+J43Jilg8OdczFx9q/KudByJa2Gut+6MnctP?= =?us-ascii?Q?T2H9epO9edOn7s9/zltqsVuT1JsxnZK24Om7nbPeHnPxdrEzWumPai/BkO/f?= =?us-ascii?Q?eMtjhcUs9XPznRIjl2AJzDGxm19sih5EZQ5JCmCUtoSiqaZIp5CLo7cnaUWV?= =?us-ascii?Q?s++B2KVmww2Bv5MOYVBg8UyajVfwEbx0/b/QZ3vwJeudZQ/fS5y1Wmov+wmN?= =?us-ascii?Q?9q0aABLaRFeSmeEBmR0l+KltrJOsZ/cdum8d8BOm2dOX5TZhhyqdL1lQEuRx?= =?us-ascii?Q?POAv1guAfwEOV+gWe4wR7MjeApPEnqKohodtHAPuzkTWm1mQXnIpvgXtNsPA?= =?us-ascii?Q?t2wAz9HxRbAbyXXao2GcoeNgVJK+xVvjhjity/mdyNC117ZWrSMBYaEGyePb?= =?us-ascii?Q?sPIybVXSTlT9iDelE07U85c7KrkOvgliv2kM77fj1hg8k3DMCVQyKmnzY/yo?= =?us-ascii?Q?yv8pQMoRzdU4wemAZ0i4Aw4Lrszr8aoWOMY0hG/Xf1wr5OXDITzXOmKmoWOZ?= =?us-ascii?Q?Od0/Y81XTXYJ7cSKedn6sUbTGz8VfX4UMNG8tlSkqgcKBkNdXbRI9rFn1g0j?= =?us-ascii?Q?jXx8gSpWXqNGIcvfA6SSnN7G7NOGevMxF3WD45wvzZXieW6p1y2NUCWaDixM?= =?us-ascii?Q?48IhP2fpqvDRUx79zZrBFchLf58wZzqZ8dm2qMdrLJczD/0RRhgs1VVvULhM?= =?us-ascii?Q?TUBI3CdojgxxLLfoxAyYr+ZACZtlNRRcZV/bGUdEQaTjEmmhtf4nLGhrhjEY?= =?us-ascii?Q?K9uue4dEJH7k5CDiSdOAFkidpTi6uRLfvdO+cTYfEf9m1IOxmPvaL993uVlb?= =?us-ascii?Q?QMueK6OzFgvxV2rNJe5Dsee1lXWVXMcf6/YR8wQTio+3KtAOKz7MKR0UZYXp?= =?us-ascii?Q?2cvrb3KJflAzdxivD470bJZg+X7UFoJttkoy5fI2SHTlovYc3uAE2skmZZ3v?= =?us-ascii?Q?xi4yKDuKYej1mgiS+tac97uvgpRFL6CBWcT7DYkJ9URRLiA/GZAYLB1h4BzO?= =?us-ascii?Q?KfBYpzgGUUSBoEDw7r6GnLnZHq1ntP8DKmEYYei3xNk120DtHRRfEqR9RsQq?= =?us-ascii?Q?PZIbhgG5+6m5utQBP87o6Cxdj7haMxTJ+xcdaL2C9AB4JgEAGNI6m2AveaUX?= =?us-ascii?Q?dKwXWOH7HG2HWgS9sIdHTgBpbH38Lh9ud21yvoyFv9jedabbDJBdHU9Ibtmp?= =?us-ascii?Q?bO6MPmfKFv3pnh68MlcT95ORcuJp4nhCWlDGFQL/jDmQeLdR/sVKxHq6xDP1?= =?us-ascii?Q?PwzaOa8VVCG2HmRQOwKw1ROZY93Duo6WOvWAtJw7?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5aa5770-4f00-429f-1466-08dba244d248 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 12:47:47.5545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j9LDXsRLWNFEJxLIhFjHq/MXAkLThR3n/3J7GHPZ13/ftt9AIhg4pymIazkmRRfo X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8341 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_054759_402652_5224AADD X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote: > On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > > The solution is to drop those locking patches entirely and rethink the whole > > thing. > > Agreed, that was exactly what I thought when looking at this patch. > > I dropped the original 10 patches and the 4 fixes on-top from the IOMMU > tree. This needs more investigation and adaption of the actual API users > before it can be reconsidered. Why did you drop the whole series? The group changes are fine Jason _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AAB0EE4996 for ; Mon, 21 Aug 2023 12:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tdF1YvF/A41Ab9pMaOGGYP2lqMzBiWGev4WkuK6F4p4=; b=pHzD10yhBfB1Lo 94dAVVFMu1LkhQsR14n862W60ITbQvLUeMIF3Tfo17m6W6ZYCjEpoUmQ6d9EwlyBjLM8q4NsziszN BC6+Z0crUfs8IrubfW2Mysvis6+01rQ9iD932/8PHQl1jMVWOiPkXHo5Cq2GcxuOYaeO9hcls8G1h bXOfM0FCMIEbdrOwi77AFM21I+0W2LYcKtB1ooPOfSdP4vEQD1Hw/BwkN9Wb9/hTxLLOXJ9t/O+p5 XynGUIvC+MUZhYu0HTqc6QwuH67dzCAqw9RP87oVh91q+xDooWj1CkhNn7xPImqBUTqXsD9Uc8iAz JOvPk++GtTNq8KmiEL2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY4KB-00E1j1-0S; Mon, 21 Aug 2023 12:48:03 +0000 Received: from mail-bn8nam12on20626.outbound.protection.outlook.com ([2a01:111:f400:fe5b::626] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qY4K7-00E1hM-1B; Mon, 21 Aug 2023 12:48:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dUmLK/nmIMWHYgvdCuAf//JphfntRaXlUEjVbnjbHt/PUruU8tFzJhjoGbf2dsqtDCyueD47QuO7dq+obzHSmFeUdCwxDNfC81lSrQ5umnO+ahr73MdgancaVvxym4vsLDzIUk1dCy3gmBDub25NPcAAQxWnCb5U1yWqRFHNc38LHcyW7dRXOqIkli45lCWgLrsyoYLen1BC5qp1x990d740tAuakyxOVZpfff6lCuKKuBXwIZOIKXNMgoSksx5I9uVV8YFqU6dWYaDuXEavasPA5jo8nCSlwFjQBVcyq5D3DNzRiBSKiMMVxpkyjStVzsUp4HG3R2dbLQUZ/uIjWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i5GsFyI5GJmuujrW0DUtJ8taZ70zjMgaQ0pdfSIUmQI=; b=MSmZsTn0suSrDgkHKmD4Nn3Vo+YNcMXsbx3uVMAOOc/dZc33r01kJO/m5WL3T1sl/ZmOjuPYoB2g6ymrhpxXlOUcn/PX5m5YfytBRCQX5ht9MKbUsZ/EyjEMikEX5QLQl516QTjefaVUbHPYmjfJtyI7gRqpTmjKqtiSvD/zV6LHIDxT+3NKxAQ28dKtgpY5270pbo9YsZMJmTJza6oHAnTZg0ZlT3DVm0DcNsH6vA23vmQ0haptQUbuozhn4xngHNmkL3hI2P4RybmtzarXKI997d3894g/zBb+sXF7lltQUuxFJbACy33FiworplFpApIa2Nt3tUQ2XbP6p6IhHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i5GsFyI5GJmuujrW0DUtJ8taZ70zjMgaQ0pdfSIUmQI=; b=dKCEZ9XMExO+U64YpfZ899mI38wOmX1KZg5I0QsUt9dDR2XIz6fljoqIozNO88agt9bmrgdbuDiCM+jYlZyawimAu6zchOlUT1v3fX5uG6gnGBLXe6tfqJzJR0cj6q/jP8j6ZPGYMd24lT1Md1yO7M6Aei5iPG3NGTgYQx2MgOX2WddCi2juZ3GJpWBACTpeJDPZWRe3NPgeBs8/wXIYiKfS7S8cDMUZ3gqpkeZe81QXX9U8i4ALow4uQut7mFgdLDyL8bPyH6wOzZ0m9BSOxfAnrhL71iEOliogbmGbdeZFHZZVnt85RlMNFk29c4Sgvu5BoOmcU7A9BfOv6MxnwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by DS0PR12MB8341.namprd12.prod.outlook.com (2603:10b6:8:f8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 12:47:47 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1%6]) with mapi id 15.20.6699.020; Mon, 21 Aug 2023 12:47:47 +0000 Date: Mon, 21 Aug 2023 09:47:46 -0300 From: Jason Gunthorpe To: Joerg Roedel Cc: Robin Murphy , Andy Gross , David Airlie , alsa-devel@alsa-project.org, Bjorn Andersson , Andrzej Hajda , ath10k@lists.infradead.org, ath11k@lists.infradead.org, Mark Brown , Bryan O'Donoghue , Christian Gmeiner , Daniel Vetter , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Emma Anholt , etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org, Frank Rowand , iommu@lists.linux.dev, Jernej Skrabec , Konrad Dybcio , Kalle Valo , Lucas Stach , Liam Girdwood , Russell King , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-wireless@vger.kernel.org, Marijn Suijten , Mauro Carvalho Chehab , Mikko Perttunen , Maxime Ripard , Sinan Kaya , Jaroslav Kysela , Abhinav Kumar , Jeff Johnson , Vikash Garodia , Rob Clark , Rob Herring , Samuel Holland , Sean Paul , Stanimir Varbanov , Thierry Reding , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , Will Deacon , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Lu Baolu , Joerg Roedel , Kevin Tian , Marek Szyprowski , Chen-Yu Tsai Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN2PR20CA0065.namprd20.prod.outlook.com (2603:10b6:208:235::34) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|DS0PR12MB8341:EE_ X-MS-Office365-Filtering-Correlation-Id: b5aa5770-4f00-429f-1466-08dba244d248 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CGF8zel1taRlADL03+zpPzjaQXOoChnNhkSfrWMPOxDtKVuRhd1RtIocUOvCPW0Gnki0Zd+tURdQvBZVGt0wNmYeANR0Dl9BsHNm0MuklqaYI7UgyWMrVuXVahDUyb/dLkHEaB3JY05fqnvntop1/MZezqfTCTXwDBn5pfHgb/BZiC0OxI52/LO1g/1m5IpHsXr+ozrH1ZVwOtApgVV7z9w/cxNhKGNjGqYU8WdcpCDOwyDLvSsvCP16l3faRlGWF2iUjE7Xy3UDkc51q7QxjszqJ/zqZ+jaQmUUWubEi4hsOzVENB/7vLRgoZdiy10wrRt+AaXjN0/6xnXCVqO/E3+3qU6wPfSNOBT2ivoJzNQaCQC6WPPdQZC8/TdfzhHpe4+eNrs4+AjZ5JAe/DPJny1rmxB4d3pM8J43srXWKTRrTTgqVf8Yn0VPzs+pMw4Nc4yfG8lD1ITlWbP36BLClxuMqJr8eKCDPJhcMFMWE1RJjM6Y3TSqMyu6qWKmeUbVEkozxUYwUOdCvg/us5AuGhGh23Hk7tCZbvTAiqOJcTrGhyArKozypA2/lbXvgSm0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199024)(186009)(1800799009)(2906002)(4744005)(7416002)(7366002)(7406005)(38100700002)(6506007)(6486002)(83380400001)(5660300002)(26005)(86362001)(8676002)(2616005)(8936002)(4326008)(316002)(66946007)(6512007)(54906003)(6916009)(66556008)(66476007)(478600001)(36756003)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W8ahnWSFdLqj3/2FrxKcJRUBtTV+iTAW5m9zZr18g1KUns9xgwW1e1A5VRVT?= =?us-ascii?Q?x5fUDGPYJGgEIfOsaVqqIr86tfLoBzzZqzGASpypPIiRzafvbnD/FEdeOeTe?= =?us-ascii?Q?JF+GMm9rz2elCO8lJ59TRStXeS9IPTlbGX7xVj/XfgIevhoTSYNHsM/+jUKx?= =?us-ascii?Q?eIVkGRnQEf4QmqbqomeTDhQswcTCM+BLyAh8NmV5E0WLQYHR7djpdesjHkAU?= =?us-ascii?Q?WaTNsUIM5nHZFwrF6uTBwkSHCSBRbcYmggFh7rstw6KXfpiK49VB8lNlr3TZ?= =?us-ascii?Q?dLUFd1SmmCDmLaGiWmwCwD2p+J43Jilg8OdczFx9q/KudByJa2Gut+6MnctP?= =?us-ascii?Q?T2H9epO9edOn7s9/zltqsVuT1JsxnZK24Om7nbPeHnPxdrEzWumPai/BkO/f?= =?us-ascii?Q?eMtjhcUs9XPznRIjl2AJzDGxm19sih5EZQ5JCmCUtoSiqaZIp5CLo7cnaUWV?= =?us-ascii?Q?s++B2KVmww2Bv5MOYVBg8UyajVfwEbx0/b/QZ3vwJeudZQ/fS5y1Wmov+wmN?= =?us-ascii?Q?9q0aABLaRFeSmeEBmR0l+KltrJOsZ/cdum8d8BOm2dOX5TZhhyqdL1lQEuRx?= =?us-ascii?Q?POAv1guAfwEOV+gWe4wR7MjeApPEnqKohodtHAPuzkTWm1mQXnIpvgXtNsPA?= =?us-ascii?Q?t2wAz9HxRbAbyXXao2GcoeNgVJK+xVvjhjity/mdyNC117ZWrSMBYaEGyePb?= =?us-ascii?Q?sPIybVXSTlT9iDelE07U85c7KrkOvgliv2kM77fj1hg8k3DMCVQyKmnzY/yo?= =?us-ascii?Q?yv8pQMoRzdU4wemAZ0i4Aw4Lrszr8aoWOMY0hG/Xf1wr5OXDITzXOmKmoWOZ?= =?us-ascii?Q?Od0/Y81XTXYJ7cSKedn6sUbTGz8VfX4UMNG8tlSkqgcKBkNdXbRI9rFn1g0j?= =?us-ascii?Q?jXx8gSpWXqNGIcvfA6SSnN7G7NOGevMxF3WD45wvzZXieW6p1y2NUCWaDixM?= =?us-ascii?Q?48IhP2fpqvDRUx79zZrBFchLf58wZzqZ8dm2qMdrLJczD/0RRhgs1VVvULhM?= =?us-ascii?Q?TUBI3CdojgxxLLfoxAyYr+ZACZtlNRRcZV/bGUdEQaTjEmmhtf4nLGhrhjEY?= =?us-ascii?Q?K9uue4dEJH7k5CDiSdOAFkidpTi6uRLfvdO+cTYfEf9m1IOxmPvaL993uVlb?= =?us-ascii?Q?QMueK6OzFgvxV2rNJe5Dsee1lXWVXMcf6/YR8wQTio+3KtAOKz7MKR0UZYXp?= =?us-ascii?Q?2cvrb3KJflAzdxivD470bJZg+X7UFoJttkoy5fI2SHTlovYc3uAE2skmZZ3v?= =?us-ascii?Q?xi4yKDuKYej1mgiS+tac97uvgpRFL6CBWcT7DYkJ9URRLiA/GZAYLB1h4BzO?= =?us-ascii?Q?KfBYpzgGUUSBoEDw7r6GnLnZHq1ntP8DKmEYYei3xNk120DtHRRfEqR9RsQq?= =?us-ascii?Q?PZIbhgG5+6m5utQBP87o6Cxdj7haMxTJ+xcdaL2C9AB4JgEAGNI6m2AveaUX?= =?us-ascii?Q?dKwXWOH7HG2HWgS9sIdHTgBpbH38Lh9ud21yvoyFv9jedabbDJBdHU9Ibtmp?= =?us-ascii?Q?bO6MPmfKFv3pnh68MlcT95ORcuJp4nhCWlDGFQL/jDmQeLdR/sVKxHq6xDP1?= =?us-ascii?Q?PwzaOa8VVCG2HmRQOwKw1ROZY93Duo6WOvWAtJw7?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5aa5770-4f00-429f-1466-08dba244d248 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 12:47:47.5545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j9LDXsRLWNFEJxLIhFjHq/MXAkLThR3n/3J7GHPZ13/ftt9AIhg4pymIazkmRRfo X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8341 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_054759_402652_5224AADD X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote: > On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > > The solution is to drop those locking patches entirely and rethink the whole > > thing. > > Agreed, that was exactly what I thought when looking at this patch. > > I dropped the original 10 patches and the 4 fixes on-top from the IOMMU > tree. This needs more investigation and adaption of the actual API users > before it can be reconsidered. Why did you drop the whole series? The group changes are fine Jason -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45349EE49AF for ; Mon, 21 Aug 2023 12:47:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 46CFD10E244; Mon, 21 Aug 2023 12:47:52 +0000 (UTC) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2041.outbound.protection.outlook.com [40.107.237.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69FFF10E244; Mon, 21 Aug 2023 12:47:50 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dUmLK/nmIMWHYgvdCuAf//JphfntRaXlUEjVbnjbHt/PUruU8tFzJhjoGbf2dsqtDCyueD47QuO7dq+obzHSmFeUdCwxDNfC81lSrQ5umnO+ahr73MdgancaVvxym4vsLDzIUk1dCy3gmBDub25NPcAAQxWnCb5U1yWqRFHNc38LHcyW7dRXOqIkli45lCWgLrsyoYLen1BC5qp1x990d740tAuakyxOVZpfff6lCuKKuBXwIZOIKXNMgoSksx5I9uVV8YFqU6dWYaDuXEavasPA5jo8nCSlwFjQBVcyq5D3DNzRiBSKiMMVxpkyjStVzsUp4HG3R2dbLQUZ/uIjWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i5GsFyI5GJmuujrW0DUtJ8taZ70zjMgaQ0pdfSIUmQI=; b=MSmZsTn0suSrDgkHKmD4Nn3Vo+YNcMXsbx3uVMAOOc/dZc33r01kJO/m5WL3T1sl/ZmOjuPYoB2g6ymrhpxXlOUcn/PX5m5YfytBRCQX5ht9MKbUsZ/EyjEMikEX5QLQl516QTjefaVUbHPYmjfJtyI7gRqpTmjKqtiSvD/zV6LHIDxT+3NKxAQ28dKtgpY5270pbo9YsZMJmTJza6oHAnTZg0ZlT3DVm0DcNsH6vA23vmQ0haptQUbuozhn4xngHNmkL3hI2P4RybmtzarXKI997d3894g/zBb+sXF7lltQUuxFJbACy33FiworplFpApIa2Nt3tUQ2XbP6p6IhHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i5GsFyI5GJmuujrW0DUtJ8taZ70zjMgaQ0pdfSIUmQI=; b=dKCEZ9XMExO+U64YpfZ899mI38wOmX1KZg5I0QsUt9dDR2XIz6fljoqIozNO88agt9bmrgdbuDiCM+jYlZyawimAu6zchOlUT1v3fX5uG6gnGBLXe6tfqJzJR0cj6q/jP8j6ZPGYMd24lT1Md1yO7M6Aei5iPG3NGTgYQx2MgOX2WddCi2juZ3GJpWBACTpeJDPZWRe3NPgeBs8/wXIYiKfS7S8cDMUZ3gqpkeZe81QXX9U8i4ALow4uQut7mFgdLDyL8bPyH6wOzZ0m9BSOxfAnrhL71iEOliogbmGbdeZFHZZVnt85RlMNFk29c4Sgvu5BoOmcU7A9BfOv6MxnwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by DS0PR12MB8341.namprd12.prod.outlook.com (2603:10b6:8:f8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 12:47:47 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1%6]) with mapi id 15.20.6699.020; Mon, 21 Aug 2023 12:47:47 +0000 Date: Mon, 21 Aug 2023 09:47:46 -0300 From: Jason Gunthorpe To: Joerg Roedel Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN2PR20CA0065.namprd20.prod.outlook.com (2603:10b6:208:235::34) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|DS0PR12MB8341:EE_ X-MS-Office365-Filtering-Correlation-Id: b5aa5770-4f00-429f-1466-08dba244d248 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CGF8zel1taRlADL03+zpPzjaQXOoChnNhkSfrWMPOxDtKVuRhd1RtIocUOvCPW0Gnki0Zd+tURdQvBZVGt0wNmYeANR0Dl9BsHNm0MuklqaYI7UgyWMrVuXVahDUyb/dLkHEaB3JY05fqnvntop1/MZezqfTCTXwDBn5pfHgb/BZiC0OxI52/LO1g/1m5IpHsXr+ozrH1ZVwOtApgVV7z9w/cxNhKGNjGqYU8WdcpCDOwyDLvSsvCP16l3faRlGWF2iUjE7Xy3UDkc51q7QxjszqJ/zqZ+jaQmUUWubEi4hsOzVENB/7vLRgoZdiy10wrRt+AaXjN0/6xnXCVqO/E3+3qU6wPfSNOBT2ivoJzNQaCQC6WPPdQZC8/TdfzhHpe4+eNrs4+AjZ5JAe/DPJny1rmxB4d3pM8J43srXWKTRrTTgqVf8Yn0VPzs+pMw4Nc4yfG8lD1ITlWbP36BLClxuMqJr8eKCDPJhcMFMWE1RJjM6Y3TSqMyu6qWKmeUbVEkozxUYwUOdCvg/us5AuGhGh23Hk7tCZbvTAiqOJcTrGhyArKozypA2/lbXvgSm0 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR12MB5869.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199024)(186009)(1800799009)(2906002)(4744005)(7416002)(7366002)(7406005)(38100700002)(6506007)(6486002)(83380400001)(5660300002)(26005)(86362001)(8676002)(2616005)(8936002)(4326008)(316002)(66946007)(6512007)(54906003)(6916009)(66556008)(66476007)(478600001)(36756003)(41300700001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W8ahnWSFdLqj3/2FrxKcJRUBtTV+iTAW5m9zZr18g1KUns9xgwW1e1A5VRVT?= =?us-ascii?Q?x5fUDGPYJGgEIfOsaVqqIr86tfLoBzzZqzGASpypPIiRzafvbnD/FEdeOeTe?= =?us-ascii?Q?JF+GMm9rz2elCO8lJ59TRStXeS9IPTlbGX7xVj/XfgIevhoTSYNHsM/+jUKx?= =?us-ascii?Q?eIVkGRnQEf4QmqbqomeTDhQswcTCM+BLyAh8NmV5E0WLQYHR7djpdesjHkAU?= =?us-ascii?Q?WaTNsUIM5nHZFwrF6uTBwkSHCSBRbcYmggFh7rstw6KXfpiK49VB8lNlr3TZ?= =?us-ascii?Q?dLUFd1SmmCDmLaGiWmwCwD2p+J43Jilg8OdczFx9q/KudByJa2Gut+6MnctP?= =?us-ascii?Q?T2H9epO9edOn7s9/zltqsVuT1JsxnZK24Om7nbPeHnPxdrEzWumPai/BkO/f?= =?us-ascii?Q?eMtjhcUs9XPznRIjl2AJzDGxm19sih5EZQ5JCmCUtoSiqaZIp5CLo7cnaUWV?= =?us-ascii?Q?s++B2KVmww2Bv5MOYVBg8UyajVfwEbx0/b/QZ3vwJeudZQ/fS5y1Wmov+wmN?= =?us-ascii?Q?9q0aABLaRFeSmeEBmR0l+KltrJOsZ/cdum8d8BOm2dOX5TZhhyqdL1lQEuRx?= =?us-ascii?Q?POAv1guAfwEOV+gWe4wR7MjeApPEnqKohodtHAPuzkTWm1mQXnIpvgXtNsPA?= =?us-ascii?Q?t2wAz9HxRbAbyXXao2GcoeNgVJK+xVvjhjity/mdyNC117ZWrSMBYaEGyePb?= =?us-ascii?Q?sPIybVXSTlT9iDelE07U85c7KrkOvgliv2kM77fj1hg8k3DMCVQyKmnzY/yo?= =?us-ascii?Q?yv8pQMoRzdU4wemAZ0i4Aw4Lrszr8aoWOMY0hG/Xf1wr5OXDITzXOmKmoWOZ?= =?us-ascii?Q?Od0/Y81XTXYJ7cSKedn6sUbTGz8VfX4UMNG8tlSkqgcKBkNdXbRI9rFn1g0j?= =?us-ascii?Q?jXx8gSpWXqNGIcvfA6SSnN7G7NOGevMxF3WD45wvzZXieW6p1y2NUCWaDixM?= =?us-ascii?Q?48IhP2fpqvDRUx79zZrBFchLf58wZzqZ8dm2qMdrLJczD/0RRhgs1VVvULhM?= =?us-ascii?Q?TUBI3CdojgxxLLfoxAyYr+ZACZtlNRRcZV/bGUdEQaTjEmmhtf4nLGhrhjEY?= =?us-ascii?Q?K9uue4dEJH7k5CDiSdOAFkidpTi6uRLfvdO+cTYfEf9m1IOxmPvaL993uVlb?= =?us-ascii?Q?QMueK6OzFgvxV2rNJe5Dsee1lXWVXMcf6/YR8wQTio+3KtAOKz7MKR0UZYXp?= =?us-ascii?Q?2cvrb3KJflAzdxivD470bJZg+X7UFoJttkoy5fI2SHTlovYc3uAE2skmZZ3v?= =?us-ascii?Q?xi4yKDuKYej1mgiS+tac97uvgpRFL6CBWcT7DYkJ9URRLiA/GZAYLB1h4BzO?= =?us-ascii?Q?KfBYpzgGUUSBoEDw7r6GnLnZHq1ntP8DKmEYYei3xNk120DtHRRfEqR9RsQq?= =?us-ascii?Q?PZIbhgG5+6m5utQBP87o6Cxdj7haMxTJ+xcdaL2C9AB4JgEAGNI6m2AveaUX?= =?us-ascii?Q?dKwXWOH7HG2HWgS9sIdHTgBpbH38Lh9ud21yvoyFv9jedabbDJBdHU9Ibtmp?= =?us-ascii?Q?bO6MPmfKFv3pnh68MlcT95ORcuJp4nhCWlDGFQL/jDmQeLdR/sVKxHq6xDP1?= =?us-ascii?Q?PwzaOa8VVCG2HmRQOwKw1ROZY93Duo6WOvWAtJw7?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5aa5770-4f00-429f-1466-08dba244d248 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 12:47:47.5545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j9LDXsRLWNFEJxLIhFjHq/MXAkLThR3n/3J7GHPZ13/ftt9AIhg4pymIazkmRRfo X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8341 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Emma Anholt , Kevin Tian , dri-devel@lists.freedesktop.org, Mikko Perttunen , Vikash Garodia , Jeff Johnson , Chen-Yu Tsai , Thierry Reding , ath10k@lists.infradead.org, Andrzej Hajda , Marijn Suijten , Frank Rowand , Marek Szyprowski , Samuel Holland , Takashi Iwai , Sinan Kaya , Vinod Koul , Jernej Skrabec , iommu@lists.linux.dev, Andy Gross , Russell King , Bryan O'Donoghue , ath11k@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Jaroslav Kysela , Joerg Roedel , Will Deacon , linux-arm-msm@vger.kernel.org, Kalle Valo , Chen-Yu Tsai , etnaviv@lists.freedesktop.org, Maxime Ripard , Abhinav Kumar , dmaengine@vger.kernel.org, Mark Brown , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Sean Paul , linux-arm-kernel@lists.infradead.org, freedreno@lists.freedesktop.org, Bjorn Andersson , Stanimir Varbanov , linux-wireless@vger.kernel.org, Liam Girdwood , linux-sunxi@lists.linux.dev, Konrad Dybcio , Rob Herring , Dmitry Baryshkov , Lu Baolu , Robin Murphy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote: > On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > > The solution is to drop those locking patches entirely and rethink the whole > > thing. > > Agreed, that was exactly what I thought when looking at this patch. > > I dropped the original 10 patches and the 4 fixes on-top from the IOMMU > tree. This needs more investigation and adaption of the actual API users > before it can be reconsidered. Why did you drop the whole series? The group changes are fine Jason