Re: [meta-arm] [PATCH] arm/linux-yocto: change defconfig patch for 6.4

[Jon Mason <jdmason@kudzu.us>]

On Mon, Aug 21, 2023 at 03:59:45PM +0300, Mikko Rapeli wrote:
> Hi,
> 
> On Sun, Aug 20, 2023 at 04:51:06PM -0500, Jon Mason wrote:
> > Use the patch that Mikko Rapeli is trying to upstream to work around the
> > Nuvoton defconfig issue instead of reverting the patch that added the
> > platform to the kernel.
> > 
> > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > ---
> >  ...g-remove-CONFIG_COMMON_CLK_NPCM8XX-y.patch | 50 +++++++++++++++++++
> >  ...config-Add-Nuvoton-NPCM-family-suppo.patch | 45 -----------------
> >  .../linux/linux-yocto%.bbappend               |  5 ++
> >  .../linux/linux-yocto-rt_6.1%.bbappend        |  1 -
> >  .../linux/linux-yocto_6.1%.bbappend           |  1 -
> >  5 files changed, 55 insertions(+), 47 deletions(-)
> >  create mode 100644 meta-arm/recipes-kernel/linux/files/aarch64/0001-arm64-defconfig-remove-CONFIG_COMMON_CLK_NPCM8XX-y.patch
> >  delete mode 100644 meta-arm/recipes-kernel/linux/files/aarch64/0002-Revert-arm64-defconfig-Add-Nuvoton-NPCM-family-suppo.patch
> > 
> > diff --git a/meta-arm/recipes-kernel/linux/files/aarch64/0001-arm64-defconfig-remove-CONFIG_COMMON_CLK_NPCM8XX-y.patch b/meta-arm/recipes-kernel/linux/files/aarch64/0001-arm64-defconfig-remove-CONFIG_COMMON_CLK_NPCM8XX-y.patch
> > new file mode 100644
> > index 00000000..d7f01853
> > --- /dev/null
> > +++ b/meta-arm/recipes-kernel/linux/files/aarch64/0001-arm64-defconfig-remove-CONFIG_COMMON_CLK_NPCM8XX-y.patch
> > @@ -0,0 +1,50 @@
> > +From 94a5e7ffe5855272708a94190820534c4f51bdd8 Mon Sep 17 00:00:00 2001
> > +From: Mikko Rapeli <mikko.rapeli@linaro.org>
> > +Date: Tue, 15 Aug 2023 10:36:56 +0300
> > +Subject: [PATCH] arm64: defconfig: remove CONFIG_COMMON_CLK_NPCM8XX=y
> > +
> > +There is no code for this config option and enabling it in defconfig
> > +causes warnings from tools which are detecting unused and obsolete
> > +kernel config flags since the flag will be completely missing from
> > +effective build config after "make olddefconfig".
> > +
> > +Fixes yocto kernel recipe build time warning:
> > +
> > +WARNING: [kernel config]: This BSP contains fragments with warnings:
> > +...
> > +[INFO]: the following symbols were not found in the active
> > +configuration:
> > +     - CONFIG_COMMON_CLK_NPCM8XX
> > +
> > +The flag was added with commit 45472f1e5348c7b755b4912f2f529ec81cea044b
> > +v5.19-rc4-15-g45472f1e5348 so 6.1 and 6.4 stable kernel trees are
> > +affected.
> > +
> > +Fixes: 45472f1e5348c7b755b4912f2f529ec81cea044b ("arm64: defconfig: Add Nuvoton NPCM family support")
> > +Cc: stable@kernel.org
> > +Cc: Bruce Ashfield <bruce.ashfield@gmail.com>
> > +Cc: Jon Mason <jon.mason@arm.com>
> > +Cc: Jon Mason <jdmason@kudzu.us>
> > +Cc: Ross Burton <ross@burtonini.com>
> > +Cc: Arnd Bergmann <arnd@arndb.de>
> > +Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> > +
> > +Signed-off-by: Jon Mason <jon.mason@arm.com>
> > +Upstream-Status: Inappropriate
> 
> Upstream-Status: Submitted [https://lists.infradead.org/pipermail/linux-arm-kernel/2023-August/859760.html]

Good catch, patch updated (not resending, as this is a fairly trivial
change).

Thanks,
Jon

> 
> Cheers,
> 
> -Mikko
>