From: Matthew Wilcox <willy@infradead.org>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH] secretmem: Conert page_is_secretmem() to folio_is_secretmem()
Date: Mon, 21 Aug 2023 16:53:32 +0100 [thread overview]
Message-ID: <ZOOIfF1rm85NCaw1@casper.infradead.org> (raw)
In-Reply-To: <96895823-ce2a-5dc7-77a1-a28d1242bc6d@redhat.com>
On Mon, Aug 21, 2023 at 05:32:50PM +0200, David Hildenbrand wrote:
> > - if (PageCompound(page) || !PageLRU(page))
> > + if (folio_test_large(folio) || folio_test_lru(folio))
> > return false;
>
> You converted a "!PageLRU(page)" into a "folio_test_lru(folio)".
>
> Shouldn't that be a "!folio_test_lru(folio)" ?
Well, that's embarrassing. Obviously I don't have any secretmem
hardware, so my smoke-test didn't catch it. Thanks, will do a v2.
next prev parent reply other threads:[~2023-08-21 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 14:17 [PATCH] secretmem: Conert page_is_secretmem() to folio_is_secretmem() Matthew Wilcox (Oracle)
2023-08-21 14:48 ` Mike Rapoport
2023-08-21 15:32 ` David Hildenbrand
2023-08-21 15:53 ` Matthew Wilcox [this message]
2023-08-21 16:14 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOOIfF1rm85NCaw1@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.