All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod v1.6.x][PATCH] tests: mockup: unbind mockup devices before unloading the module
Date: Tue, 22 Aug 2023 08:21:51 +0800	[thread overview]
Message-ID: <ZOP/n30hYR/8zN60@sol> (raw)
In-Reply-To: <20230821153339.26305-1-brgl@bgdev.pl>

On Mon, Aug 21, 2023 at 05:33:39PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> gpio-mockup relies on the GPIO devices being registered in module's __init
> function and them being unregistered in __exit. This works with the GPIO
> subsystem as it only takes a reference to the underlying owner module when
> a GPIO descriptor is requested and not when the GPIO device is
> instantiated.
> 
> This behavior may change in the future in the kernel so make the behavior
> of libgpiomockup more correct and have it unbind all mockup devices over
> sysfs before unloading the module.
> 

Never knew that unbinding was even an option.
Maybe update gpio-mockup's documentation?

Just clarifying what the potential impact of the existing libgpiomockup
behaviour and future kernel behaviour is - the kernel may log errors but
otherwise correctly handle userspace unloading behaving badly?
So this patch is pre-emptory noise reduction?

Cheers,
Kent.

  reply	other threads:[~2023-08-22  0:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 15:33 [libgpiod v1.6.x][PATCH] tests: mockup: unbind mockup devices before unloading the module Bartosz Golaszewski
2023-08-22  0:21 ` Kent Gibson [this message]
2023-08-22  7:08   ` Bartosz Golaszewski
2023-08-24  7:32     ` Bartosz Golaszewski
2023-08-24  7:36       ` Kent Gibson
2023-08-24  7:39         ` Bartosz Golaszewski
2023-08-24  8:46           ` Linus Walleij
2023-08-24  9:12             ` Bartosz Golaszewski
2023-08-24  8:47 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOP/n30hYR/8zN60@sol \
    --to=warthog618@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.