All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft,v2] INSTALL: provide examples to install python bindings
Date: Mon, 21 Aug 2023 22:05:52 +0200	[thread overview]
Message-ID: <ZOPDoG4Ow5pcmYnM@calendula> (raw)
In-Reply-To: <20230821175521.GA46797@azazel.net>

On Mon, Aug 21, 2023 at 06:55:21PM +0100, Jeremy Sowden wrote:
> On 2023-08-21, at 13:28:40 +0200, Pablo Neira Ayuso wrote:
> > Provide examples to install python bindings with legacy setup.py and pip
> > with .toml file.
> > 
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > ---
> > v2: add Jeremy's feedback.
> > 
> >  INSTALL | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> > 
> > diff --git a/INSTALL b/INSTALL
> > index 53021e5aafc3..6539ebdd6457 100644
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -84,10 +84,14 @@ Installation instructions for nftables
> >   Python support
> >   ==============
> >  
> > - CPython bindings are available for nftables under the py/ folder.
> > + CPython bindings are available for nftables under the py/ folder.  They can be
> > + installed using pip:
> >  
> > - A pyproject.toml config file and legacy setup.py script are provided to install
> > - it.
> > +    python -m pip install py/
> > +
> > + Alternatively, legacy setup.py script is also provided to install it:
> > +
> > +	python setup.py install
> >  
> >   Source code
> >   ===========
> > -- 
> > 2.30.2
> > 
> 
> If you want to retain a reference to setup.py, then how about this
> patch?

Patch is applied here:

http://git.netfilter.org/nftables/commit/?id=97c28c926096950f1646c99b85a31de309429a0c

Thanks for your feedback.

      reply	other threads:[~2023-08-21 20:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 11:28 [PATCH nft,v2] INSTALL: provide examples to install python bindings Pablo Neira Ayuso
2023-08-21 17:55 ` Jeremy Sowden
2023-08-21 20:05   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOPDoG4Ow5pcmYnM@calendula \
    --to=pablo@netfilter.org \
    --cc=jeremy@azazel.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.