Re: [PATCH v1 2/2] perf/tools: Allow to use cpuinfo on loongarch

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Tue, Aug 22, 2023 at 05:32:07PM +0800, Yanteng Si escreveu:
> Define these macros so that the CPU name can be displayed
> when running perf report and perf timechart.
> 
> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
> ---
>  tools/perf/util/header.c    | 2 ++
>  tools/perf/util/svghelper.c | 7 ++++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 52fbf526fe74..c6e19192bd28 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -456,6 +456,8 @@ static int write_cpudesc(struct feat_fd *ff,
>  #define CPUINFO_PROC	{ "Processor", }
>  #elif defined(__xtensa__)
>  #define CPUINFO_PROC	{ "core ID", }
> +#elif defined(__loongarch__)
> +#define CPUINFO_PROC	{ "Model Name", }
>  #else
>  #define CPUINFO_PROC	{ "model name", }
>  #endif
> diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c
> index 5c62d3118c41..0259715ad6a6 100644
> --- a/tools/perf/util/svghelper.c
> +++ b/tools/perf/util/svghelper.c
> @@ -322,6 +322,11 @@ void svg_waiting(int Yslot, int cpu, u64 start, u64 end, const char *backtrace)
>  
>  static char *cpu_model(void)
>  {
> +#if defined(__loongarch__)
> +#define CPU_TYPE	"Model Name"
> +#else
> +#define CPU_TYPE	"model name"
> +#endif
>  	static char cpu_m[255];
>  	char buf[256];
>  	FILE *file;
> @@ -331,7 +336,7 @@ static char *cpu_model(void)
>  	file = fopen("/proc/cpuinfo", "r");
>  	if (file) {
>  		while (fgets(buf, 255, file)) {
> -			if (strstr(buf, "model name")) {
> +			if (strstr(buf, CPU_TYPE)) {

Isn't it better to just switch to strcasestr()?

- Arnaldo

>  				strlcpy(cpu_m, &buf[13], 255);
>  				break;
>  			}
> -- 
> 2.31.4
> 

-- 

- Arnaldo