From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A78EE49AF for ; Wed, 23 Aug 2023 07:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233324AbjHWHbL (ORCPT ); Wed, 23 Aug 2023 03:31:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233319AbjHWHbL (ORCPT ); Wed, 23 Aug 2023 03:31:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E91DAE52; Wed, 23 Aug 2023 00:30:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68422615B3; Wed, 23 Aug 2023 07:30:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E423CC433C7; Wed, 23 Aug 2023 07:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692775855; bh=0BU5tvuZoETLLYAzQzR1sD8FFkPX6j54eFyEPsWBB3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S6oVBX+c/AVyJt6WAVLtZ8XXBiSB2R0n/Y9V1xiyi/lJ02SycIsXE8WXobpe5Vbbu iqkiIyXxvkhczBoiglFGvXKBsmB0nOEZnY7ZEpBbsL2oOFbEogtmsux8iCl+ygFZ1m DSzI/tXpMaej4Rqkd+BiRGf4OkNXFc+aH9tdHH7FWJ7nax+uXdD9zLILElJt1n4mTn pqtLddxtsga5YZkSOfObuNqjUnvNRV4BLDLoi6Xh+5MbXb5UDRJQJYUlNl7R/DZvpd qGaLhJKrDeHXxiEF3heKSnfrUSGIgOqX6iaLsXCIeDJTkZi4VSAJ8eKW6vl2Pram/X ZDyLyKf55GB7w== Date: Wed, 23 Aug 2023 09:30:48 +0200 From: Lorenzo Pieralisi To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Jim Quinlan , Florian Fainelli , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property Message-ID: References: <20230623144100.34196-1-james.quinlan@broadcom.com> <20230623144100.34196-2-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Aug 21, 2023 at 12:01:50PM -0400, Jim Quinlan wrote: > On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi > wrote: > > > > On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote: > > > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi > > > wrote: > > > > > > > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote: > > > > > This commit adds the boolean "brcm,enable-l1ss" property: > > > > > > > > > > The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs -- > > > > > requires the driver probe() to deliberately place the HW one of three > > > > > CLKREQ# modes: > > > > > > > > > > (a) CLKREQ# driven by the RC unconditionally > > > > > (b) CLKREQ# driven by the EP for ASPM L0s, L1 > > > > > (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS). > > > > > > > > > > The HW+driver can tell the difference between downstream devices that > > > > > need (a) and (b), but does not know when to configure (c). All devices > > > > > should work fine when the driver chooses (a) or (b), but (c) may be > > > > > desired to realize the extra power savings that L1SS offers. So we > > > > > introduce the boolean "brcm,enable-l1ss" property to inform the driver > > > > > that (c) is desired. Setting this property only makes sense when the > > > > > downstream device is L1SS-capable and the OS is configured to activate > > > > > this mode (e.g. policy==powersupersave). > > > > > > > > > > This property is already present in the Raspian version of Linux, but the > > > > > upstream driver implementation that follows adds more details and > > > > > discerns between (a) and (b). > > > > > > > > > > Signed-off-by: Jim Quinlan > > > > > Reviewed-by: Rob Herring > > > > > --- > > > > > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++ > > > > > 1 file changed, 9 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > > > > index 7e15aae7d69e..8b61c2179608 100644 > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > > > > @@ -64,6 +64,15 @@ properties: > > > > > > > > > > aspm-no-l0s: true > > > > > > > > > > + brcm,enable-l1ss: > > > > > + description: Indicates that PCIe L1SS power savings > > > > > + are desired, the downstream device is L1SS-capable, and the > > > > > + OS has been configured to enable this mode. For boards > > > > > > > > What does this mean ? I don't think DT properties are supposed > > > > to carry information related to how the OS is configured. > > > > > > The DT setting in question is unrelated to the statement "and the OS > > > has been configured to > > > enable this mode". > > > > > > This is merely saying that even if you enable "brcm,l1ss-enable" > > > that you may not get L1SS power savings w/o setting > > > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y". > > > I mentioned that exact term but a reviewer nakked it because > > > apparently DT descriptions should not be OS specific. > > > > > > I am actually open for this to be a command-line option but I wanted to honor > > > what the Raspian OS folks have already done. RaspianOS already has > > > "brcm,enable-l1ss" > > > set in their DTS files. > > > > This is about the mainline kernel, I don't have any visibility into > > downstream kernels (where that property management was added without DT > > and PCI maintainers supervision). > > > > Raspian OS folks' choice is theirs but it can't and it shouldn't override > > the mainline review process even though I understand the position you > > are in. > > Understood, but using the command line has its warts as well; I now recall the > discussion Bjorn and I had regarding this option. I'm pretty sure > that upstreaam will not allow the following > possible command line kernel params: > > brcm,enable-l1ss > pci=brcm,entable-l1ss > > Bjorn suggested using the documented but (IMO) obscure and rarely > used format > > pci=[:]:.[/.]*pci::[::] > > but this is just going in the wrong direction; here's why. Using the > above iformat s completely dependent on the > PCI "linux-domaiin" property, a non-HW related DT property I might > add. Since "linux-domain" is already > a valid and well-used DT property, and the value of the above > command line format is dependent > on the value of the "linux-domain", why not be consistent and let > "brcm,enable-l1ss" be a Broadcom specific property? I am just asking to add a module_param to the host controller driver. Anyway - time is running out for v6.6, I need Rob's feedback, if I don't hear from him today I will merge the last three patches and postpone the discussion. Thanks, Lorenzo > > Regards, > Jim Quinlan > Broadcom STB/CM > > > > > > Thanks, > > Lorenzo > > > > > > > > Regards, > > > Jim > > > > > > > Again - it depends on what DT should be used for, I am not claiming to > > > > have any authority on that, just asking. > > > > > > > > Thanks, > > > > Lorenzo > > > > > > > > > + using a mini-card connector, this mode may not meet the > > > > > + TCRLon maximum time of 400ns, as specified in 3.2.5.2.2 > > > > > + of the PCI Express Mini CEM 2.0 specification. > > > > > + type: boolean > > > > > + > > > > > brcm,scb-sizes: > > > > > description: u64 giving the 64bit PCIe memory > > > > > viewport size of a memory controller. There may be up to > > > > > -- > > > > > 2.17.1 > > > > > > > > > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3643EE49AB for ; Wed, 23 Aug 2023 07:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sQMOdWWddrbQSZH2BQ+znkeGQIXTupW+p08gysaIM8A=; b=u9rg7vBnciGeaS +UR/63DVPizDQ3LktLJePNodHwieYRdN6zNQ6pIRKIl2ayiIjjxxByrrM+K6wOxT+BSeh1wKZx1KH QDUIi2qebFfAvFU8l3rOhFUdXD6Ovg5rKwb/kDJqwyVzBz1TW7xiMeTDi/6Rb+qwGvq8+7Ig6sIWr E34v0nP5CRQh4d7zvJt01P3GWFwtHe62WDsNDOXyLWT0+Or4XZTaN72iOyRzRO4x27OcypdLVWLcr GPpzOlvnkxgZJU6S/4M/HvN2T60s3tafBnemOP8OYeuCarmhisaWNocFWL+CM8FacFqcmI2LvIJr1 nOe3JJV1d2SL5+b2o61Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYiKS-00HSul-1X; Wed, 23 Aug 2023 07:31:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYiKP-00HSuL-1s; Wed, 23 Aug 2023 07:30:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68815616A4; Wed, 23 Aug 2023 07:30:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E423CC433C7; Wed, 23 Aug 2023 07:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692775855; bh=0BU5tvuZoETLLYAzQzR1sD8FFkPX6j54eFyEPsWBB3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S6oVBX+c/AVyJt6WAVLtZ8XXBiSB2R0n/Y9V1xiyi/lJ02SycIsXE8WXobpe5Vbbu iqkiIyXxvkhczBoiglFGvXKBsmB0nOEZnY7ZEpBbsL2oOFbEogtmsux8iCl+ygFZ1m DSzI/tXpMaej4Rqkd+BiRGf4OkNXFc+aH9tdHH7FWJ7nax+uXdD9zLILElJt1n4mTn pqtLddxtsga5YZkSOfObuNqjUnvNRV4BLDLoi6Xh+5MbXb5UDRJQJYUlNl7R/DZvpd qGaLhJKrDeHXxiEF3heKSnfrUSGIgOqX6iaLsXCIeDJTkZi4VSAJ8eKW6vl2Pram/X ZDyLyKf55GB7w== Date: Wed, 23 Aug 2023 09:30:48 +0200 From: Lorenzo Pieralisi To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Jim Quinlan , Florian Fainelli , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property Message-ID: References: <20230623144100.34196-1-james.quinlan@broadcom.com> <20230623144100.34196-2-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230823_003057_704174_474E2F53 X-CRM114-Status: GOOD ( 49.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMjEsIDIwMjMgYXQgMTI6MDE6NTBQTSAtMDQwMCwgSmltIFF1aW5sYW4gd3Jv dGU6Cj4gT24gTW9uLCBBdWcgMjEsIDIwMjMgYXQgMTE6NDHigK9BTSBMb3JlbnpvIFBpZXJhbGlz aQo+IDxscGllcmFsaXNpQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIE1vbiwgQXVnIDIx LCAyMDIzIGF0IDExOjI1OjExQU0gLTA0MDAsIEppbSBRdWlubGFuIHdyb3RlOgo+ID4gPiBPbiBN b24sIEF1ZyAyMSwgMjAyMyBhdCAxMDo0N+KAr0FNIExvcmVuem8gUGllcmFsaXNpCj4gPiA+IDxs cGllcmFsaXNpQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gT24gRnJpLCBKdW4g MjMsIDIwMjMgYXQgMTA6NDA6NTRBTSAtMDQwMCwgSmltIFF1aW5sYW4gd3JvdGU6Cj4gPiA+ID4g PiBUaGlzIGNvbW1pdCBhZGRzIHRoZSBib29sZWFuICJicmNtLGVuYWJsZS1sMXNzIiBwcm9wZXJ0 eToKPiA+ID4gPiA+Cj4gPiA+ID4gPiAgIFRoZSBCcm9hZGNvbSBTVEIvQ00gUENJZSBIVyAtLSBh IGNvcmUgdGhhdCBpcyBhbHNvIHVzZWQgYnkgUlBpIFNPQ3MgLS0KPiA+ID4gPiA+ICAgcmVxdWly ZXMgdGhlIGRyaXZlciBwcm9iZSgpIHRvIGRlbGliZXJhdGVseSBwbGFjZSB0aGUgSFcgb25lIG9m IHRocmVlCj4gPiA+ID4gPiAgIENMS1JFUSMgbW9kZXM6Cj4gPiA+ID4gPgo+ID4gPiA+ID4gICAo YSkgQ0xLUkVRIyBkcml2ZW4gYnkgdGhlIFJDIHVuY29uZGl0aW9uYWxseQo+ID4gPiA+ID4gICAo YikgQ0xLUkVRIyBkcml2ZW4gYnkgdGhlIEVQIGZvciBBU1BNIEwwcywgTDEKPiA+ID4gPiA+ICAg KGMpIEJpZGlyZWN0aW9uYWwgQ0xLUkVRIywgYXMgdXNlZCBmb3IgTDEgU3Vic3RhdGVzIChMMVNT KS4KPiA+ID4gPiA+Cj4gPiA+ID4gPiAgIFRoZSBIVytkcml2ZXIgY2FuIHRlbGwgdGhlIGRpZmZl cmVuY2UgYmV0d2VlbiBkb3duc3RyZWFtIGRldmljZXMgdGhhdAo+ID4gPiA+ID4gICBuZWVkIChh KSBhbmQgKGIpLCBidXQgZG9lcyBub3Qga25vdyB3aGVuIHRvIGNvbmZpZ3VyZSAoYykuICBBbGwg ZGV2aWNlcwo+ID4gPiA+ID4gICBzaG91bGQgd29yayBmaW5lIHdoZW4gdGhlIGRyaXZlciBjaG9v c2VzIChhKSBvciAoYiksIGJ1dCAoYykgbWF5IGJlCj4gPiA+ID4gPiAgIGRlc2lyZWQgdG8gcmVh bGl6ZSB0aGUgZXh0cmEgcG93ZXIgc2F2aW5ncyB0aGF0IEwxU1Mgb2ZmZXJzLiAgU28gd2UKPiA+ ID4gPiA+ICAgaW50cm9kdWNlIHRoZSBib29sZWFuICJicmNtLGVuYWJsZS1sMXNzIiBwcm9wZXJ0 eSB0byBpbmZvcm0gdGhlIGRyaXZlcgo+ID4gPiA+ID4gICB0aGF0IChjKSBpcyBkZXNpcmVkLiAg U2V0dGluZyB0aGlzIHByb3BlcnR5IG9ubHkgbWFrZXMgc2Vuc2Ugd2hlbiB0aGUKPiA+ID4gPiA+ ICAgZG93bnN0cmVhbSBkZXZpY2UgaXMgTDFTUy1jYXBhYmxlIGFuZCB0aGUgT1MgaXMgY29uZmln dXJlZCB0byBhY3RpdmF0ZQo+ID4gPiA+ID4gICB0aGlzIG1vZGUgKGUuZy4gcG9saWN5PT1wb3dl cnN1cGVyc2F2ZSkuCj4gPiA+ID4gPgo+ID4gPiA+ID4gICBUaGlzIHByb3BlcnR5IGlzIGFscmVh ZHkgcHJlc2VudCBpbiB0aGUgUmFzcGlhbiB2ZXJzaW9uIG9mIExpbnV4LCBidXQgdGhlCj4gPiA+ ID4gPiAgIHVwc3RyZWFtIGRyaXZlciBpbXBsZW1lbnRhdGlvbiB0aGF0IGZvbGxvd3MgYWRkcyBt b3JlIGRldGFpbHMgYW5kCj4gPiA+ID4gPiAgIGRpc2Nlcm5zIGJldHdlZW4gKGEpIGFuZCAoYiku Cj4gPiA+ID4gPgo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSmltIFF1aW5sYW4gPGphbWVzLnF1 aW5sYW5AYnJvYWRjb20uY29tPgo+ID4gPiA+ID4gUmV2aWV3ZWQtYnk6IFJvYiBIZXJyaW5nIDxy b2JoQGtlcm5lbC5vcmc+Cj4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ICBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvcGNpL2JyY20sc3RiLXBjaWUueWFtbCB8IDkgKysrKysrKysrCj4g PiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKQo+ID4gPiA+ID4KPiA+ID4g PiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2Jy Y20sc3RiLXBjaWUueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kv YnJjbSxzdGItcGNpZS55YW1sCj4gPiA+ID4gPiBpbmRleCA3ZTE1YWFlN2Q2OWUuLjhiNjFjMjE3 OTYwOCAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9wY2kvYnJjbSxzdGItcGNpZS55YW1sCj4gPiA+ID4gPiArKysgYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2JyY20sc3RiLXBjaWUueWFtbAo+ID4gPiA+ID4gQEAg LTY0LDYgKzY0LDE1IEBAIHByb3BlcnRpZXM6Cj4gPiA+ID4gPgo+ID4gPiA+ID4gICAgYXNwbS1u by1sMHM6IHRydWUKPiA+ID4gPiA+Cj4gPiA+ID4gPiArICBicmNtLGVuYWJsZS1sMXNzOgo+ID4g PiA+ID4gKyAgICBkZXNjcmlwdGlvbjogSW5kaWNhdGVzIHRoYXQgUENJZSBMMVNTIHBvd2VyIHNh dmluZ3MKPiA+ID4gPiA+ICsgICAgICBhcmUgZGVzaXJlZCwgdGhlIGRvd25zdHJlYW0gZGV2aWNl IGlzIEwxU1MtY2FwYWJsZSwgYW5kIHRoZQo+ID4gPiA+ID4gKyAgICAgIE9TIGhhcyBiZWVuIGNv bmZpZ3VyZWQgdG8gZW5hYmxlIHRoaXMgbW9kZS4gIEZvciBib2FyZHMKPiA+ID4gPgo+ID4gPiA+ IFdoYXQgZG9lcyB0aGlzIG1lYW4gPyBJIGRvbid0IHRoaW5rIERUIHByb3BlcnRpZXMgYXJlIHN1 cHBvc2VkCj4gPiA+ID4gdG8gY2FycnkgaW5mb3JtYXRpb24gcmVsYXRlZCB0byBob3cgdGhlIE9T IGlzIGNvbmZpZ3VyZWQuCj4gPiA+Cj4gPiA+IFRoZSBEVCBzZXR0aW5nIGluIHF1ZXN0aW9uIGlz IHVucmVsYXRlZCB0byB0aGUgc3RhdGVtZW50ICJhbmQgdGhlIE9TCj4gPiA+IGhhcyBiZWVuIGNv bmZpZ3VyZWQgdG8KPiA+ID4gZW5hYmxlIHRoaXMgbW9kZSIuCj4gPiA+Cj4gPiA+IFRoaXMgaXMg bWVyZWx5IHNheWluZyB0aGF0IGV2ZW4gaWYgeW91IGVuYWJsZSAiYnJjbSxsMXNzLWVuYWJsZSIK PiA+ID4gdGhhdCB5b3UgbWF5IG5vdCBnZXQgTDFTUyBwb3dlciBzYXZpbmdzIHcvbyBzZXR0aW5n Cj4gPiA+ICJDT05GSUdfUENJRUFTUE1fUE9XRVJfU1VQRVJTQVZFPXkiLgo+ID4gPiBJIG1lbnRp b25lZCB0aGF0IGV4YWN0IHRlcm0gYnV0IGEgcmV2aWV3ZXIgbmFra2VkIGl0IGJlY2F1c2UKPiA+ ID4gYXBwYXJlbnRseSBEVCBkZXNjcmlwdGlvbnMgc2hvdWxkIG5vdCBiZSBPUyBzcGVjaWZpYy4K PiA+ID4KPiA+ID4gSSBhbSBhY3R1YWxseSBvcGVuIGZvciB0aGlzIHRvIGJlIGEgY29tbWFuZC1s aW5lIG9wdGlvbiBidXQgSSB3YW50ZWQgdG8gaG9ub3IKPiA+ID4gd2hhdCB0aGUgUmFzcGlhbiBP UyBmb2xrcyBoYXZlIGFscmVhZHkgZG9uZS4gIFJhc3BpYW5PUyBhbHJlYWR5IGhhcwo+ID4gPiAi YnJjbSxlbmFibGUtbDFzcyIKPiA+ID4gc2V0IGluIHRoZWlyIERUUyBmaWxlcy4KPiA+Cj4gPiBU aGlzIGlzIGFib3V0IHRoZSBtYWlubGluZSBrZXJuZWwsIEkgZG9uJ3QgaGF2ZSBhbnkgdmlzaWJp bGl0eSBpbnRvCj4gPiBkb3duc3RyZWFtIGtlcm5lbHMgKHdoZXJlIHRoYXQgcHJvcGVydHkgbWFu YWdlbWVudCB3YXMgYWRkZWQgd2l0aG91dCBEVAo+ID4gYW5kIFBDSSBtYWludGFpbmVycyBzdXBl cnZpc2lvbikuCj4gPgo+ID4gUmFzcGlhbiBPUyBmb2xrcycgY2hvaWNlIGlzIHRoZWlycyBidXQg aXQgY2FuJ3QgYW5kIGl0IHNob3VsZG4ndCBvdmVycmlkZQo+ID4gdGhlIG1haW5saW5lIHJldmll dyBwcm9jZXNzIGV2ZW4gdGhvdWdoIEkgdW5kZXJzdGFuZCB0aGUgcG9zaXRpb24geW91Cj4gPiBh cmUgaW4uCj4gCj4gVW5kZXJzdG9vZCwgYnV0IHVzaW5nIHRoZSBjb21tYW5kIGxpbmUgaGFzIGl0 cyB3YXJ0cyBhcyB3ZWxsOyBJIG5vdyByZWNhbGwgdGhlCj4gZGlzY3Vzc2lvbiBCam9ybiBhbmQg SSAgaGFkIHJlZ2FyZGluZyB0aGlzIG9wdGlvbi4gIEknbSBwcmV0dHkgc3VyZQo+IHRoYXQgdXBz dHJlYWFtIHdpbGwgbm90IGFsbG93IHRoZSBmb2xsb3dpbmcKPiBwb3NzaWJsZSBjb21tYW5kIGxp bmUga2VybmVsIHBhcmFtczoKPiAKPiAgICAgYnJjbSxlbmFibGUtbDFzcwo+ICAgICBwY2k9YnJj bSxlbnRhYmxlLWwxc3MKPiAKPiBCam9ybiBzdWdnZXN0ZWQgdXNpbmcgdGhlICBkb2N1bWVudGVk IGJ1dCAoSU1PKSBvYnNjdXJlICBhbmQgIHJhcmVseQo+IHVzZWQgIGZvcm1hdAo+IAo+ICAgICBw Y2k9Wzxkb21haW4+Ol08YnVzPjo8ZGV2Pi48ZnVuYz5bLzxkZXY+LjxmdW5jPl0qcGNpOjx2ZW5k b3I+OjxkZXZpY2U+Wzo8c3VidmVuZG9yPjo8c3ViZGV2aWNlPl0KPiAKPiBidXQgdGhpcyBpcyBq dXN0IGdvaW5nIGluIHRoZSB3cm9uZyBkaXJlY3Rpb247IGhlcmUncyB3aHkuICBVc2luZyB0aGUK PiBhYm92ZSBpZm9ybWF0IHMgY29tcGxldGVseSBkZXBlbmRlbnQgb24gdGhlCj4gUENJICJsaW51 eC1kb21haWluIiAgcHJvcGVydHksICBhIG5vbi1IVyByZWxhdGVkIERUIHByb3BlcnR5IEkgIG1p Z2h0Cj4gYWRkLiAgU2luY2UgImxpbnV4LWRvbWFpbiIgaXMgYWxyZWFkeQo+IGEgdmFsaWQgYW5k IHdlbGwtdXNlZCAgRFQgcHJvcGVydHksIGFuZCB0aGUgdmFsdWUgb2YgIHRoZSBhYm92ZQo+IGNv bW1hbmQgbGluZSBmb3JtYXQgaXMgZGVwZW5kZW50Cj4gb24gdGhlIHZhbHVlIG9mIHRoZSAibGlu dXgtZG9tYWluIiwgd2h5IG5vdCBiZSBjb25zaXN0ZW50IGFuZCBsZXQKPiAiYnJjbSxlbmFibGUt bDFzcyIgYmUgYSBCcm9hZGNvbSBzcGVjaWZpYyBwcm9wZXJ0eT8KCkkgYW0ganVzdCBhc2tpbmcg dG8gYWRkIGEgbW9kdWxlX3BhcmFtIHRvIHRoZSBob3N0IGNvbnRyb2xsZXIgZHJpdmVyLgoKQW55 d2F5IC0gdGltZSBpcyBydW5uaW5nIG91dCBmb3IgdjYuNiwgSSBuZWVkIFJvYidzIGZlZWRiYWNr LCBpZiBJIGRvbid0CmhlYXIgZnJvbSBoaW0gdG9kYXkgSSB3aWxsIG1lcmdlIHRoZSBsYXN0IHRo cmVlIHBhdGNoZXMgYW5kIHBvc3Rwb25lIHRoZQpkaXNjdXNzaW9uLgoKVGhhbmtzLApMb3Jlbnpv Cgo+IAo+IFJlZ2FyZHMsCj4gSmltIFF1aW5sYW4KPiBCcm9hZGNvbSBTVEIvQ00KPiAKPiAKPiA+ Cj4gPiBUaGFua3MsCj4gPiBMb3JlbnpvCj4gPgo+ID4gPgo+ID4gPiBSZWdhcmRzLAo+ID4gPiBK aW0KPiA+ID4KPiA+ID4gPiBBZ2FpbiAtIGl0IGRlcGVuZHMgb24gd2hhdCBEVCBzaG91bGQgYmUg dXNlZCBmb3IsIEkgYW0gbm90IGNsYWltaW5nIHRvCj4gPiA+ID4gaGF2ZSBhbnkgYXV0aG9yaXR5 IG9uIHRoYXQsIGp1c3QgYXNraW5nLgo+ID4gPiA+Cj4gPiA+ID4gVGhhbmtzLAo+ID4gPiA+IExv cmVuem8KPiA+ID4gPgo+ID4gPiA+ID4gKyAgICAgIHVzaW5nIGEgbWluaS1jYXJkIGNvbm5lY3Rv ciwgdGhpcyBtb2RlIG1heSBub3QgbWVldCB0aGUKPiA+ID4gPiA+ICsgICAgICBUQ1JMb24gbWF4 aW11bSB0aW1lIG9mIDQwMG5zLCBhcyBzcGVjaWZpZWQgaW4gMy4yLjUuMi4yCj4gPiA+ID4gPiAr ICAgICAgb2YgdGhlIFBDSSBFeHByZXNzIE1pbmkgQ0VNIDIuMCBzcGVjaWZpY2F0aW9uLgo+ID4g PiA+ID4gKyAgICB0eXBlOiBib29sZWFuCj4gPiA+ID4gPiArCj4gPiA+ID4gPiAgICBicmNtLHNj Yi1zaXplczoKPiA+ID4gPiA+ICAgICAgZGVzY3JpcHRpb246IHU2NCBnaXZpbmcgdGhlIDY0Yml0 IFBDSWUgbWVtb3J5Cj4gPiA+ID4gPiAgICAgICAgdmlld3BvcnQgc2l6ZSBvZiBhIG1lbW9yeSBj b250cm9sbGVyLiAgVGhlcmUgbWF5IGJlIHVwIHRvCj4gPiA+ID4gPiAtLQo+ID4gPiA+ID4gMi4x Ny4xCj4gPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4KPiA+Cj4gPgoKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==