From: Thierry Reding <thierry.reding@gmail.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Thierry Reding <treding@nvidia.com>, Peng Fan <peng.fan@nxp.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v1 0/1] tegra_mmc: get tap and trim from dts
Date: Wed, 23 Aug 2023 12:53:26 +0200 [thread overview]
Message-ID: <ZOXlJmZicgBUINlb@orome> (raw)
In-Reply-To: <20230819153501.77245-1-clamor95@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Sat, Aug 19, 2023 at 06:35:00PM +0300, Svyatoslav Ryhel wrote:
> Default-tap and default-trim values are used for eMMC setup
> mostly on T114+ devices. As for now, those values are hardcoded
> for T210 and ignored for all other Tegra generations. Fix this
> by passing tap and trim values from dts.
>
> This commit will cause regression on T210 (emmc may not work),
> fix is applied in tegra210.dtsi and will be sent next week.
Heh... I don't think so. If you already know that this will cause a
regression on Tegra210 you need to rework this. Adding regressions
accidentally is already bad enough, but doing so knowingly is a big
no-no.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-23 10:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 15:35 [PATCH v1 0/1] tegra_mmc: get tap and trim from dts Svyatoslav Ryhel
2023-08-19 15:35 ` [PATCH v1 1/1] mmc: tegra: get default-tap and default-trim from device tree Svyatoslav Ryhel
2023-08-23 11:03 ` Thierry Reding
2023-08-23 11:38 ` Svyatoslav Ryhel
2023-08-24 13:29 ` Thierry Reding
2023-08-24 13:33 ` Svyatoslav Ryhel
2023-08-23 12:02 ` Svyatoslav Ryhel
2023-08-24 13:30 ` Thierry Reding
2023-08-23 10:53 ` Thierry Reding [this message]
2023-08-23 11:30 ` [PATCH v1 0/1] tegra_mmc: get tap and trim from dts Svyatoslav Ryhel
2023-08-24 13:27 ` Thierry Reding
2023-08-24 13:31 ` Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOXlJmZicgBUINlb@orome \
--to=thierry.reding@gmail.com \
--cc=clamor95@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=peng.fan@nxp.com \
--cc=treding@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.