From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [nft PATCH] tests: shell: Stabilize sets/reset_command_0 test
Date: Wed, 23 Aug 2023 18:53:27 +0200 [thread overview]
Message-ID: <ZOY5h1wr2gue1Two@orbyte.nwl.cc> (raw)
In-Reply-To: <20230823095404.10494-1-phil@nwl.cc>
On Wed, Aug 23, 2023 at 11:54:04AM +0200, Phil Sutter wrote:
> Timeout/expiry value testing based on seconds is way too fragile,
> especially with slow debug kernels. Rewrite the unit to test
> minute-based values. This means it is no longer feasible to wait for
> values to sufficiently change, so instead specify an 'expires' value
> when creating the ruleset and drop the 'sleep' call.
>
> While being at it:
>
> - Combine 'get element' and 'reset element' calls into one, assert the
> relevant (sanitized) line appears twice in output instead of comparing
> with 'diff'.
> - Turn comments into 'echo' calls to help debugging if the test fails.
>
> Reported-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch applied.
prev parent reply other threads:[~2023-08-23 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 9:54 [nft PATCH] tests: shell: Stabilize sets/reset_command_0 test Phil Sutter
2023-08-23 16:53 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOY5h1wr2gue1Two@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.