From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C2710979 for ; Thu, 24 Aug 2023 15:15:46 +0000 (UTC) Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-d72b76f202bso7809131276.1 for ; Thu, 24 Aug 2023 08:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692890145; x=1693494945; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=BCC0wwp7wWSIy0MrdACmgS4Vp0ye9VEhwI7wuPMec4A=; b=FtVfL5Tf+6L+aGO+3VLVFfVEdfsELAv/SkE1PTKpiAC3gFVBjTzmjrn/G6noL3tCwT nY/EAJeRp1nUZ1X8yuA3Jxf69ZaoSNHuvOQh3ULPUAYpMu4LVrXdZw1h4nH2PAlfwGQ5 HGQOfNLw0wvbAHb80uzDgzcI3HY8lXjzMoOoHDVH4Pz8HXQOOW7DfntGjjOL04U2gBH5 ZxYs546ol999Lp9xjtgeFXwtR0AaARSkkT0m/gVyhfqtUMb/pTpVMTXHfDw9wPW17NyP 1E6e3/AVVS3EyluWhAt1DasCBBld/p7NdQ0UhAyRFy01f8SCDMvj/nvu0ZKPtEv3L+Gt UNqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692890145; x=1693494945; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BCC0wwp7wWSIy0MrdACmgS4Vp0ye9VEhwI7wuPMec4A=; b=Z79lgqGakv4EihLesq3WpzgQ/669/yEPhd/sVjnmyieunxIYBRBzNVIMzLhDV25WfK s9N70x1zYgKBCMT4UZWMA1CDreZNhR+U4FrlWo6r7kNEhCH78VL4WLCTPCxTecZ2+Z14 gIjVSf40Es2sD9KYsl/qmaVOZrNnfyS/B49Np4Z612B4ALDsuT/Wu1asdE6MsMLYGYO9 4MnymT1jv8+8eYsryQDodz+JGppaBaGKerQ6syP3Qh8XwRfjUuMfRcEzE+2FP6nPTFiS nAvNIGATH/rLSpTotwsHffp/syVt0Is0K16Yllop7Qc8MgDJ6U9lS2+K3W+Xlx712wsB 6P2w== X-Gm-Message-State: AOJu0Yzvg66dCPQak/Ntc6/aBWg/11hiteJBSB3h5fzN9APgHMcUw1r2 f442zG9xZmRNq6Azmp9Ll859q4BctZs= X-Google-Smtp-Source: AGHT+IEE5MT+OR26AI25mjbMCPL/tYmhkhOKeyxLgW2HJM/WWK+y8/HYNn2t4mxnVIC7aAY/Rh8OZ4/3wmA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:2484:0:b0:d74:cdd7:d491 with SMTP id k126-20020a252484000000b00d74cdd7d491mr186602ybk.5.1692890145678; Thu, 24 Aug 2023 08:15:45 -0700 (PDT) Date: Thu, 24 Aug 2023 08:15:44 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230704075054.3344915-1-stevensd@google.com> <20230704075054.3344915-6-stevensd@google.com> <20230705102547.hr2zxkdkecdxp5tf@linux.intel.com> Message-ID: Subject: Re: [PATCH v7 5/8] KVM: x86/mmu: Don't pass FOLL_GET to __kvm_follow_pfn From: Sean Christopherson To: David Stevens Cc: Yu Zhang , Marc Zyngier , Michael Ellerman , Peter Xu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 24, 2023, David Stevens wrote: > On Wed, Jul 5, 2023 at 7:25=E2=80=AFPM Yu Zhang wrote: > > > > On Tue, Jul 04, 2023 at 04:50:50PM +0900, David Stevens wrote: > > > @@ -4529,7 +4540,8 @@ static int kvm_tdp_mmu_page_fault(struct kvm_vc= pu *vcpu, > > > > > > out_unlock: > > > read_unlock(&vcpu->kvm->mmu_lock); > > > - kvm_release_pfn_clean(fault->pfn); > > > > Yet kvm_release_pfn() can still be triggered for the kvm_vcpu_maped gfn= s. > > What if guest uses a non-referenced page(e.g., as a vmcs12)? Although I > > believe this is not gonna happen in real world... >=20 > kvm_vcpu_map still uses gfn_to_pfn, which eventually passes FOLL_GET > to __kvm_follow_pfn. So if a guest tries to use a non-refcounted page > like that, then kvm_vcpu_map will fail and the guest will probably > crash. It won't trigger any bugs in the host, though. >=20 > It is unfortunate that the guest will be able to use certain types of > memory for some purposes but not for others. However, while it is > theoretically fixable, it's an unreasonable amount of work for > something that, as you say, nobody really cares about in practice [1]. >=20 > [1] https://lore.kernel.org/all/ZBEEQtmtNPaEqU1i@google.com/ There are use cases that care, which is why I suggested allow_unsafe_kmap. Specifically, AWS manages their pool of guest memory in userspace and maps = it all via /dev/mem. Without that module param to let userspace opt-in, this seri= es will break such setups. It still arguably is a breaking change since it require= s userspace to opt-in, but allowing such behavior by default is simply not a = viable option, and I don't have much sympathy since so much of this mess has its o= rigins in commit e45adf665a53 ("KVM: Introduce a new guest mapping API"). The use cases that no one cares about (AFAIK) is allowing _untrusted_ users= pace to back guest RAM with arbitrary memory. In other words, I want KVM to all= ow (by default) mapping device memory into the guest for things like vGPUs, wi= thout having to do the massive and invasive overhaul needed to safely allow backi= ng guest RAM with completely arbitrary memory. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDB9EC6FA8F for ; Thu, 24 Aug 2023 15:16:45 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=FtVfL5Tf; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RWmrr0pjcz3cCC for ; Fri, 25 Aug 2023 01:16:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=FtVfL5Tf; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::b4a; helo=mail-yb1-xb4a.google.com; envelope-from=3ixtnzaykdnqi40d926ee6b4.2ecb8dknff2-34lb8iji.epb01i.eh6@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RWmqt6Bl9z30XM for ; Fri, 25 Aug 2023 01:15:53 +1000 (AEST) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d7475f45d31so6086503276.0 for ; Thu, 24 Aug 2023 08:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692890145; x=1693494945; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=BCC0wwp7wWSIy0MrdACmgS4Vp0ye9VEhwI7wuPMec4A=; b=FtVfL5Tf+6L+aGO+3VLVFfVEdfsELAv/SkE1PTKpiAC3gFVBjTzmjrn/G6noL3tCwT nY/EAJeRp1nUZ1X8yuA3Jxf69ZaoSNHuvOQh3ULPUAYpMu4LVrXdZw1h4nH2PAlfwGQ5 HGQOfNLw0wvbAHb80uzDgzcI3HY8lXjzMoOoHDVH4Pz8HXQOOW7DfntGjjOL04U2gBH5 ZxYs546ol999Lp9xjtgeFXwtR0AaARSkkT0m/gVyhfqtUMb/pTpVMTXHfDw9wPW17NyP 1E6e3/AVVS3EyluWhAt1DasCBBld/p7NdQ0UhAyRFy01f8SCDMvj/nvu0ZKPtEv3L+Gt UNqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692890145; x=1693494945; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BCC0wwp7wWSIy0MrdACmgS4Vp0ye9VEhwI7wuPMec4A=; b=N2knIYCeSySIfFexQCKbv/Bk6pEAbIxpm/mOg/jRnQkqa+sZgyg3uWCrZyD7wHWdqt l63lsUjvciVMd/+f8pmedzK9LbD4weTvFJR1qYDgJIl+0/51aWTeypzJ5hJSxAwtAAJE nPLvxE1v892x1trxIU4vlWDuGrS1GMrYrN4wq3guQbYdDDSVl+zJX2UW7Z7wRtdNxnyR wNz7Nv9/j3GJOatn24hAso3sGQIY3igBVMy0Q9w4AxFZA5wH75C3tZEqnCEmjUMV1J8F Imbc6ZZiYaTFYH7sY8upGkT6ZmdC215+c//Wu+baEZhzy2+km4kdfVk/678HuOM0ILfg NB6Q== X-Gm-Message-State: AOJu0YxpAqv2MKPE4Wt/hvU3lUiRvv7TiDAWd8TKKkUM4HEskEKKxO6P ok+uenI9RzKJ+U0fYoBdjE479C2Lh+8= X-Google-Smtp-Source: AGHT+IEE5MT+OR26AI25mjbMCPL/tYmhkhOKeyxLgW2HJM/WWK+y8/HYNn2t4mxnVIC7aAY/Rh8OZ4/3wmA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:2484:0:b0:d74:cdd7:d491 with SMTP id k126-20020a252484000000b00d74cdd7d491mr186602ybk.5.1692890145678; Thu, 24 Aug 2023 08:15:45 -0700 (PDT) Date: Thu, 24 Aug 2023 08:15:44 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230704075054.3344915-1-stevensd@google.com> <20230704075054.3344915-6-stevensd@google.com> <20230705102547.hr2zxkdkecdxp5tf@linux.intel.com> Message-ID: Subject: Re: [PATCH v7 5/8] KVM: x86/mmu: Don't pass FOLL_GET to __kvm_follow_pfn From: Sean Christopherson To: David Stevens Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Marc Zyngier , linux-kernel@vger.kernel.org, Peter Xu , Yu Zhang , kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Aug 24, 2023, David Stevens wrote: > On Wed, Jul 5, 2023 at 7:25=E2=80=AFPM Yu Zhang wrote: > > > > On Tue, Jul 04, 2023 at 04:50:50PM +0900, David Stevens wrote: > > > @@ -4529,7 +4540,8 @@ static int kvm_tdp_mmu_page_fault(struct kvm_vc= pu *vcpu, > > > > > > out_unlock: > > > read_unlock(&vcpu->kvm->mmu_lock); > > > - kvm_release_pfn_clean(fault->pfn); > > > > Yet kvm_release_pfn() can still be triggered for the kvm_vcpu_maped gfn= s. > > What if guest uses a non-referenced page(e.g., as a vmcs12)? Although I > > believe this is not gonna happen in real world... >=20 > kvm_vcpu_map still uses gfn_to_pfn, which eventually passes FOLL_GET > to __kvm_follow_pfn. So if a guest tries to use a non-refcounted page > like that, then kvm_vcpu_map will fail and the guest will probably > crash. It won't trigger any bugs in the host, though. >=20 > It is unfortunate that the guest will be able to use certain types of > memory for some purposes but not for others. However, while it is > theoretically fixable, it's an unreasonable amount of work for > something that, as you say, nobody really cares about in practice [1]. >=20 > [1] https://lore.kernel.org/all/ZBEEQtmtNPaEqU1i@google.com/ There are use cases that care, which is why I suggested allow_unsafe_kmap. Specifically, AWS manages their pool of guest memory in userspace and maps = it all via /dev/mem. Without that module param to let userspace opt-in, this seri= es will break such setups. It still arguably is a breaking change since it require= s userspace to opt-in, but allowing such behavior by default is simply not a = viable option, and I don't have much sympathy since so much of this mess has its o= rigins in commit e45adf665a53 ("KVM: Introduce a new guest mapping API"). The use cases that no one cares about (AFAIK) is allowing _untrusted_ users= pace to back guest RAM with arbitrary memory. In other words, I want KVM to all= ow (by default) mapping device memory into the guest for things like vGPUs, wi= thout having to do the massive and invasive overhaul needed to safely allow backi= ng guest RAM with completely arbitrary memory. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F94AC3DA6F for ; Thu, 24 Aug 2023 15:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=tEP4Vfajqy9ofevjWzsE7hOuBgQgQRJxkvDmbsCg8Vk=; b=pQOO0lLN/PPAmAXwwzFmSCsJ4X J95X50fiKuXxyn6QTu3wXwttKo0CzZAvKBAXT1vJMcJvFQQeYbBxUwGxu28K0ghWQvvft/12nXQ+V XU4Inml+0VVQNGe9cqLS30vTHPLS6IIBcaJv0cv/6AEkruhdckRty6gRWgCc/GUJiamxNj2f4IRiB CIH0WdhH9llxcCZ2NpGwzVd3fQCi712MHL2eqis59U0JsHU9poWENvLlT66PsnlWQ2vDzelIEqoUi XlAHmKJ+3+OO69ptqP8G95gY1tWQhPNOk8X508ss9CMxCJuh3GxZ2nb57x7ZsXjxf/+5SuNAlHwbA N+/VLjvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZC3t-003LQs-1I; Thu, 24 Aug 2023 15:15:53 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZC3q-003LPl-1P for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2023 15:15:51 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d6adc83eb10so7807063276.2 for ; Thu, 24 Aug 2023 08:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692890145; x=1693494945; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=BCC0wwp7wWSIy0MrdACmgS4Vp0ye9VEhwI7wuPMec4A=; b=FtVfL5Tf+6L+aGO+3VLVFfVEdfsELAv/SkE1PTKpiAC3gFVBjTzmjrn/G6noL3tCwT nY/EAJeRp1nUZ1X8yuA3Jxf69ZaoSNHuvOQh3ULPUAYpMu4LVrXdZw1h4nH2PAlfwGQ5 HGQOfNLw0wvbAHb80uzDgzcI3HY8lXjzMoOoHDVH4Pz8HXQOOW7DfntGjjOL04U2gBH5 ZxYs546ol999Lp9xjtgeFXwtR0AaARSkkT0m/gVyhfqtUMb/pTpVMTXHfDw9wPW17NyP 1E6e3/AVVS3EyluWhAt1DasCBBld/p7NdQ0UhAyRFy01f8SCDMvj/nvu0ZKPtEv3L+Gt UNqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692890145; x=1693494945; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BCC0wwp7wWSIy0MrdACmgS4Vp0ye9VEhwI7wuPMec4A=; b=VYjGTlL8ewLMHAB/H/wkJDd6VWmmoRvAIS7ICzTvcswmtjxcksJ7KINkWxNL9ygBC2 O1zaAlxxE8CSKpRh0/b/7GHdixCYJfnwb7Iujwo2PhL7bx89FdzBMO55wymGPrI+0sAn JlhcMZ63li/AZBz7r9mhQmxDO0QdPlQ7cuFS5sjYm41Y/VWsph70wyvcBTG3CcDfCGfP x0Krnj6Pzxt5Rs1Eq77bHymZrvOhHbEF3d4eoSrizJ6OCmImGFxyU7eZ6qNsUioeB7xA HYZRX+t9c1rd1i3NEQASk5aG+kx9JqYDjgmNIKocHyZL7PJGGAMwM8wL4atqmIIQ+t01 Qftg== X-Gm-Message-State: AOJu0YzLW77GwtCT+6fLEs8+0nXfAOe8vBQxVDP2wI+XgkDOXib+hlDk a2avslqpPjipo5JXG/2h3UTcP+uEFQ0= X-Google-Smtp-Source: AGHT+IEE5MT+OR26AI25mjbMCPL/tYmhkhOKeyxLgW2HJM/WWK+y8/HYNn2t4mxnVIC7aAY/Rh8OZ4/3wmA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:2484:0:b0:d74:cdd7:d491 with SMTP id k126-20020a252484000000b00d74cdd7d491mr186602ybk.5.1692890145678; Thu, 24 Aug 2023 08:15:45 -0700 (PDT) Date: Thu, 24 Aug 2023 08:15:44 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230704075054.3344915-1-stevensd@google.com> <20230704075054.3344915-6-stevensd@google.com> <20230705102547.hr2zxkdkecdxp5tf@linux.intel.com> Message-ID: Subject: Re: [PATCH v7 5/8] KVM: x86/mmu: Don't pass FOLL_GET to __kvm_follow_pfn From: Sean Christopherson To: David Stevens Cc: Yu Zhang , Marc Zyngier , Michael Ellerman , Peter Xu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_081550_477887_4C99342E X-CRM114-Status: GOOD ( 19.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBdWcgMjQsIDIwMjMsIERhdmlkIFN0ZXZlbnMgd3JvdGU6Cj4gT24gV2VkLCBKdWwg NSwgMjAyMyBhdCA3OjI14oCvUE0gWXUgWmhhbmcgPHl1LmMuemhhbmdAbGludXguaW50ZWwuY29t PiB3cm90ZToKPiA+Cj4gPiBPbiBUdWUsIEp1bCAwNCwgMjAyMyBhdCAwNDo1MDo1MFBNICswOTAw LCBEYXZpZCBTdGV2ZW5zIHdyb3RlOgo+ID4gPiBAQCAtNDUyOSw3ICs0NTQwLDggQEAgc3RhdGlj IGludCBrdm1fdGRwX21tdV9wYWdlX2ZhdWx0KHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKPiA+ID4K PiA+ID4gIG91dF91bmxvY2s6Cj4gPiA+ICAgICAgIHJlYWRfdW5sb2NrKCZ2Y3B1LT5rdm0tPm1t dV9sb2NrKTsKPiA+ID4gLSAgICAga3ZtX3JlbGVhc2VfcGZuX2NsZWFuKGZhdWx0LT5wZm4pOwo+ ID4KPiA+IFlldCBrdm1fcmVsZWFzZV9wZm4oKSBjYW4gc3RpbGwgYmUgdHJpZ2dlcmVkIGZvciB0 aGUga3ZtX3ZjcHVfbWFwZWQgZ2Zucy4KPiA+IFdoYXQgaWYgZ3Vlc3QgdXNlcyBhIG5vbi1yZWZl cmVuY2VkIHBhZ2UoZS5nLiwgYXMgYSB2bWNzMTIpPyBBbHRob3VnaCBJCj4gPiBiZWxpZXZlIHRo aXMgaXMgbm90IGdvbm5hIGhhcHBlbiBpbiByZWFsIHdvcmxkLi4uCj4gCj4ga3ZtX3ZjcHVfbWFw IHN0aWxsIHVzZXMgZ2ZuX3RvX3Bmbiwgd2hpY2ggZXZlbnR1YWxseSBwYXNzZXMgRk9MTF9HRVQK PiB0byBfX2t2bV9mb2xsb3dfcGZuLiBTbyBpZiBhIGd1ZXN0IHRyaWVzIHRvIHVzZSBhIG5vbi1y ZWZjb3VudGVkIHBhZ2UKPiBsaWtlIHRoYXQsIHRoZW4ga3ZtX3ZjcHVfbWFwIHdpbGwgZmFpbCBh bmQgdGhlIGd1ZXN0IHdpbGwgcHJvYmFibHkKPiBjcmFzaC4gSXQgd29uJ3QgdHJpZ2dlciBhbnkg YnVncyBpbiB0aGUgaG9zdCwgdGhvdWdoLgo+IAo+IEl0IGlzIHVuZm9ydHVuYXRlIHRoYXQgdGhl IGd1ZXN0IHdpbGwgYmUgYWJsZSB0byB1c2UgY2VydGFpbiB0eXBlcyBvZgo+IG1lbW9yeSBmb3Ig c29tZSBwdXJwb3NlcyBidXQgbm90IGZvciBvdGhlcnMuIEhvd2V2ZXIsIHdoaWxlIGl0IGlzCj4g dGhlb3JldGljYWxseSBmaXhhYmxlLCBpdCdzIGFuIHVucmVhc29uYWJsZSBhbW91bnQgb2Ygd29y ayBmb3IKPiBzb21ldGhpbmcgdGhhdCwgYXMgeW91IHNheSwgbm9ib2R5IHJlYWxseSBjYXJlcyBh Ym91dCBpbiBwcmFjdGljZSBbMV0uCj4gCj4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2Fs bC9aQkVFUXRtdE5QYUVxVTFpQGdvb2dsZS5jb20vCgpUaGVyZSBhcmUgdXNlIGNhc2VzIHRoYXQg Y2FyZSwgd2hpY2ggaXMgd2h5IEkgc3VnZ2VzdGVkIGFsbG93X3Vuc2FmZV9rbWFwLgpTcGVjaWZp Y2FsbHksIEFXUyBtYW5hZ2VzIHRoZWlyIHBvb2wgb2YgZ3Vlc3QgbWVtb3J5IGluIHVzZXJzcGFj ZSBhbmQgbWFwcyBpdCBhbGwKdmlhIC9kZXYvbWVtLiAgV2l0aG91dCB0aGF0IG1vZHVsZSBwYXJh bSB0byBsZXQgdXNlcnNwYWNlIG9wdC1pbiwgdGhpcyBzZXJpZXMgd2lsbApicmVhayBzdWNoIHNl dHVwcy4gIEl0IHN0aWxsIGFyZ3VhYmx5IGlzIGEgYnJlYWtpbmcgY2hhbmdlIHNpbmNlIGl0IHJl cXVpcmVzCnVzZXJzcGFjZSB0byBvcHQtaW4sIGJ1dCBhbGxvd2luZyBzdWNoIGJlaGF2aW9yIGJ5 IGRlZmF1bHQgaXMgc2ltcGx5IG5vdCBhIHZpYWJsZQpvcHRpb24sIGFuZCBJIGRvbid0IGhhdmUg bXVjaCBzeW1wYXRoeSBzaW5jZSBzbyBtdWNoIG9mIHRoaXMgbWVzcyBoYXMgaXRzIG9yaWdpbnMK aW4gY29tbWl0IGU0NWFkZjY2NWE1MyAoIktWTTogSW50cm9kdWNlIGEgbmV3IGd1ZXN0IG1hcHBp bmcgQVBJIikuCgpUaGUgdXNlIGNhc2VzIHRoYXQgbm8gb25lIGNhcmVzIGFib3V0IChBRkFJSykg aXMgYWxsb3dpbmcgX3VudHJ1c3RlZF8gdXNlcnNwYWNlCnRvIGJhY2sgZ3Vlc3QgUkFNIHdpdGgg YXJiaXRyYXJ5IG1lbW9yeS4gIEluIG90aGVyIHdvcmRzLCBJIHdhbnQgS1ZNIHRvIGFsbG93Cihi eSBkZWZhdWx0KSBtYXBwaW5nIGRldmljZSBtZW1vcnkgaW50byB0aGUgZ3Vlc3QgZm9yIHRoaW5n cyBsaWtlIHZHUFVzLCB3aXRob3V0CmhhdmluZyB0byBkbyB0aGUgbWFzc2l2ZSBhbmQgaW52YXNp dmUgb3ZlcmhhdWwgbmVlZGVkIHRvIHNhZmVseSBhbGxvdyBiYWNraW5nIGd1ZXN0ClJBTSB3aXRo IGNvbXBsZXRlbHkgYXJiaXRyYXJ5IG1lbW9yeS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK