From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Martin Zaťovič" <m.zatovic1@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linus.walleij@linaro.org, quic_jhugo@quicinc.com,
nipun.gupta@amd.com, tzimmermann@suse.de, ogabbay@kernel.org,
mathieu.poirier@linaro.org, axboe@kernel.dk,
damien.lemoal@opensource.wdc.com, linux@zary.sk, arnd@arndb.de,
yangyicong@hisilicon.com, benjamin.tissoires@redhat.com,
masahiroy@kernel.org, jacek.lawrynowicz@linux.intel.com,
geert+renesas@glider.be, devicetree@vger.kernel.org
Subject: Re: [PATCHv5 2/4] wiegand: add Wiegand bus driver
Date: Thu, 24 Aug 2023 16:28:05 +0300 [thread overview]
Message-ID: <ZOda5RY/2yW6Y63Q@smile.fi.intel.com> (raw)
In-Reply-To: <ZOdSudrhg/9u3a9N@fedora>
On Thu, Aug 24, 2023 at 02:53:13PM +0200, Martin Zaťovič wrote:
> On Thu, Aug 24, 2023 at 01:40:35PM +0200, Greg KH wrote:
> > On Thu, Aug 24, 2023 at 01:10:13PM +0200, Martin Zaťovič wrote:
...
> > > +static inline void wiegand_controller_put(void *ptr)
> >
> > Why is this a void *? It should be "struct wiegand_controller *"
>
> It is a void* because it is being passed to devm_add_action_or_reset()
> and this function only accepts a pointer to a function that accepts a void*
> parameter. I am not sure if there is a way around it.
I just replied with a deeper review with the answer to this.
> > Please never use void * if at all possible.
Correct. We better to have a type checking when possible. Esp. for the exported
functions.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-24 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 11:10 [PATCHv5 0/4] Wiegand bus driver and GPIO bitbanged controller Martin Zaťovič
2023-08-24 11:10 ` [PATCHv5 1/4] dt-bindings: wiegand: add Wiegand controller common properties Martin Zaťovič
2023-08-24 13:37 ` Rob Herring
2023-08-25 13:17 ` Martin Zaťovič
2023-08-24 11:10 ` [PATCHv5 2/4] wiegand: add Wiegand bus driver Martin Zaťovič
2023-08-24 11:40 ` Greg KH
2023-08-24 12:53 ` Martin Zaťovič
2023-08-24 13:08 ` Greg KH
2023-08-24 13:28 ` Andy Shevchenko [this message]
2023-08-24 13:26 ` Andy Shevchenko
2023-08-24 11:10 ` [PATCHv5 3/4] dt-bindings: wiegand: add GPIO bitbanged Wiegand controller Martin Zaťovič
2023-08-24 12:32 ` Rob Herring
2023-08-24 13:40 ` Rob Herring
2023-08-24 11:10 ` [PATCHv5 4/4] wiegand: add Wiegand GPIO bitbanged controller driver Martin Zaťovič
2023-08-24 13:35 ` Andy Shevchenko
2023-08-24 13:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOda5RY/2yW6Y63Q@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=benjamin.tissoires@redhat.com \
--cc=conor+dt@kernel.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@zary.sk \
--cc=m.zatovic1@gmail.com \
--cc=masahiroy@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nipun.gupta@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.