Re: [PATCH v1 1/2] verdin-am62: add u-boot update wrappers

[Francesco Dolcini <francesco@dolcini.it>]

Hello Nishanth,

On Thu, Aug 24, 2023 at 07:10:57AM -0500, Nishanth Menon wrote:
> On 13:19-20230824, Francesco Dolcini wrote:
> > On Thu, Aug 24, 2023 at 10:08:49AM +0200, Emanuele Ghidoli wrote:
> > > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> > > 
> > > Add update_tiboot3, update_tispl and update_uboot wrappers to update
> > > R5 SPL, A53 SPL and A53 U-boot respectively.
> > > 
> > > Usage example:
> > > > tftpboot ${loadaddr} tiboot3-am62x-gp-verdin.bin
> > > > run update_tiboot3
> > > 
> > > > tftpboot ${loadaddr} tispl.bin
> > > > run update_tispl
> > > 
> > > > tftpboot ${loadaddr} u-boot.img
> > > > run update_uboot
> > > 
> > > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> > 
> > Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Should you update documentation to indicate the usage?

Yeah, probably we could add it. I would not remove the existing direct
command usage since this is adding just env variables that could be
removed from the env even at runtime.

In general the reason for these commands is that our users are
accustomed to have a "guided" way to update u-boot without having to dig
into the documentation. They are just convenient.

Marcel: what do you think?

Francesco