From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com,
gregory.f.germano@intel.com, matthew.d.roper@intel.com,
tomasz.mistat@intel.com, nirmoy.das@intel.com
Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123
Date: Thu, 24 Aug 2023 16:57:12 +0200 [thread overview]
Message-ID: <ZOdvyEHfjKQ7WG4I@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230823185104.1994138-3-jonathan.cavitt@intel.com>
Hi Jonathan,
> + /* Wa_16018031267, Wa_16018063123 */
> + if (engine->class == COPY_ENGINE_CLASS &&
> + NEEDS_FASTCOLOR_BLT_WABB(i915))
maybe we should have something like
gt_needs_wa_XXX(struct intel_gt *gt)
engine_needs_wa_XXX(struct intel_engine_ce *engine)
Just thinking aloud here, not relevant to this series.
Andi
> + wa_masked_field_set(wal, ECOSKPD(engine->mmio_base),
> + XEHP_BLITTER_SCHEDULING_MODE_MASK,
> + XEHP_BLITTER_ROUND_ROBIN_MODE);
> }
>
> static void
> --
> 2.25.1
next prev parent reply other threads:[~2023-08-24 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 18:51 [Intel-gfx] [PATCH v2 0/2] Apply Wa_16018031267 / Wa_16018063123 Jonathan Cavitt
2023-08-23 18:51 ` [Intel-gfx] [PATCH v2 1/2] drm/i915: Add WABB blit for " Jonathan Cavitt
2023-08-24 14:53 ` Andi Shyti
2023-08-24 15:01 ` Cavitt, Jonathan
2023-08-24 17:57 ` Matt Roper
2023-08-23 18:51 ` [Intel-gfx] [PATCH v2 2/2] drm/i915: Set copy engine arbitration " Jonathan Cavitt
2023-08-24 14:57 ` Andi Shyti [this message]
2023-08-23 21:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123 (rev2) Patchwork
2023-08-23 21:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-23 21:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-08-24 21:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123 (rev3) Patchwork
2023-08-24 21:09 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-24 21:24 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOdvyEHfjKQ7WG4I@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=gregory.f.germano@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=nirmoy.das@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tomasz.mistat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.