From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72E92C83F11 for ; Mon, 28 Aug 2023 10:56:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3257374C; Mon, 28 Aug 2023 12:55:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3257374C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1693220198; bh=93Q1+09FZxhS4XNoxqvDb1t4zqKJ0lCyw9SI6NZjvGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=UJJ9MNuPryMpLtRvWfRJqdpdHNE5+Gs90RiOVbmtZsA/TsDf0QFiC/rLrH3m5YU06 Wo0LfFHVEZ0t9TB/7vEAICnpNi512POEetY2GaQS30P1JGo/gaekWpJyRQb6nyWOs5 aE2nqNKYFRUOOwnr811DfHyXpC7XUZGNP3TB0lnI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C093CF80094; Mon, 28 Aug 2023 12:55:27 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 62DA2F80158; Mon, 28 Aug 2023 12:55:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A3EE0F80158; Mon, 28 Aug 2023 12:55:24 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 63F23F80094 for ; Mon, 28 Aug 2023 12:55:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 63F23F80094 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=UPnxuJD3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693220123; x=1724756123; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=93Q1+09FZxhS4XNoxqvDb1t4zqKJ0lCyw9SI6NZjvGQ=; b=UPnxuJD3r9HNmK+pDa7d2SMHCJYC2rcQNfAVTb99WeFIwBPSEjHNlSHW 0+zHvRABzutUMGuFGs96otHPZ9QP2fuiJ0PHf4yFRa+SYUtm5L3luaEtw iUJX6y6XmTJyEPNFxv+F6kUTZdCypgBDG1q3EXOCAwIw/v3z2gXymWaq5 4Bf1TYQetjHf5VdVPNtzdAVdLng0gFhCIPWmq4LKMxV4ZzvmE94tZHKeF PGbanIqK4k42YJ+061/ezfHAFTGLLMKvi/+dXqnsdDMUOotS5ndOR4Qu9 LXmTdjfbL7NmiYo2f/ppDRkb2uBSBw8KUGD2WT6zUnmTZWJ8rvNtAh8uj A==; X-IronPort-AV: E=McAfee;i="6600,9927,10815"; a="373962709" X-IronPort-AV: E=Sophos;i="6.02,207,1688454000"; d="scan'208";a="373962709" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 03:55:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10815"; a="738201863" X-IronPort-AV: E=Sophos;i="6.02,207,1688454000"; d="scan'208";a="738201863" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 28 Aug 2023 03:55:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qaZtr-00F6Ig-0Y; Mon, 28 Aug 2023 13:55:15 +0300 Date: Mon, 28 Aug 2023 13:55:14 +0300 From: Andy Shevchenko To: Biju Das Cc: Lee Jones , Charles Keepax , Richard Fitzgerald , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Geert Uytterhoeven , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] mfd: madera-i2c: Simplify probe() Message-ID: References: <20230826091751.51634-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230826091751.51634-1-biju.das.jz@bp.renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: AZINCICXE3WZT5HWH2Q3VRYKZNFRYAMW X-Message-ID-Hash: AZINCICXE3WZT5HWH2Q3VRYKZNFRYAMW X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, Aug 26, 2023 at 10:17:51AM +0100, Biju Das wrote: > Simplify probe() by replacing of_device_get_match_data() and ID lookup for > retrieving match data by i2c_get_match_data(). ... > - of_data = of_device_get_match_data(&i2c->dev); > - if (of_data) > - type = (unsigned long)of_data; > - else > - type = id->driver_data; > + type = (unsigned long)i2c_get_match_data(i2c); > This blank line is not needed after this change. > switch (type) { -- With Best Regards, Andy Shevchenko