From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <helgaas@kernel.org>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] MIPS: TXx9: Do PCI error checks on own line
Date: Mon, 28 Aug 2023 11:10:59 +0200 [thread overview]
Message-ID: <ZOxko5RB0ZilMHv5@alpha.franken.de> (raw)
In-Reply-To: <20230827133705.12991-3-ilpo.jarvinen@linux.intel.com>
On Sun, Aug 27, 2023 at 04:36:59PM +0300, Ilpo Järvinen wrote:
> Instead of if conditions with line splits, use the usual error handling
> pattern with a separate variable to improve readability.
>
> The second check can use reverse logic which reduces indentation level.
>
> No functional changes intended.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> arch/mips/txx9/generic/pci.c | 43 +++++++++++++++++++-----------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2023-08-28 9:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 13:36 [PATCH v2 0/8] PCI/treewide: Cleanup/streamline PCI error code handling Ilpo Järvinen
2023-08-27 13:36 ` [PATCH v2 1/8] alpha: Streamline convoluted PCI error handling Ilpo Järvinen
2023-08-27 13:36 ` Ilpo Järvinen
2023-08-27 13:36 ` [PATCH v2 2/8] MIPS: TXx9: Do PCI error checks on own line Ilpo Järvinen
2023-08-28 9:10 ` Thomas Bogendoerfer [this message]
2023-08-27 13:37 ` [PATCH v2 3/8] sh: pci: Do PCI error check " Ilpo Järvinen
2023-08-27 13:37 ` [PATCH v2 4/8] atm: iphase: Do PCI error checks " Ilpo Järvinen
2023-08-27 13:37 ` [PATCH v2 5/8] I2C: ali15x3: " Ilpo Järvinen
2023-08-28 22:10 ` Andi Shyti
2023-08-30 19:18 ` Wolfram Sang
2023-08-27 13:37 ` [PATCH v2 6/8] PCI: Do error check on own line to split long if conditions Ilpo Järvinen
2023-08-27 13:37 ` [PATCH v2 7/8] PCI: xgene: Do PCI error check on own line Ilpo Järvinen
2023-08-27 13:37 ` Ilpo Järvinen
2023-08-29 16:05 ` Rob Herring
2023-08-29 16:05 ` Rob Herring
2023-08-29 16:14 ` Ilpo Järvinen
2023-08-29 16:14 ` Ilpo Järvinen
2023-08-29 16:23 ` Ilpo Järvinen
2023-08-29 16:23 ` Ilpo Järvinen
2023-08-27 13:37 ` [PATCH v2 8/8] scsi: ipr: Do PCI error checks " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOxko5RB0ZilMHv5@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=andi.shyti@kernel.org \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.