From: Baoquan He <bhe@redhat.com>
To: Simon Horman <horms@kernel.org>
Cc: Hari Bathini <hbathini@linux.ibm.com>,
Kexec-ml <kexec@lists.infradead.org>
Subject: Re: [PATCH] kexec: update manpage with explicit mention of clean kexec
Date: Mon, 28 Aug 2023 17:42:05 +0800 [thread overview]
Message-ID: <ZOxr7VjBhBe6WW91@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20230828074810.GY3523530@kernel.org>
On 08/28/23 at 09:48am, Simon Horman wrote:
> On Mon, Aug 28, 2023 at 11:46:14AM +0530, Hari Bathini wrote:
> > Any comments on this, please..
>
> Hi Hari,
>
> Sorry, I had missed this.
>
> > On 07/07/23 10:59 am, Hari Bathini wrote:
> > > While the manpage does mention about kexec boot with a clean shutdown,
> > > it is not explicit about it. Make it explicit.
> > >
> > > Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
> > > ---
> > > kexec/kexec.8 | 12 ++++++++++--
> > > 1 file changed, 10 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/kexec/kexec.8 b/kexec/kexec.8
> > > index 3a344c5..87e4ab5 100644
> > > --- a/kexec/kexec.8
> > > +++ b/kexec/kexec.8
> > > @@ -95,8 +95,16 @@ then you would use the following command to load the kernel:
> > > .RB "\-\-append=" "root=/dev/hda1" "\ \-\-initrd=" /boot/initrd
> > > .RE
> > > .PP
> > > -After this kernel is loaded, it can be booted to at any time using the
> > > -command:
> > > +After this kernel is loaded, assuming your Linux distribution supports
> > > +kexec-based rebooting, it can be booted to, with a clean shutdown, using
> > > +the command:
>
> Perhaps user-space would be better than "your Linux distribution".
> But perhaps that is just kernel developer speak and makes less
> sense to others.
Agree, linux distrobution doesn't make sense here. And since this is a
kexec man page, does it really need to make this change? We know
kexec-tools loaded a kernel, we will use kexec-tools to trigger the
reboot. Wondering why we need to stress distros or kernel or kexec-tools
supports the kexec-based rebooting. 'with a clean shutdown' seems a
little helpful though.
>
> > > +
> > > +.RS
> > > +.BR reboot
> > > +.RE
> > > +.PP
> > > +Alternatively, it can also be booted to, without calling shutdown(8), with
> > > +the command:
> > >
> > > .RS
> > > .BR kexec \ \-e
> >
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2023-08-28 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 5:29 [PATCH] kexec: update manpage with explicit mention of clean kexec Hari Bathini
2023-08-28 6:16 ` Hari Bathini
2023-08-28 7:48 ` Simon Horman
2023-08-28 9:42 ` Baoquan He [this message]
2023-09-11 6:34 ` Hari Bathini
2023-09-20 11:41 ` Simon Horman
2023-09-20 12:01 ` Hari Bathini
2023-08-28 10:27 ` Hari Bathini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOxr7VjBhBe6WW91@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=hbathini@linux.ibm.com \
--cc=horms@kernel.org \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.