From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Lee Jones <lee@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] mfd: max77541: Simplify probe()
Date: Mon, 28 Aug 2023 14:20:27 +0300 [thread overview]
Message-ID: <ZOyC++vjeg4TGCpx@smile.fi.intel.com> (raw)
In-Reply-To: <20230826091020.45621-1-biju.das.jz@bp.renesas.com>
On Sat, Aug 26, 2023 at 10:10:20AM +0100, Biju Das wrote:
> Simplify probe() by replacing device_get_match_data() and ID lookup for
> retrieving match data by i2c_get_match_data().
>
> While at it, drop leading commas from OF table.
...
> - return -EINVAL;
> + return -ENODEV;
Why?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-28 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 9:10 [PATCH] mfd: max77541: Simplify probe() Biju Das
2023-08-28 11:20 ` Andy Shevchenko [this message]
2023-08-28 11:36 ` Biju Das
2023-08-28 11:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOyC++vjeg4TGCpx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=lee@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.