From: Nam Cao <namcaov@gmail.com>
To: Oliver Crumrine <ozlinux@hotmail.com>
Cc: gregkh@linuxfoundation.org, colin.i.king@gmail.com,
sumitraartsy@gmail.com, u.kleine-koenig@pengutronix.de,
geert@linux-m68k.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v4 1/6] staging: octeon: clean up the octeon ethernet driver
Date: Mon, 28 Aug 2023 16:23:29 +0200 [thread overview]
Message-ID: <ZOyt4QEYivtMVaFE@nam-dell> (raw)
In-Reply-To: <PH7PR11MB7643C65E067BAB032F930488BCE0A@PH7PR11MB7643.namprd11.prod.outlook.com>
On Mon, Aug 28, 2023 at 09:39:14AM -0400, Oliver Crumrine wrote:
> Make the octeon ethernet driver better adhere to the
> kernel coding standard
Try to be more specific with your description. For example, mention that the
patch remove typedef cvmx_spi_mode_t because "...". Same thing for your title,
it's way too generic.
Have a look at the accepted patches to see how commit messages should be written.
Best regards,
Nam
next prev parent reply other threads:[~2023-08-28 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1693229582.git.ozlinux@hotmail.com>
2023-08-28 13:39 ` [PATCH v4 1/6] staging: octeon: clean up the octeon ethernet driver Oliver Crumrine
2023-08-28 14:23 ` Nam Cao [this message]
2023-08-28 14:38 ` Nam Cao
2023-08-28 14:45 ` Greg KH
2023-08-28 13:39 ` [PATCH v4 2/6] " Oliver Crumrine
2023-08-28 13:39 ` [PATCH v4 3/6] " Oliver Crumrine
2023-08-28 13:39 ` [PATCH v4 4/6] " Oliver Crumrine
2023-08-28 13:39 ` [PATCH v4 5/6] " Oliver Crumrine
2023-08-28 13:39 ` [PATCH v4 6/6] " Oliver Crumrine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOyt4QEYivtMVaFE@nam-dell \
--to=namcaov@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ozlinux@hotmail.com \
--cc=sumitraartsy@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.