All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: Henry Wang <Henry.Wang@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	"michal.orzel@amd.com" <michal.orzel@amd.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [XEN][PATCH v10 03/20] xen/arm/device: Remove __init from function type
Date: Mon, 28 Aug 2023 09:21:50 -0700	[thread overview]
Message-ID: <ZOzJngLaiVrM6V_w@amd.com> (raw)
In-Reply-To: <2A11B6BD-60C3-49A6-9680-084E41EBCB6D@arm.com>

Hi Henry,
On Mon, Aug 28, 2023 at 01:53:15AM +0000, Henry Wang wrote:
> Hi Vikram,
> 
> > On Aug 25, 2023, at 16:02, Vikram Garhwal <vikram.garhwal@amd.com> wrote:
> > 
> > +
> > +/*
> > + * handle_device_interrupts retrieves the interrupts configuration from
> > + * a device tree node and maps those interrupts to the target domain.
> > + *
> > + * Returns:
> > + *   < 0 error
> > + *   0   success
> > + */
> > +int handle_device_interrupts(struct domain *d,
> > +                             struct dt_device_node *dev,
> > +                             bool need_mapping)
> 
> I think you missed one of Julien’s comment in v9 that this function is
> suggested to be renamed to "map_device_irqs_to_domain" [1].
> 
I sent v10 bit early. I will do the renaming in v11.

Thanks,
Vikram
> [1] https://lore.kernel.org/xen-devel/5908b638-f436-4060-a426-9839fc563c63@xen.org/
> 
> Kind regards,
> Henry
> 


  reply	other threads:[~2023-08-28 16:22 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  8:02 [XEN][PATCH v10 00/20] dynamic node programming using overlay dtbo Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 01/20] common/device_tree: handle memory allocation failure in __unflatten_device_tree() Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 02/20] common/device_tree.c: unflatten_device_tree() propagate errors Vikram Garhwal
2023-08-28  1:41   ` Henry Wang
2023-08-29  7:09   ` Michal Orzel
2023-08-29 22:24   ` Stefano Stabellini
2023-08-25  8:02 ` [XEN][PATCH v10 03/20] xen/arm/device: Remove __init from function type Vikram Garhwal
2023-08-28  1:53   ` Henry Wang
2023-08-28 16:21     ` Vikram Garhwal [this message]
2023-08-29  7:17   ` Michal Orzel
2023-08-30 17:16     ` Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 04/20] common/device_tree: Export __unflatten_device_tree() Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 05/20] xen/arm: Add CONFIG_OVERLAY_DTB Vikram Garhwal
2023-08-29  7:23   ` Michal Orzel
2023-08-30 17:16     ` Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 06/20] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 07/20] libfdt: overlay: change overlay_get_target() Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 08/20] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Vikram Garhwal
2023-08-28  1:59   ` Henry Wang
2023-08-29  7:41   ` Michal Orzel
2023-08-29 22:27   ` Stefano Stabellini
2023-08-25  8:02 ` [XEN][PATCH v10 09/20] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Vikram Garhwal
2023-08-29  8:05   ` Michal Orzel
2023-08-30 17:20     ` Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 10/20] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock Vikram Garhwal
2023-08-28 16:29   ` Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 11/20] xen/iommu: Introduce iommu_remove_dt_device() Vikram Garhwal
2023-08-29  8:23   ` Michal Orzel
2023-08-30 17:48     ` Vikram Garhwal
2023-08-31  0:35       ` Stefano Stabellini
2023-08-31  7:23       ` Michal Orzel
2023-08-31  7:32         ` Michal Orzel
2023-09-01  2:01           ` Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops Vikram Garhwal
2023-08-29  8:51   ` Michal Orzel
2023-08-29 22:45     ` Stefano Stabellini
2023-08-30  9:17       ` Michal Orzel
2023-08-25  8:02 ` [XEN][PATCH v10 13/20] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 14/20] common/device_tree: Add rwlock for dt_host Vikram Garhwal
2023-08-28 16:26   ` Vikram Garhwal
2023-08-29  9:27   ` Michal Orzel
2023-08-25  8:02 ` [XEN][PATCH v10 15/20] arm/asm/setup.h: Update struct map_range_data to add rangeset Vikram Garhwal
2023-08-29 12:16   ` Michal Orzel
2023-08-25  8:02 ` [XEN][PATCH v10 16/20] xen/arm: Implement device tree node removal functionalities Vikram Garhwal
2023-08-29 23:45   ` Stefano Stabellini
2023-08-25  8:02 ` [XEN][PATCH v10 17/20] xen/arm: Implement device tree node addition functionalities Vikram Garhwal
2023-08-29 23:45   ` Stefano Stabellini
2023-08-25  8:02 ` [XEN][PATCH v10 18/20] tools/libs/ctrl: Implement new xc interfaces for dt overlay Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 19/20] tools/libs/light: Implement new libxl functions for device tree overlay ops Vikram Garhwal
2023-08-25  8:02 ` [XEN][PATCH v10 20/20] tools/xl: Add new xl command overlay for device tree overlay support Vikram Garhwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOzJngLaiVrM6V_w@amd.com \
    --to=vikram.garhwal@amd.com \
    --cc=Bertrand.Marquis@arm.com \
    --cc=Henry.Wang@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.