From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, herve.codina@bootlin.com
Subject: Re: + minmax-deduplicate-__unconst_integer_typeof.patch added to mm-nonmm-unstable branch
Date: Tue, 12 Sep 2023 01:23:12 +0300 [thread overview]
Message-ID: <ZP+TUDTPpsJbdaio@smile.fi.intel.com> (raw)
In-Reply-To: <20230911145956.7b36e463d16583cede78b2b6@linux-foundation.org>
On Mon, Sep 11, 2023 at 02:59:56PM -0700, Andrew Morton wrote:
> On Tue, 12 Sep 2023 00:47:43 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
...
> > > -/*
> > > * Do not check the array parameter using __must_be_array().
> > > * In the following legit use-case where the "array" passed is a simple pointer,
> > > * __must_be_array() will return a failure.
> >
> > A side note: If you look at the original email and patch you will see a subtle
> > difference that makes patch better looking. It's because I started using
> > --patience when formatting them. Perhaps you can enable it in your scripts.
>
> Interesting, thanks.
>
> I use plain old diff :(. A while back I had everything working (I
> thought) using `git diff' instead but found that it was producing diffs that
> gave git-quiltimport a heart attack. Ran out of time, didn't debug,
> disabled it. I'll revisit at some point.
Ah, I see. I don't know good implementation of patience diff outside of
the Git, not sure then if you can enable it easily.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-09-12 2:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 18:25 + minmax-deduplicate-__unconst_integer_typeof.patch added to mm-nonmm-unstable branch Andrew Morton
2023-09-11 21:47 ` Andy Shevchenko
2023-09-11 21:59 ` Andrew Morton
2023-09-11 22:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP+TUDTPpsJbdaio@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.