From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8452CA0ECA for ; Mon, 11 Sep 2023 21:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241953AbjIKU52 (ORCPT ); Mon, 11 Sep 2023 16:57:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235915AbjIKJqV (ORCPT ); Mon, 11 Sep 2023 05:46:21 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 898C7E40; Mon, 11 Sep 2023 02:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694425576; x=1725961576; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IYRDvoE7lgXht+BNocpgzZz5d2+b/mY+Hmn7D6BVF4M=; b=J4gSuxhRFtHkb94hNxkn+zo7GEgp9pJKD+mkRgllj578RBiAoGOYVETz dZYsZJQxKkJqE53LrEKKijEg/ZlxeTELpwIS5PGQpda+wfuSD2p7AkkK7 +9GW96p2A4fOpnBZ0Sy4d6LesC3L2eBdjqoS83hkKylYMrcVQb/7vM0Yw EwRlGYAkljqqe/RH2KsBNFuvO61K/eJSpZrMK7yefYtbbnciZKIf/inw3 EDFGmJ/2RQUqk2pA71hGsliogKJVXA+Xwpr26Cnp4fLEiP4zN93GpJzwN UZhUU3fkUUccroDlmP30LQAnTAIfaItI1AWEi/tv0Zw+Ag/QL32/Tuoyb A==; X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="377956314" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="377956314" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 02:46:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="1074076621" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="1074076621" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 02:46:13 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qfdUg-008HX3-2R; Mon, 11 Sep 2023 12:46:10 +0300 Date: Mon, 11 Sep 2023 12:46:10 +0300 From: Andy Shevchenko To: Linhua Xu Cc: Linus Walleij , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, lh xu , Zhirong Qiu , Xiongpeng Wu Subject: Re: [PATCH V2 1/6] pinctrl: sprd: Modify the probe function parameters Message-ID: References: <20230908055146.18347-1-Linhua.xu@unisoc.com> <20230908055146.18347-2-Linhua.xu@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908055146.18347-2-Linhua.xu@unisoc.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Sep 08, 2023 at 01:51:41PM +0800, Linhua Xu wrote: > From: Linhua Xu > > For UNISOC pin controller, the offset values of the common register and > misc register will be different. Thus put these in the probe function > parameters. ... > +#define PINCTRL_REG_OFFSET 0x20 0x0020 to make it look as related to the other one, as they are of the same type: register offsets. > +#define PINCTRL_REG_MISC_OFFSET 0x4020 -- With Best Regards, Andy Shevchenko