From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH v2 0/4] Match data improvements for mcp23s08 driver
Date: Mon, 11 Sep 2023 13:10:36 +0300 [thread overview]
Message-ID: <ZP7nnIdwQCcOV6MY@smile.fi.intel.com> (raw)
In-Reply-To: <20230909121903.34062-1-biju.das.jz@bp.renesas.com>
On Sat, Sep 09, 2023 at 01:18:59PM +0100, Biju Das wrote:
> This patch series aims to add match data improvements for mcp23s08 driver.
> This patch series is only compile tested.
Now, do you see the common grounds for unifying two data structure types you
created?
IN the common header you may introduce a type and use it in the both files.
For the patches 1 & 3 (the API simplification):
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-09-11 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 12:18 [PATCH v2 0/4] Match data improvements for mcp23s08 driver Biju Das
2023-09-09 12:19 ` [PATCH v2 1/4] pinctrl: mcp23s08_i2c: Extend match support for OF tables Biju Das
2023-09-09 12:19 ` [PATCH v2 2/4] pinctrl: mcp23s08_i2c: Simplify probe() Biju Das
2023-09-09 12:19 ` [PATCH v2 3/4] pinctrl: mcp23s08_spi: " Biju Das
2023-09-09 12:19 ` [PATCH v2 4/4] pinctrl: mcp23s08_spi: Simplify mcp23s08_spi_regmap_init() Biju Das
2023-09-11 10:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP7nnIdwQCcOV6MY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.