From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Yury Norov <yury.norov@gmail.com>,
Uros Bizjak <ubizjak@gmail.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v1 1/1] bitops: Share BYTES_TO_BITS() for everyone
Date: Thu, 31 Aug 2023 16:21:30 +0300 [thread overview]
Message-ID: <ZPCT2vV0r8l/wxim@smile.fi.intel.com> (raw)
In-Reply-To: <a5574786-0a49-454d-67e3-571983e6a6e8@intel.com>
On Fri, Aug 25, 2023 at 04:49:07PM +0200, Alexander Lobakin wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Thu, 24 Aug 2023 15:37:28 +0300
>
> > It may be new callers for the same macro, share it.
> >
> > Note, it's unknown why it's represented in the current form instead of
> > simple multiplication and commit 1ff511e35ed8 ("tracing/kprobes: Add
> > bitfield type") doesn't explain that neither. Let leave it as is and
> > we may improve it in the future.
>
> Maybe symmetrical change in tools/ like I did[0] an aeon ago?
Hmm... Why can't you simply upstream your version? It seems better than mine.
> [0]
> https://github.com/alobakin/linux/commit/fd308001fe6d38837fe820427209a6a99e4850a8
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-31 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 12:37 [PATCH v1 1/1] bitops: Share BYTES_TO_BITS() for everyone Andy Shevchenko
2023-08-25 14:49 ` Alexander Lobakin
2023-08-30 7:16 ` Masami Hiramatsu
2023-08-31 13:21 ` Andy Shevchenko [this message]
2023-09-06 14:40 ` Alexander Lobakin
2023-09-06 14:54 ` Andy Shevchenko
2023-09-10 14:07 ` Yury Norov
2023-09-11 14:42 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPCT2vV0r8l/wxim@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=ubizjak@gmail.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.