Re: [PATCH for-8.2 v2 2/2] migration: Allow user to specify migration switchover bandwidth

[Peter Xu <peterx@redhat.com>]

On Thu, Aug 31, 2023 at 07:14:47PM +0100, Joao Martins wrote:
> On 03/08/2023 16:53, Peter Xu wrote:
> > @@ -2719,7 +2729,8 @@ static void migration_update_counters(MigrationState *s,
> >      update_iteration_initial_status(s);
> >  
> >      trace_migrate_transferred(transferred, time_spent,
> > -                              bandwidth, s->threshold_size);
> > +                              bandwidth, migrate_max_switchover_bandwidth(),
> > +                              s->threshold_size);
> >  }
> 
> (...)
> 
> > diff --git a/migration/trace-events b/migration/trace-events
> > index 4666f19325..1296b8db5b 100644
> > --- a/migration/trace-events
> > +++ b/migration/trace-events
> > @@ -185,7 +185,7 @@ source_return_path_thread_shut(uint32_t val) "0x%x"
> >  source_return_path_thread_resume_ack(uint32_t v) "%"PRIu32
> >  source_return_path_thread_switchover_acked(void) ""
> >  migration_thread_low_pending(uint64_t pending) "%" PRIu64
> > -migrate_transferred(uint64_t transferred, uint64_t time_spent, uint64_t bandwidth, uint64_t size) "transferred %" PRIu64 " time_spent %" PRIu64 " bandwidth %" PRIu64 " max_size %" PRId64
> > +migrate_transferred(uint64_t transferred, uint64_t time_spent, uint64_t bandwidth, uint64_t avail_bw, uint64_t size) "transferred %" PRIu64 " time_spent %" PRIu64 " bandwidth %" PRIu64 " avail_bw %" PRIu64 " max_size %" PRId64
> 
> Given your previous snippet, perhaps you meant to introduce
> 'max_switchover_bandwidth' arg, unless of course you meant in the callpath of
> the tracepoint to instead use @avail_bw as the variable to use?

Yeah, got it overlooked...  I'll fix that when repost, thanks.

-- 
Peter Xu