From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87AF719BB8 for ; Thu, 31 Aug 2023 19:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=81pEEPzDrTbjGaI9j7v0hbeGFpNTfmwvffPam1Ew96U=; b=27aHc7s+9OzXhWa+4EOzypMqQB 0N5I52wWH00Y2yo9r7zq8hBpaBem3exGQyXI+swDvtYo9JFWTlJd5CnHqiP3T7xvwWzGxhzsxYQyS 7HGno9mcFn+obFIvjPTws/UwhlBE/AFh0xJ/71OCQYusA/UtR0ONG9yHnWaSlI8gpl4++fyql3aSG JpFp/DdKgoeMFkmZLXW5vojmaUTMwtUgkWCER7Xks+EyEWs2VYcql2Mm767caxRNdSmFzAoF1eaO/ LdnbxOiNDydU4PH4BtVmYgr0KYTviCahI927h1DF22LHU+E1MP0Fa/DqdTJcGmZ5kkKCGz9rdAHOf mwap065A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qbnTO-00Fko7-0W; Thu, 31 Aug 2023 19:36:58 +0000 Date: Thu, 31 Aug 2023 12:36:58 -0700 From: Luis Chamberlain To: Jeff Layton Cc: Frederick Lawler , kdevops@lists.linux.dev, kernel-team@cloudflare.com Subject: Re: [RFC PATCH] fstests: Request inferred user Message-ID: References: <20230830235333.1658555-1-fred@cloudflare.com> <62020beb3761f1bdd60434940cfd0b617dbbc4a7.camel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62020beb3761f1bdd60434940cfd0b617dbbc4a7.camel@kernel.org> Sender: Luis Chamberlain On Thu, Aug 31, 2023 at 03:35:47PM -0400, Jeff Layton wrote: > On Thu, 2023-08-31 at 12:30 -0700, Luis Chamberlain wrote: > > On Thu, Aug 31, 2023 at 08:51:22AM -0500, Frederick Lawler wrote: > > > On Thu, Aug 31, 2023 at 06:13:23AM -0400, Jeff Layton wrote: > > > > On Wed, 2023-08-30 at 18:53 -0500, Frederick Lawler wrote: > > > > > Currently when running make fstests for bare-metal setups, the data_user > > > > > 'vagrant' is set for the /data partition. This is currently set as the default > > > > > data_user. We have the option to edit this in extra_vars.yml. > > > > > > > > > > make linux checks for an inferred user prior to setting the uid/gid for > > > > > the /data partition. > > > > > > > > > > In the situation where we don't add the 'vagrant' user to the > > > > > bare-metal, we get a "user does not exist" on make fstests. > > > > > > > > > > In both cases we do not want to switch users between the two targets, > > > > > nor do we want to necessarily ensure that the 'vagrant' user exists on > > > > > the metal. Therefore, request the inferred user on make fstests. > > > > > > > > > > Signed-off-by: Frederick Lawler > > > > > --- > > > > > Since this is essentially in two places, I figure this should be more > > > > > generic and then included in other make targets like cxl. But this is to > > > > > get the discussion going if this or some other generic approach is > > > > > preferred. > > > > > --- > > > > > playbooks/roles/fstests/tasks/main.yml | 37 ++++++++++++++++++++++++++ > > > > > 1 file changed, 37 insertions(+) > > > > > > > > > > diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml > > > > > index e2d7ce5295b7..2898833b0732 100644 > > > > > --- a/playbooks/roles/fstests/tasks/main.yml > > > > > +++ b/playbooks/roles/fstests/tasks/main.yml > > > > > @@ -10,6 +10,43 @@ > > > > > skip: true > > > > > tags: vars > > > > > > > > > > +- name: Get username we are using > > > > > + command: > > > > > + cmd: whoami > > > > > + register: username_on_target > > > > > + when: > > > > > + - infer_uid_and_group|bool > > > > > + > > > > > +- name: Set target user as a fact > > > > > + set_fact: > > > > > + target_user: "{{ username_on_target.stdout }}" > > > > > + when: > > > > > + - infer_uid_and_group|bool > > > > > + > > > > > +- name: Run getent against the inferred target user > > > > > + getent: > > > > > + database: passwd > > > > > + key: "{{ target_user }}" > > > > > + register: getent_running_user > > > > > + when: > > > > > + - infer_uid_and_group|bool > > > > > + > > > > > +- name: Run getent against the inferred target group > > > > > + getent: > > > > > + database: group > > > > > + key: "{{ target_user }}" > > > > > + register: getent_on_group > > > > > + when: > > > > > + - infer_uid_and_group|bool > > > > > + > > > > > +- name: Override user and group with inferred settings if feature is enabled > > > > > + set_fact: > > > > > + user: "hplip" > > > > > > > > Why "hplip" here? > > > > > > This was mostly copy/pasted from > > > ./playbooks/roles/bootlinux/tasks/main.yml. I see it was introduced in commit > > > f10add06446b ("kdevops: remove ansible galaxy dependency") for that file, > > > but I'm unclear the use there. I'd like to know as well. > > > > I recall fstets having odd user requirements but that was just for some > > odd tests. I can't trace hplip down to anything so I say we just remove > > it for both. > > If you have an HP printer/scanner/copier then there is an "hplip" > package for Fedora with some of their drivers and such. > > That's why it seemed so weird here. Indeed, super odd! Well good riddance, I nuked it. Luis