From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Radu Pirea <radu-nicolae.pirea@nxp.com>
Cc: "atenart@kernel.org" <atenart@kernel.org>,
"Radu-nicolae Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>,
"sd@queasysnail.net" <sd@queasysnail.net>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Sebastian Tobuschat <sebastian.tobuschat@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC net-next v2 5/5] net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag
Date: Fri, 1 Sep 2023 10:27:14 +0100 [thread overview]
Message-ID: <ZPGuchwza3xr5SaF@shell.armlinux.org.uk> (raw)
In-Reply-To: <518c11e9000f895fddb5b3dc4d5b2bf445cf320f.camel@nxp.com>
On Fri, Sep 01, 2023 at 09:09:06AM +0000, Radu Pirea wrote:
> On Wed, 2023-08-30 at 13:35 +0200, Sabrina Dubroca wrote:
> ...
>
> > And it's not restored when the link goes back up? That's inconvenient
> > :/
> > Do we end up with inconsistent state? ie driver and core believe
> > everything is still offloaded, but HW lost all state? do we leak
> > some resources allocated by the driver?
>
> Yes. We end up with inconsistent state. The HW will lost all state when
> the phy is reseted. No resource is leaked, everything is there, but the
> configuration needs to be reapplied.
If it's happening because the PHY is being re-attached from the network
driver, then wouldn't it be a good idea to synchronise the hardware
state with the software configuration in the ->config_init function?
Presumably the hardware state is also lost when resuming from suspend
as well? If so, that'll also fix that issue as well.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-09-01 9:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 9:16 [RFC net-next v2 0/5] Add MACsec support for TJA11XX C45 PHYs Radu Pirea (NXP OSS)
2023-08-24 9:16 ` [RFC net-next v2 1/5] net: macsec: documentation for macsec_context and macsec_ops Radu Pirea (NXP OSS)
2023-08-24 13:26 ` Antoine Tenart
2023-08-24 9:16 ` [RFC net-next v2 2/5] net: macsec: introduce mdo_insert_tx_tag Radu Pirea (NXP OSS)
2023-08-24 14:54 ` Sabrina Dubroca
2023-08-25 10:01 ` Radu Pirea (OSS)
2023-08-24 9:16 ` [RFC net-next v2 3/5] net: phy: nxp-c45-tja11xx add MACsec support Radu Pirea (NXP OSS)
2023-08-25 12:52 ` Sabrina Dubroca
2023-08-25 13:29 ` Andrew Lunn
2023-08-25 13:44 ` Radu Pirea (OSS)
2023-08-25 13:50 ` Andrew Lunn
2023-08-25 14:12 ` Radu Pirea (OSS)
2023-08-30 12:06 ` Russell King (Oracle)
2023-08-28 10:43 ` Sabrina Dubroca
2023-08-27 8:03 ` Simon Horman
2023-08-24 9:16 ` [RFC net-next v2 4/5] net: phy: nxp-c45-tja11xx: add MACsec statistics Radu Pirea (NXP OSS)
2023-08-25 13:41 ` Sabrina Dubroca
2023-08-25 14:22 ` Radu Pirea (OSS)
2023-08-24 9:16 ` [RFC net-next v2 5/5] net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag Radu Pirea (NXP OSS)
2023-08-27 8:05 ` Simon Horman
2023-08-28 10:17 ` Sabrina Dubroca
2023-08-28 13:46 ` Radu Pirea (OSS)
2023-08-30 11:35 ` Sabrina Dubroca
2023-09-01 9:09 ` Radu Pirea
2023-09-01 9:27 ` Russell King (Oracle) [this message]
2023-09-01 11:31 ` Radu Pirea (OSS)
2023-09-01 12:45 ` Russell King (Oracle)
2023-09-01 10:07 ` Sabrina Dubroca
2023-09-01 10:32 ` Russell King (Oracle)
2023-09-01 13:56 ` Sabrina Dubroca
2023-09-01 11:58 ` Radu Pirea (OSS)
2023-09-01 13:57 ` Sabrina Dubroca
2023-09-01 14:22 ` Radu Pirea (OSS)
2023-09-01 15:37 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPGuchwza3xr5SaF@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@nxp.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=richardcochran@gmail.com \
--cc=sd@queasysnail.net \
--cc=sebastian.tobuschat@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.