From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Xingui Yang <yangxingui@huawei.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
john.g.garry@oracle.com, damien.lemoal@opensource.wdc.com,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
himanshu.madhani@cavium.com, felipe.balbi@linux.intel.com,
gregkh@linuxfoundation.org, uma.shankar@intel.com,
anshuman.gupta@intel.com, animesh.manna@intel.com,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
prime.zeng@hisilicon.com, kangfenglong@huawei.com,
chenxiang66@hisilicon.com
Subject: Re: [PATCH v5 1/3] seq_file: Add helper macro to define attribute for rw file
Date: Mon, 4 Sep 2023 13:53:40 +0300 [thread overview]
Message-ID: <ZPW3NFT9av+AYwnL@smile.fi.intel.com> (raw)
In-Reply-To: <20230904084804.39564-2-yangxingui@huawei.com>
On Mon, Sep 04, 2023 at 08:48:02AM +0000, Xingui Yang wrote:
> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> for read-only file, but many of drivers want a helper macro for read-write
> file too.
>
> So we add DEFINE_SHOW_STORE_ATTRIBUTE helper to reduce duplicated code.
>
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
I believe you need to preserve Luo's authorship.
Perhaps,
Co-developed-by: Xingui ...
(depending if you really do some job in the certain patch(es) or not).
> Signed-off-by: Xingui Yang <yangxingui@huawei.com>
Code wise LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-04 10:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 8:48 [PATCH v5 0/3] Add helper macro DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Xingui Yang
2023-09-04 8:48 ` [PATCH v5 1/3] seq_file: Add helper macro to define attribute for rw file Xingui Yang
2023-09-04 10:53 ` Andy Shevchenko [this message]
2023-09-04 8:48 ` [PATCH v5 2/3] scsi: hisi_sas: Use DEFINE_SHOW_STORE_ATTRIBUTE helper for debugfs Xingui Yang
2023-09-04 10:55 ` Andy Shevchenko
2023-09-04 8:48 ` [PATCH v5 3/3] scsi: qla2xxx: " Xingui Yang
2023-09-04 10:56 ` Andy Shevchenko
2023-09-04 13:05 ` yangxingui
2023-09-04 13:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPW3NFT9av+AYwnL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=animesh.manna@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=himanshu.madhani@cavium.com \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@hisilicon.com \
--cc=uma.shankar@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.