All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Utkarsh Patel <utkarsh.h.patel@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	pmalani@chromium.org, chrome-platform@lists.linux.dev,
	andriy.shevchenko@linux.intel.com, bleung@chromium.org
Subject: Re: [PATCH v2 2/5] usb: typec: Add Active or Passive cable defination to cable discover mode VDO
Date: Mon, 4 Sep 2023 10:07:44 +0300	[thread overview]
Message-ID: <ZPWCQKgZUUITOUnW@kuha.fi.intel.com> (raw)
In-Reply-To: <20230830223950.1360865-3-utkarsh.h.patel@intel.com>

On Wed, Aug 30, 2023 at 03:39:47PM -0700, Utkarsh Patel wrote:
> As per USB Type-C Connector specification v2.2 section F.2.6, BIT25
> represents Active or Passive cable. Added BIT25 defination to the
> Thunderbolt 3 cable discover mode VDO.
> 
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> Changes in v2:
> - This change is being added as new patch in this series.
>  
>  include/linux/usb/typec_tbt.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/usb/typec_tbt.h b/include/linux/usb/typec_tbt.h
> index 63dd44b72e0c..c7a2153bd6f5 100644
> --- a/include/linux/usb/typec_tbt.h
> +++ b/include/linux/usb/typec_tbt.h
> @@ -46,6 +46,7 @@ struct typec_thunderbolt_data {
>  #define TBT_CABLE_OPTICAL		BIT(21)
>  #define TBT_CABLE_RETIMER		BIT(22)
>  #define TBT_CABLE_LINK_TRAINING		BIT(23)
> +#define TBT_CABLE_ACTIVE_PASSIVE	BIT(25)
>  
>  #define TBT_SET_CABLE_SPEED(_s_)	(((_s_) & GENMASK(2, 0)) << 16)
>  #define TBT_SET_CABLE_ROUNDED(_g_)	(((_g_) & GENMASK(1, 0)) << 19)
> -- 
> 2.25.1

-- 
heikki

  reply	other threads:[~2023-09-04  7:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 22:39 [PATCH v2 0/5] Displayport Alternate Mode 2.1 Support Utkarsh Patel
2023-08-30 22:39 ` [PATCH v2 1/5] usb: typec: Add " Utkarsh Patel
2023-08-30 22:39 ` [PATCH v2 2/5] usb: typec: Add Active or Passive cable defination to cable discover mode VDO Utkarsh Patel
2023-09-04  7:07   ` Heikki Krogerus [this message]
2023-08-30 22:39 ` [PATCH v2 3/5] usb: pd: Add helper macro to get Type C cable speed Utkarsh Patel
2023-09-04  7:08   ` Heikki Krogerus
2023-09-04  7:11     ` Heikki Krogerus
2023-09-05 23:47       ` Patel, Utkarsh H
2023-08-30 22:39 ` [PATCH v2 4/5] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support Utkarsh Patel
2023-08-31 10:18   ` kernel test robot
2023-08-31 15:24   ` Patel, Utkarsh H
2023-09-08 17:03     ` Prashant Malani
2023-09-08 20:11       ` Patel, Utkarsh H
2023-08-30 22:39 ` [PATCH v2 5/5] usb: typec: intel_pmc_mux: Configure Displayport Alternate mode 2.1 Utkarsh Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPWCQKgZUUITOUnW@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pmalani@chromium.org \
    --cc=utkarsh.h.patel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.