From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA1BC71153 for ; Mon, 4 Sep 2023 08:55:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236423AbjIDIzv (ORCPT ); Mon, 4 Sep 2023 04:55:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbjIDIzv (ORCPT ); Mon, 4 Sep 2023 04:55:51 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16E85131; Mon, 4 Sep 2023 01:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693817748; x=1725353748; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Bjr8VKvgs/rVspRwakQ9zo2f6fkmmFaw7ymumH5rC6w=; b=JF7szY1Gx76t3KxnnSO3qTWH4kSiLltz21zN8HiLWfWLqTkrdbA3zONb +0NBc4cge3G3V5lv/VSKx7P8WKhvy3yhUpyDc6toQBC9Ni9B0dC14d6rF SexkVsrUze4wepshyz0yICkweVWu2dOaGzytdhgvbhuB0twF5gKE1fCsx O8OTdMBvNQ+X5Xw1PLynWjBVNUO7a63E7nNVXRAJGdpIDnJRwATkSPHd7 TQJUkabzt5E6WezHiPP7f5Op2LrCAZYzWM658I3MK1cbn6dcdNSLGbf+9 orlezqKTRIUbTl15f1gtvNt7co8hHvuLxrWs+VY7/0tB6FfNPuUuwupox g==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="462920560" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="462920560" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 01:55:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="769913289" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="769913289" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 01:55:43 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qd5My-006NXI-0v; Mon, 04 Sep 2023 11:55:40 +0300 Date: Mon, 4 Sep 2023 11:55:39 +0300 From: Andy Shevchenko To: Linus Walleij Cc: Mark Brown , Bartosz Golaszewski , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski , Dan Carpenter Subject: Re: [RFT PATCH v2] spi: bcm2835: reduce the abuse of the GPIO API Message-ID: References: <20230901111548.12733-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Sep 02, 2023 at 06:56:51PM +0200, Linus Walleij wrote: > On Fri, Sep 1, 2023 at 2:31 PM Mark Brown wrote: > > > > > + struct gpiod_lookup_table *lookup __free(kfree) = NULL; > > > > > Whoa! > > > This is really neat. > > > As noted, it will confuse static checkers at no end, but they just have > > > to adopt. (CC to Dan C if he now runs into this.) > > > > It also doesn't look amazing for humans, it's very not C like... > > and the __free() macro was introduced by Peter > Z who also very famously suggested (OTOMH!) that instead of > adopting Rust to the kernel it would be possible to bring the > desired Rust features into C. Competition is always good :-) > Which is what he does, well the feature has been there for a while > but he identified it and made it easily accessible. > > Now if this path is desirable ... yeah. Maybe a matter of taste. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAFC6C83F33 for ; Mon, 4 Sep 2023 08:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9V5K5iYhFaPDhq9xBbpSP3mYQtME5VyX6as7pmEq4hA=; b=DZQLjz/MC0g1pM 0CA8uYCuGGLFHHGjGD5yyxY450Qv4ND6TteIuWasH0Q3MDfmwwUHpOpvx2UBfIE8sWP13cTk6EMUD BbnzNM7AgXTC3mAMUYoJQva3FbtTVekgJVrBOHDhf//BlhxY7svB64VjJVaaZCR04EhvRKZsn75le r5QgnPN7zO1wzx5A/mDwyXO1qWdG5OkyMaUmX255c5hnPdEZokodBpYgCf4ARlGFnnt8CE2XBh/Ff D8pGdu340ZCwQ4Ujlp+zJforjNgm5oPTAzPD5kiHP4yLMtSnl/MtD2FcEbX72GjrkWB3idFLS0r1/ HCSIGUSzmPnTG2LiEsCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qd5ND-003b3X-1q; Mon, 04 Sep 2023 08:55:55 +0000 Received: from mgamail.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qd5N7-003b22-3A; Mon, 04 Sep 2023 08:55:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693817749; x=1725353749; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Bjr8VKvgs/rVspRwakQ9zo2f6fkmmFaw7ymumH5rC6w=; b=dWNi1MznfCAZHePT47kLUfiZQL1DBjG6o16/zXHALRuXmFjCuJGJmVzY /7NiiNwUI0JIYDxm6/DsnmWdR0zR+9ny+/90Hsq006MxMMp+u12Wan00l SYf01aU2QkikyWh5aeHxefyiZVEf8MEQgdwWhSDNDOztkJEBaJUbhBf0c 88IH6sP+5Tdrzpnp+meXiLjCoM7VyVFYgHQ7mbQJCwEv+SE7LElFYcKL0 mR/6Rfx2UOfoj+oaZt9gcUNK6DgLdT8OaZM8A3zUIcuDxvfpmlA5W9Um1 RWSsmOZtycCC/468pXTrBLa1TW1YEguXPLcXep4xKudX5jxYTaq0Xmlfo Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="462920559" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="462920559" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 01:55:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="769913289" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="769913289" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 01:55:43 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qd5My-006NXI-0v; Mon, 04 Sep 2023 11:55:40 +0300 Date: Mon, 4 Sep 2023 11:55:39 +0300 From: Andy Shevchenko To: Linus Walleij Cc: Mark Brown , Bartosz Golaszewski , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski , Dan Carpenter Subject: Re: [RFT PATCH v2] spi: bcm2835: reduce the abuse of the GPIO API Message-ID: References: <20230901111548.12733-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230904_015550_047823_2E296E1B X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBTZXAgMDIsIDIwMjMgYXQgMDY6NTY6NTFQTSArMDIwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBPbiBGcmksIFNlcCAxLCAyMDIzIGF0IDI6MzHigK9QTSBNYXJrIEJyb3duIDxicm9v bmllQGtlcm5lbC5vcmc+IHdyb3RlOgo+IAo+ID4gPiA+ICsgICAgICAgc3RydWN0IGdwaW9kX2xv b2t1cF90YWJsZSAqbG9va3VwIF9fZnJlZShrZnJlZSkgPSBOVUxMOwo+ID4KPiA+ID4gV2hvYSEK PiA+ID4gVGhpcyBpcyByZWFsbHkgbmVhdC4KPiA+ID4gQXMgbm90ZWQsIGl0IHdpbGwgY29uZnVz ZSBzdGF0aWMgY2hlY2tlcnMgYXQgbm8gZW5kLCBidXQgdGhleSBqdXN0IGhhdmUKPiA+ID4gdG8g YWRvcHQuIChDQyB0byBEYW4gQyBpZiBoZSBub3cgcnVucyBpbnRvIHRoaXMuKQo+ID4KPiA+IEl0 IGFsc28gZG9lc24ndCBsb29rIGFtYXppbmcgZm9yIGh1bWFucywgaXQncyB2ZXJ5IG5vdCBDIGxp a2UuLi4KPiAKPiA8bGludXgvY2xlYW51cC5oPiBhbmQgdGhlIF9fZnJlZSgpIG1hY3JvIHdhcyBp bnRyb2R1Y2VkIGJ5IFBldGVyCj4gWiB3aG8gYWxzbyB2ZXJ5IGZhbW91c2x5IHN1Z2dlc3RlZCAo T1RPTUghKSB0aGF0IGluc3RlYWQgb2YKPiBhZG9wdGluZyBSdXN0IHRvIHRoZSBrZXJuZWwgaXQg d291bGQgYmUgcG9zc2libGUgdG8gYnJpbmcgdGhlCj4gZGVzaXJlZCBSdXN0IGZlYXR1cmVzIGlu dG8gQy4KCkNvbXBldGl0aW9uIGlzIGFsd2F5cyBnb29kIDotKQoKPiBXaGljaCBpcyB3aGF0IGhl IGRvZXMsIHdlbGwgdGhlIGZlYXR1cmUgaGFzIGJlZW4gdGhlcmUgZm9yIGEgd2hpbGUKPiBidXQg aGUgaWRlbnRpZmllZCBpdCBhbmQgbWFkZSBpdCBlYXNpbHkgYWNjZXNzaWJsZS4KPiAKPiBOb3cg aWYgdGhpcyBwYXRoIGlzIGRlc2lyYWJsZSAuLi4geWVhaC4gTWF5YmUgYSBtYXR0ZXIgb2YgdGFz dGUuCgotLSAKV2l0aCBCZXN0IFJlZ2FyZHMsCkFuZHkgU2hldmNoZW5rbwoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==